65784 2011-08-05 12:22:59 -0700 Web Inspector: Network panel always displays file:// resources as "(pending)" 2011-08-10 01:27:08 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caseq caseq apavlov bweinstein dglazkov joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 447334 0 caseq 2011-08-05 12:22:59 -0700 1. Open inspector 2. Switch to the Network panel 3. Navigate to a file:// url 3. Observe that all file URLs have status of "(pending)" 447344 1 103095 caseq 2011-08-05 12:34:12 -0700 Created attachment 103095 patch - report status for non-http(s?) resources that are finished and not failed as "Success" - "(Pending)" -> "(pending)" for consistency with other bogus status values 447899 2 pfeldman 2011-08-08 01:09:56 -0700 (you should not regress data url behavior). btw: a test for file: and data: would be great. 447980 3 103239 caseq 2011-08-08 07:11:14 -0700 Created attachment 103239 patch - added a test note that data URL behavior is not actually regressed: we used to have "(data url)" as a status for data URLs, now it's just "Success". 448062 4 103239 pfeldman 2011-08-08 10:05:55 -0700 Comment on attachment 103239 patch View in context: https://bugs.webkit.org/attachment.cgi?id=103239&action=review > LayoutTests/inspector/network-status-non-http.html:5 > +test = function() { function test() { > LayoutTests/inspector/network-status-non-http.html:14 > + var dataGrid = logView.element.querySelector("table.data"); what is dataGrid.textContent ? > LayoutTests/inspector/network-status-non-http.html:44 > +function addElement(src) addScriptElement > LayoutTests/inspector/network-status-non-http.html:48 > + document.body.appendChild(element); document.head.appendChild 448097 5 103239 webkit.review.bot 2011-08-08 10:49:28 -0700 Comment on attachment 103239 patch Attachment 103239 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9330533 New failing tests: inspector/network-status-non-http.html 449028 6 caseq 2011-08-10 01:27:08 -0700 Manually committed r92755: http://trac.webkit.org/changeset/92755 103095 2011-08-05 12:34:12 -0700 2011-08-08 07:11:14 -0700 patch file-pending.patch text/plain 2149 caseq ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0VuZ2xpc2gubHByb2ovbG9jYWxpemVkU3RyaW5n cy5qcyBiL1NvdXJjZS9XZWJDb3JlL0VuZ2xpc2gubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcwpp bmRleCA5M2RjYjQ3OGE3N2FiZDAyMzBiYzMyZTYwMDZkMjIxN2ZmYjA3NWViLi44YjRkOGM4ZGE3 ZWRiYzQ1NjM5MjdlODdmZjhiYTYyNDVmNjliZWY2IDEwMDY0NApHSVQgYmluYXJ5IHBhdGNoCmRl bHRhIDEwNAp6Y21hRnhpbi0/dl5NPmBPKWlvRmo3KlpNWDcqWkhBZm4rKl5DVzhffkVRMTFyRWY2 YSl6LTFATGgjMEV8R242dFUKZDE3UnZkRiVUbEZMejA+N3pecCZ7QEBjV24kNH00SDFPUHE8OE9R KHQKCmRlbHRhIDI2CmljbWVCcSF+RWJDXk0+YE9DO3crPG83e1h4WHRGQWd6fjwmTm90Z2wreCh0 aX0KCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL05ldHdv cmtQYW5lbC5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvTmV0d29ya1Bh bmVsLmpzCmluZGV4IDA5YTFmMWYuLjRhZGJhYTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvTmV0d29ya1BhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvTmV0d29ya1BhbmVsLmpzCkBAIC0xOTM1LDEyICsxOTM1LDEy IEBAIFdlYkluc3BlY3Rvci5OZXR3b3JrRGF0YUdyaWROb2RlLnByb3RvdHlwZSA9IHsKICAgICAg ICAgICAgIGlmICh0aGlzLl9yZXNvdXJjZS5zdGF0dXNDb2RlID49IDQwMCkKICAgICAgICAgICAg ICAgICB0aGlzLmVsZW1lbnQuYWRkU3R5bGVDbGFzcygibmV0d29yay1lcnJvci1yb3ciKTsKICAg ICAgICAgfSBlbHNlIHsKLSAgICAgICAgICAgIGlmICh0aGlzLl9yZXNvdXJjZS5pc0RhdGFVUkwo KSAmJiB0aGlzLl9yZXNvdXJjZS5maW5pc2hlZCkKLSAgICAgICAgICAgICAgICB0aGlzLl9zdGF0 dXNDZWxsLnNldFRleHRBbmRUaXRsZShXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIihkYXRhIHVybCki KSk7CisgICAgICAgICAgICBpZiAoIXRoaXMuX3Jlc291cmNlLmlzSHR0cEZhbWlseSgpICYmIHRo aXMuX3Jlc291cmNlLmZpbmlzaGVkKQorICAgICAgICAgICAgICAgIHRoaXMuX3N0YXR1c0NlbGwu c2V0VGV4dEFuZFRpdGxlKFdlYkluc3BlY3Rvci5VSVN0cmluZygiU3VjY2VzcyIpKTsKICAgICAg ICAgICAgIGVsc2UgaWYgKHRoaXMuX3Jlc291cmNlLmlzUGluZ1JlcXVlc3QoKSkKICAgICAgICAg ICAgICAgICB0aGlzLl9zdGF0dXNDZWxsLnNldFRleHRBbmRUaXRsZShXZWJJbnNwZWN0b3IuVUlT dHJpbmcoIihwaW5nKSIpKTsKICAgICAgICAgICAgIGVsc2UKLSAgICAgICAgICAgICAgICB0aGlz Ll9zdGF0dXNDZWxsLnNldFRleHRBbmRUaXRsZShXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIihQZW5k aW5nKSIpKTsKKyAgICAgICAgICAgICAgICB0aGlzLl9zdGF0dXNDZWxsLnNldFRleHRBbmRUaXRs ZShXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIihwZW5kaW5nKSIpKTsKICAgICAgICAgICAgIHRoaXMu X3N0YXR1c0NlbGwuYWRkU3R5bGVDbGFzcygibmV0d29yay1kaW0tY2VsbCIpOwogICAgICAgICB9 CiAgICAgfSwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv UmVzb3VyY2UuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNl LmpzCmluZGV4IDQ3MWY1NmIuLjc5MTM4MDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2UuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9SZXNvdXJjZS5qcwpAQCAtODc3LDkgKzg3Nyw5IEBAIFdlYkluc3BlY3Rv ci5SZXNvdXJjZS5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICBpbWFnZS5zcmMgPSB0aGlzLnVy bDsKICAgICB9LAogCi0gICAgaXNEYXRhVVJMOiBmdW5jdGlvbigpCisgICAgaXNIdHRwRmFtaWx5 OiBmdW5jdGlvbigpCiAgICAgewotICAgICAgICByZXR1cm4gdGhpcy51cmwubWF0Y2goL15kYXRh Oi9pKTsKKyAgICAgICAgcmV0dXJuIHRoaXMudXJsLm1hdGNoKC9eaHR0cHM/Oi9pKTsKICAgICB9 LAogCiAgICAgcmVxdWVzdENvbnRlbnRUeXBlOiBmdW5jdGlvbigpCg== 103239 2011-08-08 07:11:14 -0700 2011-08-08 10:49:28 -0700 patch file-pending.patch text/plain 4890 caseq ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9uZXR3b3JrLXN0YXR1cy1ub24taHR0 cC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvbmV0d29yay1zdGF0dXMtbm9u LWh0dHAtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjRi OThmOWYKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvbmV0d29yay1z dGF0dXMtbm9uLWh0dHAtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsNiBAQAoreworICAgIDAgOiAi ZGF0YTphcHBsaWNhdGlvbi9qYXZhc2NyaXB0LHZhciB4ID0gMDs6IFN1Y2Nlc3MiCisgICAgMSA6 ICJuZXR3b3JrLXRlc3QuanM6IFN1Y2Nlc3MiCisgICAgMiA6ICJub24tZXhpc3RlbnQtZmlsZS5q czogKGZhaWxlZCkiCit9CisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9uZXR3 b3JrLXN0YXR1cy1ub24taHR0cC5odG1sIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL25ldHdvcmst c3RhdHVzLW5vbi1odHRwLmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4u NWU0ZDg2ZAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9uZXR3b3Jr LXN0YXR1cy1ub24taHR0cC5odG1sCkBAIC0wLDAgKzEsNjIgQEAKKzxodG1sPgorPGhlYWQ+Cis8 c2NyaXB0IHNyYz0iLi4vaHR0cC90ZXN0cy9pbnNwZWN0b3IvaW5zcGVjdG9yLXRlc3QuanMiPjwv c2NyaXB0PgorPHNjcmlwdD4KK3Rlc3QgPSBmdW5jdGlvbigpIHsKKworICAgIHZhciByZXNvdXJj ZXNUb1dhdGNoID0gL1wvbmV0d29yay10ZXN0XC5qcyR8XC9ub24tZXhpc3RlbnQtZmlsZS5qcyR8 XmRhdGE6YXBwbGljYXRpb25cL2phdmFzY3JpcHQsfC87CisgICAgdmFyIHNlZW5SZXNvdXJjZXMg PSAwOworCisgICAgZnVuY3Rpb24gZHVtcFJlc291cmNlcygpCisgICAgeworICAgICAgICB2YXIg bG9nVmlldyA9IFdlYkluc3BlY3Rvci5wYW5lbHMubmV0d29yay5fbmV0d29ya0xvZ1ZpZXc7Cisg ICAgICAgIGxvZ1ZpZXcucmVmcmVzaCgpOworICAgICAgICB2YXIgZGF0YUdyaWQgPSBsb2dWaWV3 LmVsZW1lbnQucXVlcnlTZWxlY3RvcigidGFibGUuZGF0YSIpOworICAgICAgICB2YXIgdXJscyA9 IGRvY3VtZW50LmV2YWx1YXRlKCIvL3Rib2R5L3RyL3RkW3Bvc2l0aW9uKCk9MV0vZGl2L0B0aXRs ZSIsIGRhdGFHcmlkLCBudWxsLCBYUGF0aFJlc3VsdC5PUkRFUkVEX05PREVfU05BUFNIT1RfVFlQ RSwgbnVsbCk7CisgICAgICAgIHZhciBvdXRwdXRTdHJpbmdzID0gW107CisKKyAgICAgICAgZm9y ICh2YXIgaSA9IDA7IGkgPCB1cmxzLnNuYXBzaG90TGVuZ3RoOyArK2kpIHsKKyAgICAgICAgICAg IHZhciB1cmwgPSB1cmxzLnNuYXBzaG90SXRlbShpKS52YWx1ZTsKKyAgICAgICAgICAgIGlmIChy ZXNvdXJjZXNUb1dhdGNoLnRlc3QodXJsKSkgeworICAgICAgICAgICAgICAgIHZhciB1cmxUYWls ID0gL15maWxlOi8udGVzdCh1cmwpID8gdXJsLnJlcGxhY2UoLy4qXC8vLCAiIikgOiB1cmw7Cisg ICAgICAgICAgICAgICAgdmFyIHN0YXR1cyA9IGRvY3VtZW50LmV2YWx1YXRlKCJhbmNlc3Rvcjo6 dHIvdGRbcG9zaXRpb24oKT0zXSIsIHVybHMuc25hcHNob3RJdGVtKGkpLCBudWxsLCBYUGF0aFJl c3VsdC5TVFJJTkdfVFlQRSwgbnVsbCk7CisgICAgICAgICAgICAgICAgb3V0cHV0U3RyaW5ncy5w dXNoKHVybFRhaWwgKyAiOiAiICsgc3RhdHVzLnN0cmluZ1ZhbHVlKTsKKyAgICAgICAgICAgIH0K KyAgICAgICAgfQorICAgICAgICBvdXRwdXRTdHJpbmdzLnNvcnQoKTsKKyAgICAgICAgSW5zcGVj dG9yVGVzdC5hZGRPYmplY3Qob3V0cHV0U3RyaW5ncyk7CisgICAgICAgIEluc3BlY3RvclRlc3Qu Y29tcGxldGVUZXN0KCk7CisgICAgfQorCisgICAgZnVuY3Rpb24gb25SZXNvdXJjZUZpbmlzaGVk KHJlc291cmNlKQorICAgIHsKKyAgICAgICAgaWYgKCFyZXNvdXJjZXNUb1dhdGNoLnRlc3QocmVz b3VyY2UudXJsKSkKKyAgICAgICAgICAgIHJldHVybjsKKyAgICAgICAgaWYgKCsrc2VlblJlc291 cmNlcyA9PT0gMykKKyAgICAgICAgICAgIGR1bXBSZXNvdXJjZXMoKTsKKyAgICB9CisKKyAgICBX ZWJJbnNwZWN0b3IubmV0d29ya01hbmFnZXIuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3Iu TmV0d29ya01hbmFnZXIuRXZlbnRUeXBlcy5SZXNvdXJjZUZpbmlzaGVkLCBvblJlc291cmNlRmlu aXNoZWQpOworICAgIFdlYkluc3BlY3Rvci5zaG93UGFuZWwoIm5ldHdvcmsiKTsKKyAgICBJbnNw ZWN0b3JUZXN0LmV2YWx1YXRlSW5QYWdlKCJsb2FkUmVzb3VyY2VzKCkiKTsKK30KKworZnVuY3Rp b24gYWRkRWxlbWVudChzcmMpCit7CisgICAgdmFyIGVsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVF bGVtZW50KCJzY3JpcHQiKTsKKyAgICBlbGVtZW50LnNyYyA9IHNyYzsKKyAgICBkb2N1bWVudC5i b2R5LmFwcGVuZENoaWxkKGVsZW1lbnQpOworfQorCitmdW5jdGlvbiBsb2FkUmVzb3VyY2VzKCkK K3sKKyAgICBhZGRFbGVtZW50KCIuLi9odHRwL3Rlc3RzL2luc3BlY3Rvci9uZXR3b3JrLXRlc3Qu anMiKTsKKyAgICBhZGRFbGVtZW50KCJub24tZXhpc3RlbnQtZmlsZS5qcyIpOworICAgIGFkZEVs ZW1lbnQoImRhdGE6YXBwbGljYXRpb24vamF2YXNjcmlwdCx2YXIgeCA9IDA7Iik7Cit9CisKKzwv c2NyaXB0PgorPC9oZWFkPgorPGJvZHkgb25sb2FkPSJydW5UZXN0KCkiPgorPC9ib2R5PgorPC9o dG1sPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvRW5nbGlzaC5scHJvai9sb2NhbGl6ZWRT dHJpbmdzLmpzIGIvU291cmNlL1dlYkNvcmUvRW5nbGlzaC5scHJvai9sb2NhbGl6ZWRTdHJpbmdz LmpzCmluZGV4IDkzZGNiNDc4YTc3YWJkMDIzMGJjMzJlNjAwNmQyMjE3ZmZiMDc1ZWIuLjhiNGQ4 YzhkYTdlZGJjNDU2MzkyN2U4N2ZmOGJhNjI0NWY2OWJlZjYgMTAwNjQ0CkdJVCBiaW5hcnkgcGF0 Y2gKZGVsdGEgMTA0CnpjbWFGeGluLT92Xk0+YE8paW9GajcqWk1YNypaSEFmbisqXkNXOF9+RVEx MXJFZjZhKXotMUBMaCMwRXxHbjZ0VQpkMTdSdmRGJVRsRkx6MD43el5wJntAQGNXbiQ0fTRIMU9Q cTw4T1EodAoKZGVsdGEgMjYKaWNtZUJxIX5FYkNeTT5gT0M7dys8bzd7WHhYdEZBZ3p+PCZOb3Rn bCt4KHRpfQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv TmV0d29ya1BhbmVsLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9OZXR3 b3JrUGFuZWwuanMKaW5kZXggMDlhMWYxZi4uNGFkYmFhMCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9OZXR3b3JrUGFuZWwuanMKKysrIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9OZXR3b3JrUGFuZWwuanMKQEAgLTE5MzUsMTIgKzE5 MzUsMTIgQEAgV2ViSW5zcGVjdG9yLk5ldHdvcmtEYXRhR3JpZE5vZGUucHJvdG90eXBlID0gewog ICAgICAgICAgICAgaWYgKHRoaXMuX3Jlc291cmNlLnN0YXR1c0NvZGUgPj0gNDAwKQogICAgICAg ICAgICAgICAgIHRoaXMuZWxlbWVudC5hZGRTdHlsZUNsYXNzKCJuZXR3b3JrLWVycm9yLXJvdyIp OwogICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgaWYgKHRoaXMuX3Jlc291cmNlLmlzRGF0 YVVSTCgpICYmIHRoaXMuX3Jlc291cmNlLmZpbmlzaGVkKQotICAgICAgICAgICAgICAgIHRoaXMu X3N0YXR1c0NlbGwuc2V0VGV4dEFuZFRpdGxlKFdlYkluc3BlY3Rvci5VSVN0cmluZygiKGRhdGEg dXJsKSIpKTsKKyAgICAgICAgICAgIGlmICghdGhpcy5fcmVzb3VyY2UuaXNIdHRwRmFtaWx5KCkg JiYgdGhpcy5fcmVzb3VyY2UuZmluaXNoZWQpCisgICAgICAgICAgICAgICAgdGhpcy5fc3RhdHVz Q2VsbC5zZXRUZXh0QW5kVGl0bGUoV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJTdWNjZXNzIikpOwog ICAgICAgICAgICAgZWxzZSBpZiAodGhpcy5fcmVzb3VyY2UuaXNQaW5nUmVxdWVzdCgpKQogICAg ICAgICAgICAgICAgIHRoaXMuX3N0YXR1c0NlbGwuc2V0VGV4dEFuZFRpdGxlKFdlYkluc3BlY3Rv ci5VSVN0cmluZygiKHBpbmcpIikpOwogICAgICAgICAgICAgZWxzZQotICAgICAgICAgICAgICAg IHRoaXMuX3N0YXR1c0NlbGwuc2V0VGV4dEFuZFRpdGxlKFdlYkluc3BlY3Rvci5VSVN0cmluZygi KFBlbmRpbmcpIikpOworICAgICAgICAgICAgICAgIHRoaXMuX3N0YXR1c0NlbGwuc2V0VGV4dEFu ZFRpdGxlKFdlYkluc3BlY3Rvci5VSVN0cmluZygiKHBlbmRpbmcpIikpOwogICAgICAgICAgICAg dGhpcy5fc3RhdHVzQ2VsbC5hZGRTdHlsZUNsYXNzKCJuZXR3b3JrLWRpbS1jZWxsIik7CiAgICAg ICAgIH0KICAgICB9LApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC9SZXNvdXJjZS5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUmVz b3VyY2UuanMKaW5kZXggNDcxZjU2Yi4uNzkxMzgwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZS5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlLmpzCkBAIC04NzcsOSArODc3LDkgQEAgV2ViSW5z cGVjdG9yLlJlc291cmNlLnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIGltYWdlLnNyYyA9IHRo aXMudXJsOwogICAgIH0sCiAKLSAgICBpc0RhdGFVUkw6IGZ1bmN0aW9uKCkKKyAgICBpc0h0dHBG YW1pbHk6IGZ1bmN0aW9uKCkKICAgICB7Ci0gICAgICAgIHJldHVybiB0aGlzLnVybC5tYXRjaCgv XmRhdGE6L2kpOworICAgICAgICByZXR1cm4gdGhpcy51cmwubWF0Y2goL15odHRwcz86L2kpOwog ICAgIH0sCiAKICAgICByZXF1ZXN0Q29udGVudFR5cGU6IGZ1bmN0aW9uKCkK