65771 2011-08-05 09:07:00 -0700 REGRESSION(r92433): media/video-src-change.html fails 2011-08-05 12:49:56 -0700 1 1 1 Unclassified WebKit UI Events 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P1 Normal --- 1 rniwa rniwa abarth eric.carlson koivisto pilgrim sam simon.fraser oldest_to_newest 447226 0 rniwa 2011-08-05 09:07:00 -0700 media/video-src-change.html started to fail after http://trac.webkit.org/changeset/92433 because the test assumes the second argument for removeEventListener to be optional. 447229 1 rniwa 2011-08-05 09:10:45 -0700 All regressions are P1. 447230 2 rniwa 2011-08-05 09:15:06 -0700 Looking at EventTarget code: http://trac.webkit.org/browser/trunk/Source/WebCore/dom/EventTarget.cpp#L246 It seems like the test code is wrong. We should be giving the listener as the second argument: 31 if (++loadedCount >= 2) { 32 mediaElement.removeEventListener('loadedmetadata'); 33 endTest(); 34 return; 35 } 447246 3 103079 rniwa 2011-08-05 09:46:58 -0700 Created attachment 103079 fixes the test 447264 4 103079 rniwa 2011-08-05 10:13:04 -0700 Comment on attachment 103079 fixes the test Clearing flags on attachment: 103079 Committed r92484: <http://trac.webkit.org/changeset/92484> 447265 5 rniwa 2011-08-05 10:13:07 -0700 All reviewed patches have been landed. Closing bug. 447360 6 abarth 2011-08-05 12:49:56 -0700 This bug is blowing my mind. I thought removeEventListener was special-cased by the code generator. The IDL files shouldn't affect the generated code. 103079 2011-08-05 09:46:58 -0700 2011-08-05 10:13:03 -0700 fixes the test bug-65771-20110805094657.patch text/plain 1238 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDkyNDgyKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDgtMDUgIFJ5b3N1a2UgTml3YSAgPHJu aXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihyOTI0MzMpOiBtZWRpYS92aWRl by1zcmMtY2hhbmdlLmh0bWwgZmFpbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTY1NzcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgR2l2ZSB0aGUgbGlzdGVuZXIgYXMgdGhlIHNlY29uZCBhcmd1bWVudCB0 byByZW1vdmVFdmVudExpc3RlbmVyLgorCisgICAgICAgICogbWVkaWEvdmlkZW8tc3JjLWNoYW5n ZS5odG1sOgorCiAyMDExLTA4LTA1ICBZYWVsIEFoYXJvbiAgPHlhZWwuYWhhcm9uQG5va2lhLmNv bT4KIAogICAgICAgICBkaXI9YXV0byBuZWVkcyB0byB3b3JrIG9uIHZhbHVlIG9mIGlucHV0IGFu ZCB0ZXh0YXJlYSBlbGVtZW50cwpJbmRleDogTGF5b3V0VGVzdHMvbWVkaWEvdmlkZW8tc3JjLWNo YW5nZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL21lZGlhL3ZpZGVvLXNyYy1jaGFu Z2UuaHRtbAkocmV2aXNpb24gOTI0ODEpCisrKyBMYXlvdXRUZXN0cy9tZWRpYS92aWRlby1zcmMt Y2hhbmdlLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTI5LDcgKzI5LDcgQEAKICAgICAgICAgICAg ICAgICBjb25zb2xlV3JpdGUoIiIpOwogICAgICAgICAgICAgICAgIAogICAgICAgICAgICAgICAg IGlmICgrK2xvYWRlZENvdW50ID49IDIpIHsKLSAgICAgICAgICAgICAgICAgICAgbWVkaWFFbGVt ZW50LnJlbW92ZUV2ZW50TGlzdGVuZXIoJ2xvYWRlZG1ldGFkYXRhJyk7CisgICAgICAgICAgICAg ICAgICAgIG1lZGlhRWxlbWVudC5yZW1vdmVFdmVudExpc3RlbmVyKCdsb2FkZWRtZXRhZGF0YScs IGxvYWRlZG1ldGFkYXRhKTsKICAgICAgICAgICAgICAgICAgICAgZW5kVGVzdCgpOwogICAgICAg ICAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgICAgICAgICAgfQo=