65750 2011-08-04 22:28:12 -0700 Remove LegacyDefaultOptionalArguments flag from web audio API 2011-08-06 21:08:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 pilgrim webkit-unassigned abarth crogers webkit.review.bot oldest_to_newest 447036 0 pilgrim 2011-08-04 22:28:12 -0700 As discussed in IRC, we are migrating our IDL files away from the interface-level "LegacyDefaultOptionalArguments" flag and onto argument-level [Optional] or [Optional=CallWithDefaultValue] flags. This patch migrates all remaining webaudio-related IDL files. This patch CHANGES BEHAVIOR, specifically it makes all arguments required in the noteOn(), noteGrainOn(), and noteOff() methods of AudioBufferSourceNode. This is in line with other changes already made to other parts of the web audio API which made all arguments required (for example, in AudioBuffer), so I'm assuming that this IDL file just got missed. AFAIK, web audio has no tests yet. 447037 1 103040 pilgrim 2011-08-04 22:28:49 -0700 Created attachment 103040 Patch 447096 2 103040 webkit.review.bot 2011-08-05 00:45:31 -0700 Comment on attachment 103040 Patch Clearing flags on attachment: 103040 Committed r92459: <http://trac.webkit.org/changeset/92459> 447097 3 webkit.review.bot 2011-08-05 00:45:35 -0700 All reviewed patches have been landed. Closing bug. 447695 4 crogers 2011-08-06 19:52:23 -0700 I wish I had been on the CC list for this, because it was the intention that this argument should be optional (although admittedly the spec isn't clear about this). 447699 5 abarth 2011-08-06 21:08:20 -0700 I'm not sure which API you mean specifically, but Its easy to fix. 103040 2011-08-04 22:28:49 -0700 2011-08-05 00:45:31 -0700 Patch bug-65750-20110805012855.patch text/plain 1173 pilgrim SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkyNDQ1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDgtMDQgIE1hcmsgUGls Z3JpbSAgPHBpbGdyaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSBMZWdhY3lEZWZh dWx0T3B0aW9uYWxBcmd1bWVudHMgZmxhZyBmcm9tIHdlYiBhdWRpbyBBUEkKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1NzUwCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBhbGwgZXhp c3RpbmcgdGVzdHMgcGFzcy4KKworICAgICAgICAqIHdlYmF1ZGlvL0F1ZGlvQnVmZmVyU291cmNl Tm9kZS5pZGw6CisKIDIwMTEtMDgtMDQgIE1hcmsgUGlsZ3JpbSAgPHBpbGdyaW1AY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFJlbW92ZSBMZWdhY3lEZWZhdWx0T3B0aW9uYWxBcmd1bWVudHMgZmxh ZyBmcm9tIGNhbnZhcyBJREwgZmlsZXMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3dlYmF1ZGlvL0F1 ZGlvQnVmZmVyU291cmNlTm9kZS5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvd2Vi YXVkaW8vQXVkaW9CdWZmZXJTb3VyY2VOb2RlLmlkbAkocmV2aXNpb24gOTIzNDIpCisrKyBTb3Vy Y2UvV2ViQ29yZS93ZWJhdWRpby9BdWRpb0J1ZmZlclNvdXJjZU5vZGUuaWRsCSh3b3JraW5nIGNv cHkpCkBAIC0yNSw3ICsyNSw2IEBACiBtb2R1bGUgYXVkaW8gewogICAgIC8vIEEgY2FjaGVkIChu b24tc3RyZWFtZWQpLCBtZW1vcnktcmVzaWRlbnQgYXVkaW8gc291cmNlCiAgICAgaW50ZXJmYWNl IFsKLSAgICAgICAgTGVnYWN5RGVmYXVsdE9wdGlvbmFsQXJndW1lbnRzLAogICAgICAgICBDb25k aXRpb25hbD1XRUJfQVVESU8sCiAgICAgICAgIEdlbmVyYXRlVG9KUwogICAgIF0gQXVkaW9CdWZm ZXJTb3VyY2VOb2RlIDogQXVkaW9Tb3VyY2VOb2RlIHsK