<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>65749</bug_id>
          
          <creation_ts>2011-08-04 22:22:28 -0700</creation_ts>
          <short_desc>Remove LegacyDefaultOptionalArguments flag from websockets</short_desc>
          <delta_ts>2011-08-05 00:32:31 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Mark Pilgrim (Google)">pilgrim</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>447030</commentid>
    <comment_count>0</comment_count>
    <who name="Mark Pilgrim (Google)">pilgrim</who>
    <bug_when>2011-08-04 22:22:28 -0700</bug_when>
    <thetext>As discussed in IRC, we are migrating our IDL files away from the interface-level &quot;LegacyDefaultOptionalArguments&quot; flag and onto argument-level [Optional] or [Optional=CallWithDefaultValue] flags. This patch migrates all remaining websockets-related IDL files. It does not change any behavior, i.e. it does not make any arguments required that were previously optional, nor vice-versa.

All existing tests pass.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>447031</commentid>
    <comment_count>1</comment_count>
      <attachid>103038</attachid>
    <who name="Mark Pilgrim (Google)">pilgrim</who>
    <bug_when>2011-08-04 22:23:05 -0700</bug_when>
    <thetext>Created attachment 103038
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>447088</commentid>
    <comment_count>2</comment_count>
      <attachid>103038</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-08-05 00:32:27 -0700</bug_when>
    <thetext>Comment on attachment 103038
Patch

Clearing flags on attachment: 103038

Committed r92456: &lt;http://trac.webkit.org/changeset/92456&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>447089</commentid>
    <comment_count>3</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2011-08-05 00:32:31 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>103038</attachid>
            <date>2011-08-04 22:23:05 -0700</date>
            <delta_ts>2011-08-05 00:32:26 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-65749-20110805012312.patch</filename>
            <type>text/plain</type>
            <size>1092</size>
            <attacher name="Mark Pilgrim (Google)">pilgrim</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkyNDQ0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDgtMDQgIE1hcmsgUGls
Z3JpbSAgPHBpbGdyaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSBMZWdhY3lEZWZh
dWx0T3B0aW9uYWxBcmd1bWVudHMgZmxhZyBmcm9tIHdlYnNvY2tldHMKKyAgICAgICAgaHR0cHM6
Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1NzQ5CisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBhbGwgZXhpc3Rp
bmcgdGVzdHMgcGFzcy4KKworICAgICAgICAqIHdlYnNvY2tldHMvV2ViU29ja2V0LmlkbDoKKwog
MjAxMS0wOC0wNCAgTWFyayBQaWxncmltICA8cGlsZ3JpbUBjaHJvbWl1bS5vcmc+CiAKICAgICAg
ICAgUmVtb3ZlIExlZ2FjeURlZmF1bHRPcHRpb25hbEFyZ3VtZW50cyBmbGFnIGZyb20gY2FudmFz
IElETCBmaWxlcwpJbmRleDogU291cmNlL1dlYkNvcmUvd2Vic29ja2V0cy9XZWJTb2NrZXQuaWRs
Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3dlYnNvY2tldHMvV2ViU29ja2V0LmlkbAko
cmV2aXNpb24gOTIzNDIpCisrKyBTb3VyY2UvV2ViQ29yZS93ZWJzb2NrZXRzL1dlYlNvY2tldC5p
ZGwJKHdvcmtpbmcgY29weSkKQEAgLTMzLDcgKzMzLDYgQEAgbW9kdWxlIHdlYnNvY2tldHMgewog
CiAgICAgaW50ZXJmYWNlIFsKICAgICAgICAgQ29uZGl0aW9uYWw9V0VCX1NPQ0tFVFMsCi0gICAg
ICAgIExlZ2FjeURlZmF1bHRPcHRpb25hbEFyZ3VtZW50cywKICAgICAgICAgQWN0aXZlRE9NT2Jq
ZWN0LAogICAgICAgICBDYW5CZUNvbnN0cnVjdGVkLAogICAgICAgICBDdXN0b21Db25zdHJ1Y3RG
dW5jdGlvbiwK
</data>

          </attachment>
      

    </bug>

</bugzilla>