65748 2011-08-04 22:20:20 -0700 Remove LegacyDefaultOptionalArguments flag from inspector IDLs 2011-10-28 12:29:20 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 pilgrim arv abarth arv pfeldman webkit.review.bot oldest_to_newest 447027 0 pilgrim 2011-08-04 22:20:20 -0700 As discussed in IRC, we are migrating our IDL files away from the interface-level "LegacyDefaultOptionalArguments" flag and onto argument-level [Optional] or [Optional=CallWithDefaultValue] flags. This patch migrates all remaining inspector-related IDL files. It does not change any behavior, i.e. it does not make any arguments required that were previously optional, nor vice-versa. All existing tests pass. 447028 1 103037 pilgrim 2011-08-04 22:21:00 -0700 Created attachment 103037 Patch 447044 2 103037 abarth 2011-08-04 22:38:05 -0700 Comment on attachment 103037 Patch These IDLs are only used internally by the Web Inspector. We shouldn't have any compat hacks in them. If making them strict breaks the inspector, then we should fix the inspector. 492549 3 112884 arv 2011-10-28 11:27:27 -0700 Created attachment 112884 Patch 492552 4 arv 2011-10-28 11:28:10 -0700 I manually checked all usages of the functions in these IDL files. 492555 5 abarth 2011-10-28 11:28:43 -0700 +pfeldman Please let us know if this causes any problems for the inspector. 492556 6 abarth 2011-10-28 11:28:59 -0700 > I manually checked all usages of the functions in these IDL files. Great! 492599 7 112884 webkit.review.bot 2011-10-28 12:29:15 -0700 Comment on attachment 112884 Patch Clearing flags on attachment: 112884 Committed r98750: <http://trac.webkit.org/changeset/98750> 492600 8 webkit.review.bot 2011-10-28 12:29:20 -0700 All reviewed patches have been landed. Closing bug. 103037 2011-08-04 22:21:00 -0700 2011-10-28 11:27:21 -0700 Patch bug-65748-20110805012106.patch text/plain 4818 pilgrim SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkyNDQ0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDgtMDQgIE1hcmsgUGls Z3JpbSAgPHBpbGdyaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSBMZWdhY3lEZWZh dWx0T3B0aW9uYWxBcmd1bWVudHMgZmxhZyBmcm9tIGluc3BlY3RvciBJRExzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTc0OAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYWxsIGV4 aXN0aW5nIHRlc3RzIHBhc3MuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRI b3N0LmlkbDoKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmlkbDoK KyAgICAgICAgKiBpbnNwZWN0b3IvSmF2YVNjcmlwdENhbGxGcmFtZS5pZGw6CisKIDIwMTEtMDgt MDQgIE1hcmsgUGlsZ3JpbSAgPHBpbGdyaW1AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJlbW92 ZSBMZWdhY3lEZWZhdWx0T3B0aW9uYWxBcmd1bWVudHMgZmxhZyBmcm9tIGNhbnZhcyBJREwgZmls ZXMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdEhvc3QuaWRs Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdEhv c3QuaWRsCShyZXZpc2lvbiA5MjM0MikKKysrIFNvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9Jbmpl Y3RlZFNjcmlwdEhvc3QuaWRsCSh3b3JraW5nIGNvcHkpCkBAIC0zMiwxNCArMzIsMTMgQEAKIAog bW9kdWxlIGNvcmUgewogICAgIGludGVyZmFjZSBbCi0gICAgICAgIExlZ2FjeURlZmF1bHRPcHRp b25hbEFyZ3VtZW50cywKICAgICAgICAgQ29uZGl0aW9uYWw9SU5TUEVDVE9SCiAgICAgXSBJbmpl Y3RlZFNjcmlwdEhvc3QgewogICAgICAgICB2b2lkIGNsZWFyQ29uc29sZU1lc3NhZ2VzKCk7CiAK ICAgICAgICAgW0N1c3RvbV0gRE9NT2JqZWN0IGV2YWx1YXRlKGluIERPTVN0cmluZyB0ZXh0KTsK IAotICAgICAgICB2b2lkIGNvcHlUZXh0KGluIERPTVN0cmluZyB0ZXh0KTsKKyAgICAgICAgdm9p ZCBjb3B5VGV4dChpbiBbT3B0aW9uYWw9Q2FsbFdpdGhEZWZhdWx0VmFsdWVdIERPTVN0cmluZyB0 ZXh0KTsKICAgICAgICAgW0N1c3RvbV0gdm9pZCBpbnNwZWN0KGluIERPTU9iamVjdCBvYmplY3RJ ZCwgaW4gRE9NT2JqZWN0IGhpbnRzKTsKICAgICAgICAgW0N1c3RvbV0gRE9NT2JqZWN0IGluc3Bl Y3RlZE5vZGUoaW4gaW50IG51bSk7CiAgICAgICAgIFtDdXN0b21dIERPTU9iamVjdCBpbnRlcm5h bENvbnN0cnVjdG9yTmFtZShpbiBET01PYmplY3Qgb2JqZWN0KTsKQEAgLTUwLDggKzQ5LDEwIEBA IG1vZHVsZSBjb3JlIHsKICAgICAgICAgW0N1c3RvbV0gaW50IHN0b3JhZ2VJZChpbiBET01PYmpl Y3Qgc3RvcmFnZSk7CiAKICNpZiBkZWZpbmVkKEVOQUJMRV9XT1JLRVJTKSAmJiBFTkFCTEVfV09S S0VSUwotICAgICAgICB2b2lkIGRpZENyZWF0ZVdvcmtlcihpbiBsb25nIGlkLCBpbiBET01TdHJp bmcgdXJsLCBpbiBib29sZWFuIGlzRmFrZVdvcmtlcik7Ci0gICAgICAgIHZvaWQgZGlkRGVzdHJv eVdvcmtlcihpbiBsb25nIGlkKTsKKyAgICAgICAgdm9pZCBkaWRDcmVhdGVXb3JrZXIoaW4gW09w dGlvbmFsPUNhbGxXaXRoRGVmYXVsdFZhbHVlXSBsb25nIGlkLCAKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgaW4gW09wdGlvbmFsPUNhbGxXaXRoRGVmYXVsdFZhbHVlXSBET01TdHJpbmcg dXJsLCAKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW4gW09wdGlvbmFsPUNhbGxXaXRo RGVmYXVsdFZhbHVlXSBib29sZWFuIGlzRmFrZVdvcmtlcik7CisgICAgICAgIHZvaWQgZGlkRGVz dHJveVdvcmtlcihpbiBbT3B0aW9uYWw9Q2FsbFdpdGhEZWZhdWx0VmFsdWVdIGxvbmcgaWQpOwog ICAgICAgICBsb25nIG5leHRXb3JrZXJJZCgpOwogI2VuZGlmCiAgICAgfTsKSW5kZXg6IFNvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZEhvc3QuaWRsCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZEhvc3QuaWRsCShy ZXZpc2lvbiA5MjM0MikKKysrIFNvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JGcm9u dGVuZEhvc3QuaWRsCSh3b3JraW5nIGNvcHkpCkBAIC0zMiwzMSArMzIsMzIgQEAKIAogbW9kdWxl IGNvcmUgewogICAgIGludGVyZmFjZSBbCi0gICAgICAgIExlZ2FjeURlZmF1bHRPcHRpb25hbEFy Z3VtZW50cywKICAgICAgICAgQ29uZGl0aW9uYWw9SU5TUEVDVE9SCiAgICAgXSBJbnNwZWN0b3JG cm9udGVuZEhvc3QgewogICAgICAgICB2b2lkIGxvYWRlZCgpOwogICAgICAgICB2b2lkIGNsb3Nl V2luZG93KCk7CiAgICAgICAgIHZvaWQgZGlzY29ubmVjdEZyb21CYWNrZW5kKCk7CiAgICAgICAg IHZvaWQgYnJpbmdUb0Zyb250KCk7Ci0gICAgICAgIHZvaWQgaW5zcGVjdGVkVVJMQ2hhbmdlZChp biBET01TdHJpbmcgbmV3VVJMKTsKKyAgICAgICAgdm9pZCBpbnNwZWN0ZWRVUkxDaGFuZ2VkKGlu IFtPcHRpb25hbD1DYWxsV2l0aERlZmF1bHRWYWx1ZV0gRE9NU3RyaW5nIG5ld1VSTCk7CiAKICAg ICAgICAgdm9pZCByZXF1ZXN0QXR0YWNoV2luZG93KCk7CiAgICAgICAgIHZvaWQgcmVxdWVzdERl dGFjaFdpbmRvdygpOwotICAgICAgICB2b2lkIHNldEF0dGFjaGVkV2luZG93SGVpZ2h0KGluIHVu c2lnbmVkIGxvbmcgaGVpZ2h0KTsKLSAgICAgICAgdm9pZCBtb3ZlV2luZG93QnkoaW4gZmxvYXQg eCwgaW4gZmxvYXQgeSk7Ci0gICAgICAgIHZvaWQgc2V0RXh0ZW5zaW9uQVBJKGluIERPTVN0cmlu ZyBzY3JpcHQpOworICAgICAgICB2b2lkIHNldEF0dGFjaGVkV2luZG93SGVpZ2h0KGluIFtPcHRp b25hbD1DYWxsV2l0aERlZmF1bHRWYWx1ZV0gdW5zaWduZWQgbG9uZyBoZWlnaHQpOworICAgICAg ICB2b2lkIG1vdmVXaW5kb3dCeShpbiBbT3B0aW9uYWw9Q2FsbFdpdGhEZWZhdWx0VmFsdWVdIGZs b2F0IHgsIAorICAgICAgICAgICAgICAgICAgICAgICAgICBpbiBbT3B0aW9uYWw9Q2FsbFdpdGhE ZWZhdWx0VmFsdWVdIGZsb2F0IHkpOworICAgICAgICB2b2lkIHNldEV4dGVuc2lvbkFQSShpbiBb T3B0aW9uYWw9Q2FsbFdpdGhEZWZhdWx0VmFsdWVdIERPTVN0cmluZyBzY3JpcHQpOwogCiAgICAg ICAgIERPTVN0cmluZyBsb2NhbGl6ZWRTdHJpbmdzVVJMKCk7CiAgICAgICAgIERPTVN0cmluZyBo aWRkZW5QYW5lbHMoKTsKIAotICAgICAgICB2b2lkIGNvcHlUZXh0KGluIERPTVN0cmluZyB0ZXh0 KTsKLSAgICAgICAgdm9pZCBzYXZlQXMoaW4gRE9NU3RyaW5nIGZpbGVOYW1lLCBpbiBET01TdHJp bmcgY29udGVudCk7CisgICAgICAgIHZvaWQgY29weVRleHQoaW4gW09wdGlvbmFsPUNhbGxXaXRo RGVmYXVsdFZhbHVlXSBET01TdHJpbmcgdGV4dCk7CisgICAgICAgIHZvaWQgc2F2ZUFzKGluIFtP cHRpb25hbD1DYWxsV2l0aERlZmF1bHRWYWx1ZV0gRE9NU3RyaW5nIGZpbGVOYW1lLCAKKyAgICAg ICAgICAgICAgICAgICAgaW4gW09wdGlvbmFsPUNhbGxXaXRoRGVmYXVsdFZhbHVlXSBET01TdHJp bmcgY29udGVudCk7CiAKICAgICAgICAgW0N1c3RvbV0gRE9NU3RyaW5nIHBsYXRmb3JtKCk7CiAg ICAgICAgIFtDdXN0b21dIERPTVN0cmluZyBwb3J0KCk7CiAgICAgICAgIFtDdXN0b21dIHZvaWQg c2hvd0NvbnRleHRNZW51KGluIE1vdXNlRXZlbnQgZXZlbnQsIGluIERPTU9iamVjdCBpdGVtcyk7 Ci0gICAgICAgIHZvaWQgc2VuZE1lc3NhZ2VUb0JhY2tlbmQoaW4gRE9NU3RyaW5nIG1lc3NhZ2Up OworICAgICAgICB2b2lkIHNlbmRNZXNzYWdlVG9CYWNrZW5kKGluIFtPcHRpb25hbD1DYWxsV2l0 aERlZmF1bHRWYWx1ZV0gRE9NU3RyaW5nIG1lc3NhZ2UpOwogCiAgICAgICAgIFtDdXN0b21dIHZv aWQgcmVjb3JkQWN0aW9uVGFrZW4oaW4gdW5zaWduZWQgbG9uZyBhY3Rpb25Db2RlKTsKICAgICAg ICAgW0N1c3RvbV0gdm9pZCByZWNvcmRQYW5lbFNob3duKGluIHVuc2lnbmVkIGxvbmcgcGFuZWxD b2RlKTsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9KYXZhU2NyaXB0Q2FsbEZyYW1l LmlkbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSmF2YVNjcmlwdENh bGxGcmFtZS5pZGwJKHJldmlzaW9uIDkyMzQyKQorKysgU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L0phdmFTY3JpcHRDYWxsRnJhbWUuaWRsCSh3b3JraW5nIGNvcHkpCkBAIC0yNyw3ICsyNyw2IEBA IG1vZHVsZSBpbnNwZWN0b3IgewogCiAgICAgaW50ZXJmYWNlIFsKICAgICAgICAgQ29uZGl0aW9u YWw9SkFWQVNDUklQVF9ERUJVR0dFUiwKLSAgICAgICAgTGVnYWN5RGVmYXVsdE9wdGlvbmFsQXJn dW1lbnRzLAogICAgICAgICBPbWl0Q29uc3RydWN0b3IsCiAgICAgICAgIERvbnRDaGVja0VudW1z CiAgICAgXSBKYXZhU2NyaXB0Q2FsbEZyYW1lIHsK 112884 2011-10-28 11:27:27 -0700 2011-10-28 12:29:15 -0700 Patch bug-65748-20111028112726.patch text/plain 2335 arv U3VidmVyc2lvbiBSZXZpc2lvbjogOTg3MjgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAzNGM0ODQ0MDExNWZiNTFk MWNhZDM1YmQwODYyY2ExYTQxMzFlMTZhLi4wYTA3ODBkMjRlZDkyNDVjOGQ5ODY1NzA1ODI3N2Nk YzZjMTRjZWJjIDEwMDc1NQotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMTAtMjggIEVyaWsg QXJ2aWRzc29uICA8YXJ2QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZW1vdmUgTGVnYWN5RGVm YXVsdE9wdGlvbmFsQXJndW1lbnRzIGZsYWcgZnJvbSBpbnNwZWN0b3IgSURMcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjU3NDgKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5n IHRlc3RzLgorCisgICAgICAgICogaW5zcGVjdG9yL0luamVjdGVkU2NyaXB0SG9zdC5pZGw6Cisg ICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kSG9zdC5pZGw6CisgICAgICAgICog aW5zcGVjdG9yL0phdmFTY3JpcHRDYWxsRnJhbWUuaWRsOgorCiAyMDExLTEwLTI4ICBQYXZlbCBG ZWxkbWFuICA8cGZlbGRtYW5AZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXNldCBsaW5lIG51bWJl cnMgZm9yIHNjcmlwdHMgZ2VuZXJhdGVkIHdpdGggZG9jdW1lbnQud3JpdGUuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5qZWN0ZWRTY3JpcHRIb3N0LmlkbCBiL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9JbmplY3RlZFNjcmlwdEhvc3QuaWRsCmluZGV4IDQxMTRiMDU2 ZTk0ZDA5YzE5ZGQ3YTMzOTY5NGM4Mjk3MjI3OWE2OTIuLjNmMjIxYTVlZTcyNmEyZmU1ZGRkMWNh ZGRmNzI2ZDc0ZjM3ZTAzZWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9J bmplY3RlZFNjcmlwdEhvc3QuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9Jbmpl Y3RlZFNjcmlwdEhvc3QuaWRsCkBAIC0zMiw3ICszMiw2IEBACiAKIG1vZHVsZSBjb3JlIHsKICAg ICBpbnRlcmZhY2UgWwotICAgICAgICBMZWdhY3lEZWZhdWx0T3B0aW9uYWxBcmd1bWVudHMsCiAg ICAgICAgIENvbmRpdGlvbmFsPUlOU1BFQ1RPUgogICAgIF0gSW5qZWN0ZWRTY3JpcHRIb3N0IHsK ICAgICAgICAgdm9pZCBjbGVhckNvbnNvbGVNZXNzYWdlcygpOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kSG9zdC5pZGwgYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmlkbAppbmRleCBlOTg5ZTkzYWU3 YWUzNWU1ZDYzYzJjODU1MmE1ZTRhYWI1ZjgyZGMzLi5jYmIwYmFjYjQ1YTQ0YjcwNzJmOGJhNTBh ZTMyODE1MTg4OWI4M2JjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5z cGVjdG9yRnJvbnRlbmRIb3N0LmlkbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5z cGVjdG9yRnJvbnRlbmRIb3N0LmlkbApAQCAtMzIsNyArMzIsNiBAQAogCiBtb2R1bGUgY29yZSB7 CiAgICAgaW50ZXJmYWNlIFsKLSAgICAgICAgTGVnYWN5RGVmYXVsdE9wdGlvbmFsQXJndW1lbnRz LAogICAgICAgICBDb25kaXRpb25hbD1JTlNQRUNUT1IKICAgICBdIEluc3BlY3RvckZyb250ZW5k SG9zdCB7CiAgICAgICAgIHZvaWQgbG9hZGVkKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvSmF2YVNjcmlwdENhbGxGcmFtZS5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvSmF2YVNjcmlwdENhbGxGcmFtZS5pZGwKaW5kZXggMDBlMDEzNWJkZTczM2YxN2JjNjll MjBlZDM3NGUzMDJkMDk5ZWE4YS4uZGIwZTBhNjJhZjhjYjRhMTI2ZGQ1MDU5NWI3M2VmNWQ5Zjll NjU4MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0phdmFTY3JpcHRDYWxs RnJhbWUuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9KYXZhU2NyaXB0Q2FsbEZy YW1lLmlkbApAQCAtMjcsNyArMjcsNiBAQCBtb2R1bGUgaW5zcGVjdG9yIHsKIAogICAgIGludGVy ZmFjZSBbCiAgICAgICAgIENvbmRpdGlvbmFsPUpBVkFTQ1JJUFRfREVCVUdHRVIsCi0gICAgICAg IExlZ2FjeURlZmF1bHRPcHRpb25hbEFyZ3VtZW50cywKICAgICAgICAgT21pdENvbnN0cnVjdG9y LAogICAgICAgICBEb250Q2hlY2tFbnVtcwogICAgIF0gSmF2YVNjcmlwdENhbGxGcmFtZSB7Cg==