65747 2011-08-04 22:16:50 -0700 Remove LegacyDefaultOptionalArguments flag from notifications IDL files 2011-08-05 06:37:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 pilgrim webkit-unassigned abarth webkit.review.bot oldest_to_newest 447023 0 pilgrim 2011-08-04 22:16:50 -0700 As discussed in IRC, we are migrating our IDL files away from the interface-level "LegacyDefaultOptionalArguments" flag and onto argument-level [Optional] or [Optional=CallWithDefaultValue] flags. This patch migrates the notifications-related IDL files. It does not change any behavior, i.e. it does not make any arguments required that were previously optional, nor vice-versa. All existing tests pass. 447025 1 103036 pilgrim 2011-08-04 22:17:25 -0700 Created attachment 103036 Patch 447056 2 103036 abarth 2011-08-04 23:13:55 -0700 Comment on attachment 103036 Patch Any sense for how far along we are? 447076 3 103036 webkit.review.bot 2011-08-05 00:18:36 -0700 Comment on attachment 103036 Patch Clearing flags on attachment: 103036 Committed r92454: <http://trac.webkit.org/changeset/92454> 447077 4 webkit.review.bot 2011-08-05 00:18:40 -0700 All reviewed patches have been landed. Closing bug. 447180 5 pilgrim 2011-08-05 06:37:08 -0700 Only a handful left. Literally, less than 5. 103036 2011-08-04 22:17:25 -0700 2011-08-05 00:18:36 -0700 Patch bug-65747-20110805011732.patch text/plain 1734 pilgrim SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkyNDQ0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDgtMDQgIE1hcmsgUGls Z3JpbSAgPHBpbGdyaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSBMZWdhY3lEZWZh dWx0T3B0aW9uYWxBcmd1bWVudHMgZmxhZyBmcm9tIG5vdGlmaWNhdGlvbnMgSURMIGZpbGVzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTc0NworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0 cywgYWxsIGV4aXN0aW5nIHRlc3RzIHBhc3MuCisKKyAgICAgICAgKiBub3RpZmljYXRpb25zL05v dGlmaWNhdGlvbi5pZGw6CisgICAgICAgICogbm90aWZpY2F0aW9ucy9Ob3RpZmljYXRpb25DZW50 ZXIuaWRsOgorCiAyMDExLTA4LTA0ICBNYXJrIFBpbGdyaW0gIDxwaWxncmltQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBSZW1vdmUgTGVnYWN5RGVmYXVsdE9wdGlvbmFsQXJndW1lbnRzIGZsYWcg ZnJvbSBjYW52YXMgSURMIGZpbGVzCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9ub3RpZmljYXRpb25z L05vdGlmaWNhdGlvbi5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvbm90aWZpY2F0 aW9ucy9Ob3RpZmljYXRpb24uaWRsCShyZXZpc2lvbiA5MjM0MikKKysrIFNvdXJjZS9XZWJDb3Jl L25vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uLmlkbAkod29ya2luZyBjb3B5KQpAQCAtMzMsNyAr MzMsNiBAQCBtb2R1bGUgdGhyZWFkcyB7CiAKICAgICBpbnRlcmZhY2UgWwogICAgICAgICBDb25k aXRpb25hbD1OT1RJRklDQVRJT05TLAotICAgICAgICBMZWdhY3lEZWZhdWx0T3B0aW9uYWxBcmd1 bWVudHMsCiAgICAgICAgIEFjdGl2ZURPTU9iamVjdCwKICAgICAgICAgRXZlbnRUYXJnZXQsCiAg ICAgICAgIE9taXRDb25zdHJ1Y3RvcgpJbmRleDogU291cmNlL1dlYkNvcmUvbm90aWZpY2F0aW9u cy9Ob3RpZmljYXRpb25DZW50ZXIuaWRsCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL25v dGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uQ2VudGVyLmlkbAkocmV2aXNpb24gOTIzNDIpCisrKyBT b3VyY2UvV2ViQ29yZS9ub3RpZmljYXRpb25zL05vdGlmaWNhdGlvbkNlbnRlci5pZGwJKHdvcmtp bmcgY29weSkKQEAgLTM0LDcgKzM0LDYgQEAgbW9kdWxlIHRocmVhZHMgewogICAgIGludGVyZmFj ZSBbCiAgICAgICAgIENvbmRpdGlvbmFsPU5PVElGSUNBVElPTlMsCiAgICAgICAgIEFjdGl2ZURP TU9iamVjdCwKLSAgICAgICAgTGVnYWN5RGVmYXVsdE9wdGlvbmFsQXJndW1lbnRzLAogICAgICAg ICBPbWl0Q29uc3RydWN0b3IKICAgICBdIE5vdGlmaWNhdGlvbkNlbnRlciB7CiAgICAgICAgW1Y4 Q3VzdG9tXSBOb3RpZmljYXRpb24gY3JlYXRlSFRNTE5vdGlmaWNhdGlvbihpbiBET01TdHJpbmcg dXJsKSByYWlzZXMoRXhjZXB0aW9uKTsK