65745 2011-08-04 21:51:53 -0700 Remove LegacyDefaultOptionalArguments flag from plugin IDL files 2011-08-04 22:42:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 pilgrim webkit-unassigned abarth webkit.review.bot oldest_to_newest 447017 0 pilgrim 2011-08-04 21:51:53 -0700 As discussed in IRC, we are migrating our IDL files away from the interface-level "LegacyDefaultOptionalArguments" flag and onto argument-level [Optional] or [Optional=CallWithDefaultValue] flags. This patch migrates all remaining plugins-related IDL files. It does not change any behavior, i.e. it does not make any arguments required that were previously optional, nor vice-versa. All existing tests pass. 447018 1 103033 pilgrim 2011-08-04 21:52:29 -0700 Created attachment 103033 Patch 447045 2 103033 webkit.review.bot 2011-08-04 22:42:33 -0700 Comment on attachment 103033 Patch Clearing flags on attachment: 103033 Committed r92447: <http://trac.webkit.org/changeset/92447> 447046 3 webkit.review.bot 2011-08-04 22:42:37 -0700 All reviewed patches have been landed. Closing bug. 103033 2011-08-04 21:52:29 -0700 2011-08-04 22:42:33 -0700 Patch bug-65745-20110805005236.patch text/plain 3251 pilgrim SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkyNDQ0KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDgtMDQgIE1hcmsgUGls Z3JpbSAgPHBpbGdyaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSBMZWdhY3lEZWZh dWx0T3B0aW9uYWxBcmd1bWVudHMgZmxhZyBmcm9tIHBsdWdpbiBJREwgZmlsZXMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1NzQ1CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBhbGwg ZXhpc3RpbmcgdGVzdHMgcGFzcy4KKworICAgICAgICAqIHBsdWdpbnMvRE9NTWltZVR5cGVBcnJh eS5pZGw6CisgICAgICAgICogcGx1Z2lucy9ET01QbHVnaW4uaWRsOgorICAgICAgICAqIHBsdWdp bnMvRE9NUGx1Z2luQXJyYXkuaWRsOgorCiAyMDExLTA4LTA0ICBNYXJrIFBpbGdyaW0gIDxwaWxn cmltQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZW1vdmUgTGVnYWN5RGVmYXVsdE9wdGlvbmFs QXJndW1lbnRzIGZsYWcgZnJvbSBjYW52YXMgSURMIGZpbGVzCkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9wbHVnaW5zL0RPTU1pbWVUeXBlQXJyYXkuaWRsCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJD b3JlL3BsdWdpbnMvRE9NTWltZVR5cGVBcnJheS5pZGwJKHJldmlzaW9uIDkyMzQyKQorKysgU291 cmNlL1dlYkNvcmUvcGx1Z2lucy9ET01NaW1lVHlwZUFycmF5LmlkbAkod29ya2luZyBjb3B5KQpA QCAtMjEsMTQgKzIxLDEzIEBACiBtb2R1bGUgd2luZG93IHsKIAogICAgIGludGVyZmFjZSBbCi0g ICAgICAgIExlZ2FjeURlZmF1bHRPcHRpb25hbEFyZ3VtZW50cywKICAgICAgICAgR2VuZXJhdGVJ c1JlYWNoYWJsZT1JbXBsRnJhbWUsCiAgICAgICAgIEhhc05hbWVHZXR0ZXIsCiAgICAgICAgIEhh c0luZGV4R2V0dGVyCiAgICAgXSBET01NaW1lVHlwZUFycmF5IHsKICAgICAgICAgcmVhZG9ubHkg YXR0cmlidXRlIHVuc2lnbmVkIGxvbmcgbGVuZ3RoOwotICAgICAgICBET01NaW1lVHlwZSBpdGVt KGluIHVuc2lnbmVkIGxvbmcgaW5kZXgpOwotICAgICAgICBET01NaW1lVHlwZSBuYW1lZEl0ZW0o aW4gRE9NU3RyaW5nIG5hbWUpOworICAgICAgICBET01NaW1lVHlwZSBpdGVtKGluIFtPcHRpb25h bD1DYWxsV2l0aERlZmF1bHRWYWx1ZV0gdW5zaWduZWQgbG9uZyBpbmRleCk7CisgICAgICAgIERP TU1pbWVUeXBlIG5hbWVkSXRlbShpbiBbT3B0aW9uYWw9Q2FsbFdpdGhEZWZhdWx0VmFsdWVdIERP TVN0cmluZyBuYW1lKTsKICAgICB9OwogCiB9CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbHVnaW5z L0RPTVBsdWdpbi5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGx1Z2lucy9ET01Q bHVnaW4uaWRsCShyZXZpc2lvbiA5MjM0MikKKysrIFNvdXJjZS9XZWJDb3JlL3BsdWdpbnMvRE9N UGx1Z2luLmlkbAkod29ya2luZyBjb3B5KQpAQCAtMjEsNyArMjEsNiBAQAogbW9kdWxlIHdpbmRv dyB7CiAKICAgICBpbnRlcmZhY2UgWwotICAgICAgICBMZWdhY3lEZWZhdWx0T3B0aW9uYWxBcmd1 bWVudHMsCiAgICAgICAgIEhhc05hbWVHZXR0ZXIsCiAgICAgICAgIEhhc0luZGV4R2V0dGVyCiAg ICAgXSBET01QbHVnaW4gewpAQCAtMjksOCArMjgsOCBAQCBtb2R1bGUgd2luZG93IHsKICAgICAg ICAgcmVhZG9ubHkgYXR0cmlidXRlIERPTVN0cmluZyBmaWxlbmFtZTsKICAgICAgICAgcmVhZG9u bHkgYXR0cmlidXRlIERPTVN0cmluZyBkZXNjcmlwdGlvbjsKICAgICAgICAgcmVhZG9ubHkgYXR0 cmlidXRlIHVuc2lnbmVkIGxvbmcgbGVuZ3RoOwotICAgICAgICBET01NaW1lVHlwZSBpdGVtKGlu IHVuc2lnbmVkIGxvbmcgaW5kZXgpOwotICAgICAgICBET01NaW1lVHlwZSBuYW1lZEl0ZW0oaW4g RE9NU3RyaW5nIG5hbWUpOworICAgICAgICBET01NaW1lVHlwZSBpdGVtKGluIFtPcHRpb25hbD1D YWxsV2l0aERlZmF1bHRWYWx1ZV0gdW5zaWduZWQgbG9uZyBpbmRleCk7CisgICAgICAgIERPTU1p bWVUeXBlIG5hbWVkSXRlbShpbiBbT3B0aW9uYWw9Q2FsbFdpdGhEZWZhdWx0VmFsdWVdIERPTVN0 cmluZyBuYW1lKTsKICAgICB9OwogCiB9CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbHVnaW5zL0RP TVBsdWdpbkFycmF5LmlkbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbHVnaW5zL0RP TVBsdWdpbkFycmF5LmlkbAkocmV2aXNpb24gOTIzNDIpCisrKyBTb3VyY2UvV2ViQ29yZS9wbHVn aW5zL0RPTVBsdWdpbkFycmF5LmlkbAkod29ya2luZyBjb3B5KQpAQCAtMjEsMTUgKzIxLDE0IEBA CiBtb2R1bGUgd2luZG93IHsKIAogICAgIGludGVyZmFjZSBbCi0gICAgICAgIExlZ2FjeURlZmF1 bHRPcHRpb25hbEFyZ3VtZW50cywKICAgICAgICAgR2VuZXJhdGVJc1JlYWNoYWJsZT1JbXBsRnJh bWUsCiAgICAgICAgIEhhc05hbWVHZXR0ZXIsCiAgICAgICAgIEhhc0luZGV4R2V0dGVyCiAgICAg XSBET01QbHVnaW5BcnJheSB7CiAgICAgICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSB1bnNpZ25lZCBs b25nIGxlbmd0aDsKLSAgICAgICAgRE9NUGx1Z2luIGl0ZW0oaW4gdW5zaWduZWQgbG9uZyBpbmRl eCk7Ci0gICAgICAgIERPTVBsdWdpbiBuYW1lZEl0ZW0oaW4gRE9NU3RyaW5nIG5hbWUpOwotICAg ICAgICB2b2lkIHJlZnJlc2goaW4gYm9vbGVhbiByZWxvYWQpOworICAgICAgICBET01QbHVnaW4g aXRlbShpbiBbT3B0aW9uYWw9Q2FsbFdpdGhEZWZhdWx0VmFsdWVdIHVuc2lnbmVkIGxvbmcgaW5k ZXgpOworICAgICAgICBET01QbHVnaW4gbmFtZWRJdGVtKGluIFtPcHRpb25hbD1DYWxsV2l0aERl ZmF1bHRWYWx1ZV0gRE9NU3RyaW5nIG5hbWUpOworICAgICAgICB2b2lkIHJlZnJlc2goaW4gW09w dGlvbmFsPUNhbGxXaXRoRGVmYXVsdFZhbHVlXSBib29sZWFuIHJlbG9hZCk7CiAgICAgfTsKIAog fQo=