65740 2011-08-04 21:01:26 -0700 Remove LegacyDefaultOptionalArguments flag from XML/XSL IDL files 2011-08-05 23:43:18 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 pilgrim webkit-unassigned abarth noel.gordon webkit.review.bot oldest_to_newest 446994 0 pilgrim 2011-08-04 21:01:26 -0700 As discussed in IRC, we are migrating our IDL files away from the interface-level "LegacyDefaultOptionalArguments" flag and onto argument-level [Optional] or [Optional=CallWithDefaultValue] flags. This patch migrates XMLHttpRequest and XSL-related IDL files. It does not change any behavior, i.e. it does not make any arguments required that were previously optional, nor vice-versa. All existing tests pass. 446995 1 103028 pilgrim 2011-08-04 21:02:13 -0700 Created attachment 103028 Patch 447042 2 103028 webkit.review.bot 2011-08-04 22:37:37 -0700 Comment on attachment 103028 Patch Clearing flags on attachment: 103028 Committed r92446: <http://trac.webkit.org/changeset/92446> 447043 3 webkit.review.bot 2011-08-04 22:37:41 -0700 All reviewed patches have been landed. Closing bug. 447569 4 noel.gordon 2011-08-05 21:19:54 -0700 fyi, xsl test changed in this range http://trac.webkit.org/log/?verbose=on&rev=92450&stop_rev=92446 http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=fast%2Fxsl%2Fimport-after-comment.xml%2Cfast%2Fxsl%2Fxslt-import-depth.xml%2Cfast%2Fxsl%2Fxslt-nested-stylesheets.xml%2Cfast%2Fxsl%2Fxslt-second-level-import.xml 447571 5 abarth 2011-08-05 21:35:19 -0700 There was some discussion on IRC about http://trac.webkit.org/changeset/92448/ causing problems with XSLT. 447572 6 noel.gordon 2011-08-05 21:38:41 -0700 Good to know. Will add the same note to bug 65506. 447574 7 noel.gordon 2011-08-05 22:06:07 -0700 Gardener wasn't sure about what changed either: bug 65757, bug 65758. 447576 8 abarth 2011-08-05 22:32:13 -0700 We can try rolling out this patch, if we want to be sure. 447583 9 noel.gordon 2011-08-05 23:43:18 -0700 Not needed -- bug 65757, bug 65758 state that some xsl tests started failing on chromium win/mac/linux. But they pass on win locally for me at ToT. The flakiness dashboard states that these tests need the expectations "MISSING CRASH", and the gardener dutifully added those :) That dashboard can be misleading. I see no regressions here. 103028 2011-08-04 21:02:13 -0700 2011-08-04 22:37:37 -0700 Patch bug-65740-20110805000220.patch text/plain 6438 pilgrim SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkyNDQzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDgtMDQgIE1hcmsgUGls Z3JpbSAgPHBpbGdyaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSBMZWdhY3lEZWZh dWx0T3B0aW9uYWxBcmd1bWVudHMgZmxhZyBmcm9tIFhNTC9YU0wgSURMIGZpbGVzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTc0MAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYWxs IGV4aXN0aW5nIHRlc3RzIHBhc3MuCisKKyAgICAgICAgKiB4bWwvRE9NUGFyc2VyLmlkbDoKKyAg ICAgICAgKiB4bWwvWE1MU2VyaWFsaXplci5pZGw6CisgICAgICAgICogeG1sL1hQYXRoRXZhbHVh dG9yLmlkbDoKKyAgICAgICAgKiB4bWwvWFBhdGhFeHByZXNzaW9uLmlkbDoKKyAgICAgICAgKiB4 bWwvWFBhdGhOU1Jlc29sdmVyLmlkbDoKKyAgICAgICAgKiB4bWwvWFBhdGhSZXN1bHQuaWRsOgor ICAgICAgICAqIHhtbC9YU0xUUHJvY2Vzc29yLmlkbDoKKwogMjAxMS0wOC0wNCAgTWFyayBQaWxn cmltICA8cGlsZ3JpbUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmVtb3ZlIExlZ2FjeURlZmF1 bHRPcHRpb25hbEFyZ3VtZW50cyBmbGFnIGZyb20gY2FudmFzIElETCBmaWxlcwpJbmRleDogU291 cmNlL1dlYkNvcmUveG1sL0RPTVBhcnNlci5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUveG1sL0RPTVBhcnNlci5pZGwJKHJldmlzaW9uIDkyMzQyKQorKysgU291cmNlL1dlYkNvcmUv eG1sL0RPTVBhcnNlci5pZGwJKHdvcmtpbmcgY29weSkKQEAgLTE5LDkgKzE5LDkgQEAKIAogbW9k dWxlIHhwYXRoIHsKICAgICBpbnRlcmZhY2UgWwotICAgICAgICBMZWdhY3lEZWZhdWx0T3B0aW9u YWxBcmd1bWVudHMsCiAgICAgICAgIENhbkJlQ29uc3RydWN0ZWQKICAgICBdIERPTVBhcnNlciB7 Ci0gICAgICAgIERvY3VtZW50IHBhcnNlRnJvbVN0cmluZyhpbiBET01TdHJpbmcgc3RyLCBpbiBE T01TdHJpbmcgY29udGVudFR5cGUpOworICAgICAgICBEb2N1bWVudCBwYXJzZUZyb21TdHJpbmco aW4gW09wdGlvbmFsPUNhbGxXaXRoRGVmYXVsdFZhbHVlXSBET01TdHJpbmcgc3RyLCAKKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGluIFtPcHRpb25hbD1DYWxsV2l0aERlZmF1bHRW YWx1ZV0gRE9NU3RyaW5nIGNvbnRlbnRUeXBlKTsKICAgICB9OwogfQpJbmRleDogU291cmNlL1dl YkNvcmUveG1sL1hNTFNlcmlhbGl6ZXIuaWRsCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L3htbC9YTUxTZXJpYWxpemVyLmlkbAkocmV2aXNpb24gOTIzNDIpCisrKyBTb3VyY2UvV2ViQ29y ZS94bWwvWE1MU2VyaWFsaXplci5pZGwJKHdvcmtpbmcgY29weSkKQEAgLTIxLDEwICsyMSw5IEBA CiBtb2R1bGUgeHBhdGggewogCiAgICAgaW50ZXJmYWNlIFsKLSAgICAgICAgTGVnYWN5RGVmYXVs dE9wdGlvbmFsQXJndW1lbnRzLAogICAgICAgICBDYW5CZUNvbnN0cnVjdGVkCiAgICAgXSBYTUxT ZXJpYWxpemVyIHsKLSAgICAgICAgRE9NU3RyaW5nIHNlcmlhbGl6ZVRvU3RyaW5nKGluIE5vZGUg bm9kZSkKKyAgICAgICAgRE9NU3RyaW5nIHNlcmlhbGl6ZVRvU3RyaW5nKGluIFtPcHRpb25hbD1D YWxsV2l0aERlZmF1bHRWYWx1ZV0gTm9kZSBub2RlKQogICAgICAgICAgICAgcmFpc2VzKERPTUV4 Y2VwdGlvbik7CiAgICAgfTsKIApJbmRleDogU291cmNlL1dlYkNvcmUveG1sL1hQYXRoRXZhbHVh dG9yLmlkbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS94bWwvWFBhdGhFdmFsdWF0b3Iu aWRsCShyZXZpc2lvbiA5MjM0MikKKysrIFNvdXJjZS9XZWJDb3JlL3htbC9YUGF0aEV2YWx1YXRv ci5pZGwJKHdvcmtpbmcgY29weSkKQEAgLTE5LDIxICsxOSwyMCBAQAogCiBtb2R1bGUgeHBhdGgg ewogICAgIGludGVyZmFjZSBbCi0gICAgICAgIExlZ2FjeURlZmF1bHRPcHRpb25hbEFyZ3VtZW50 cywKICAgICAgICAgQ2FuQmVDb25zdHJ1Y3RlZCwKICAgICAgICAgQ29uZGl0aW9uYWw9WFBBVEgK ICAgICBdIFhQYXRoRXZhbHVhdG9yIHsKLSAgICAgICAgWFBhdGhFeHByZXNzaW9uIGNyZWF0ZUV4 cHJlc3Npb24oaW4gRE9NU3RyaW5nIGV4cHJlc3Npb24sCi0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIGluIFhQYXRoTlNSZXNvbHZlciByZXNvbHZlcikKKyAgICAgICAg WFBhdGhFeHByZXNzaW9uIGNyZWF0ZUV4cHJlc3Npb24oaW4gW09wdGlvbmFsPUNhbGxXaXRoRGVm YXVsdFZhbHVlXSBET01TdHJpbmcgZXhwcmVzc2lvbiwKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgaW4gW09wdGlvbmFsPUNhbGxXaXRoRGVmYXVsdFZhbHVlXSBYUGF0 aE5TUmVzb2x2ZXIgcmVzb2x2ZXIpCiAgICAgICAgICAgICByYWlzZXMoRE9NRXhjZXB0aW9uKTsK IAotICAgICAgICBYUGF0aE5TUmVzb2x2ZXIgY3JlYXRlTlNSZXNvbHZlcihpbiBOb2RlIG5vZGVS ZXNvbHZlcik7CisgICAgICAgIFhQYXRoTlNSZXNvbHZlciBjcmVhdGVOU1Jlc29sdmVyKGluIFtP cHRpb25hbD1DYWxsV2l0aERlZmF1bHRWYWx1ZV0gTm9kZSBub2RlUmVzb2x2ZXIpOwogCi0gICAg ICAgIFhQYXRoUmVzdWx0IGV2YWx1YXRlKGluIERPTVN0cmluZyBleHByZXNzaW9uLAotICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBpbiBOb2RlIGNvbnRleHROb2RlLCAKLSAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgaW4gWFBhdGhOU1Jlc29sdmVyIHJlc29sdmVyLAotICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBpbiB1bnNpZ25lZCBzaG9ydCB0eXBlLAotICAgICAgICAgICAg ICAgICAgICAgICAgICAgICBpbiBYUGF0aFJlc3VsdCBpblJlc3VsdCkKKyAgICAgICAgWFBhdGhS ZXN1bHQgZXZhbHVhdGUoaW4gW09wdGlvbmFsPUNhbGxXaXRoRGVmYXVsdFZhbHVlXSBET01TdHJp bmcgZXhwcmVzc2lvbiwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW4gW09wdGlvbmFs PUNhbGxXaXRoRGVmYXVsdFZhbHVlXSBOb2RlIGNvbnRleHROb2RlLCAKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgaW4gW09wdGlvbmFsPUNhbGxXaXRoRGVmYXVsdFZhbHVlXSBYUGF0aE5T UmVzb2x2ZXIgcmVzb2x2ZXIsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGluIFtPcHRp b25hbD1DYWxsV2l0aERlZmF1bHRWYWx1ZV0gdW5zaWduZWQgc2hvcnQgdHlwZSwKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgaW4gW09wdGlvbmFsPUNhbGxXaXRoRGVmYXVsdFZhbHVlXSBY UGF0aFJlc3VsdCBpblJlc3VsdCkKICAgICAgICAgICAgIHJhaXNlcyhET01FeGNlcHRpb24pOwog ICAgIH07CiB9CkluZGV4OiBTb3VyY2UvV2ViQ29yZS94bWwvWFBhdGhFeHByZXNzaW9uLmlkbAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS94bWwvWFBhdGhFeHByZXNzaW9uLmlkbAkocmV2 aXNpb24gOTIzNDIpCisrKyBTb3VyY2UvV2ViQ29yZS94bWwvWFBhdGhFeHByZXNzaW9uLmlkbAko d29ya2luZyBjb3B5KQpAQCAtMjIsMTIgKzIyLDExIEBAIG1vZHVsZSB4cGF0aCB7CiAKIAogICAg IGludGVyZmFjZSBbCi0gICAgICAgIExlZ2FjeURlZmF1bHRPcHRpb25hbEFyZ3VtZW50cywKICAg ICAgICAgQ29uZGl0aW9uYWw9WFBBVEgKICAgICBdIFhQYXRoRXhwcmVzc2lvbiB7Ci0gICAgICAg IFtPbGRTdHlsZU9iakNdIFhQYXRoUmVzdWx0IGV2YWx1YXRlKGluIE5vZGUgY29udGV4dE5vZGUs IAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbiB1bnNpZ25l ZCBzaG9ydCB0eXBlLCAKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgaW4gWFBhdGhSZXN1bHQgaW5SZXN1bHQpCisgICAgICAgIFtPbGRTdHlsZU9iakNdIFhQYXRo UmVzdWx0IGV2YWx1YXRlKGluIFtPcHRpb25hbD1DYWxsV2l0aERlZmF1bHRWYWx1ZV0gTm9kZSBj b250ZXh0Tm9kZSwgCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IGluIFtPcHRpb25hbD1DYWxsV2l0aERlZmF1bHRWYWx1ZV0gdW5zaWduZWQgc2hvcnQgdHlwZSwg CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGluIFtPcHRpb25h bD1DYWxsV2l0aERlZmF1bHRWYWx1ZV0gWFBhdGhSZXN1bHQgaW5SZXN1bHQpCiAgICAgICAgICAg ICByYWlzZXMoRE9NRXhjZXB0aW9uKTsKICAgICB9OwogCkluZGV4OiBTb3VyY2UvV2ViQ29yZS94 bWwvWFBhdGhOU1Jlc29sdmVyLmlkbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS94bWwv WFBhdGhOU1Jlc29sdmVyLmlkbAkocmV2aXNpb24gOTIzNDIpCisrKyBTb3VyY2UvV2ViQ29yZS94 bWwvWFBhdGhOU1Jlc29sdmVyLmlkbAkod29ya2luZyBjb3B5KQpAQCAtMjEsMTIgKzIxLDExIEBA CiBtb2R1bGUgeHBhdGggewogCiAgICAgaW50ZXJmYWNlIFsKLSAgICAgICAgTGVnYWN5RGVmYXVs dE9wdGlvbmFsQXJndW1lbnRzLAogICAgICAgICBPYmpDUHJvdG9jb2wsCiAgICAgICAgIENvbmRp dGlvbmFsPVhQQVRILAogICAgICAgICBPbWl0Q29uc3RydWN0b3IKICAgICBdIFhQYXRoTlNSZXNv bHZlciB7Ci0gICAgICAgIFtDb252ZXJ0TnVsbFN0cmluZ1RvPU51bGxdIERPTVN0cmluZyBsb29r dXBOYW1lc3BhY2VVUkkoaW4gRE9NU3RyaW5nIHByZWZpeCk7CisgICAgICAgIFtDb252ZXJ0TnVs bFN0cmluZ1RvPU51bGxdIERPTVN0cmluZyBsb29rdXBOYW1lc3BhY2VVUkkoaW4gW09wdGlvbmFs PUNhbGxXaXRoRGVmYXVsdFZhbHVlXSBET01TdHJpbmcgcHJlZml4KTsKICAgICB9OwogCiB9Cklu ZGV4OiBTb3VyY2UvV2ViQ29yZS94bWwvWFBhdGhSZXN1bHQuaWRsCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL3htbC9YUGF0aFJlc3VsdC5pZGwJKHJldmlzaW9uIDkyMzQyKQorKysgU291 cmNlL1dlYkNvcmUveG1sL1hQYXRoUmVzdWx0LmlkbAkod29ya2luZyBjb3B5KQpAQCAtMjAsNyAr MjAsNiBAQAogbW9kdWxlIHhwYXRoIHsKIAogICAgIGludGVyZmFjZSBbCi0gICAgICAgIExlZ2Fj eURlZmF1bHRPcHRpb25hbEFyZ3VtZW50cywKICAgICAgICAgQ29uZGl0aW9uYWw9WFBBVEgsCiAg ICAgICAgIEN1c3RvbU1hcmtGdW5jdGlvbgogICAgIF0gWFBhdGhSZXN1bHQgewpAQCAtNTQsNyAr NTMsNyBAQCBtb2R1bGUgeHBhdGggewogICAgICAgICAgICAgCiAgICAgICAgIE5vZGUgaXRlcmF0 ZU5leHQoKQogICAgICAgICAgICAgcmFpc2VzIChET01FeGNlcHRpb24pOwotICAgICAgICBOb2Rl IHNuYXBzaG90SXRlbShpbiB1bnNpZ25lZCBsb25nIGluZGV4KQorICAgICAgICBOb2RlIHNuYXBz aG90SXRlbShpbiBbT3B0aW9uYWw9Q2FsbFdpdGhEZWZhdWx0VmFsdWVdIHVuc2lnbmVkIGxvbmcg aW5kZXgpCiAgICAgICAgICAgICByYWlzZXMgKERPTUV4Y2VwdGlvbik7CiAgICAgfTsKIApJbmRl eDogU291cmNlL1dlYkNvcmUveG1sL1hTTFRQcm9jZXNzb3IuaWRsCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL3htbC9YU0xUUHJvY2Vzc29yLmlkbAkocmV2aXNpb24gOTIzNDIpCisrKyBT b3VyY2UvV2ViQ29yZS94bWwvWFNMVFByb2Nlc3Nvci5pZGwJKHdvcmtpbmcgY29weSkKQEAgLTMz LDcgKzMzLDYgQEAgbW9kdWxlIHhtbCB7CiAgICAgLy8gaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NTQ0NgogCiAgICAgaW50ZXJmYWNlIFsKLSAgICAgICAgTGVnYWN5RGVm YXVsdE9wdGlvbmFsQXJndW1lbnRzLAogICAgICAgICBDb25kaXRpb25hbD1YU0xULAogICAgICAg ICBDYW5CZUNvbnN0cnVjdGVkLAogICAgICAgICBDdXN0b21Db25zdHJ1Y3RGdW5jdGlvbiwK