65735 2011-08-04 17:30:54 -0700 Add detail to ASSERT message in IDBTransaction::enqueueEvent 2011-08-08 13:18:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dgrogan dgrogan hans japhet webkit.review.bot oldest_to_newest 446920 0 dgrogan 2011-08-04 17:30:54 -0700 Add detail to ASSERT message in IDBTransaction::enqueueEvent 446922 1 103009 dgrogan 2011-08-04 17:33:51 -0700 Created attachment 103009 Patch 446924 2 103009 dgrogan 2011-08-04 17:35:04 -0700 Comment on attachment 103009 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103009&action=review > Source/WebCore/storage/IDBTransaction.cpp:185 > + ASSERT_WITH_MESSAGE(!m_finished, "!m_finished, about to enqueue an event of type %s", event->type().string().utf8().data()); Will this print out the !m_finished for me? 447149 3 hans 2011-08-05 03:59:53 -0700 (In reply to comment #2) > (From update of attachment 103009 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=103009&action=review > > > Source/WebCore/storage/IDBTransaction.cpp:185 > > + ASSERT_WITH_MESSAGE(!m_finished, "!m_finished, about to enqueue an event of type %s", event->type().string().utf8().data()); > > Will this print out the !m_finished for me? Not sure I understand what you mean.. I suppose it will print when the assertion doesn't hold, i.e. when m_finished == true? 447340 4 103094 dgrogan 2011-08-05 12:30:31 -0700 Created attachment 103094 Patch 447346 5 103009 dgrogan 2011-08-05 12:35:26 -0700 Comment on attachment 103009 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103009&action=review >>> Source/WebCore/storage/IDBTransaction.cpp:185 >>> + ASSERT_WITH_MESSAGE(!m_finished, "!m_finished, about to enqueue an event of type %s", event->type().string().utf8().data()); >> >> Will this print out the !m_finished for me? > > Not sure I understand what you mean.. I suppose it will print when the assertion doesn't hold, i.e. when m_finished == true? if the assertion fails with ASSERT(!m_finished), it prints out "!m_finished\n file, line etc". if the assertion fails with ASSERT_WITH_MESSAGE(!m_finished, "some stuff") I didn't know if the assertion would print "!m_finished, some stuff\n file line etc" or just "some stuff\n file line etc" Turns out it's the first, '!m_finished' is included so I don't need to explicitly print it. 447350 6 103096 dgrogan 2011-08-05 12:39:45 -0700 Created attachment 103096 Patch 447928 7 hans 2011-08-08 03:13:51 -0700 (In reply to comment #6) > Created an attachment (id=103096) [details] > Patch LGTM 448137 8 dgrogan 2011-08-08 11:41:12 -0700 Nate, could you review this? 448215 9 103096 webkit.review.bot 2011-08-08 13:18:46 -0700 Comment on attachment 103096 Patch Clearing flags on attachment: 103096 Committed r92627: <http://trac.webkit.org/changeset/92627> 448216 10 webkit.review.bot 2011-08-08 13:18:50 -0700 All reviewed patches have been landed. Closing bug. 103009 2011-08-04 17:33:51 -0700 2011-08-05 12:35:26 -0700 Patch bug-65735-20110804173350.patch text/plain 1562 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogOTI0MzAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyNjVlZjNhN2Y2YTdkMTVl Nzk4MmQwOTk5Yzc5ZDkwNmRkMWRkZmI2Li5kY2U5ZmZmODE0MTYwMmNhMTVkNmU3ZjRmMTdlZWQ5 Nzk5YzVkMmNkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDgtMDQgIERhdmlk IEdyb2dhbiAgPGRncm9nYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIEFkZCBkZXRhaWwgdG8g QVNTRVJUIG1lc3NhZ2UgaW4gSURCVHJhbnNhY3Rpb246OmVucXVldWVFdmVudAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjU3MzUKKworICAgICAgICBJ J3ZlIGhpdCB0aGlzIGEgZmV3IHRpbWVzIGJ1dCBoYXZlbid0IGJlZW4gYWJsZSB0byBwaW4gaXQg ZG93bi4gIFRoZQorICAgICAgICBleHRyYSBkZXRhaWwgd2lsbCBiZSBoZWxwZnVsLgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywg anVzdCBhbiBlcnJvciBtZXNzYWdlLgorCisgICAgICAgICogc3RvcmFnZS9JREJUcmFuc2FjdGlv bi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJREJUcmFuc2FjdGlvbjo6ZW5xdWV1ZUV2ZW50KToK KwogMjAxMS0wOC0wNCAgSmFtZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgogCiAg ICAgICAgIFtjaHJvbWl1bV0gSW1wbGVtZW50IGEgZ2xvYmFsIHJlc291cmNlIGxpbWl0IGZvciBE cmF3aW5nQnVmZmVyIHRvIGxpbWl0IHRoZSBhbW91bnQgb2YgR1BVIG1lbW9yeSB1c2VkIGJ5IDJk IGNhbnZhcyBiYWNraW5nIHN0b3JlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvc3RvcmFn ZS9JREJUcmFuc2FjdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9zdG9yYWdlL0lEQlRyYW5zYWN0 aW9uLmNwcAppbmRleCA3MTBiYjc2MTczMWU2YmE0YjAwZDZlZWVlYTYyMzVlODIwMTlkY2ExLi44 MzBkMjc2N2QxMDc3Njk1YTkzY2ViODc3ZGQyYjJhOWNhMWJlY2JhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9zdG9yYWdlL0lEQlRyYW5zYWN0aW9uLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9zdG9yYWdlL0lEQlRyYW5zYWN0aW9uLmNwcApAQCAtMTgyLDcgKzE4Miw3IEBAIHZvaWQgSURC VHJhbnNhY3Rpb246OmNvbnRleHREZXN0cm95ZWQoKQogCiB2b2lkIElEQlRyYW5zYWN0aW9uOjpl bnF1ZXVlRXZlbnQoUGFzc1JlZlB0cjxFdmVudD4gZXZlbnQpCiB7Ci0gICAgQVNTRVJUKCFtX2Zp bmlzaGVkKTsKKyAgICBBU1NFUlRfV0lUSF9NRVNTQUdFKCFtX2ZpbmlzaGVkLCAiIW1fZmluaXNo ZWQsIGFib3V0IHRvIGVucXVldWUgYW4gZXZlbnQgb2YgdHlwZSAlcyIsIGV2ZW50LT50eXBlKCku c3RyaW5nKCkudXRmOCgpLmRhdGEoKSk7CiAgICAgaWYgKCFzY3JpcHRFeGVjdXRpb25Db250ZXh0 KCkpCiAgICAgICAgIHJldHVybjsKIAo= 103094 2011-08-05 12:30:31 -0700 2011-08-05 12:39:42 -0700 Patch bug-65735-20110805123029.patch text/plain 1595 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogOTI0MzAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyNjVlZjNhN2Y2YTdkMTVl Nzk4MmQwOTk5Yzc5ZDkwNmRkMWRkZmI2Li5mM2RlNzI5ZmVkZDVkMWIyYmIyYjcyMDIyYjUzNmVh OWU2M2I5ZGI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDgtMDQgIERhdmlk IEdyb2dhbiAgPGRncm9nYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIEFkZCBkZXRhaWwgdG8g QVNTRVJUIG1lc3NhZ2UgaW4gSURCVHJhbnNhY3Rpb246OmVucXVldWVFdmVudAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjU3MzUKKworICAgICAgICBJ J3ZlIGhpdCB0aGlzIGEgZmV3IHRpbWVzIGJ1dCBoYXZlbid0IGJlZW4gYWJsZSB0byBwaW4gaXQg ZG93bi4gIFRoZQorICAgICAgICBleHRyYSBkZXRhaWwgY291bGQgYmUgaGVscGZ1bC4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMs IGp1c3QgYW4gZXJyb3IgbWVzc2FnZS4KKworICAgICAgICAqIHN0b3JhZ2UvSURCVHJhbnNhY3Rp b24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6SURCVHJhbnNhY3Rpb246OmVucXVldWVFdmVudCk6 CisKIDIwMTEtMDgtMDQgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBbY2hyb21pdW1dIEltcGxlbWVudCBhIGdsb2JhbCByZXNvdXJjZSBsaW1pdCBmb3Ig RHJhd2luZ0J1ZmZlciB0byBsaW1pdCB0aGUgYW1vdW50IG9mIEdQVSBtZW1vcnkgdXNlZCBieSAy ZCBjYW52YXMgYmFja2luZyBzdG9yZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N0b3Jh Z2UvSURCVHJhbnNhY3Rpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvc3RvcmFnZS9JREJUcmFuc2Fj dGlvbi5jcHAKaW5kZXggNzEwYmI3NjE3MzFlNmJhNGIwMGQ2ZWVlZWE2MjM1ZTgyMDE5ZGNhMS4u YWQxZDQ4NzYzYjZlMmZkNTRkOGYzODdhMTRlZmNiMGQ5ZTAyMTczNyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvc3RvcmFnZS9JREJUcmFuc2FjdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvc3RvcmFnZS9JREJUcmFuc2FjdGlvbi5jcHAKQEAgLTE4Miw3ICsxODIsOCBAQCB2b2lkIElE QlRyYW5zYWN0aW9uOjpjb250ZXh0RGVzdHJveWVkKCkKIAogdm9pZCBJREJUcmFuc2FjdGlvbjo6 ZW5xdWV1ZUV2ZW50KFBhc3NSZWZQdHI8RXZlbnQ+IGV2ZW50KQogewotICAgIEFTU0VSVCghbV9m aW5pc2hlZCk7CisgICAgbV9maW5pc2hlZCA9IHRydWU7CisgICAgQVNTRVJUX1dJVEhfTUVTU0FH RSghbV9maW5pc2hlZCwgImZpbmlzaGVkIHRyYW5zYWN0aW9uIHRyaWVkIHRvIGVucXVldWUgYW4g ZXZlbnQgb2YgdHlwZSAlcyIsIGV2ZW50LT50eXBlKCkuc3RyaW5nKCkudXRmOCgpLmRhdGEoKSk7 CiAgICAgaWYgKCFzY3JpcHRFeGVjdXRpb25Db250ZXh0KCkpCiAgICAgICAgIHJldHVybjsKIAo= 103096 2011-08-05 12:39:45 -0700 2011-08-08 13:18:46 -0700 Patch bug-65735-20110805123944.patch text/plain 1574 dgrogan U3VidmVyc2lvbiBSZXZpc2lvbjogOTI0MzAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyNjVlZjNhN2Y2YTdkMTVl Nzk4MmQwOTk5Yzc5ZDkwNmRkMWRkZmI2Li5mM2RlNzI5ZmVkZDVkMWIyYmIyYjcyMDIyYjUzNmVh OWU2M2I5ZGI4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTEtMDgtMDQgIERhdmlk IEdyb2dhbiAgPGRncm9nYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIEFkZCBkZXRhaWwgdG8g QVNTRVJUIG1lc3NhZ2UgaW4gSURCVHJhbnNhY3Rpb246OmVucXVldWVFdmVudAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjU3MzUKKworICAgICAgICBJ J3ZlIGhpdCB0aGlzIGEgZmV3IHRpbWVzIGJ1dCBoYXZlbid0IGJlZW4gYWJsZSB0byBwaW4gaXQg ZG93bi4gIFRoZQorICAgICAgICBleHRyYSBkZXRhaWwgY291bGQgYmUgaGVscGZ1bC4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMs IGp1c3QgYW4gZXJyb3IgbWVzc2FnZS4KKworICAgICAgICAqIHN0b3JhZ2UvSURCVHJhbnNhY3Rp b24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6SURCVHJhbnNhY3Rpb246OmVucXVldWVFdmVudCk6 CisKIDIwMTEtMDgtMDQgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBbY2hyb21pdW1dIEltcGxlbWVudCBhIGdsb2JhbCByZXNvdXJjZSBsaW1pdCBmb3Ig RHJhd2luZ0J1ZmZlciB0byBsaW1pdCB0aGUgYW1vdW50IG9mIEdQVSBtZW1vcnkgdXNlZCBieSAy ZCBjYW52YXMgYmFja2luZyBzdG9yZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N0b3Jh Z2UvSURCVHJhbnNhY3Rpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvc3RvcmFnZS9JREJUcmFuc2Fj dGlvbi5jcHAKaW5kZXggNzEwYmI3NjE3MzFlNmJhNGIwMGQ2ZWVlZWE2MjM1ZTgyMDE5ZGNhMS4u MWE0ZTdmMzE1YTRlZjc4Y2M5Yzg2ZDIwZDg2OTMyOGY2OGY4NDY4NSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvc3RvcmFnZS9JREJUcmFuc2FjdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvc3RvcmFnZS9JREJUcmFuc2FjdGlvbi5jcHAKQEAgLTE4Miw3ICsxODIsNyBAQCB2b2lkIElE QlRyYW5zYWN0aW9uOjpjb250ZXh0RGVzdHJveWVkKCkKIAogdm9pZCBJREJUcmFuc2FjdGlvbjo6 ZW5xdWV1ZUV2ZW50KFBhc3NSZWZQdHI8RXZlbnQ+IGV2ZW50KQogewotICAgIEFTU0VSVCghbV9m aW5pc2hlZCk7CisgICAgQVNTRVJUX1dJVEhfTUVTU0FHRSghbV9maW5pc2hlZCwgIkEgZmluaXNo ZWQgdHJhbnNhY3Rpb24gdHJpZWQgdG8gZW5xdWV1ZSBhbiBldmVudCBvZiB0eXBlICVzLiIsIGV2 ZW50LT50eXBlKCkuc3RyaW5nKCkudXRmOCgpLmRhdGEoKSk7CiAgICAgaWYgKCFzY3JpcHRFeGVj dXRpb25Db250ZXh0KCkpCiAgICAgICAgIHJldHVybjsKIAo=