65733 2011-08-04 16:23:46 -0700 [skia] Moved calls to makeGrContextCurrent into clipPathAntiAliased from callers 2011-08-10 12:48:02 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benwells benwells benwells jamesr mikelawther reed webkit.review.bot oldest_to_newest 446883 0 benwells 2011-08-04 16:23:46 -0700 [skia] Moved calls to makeGrContextCurrent into clipPathAntiAliased from callers 446886 1 103002 benwells 2011-08-04 16:28:41 -0700 Created attachment 103002 Patch 446887 2 103002 benwells 2011-08-04 16:31:04 -0700 Comment on attachment 103002 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103002&action=review > Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp:286 > + makeGrContextCurrent(); Is this the correct place to put this? 446888 3 103002 jamesr 2011-08-04 16:33:40 -0700 Comment on attachment 103002 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103002&action=review >> Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp:286 >> + makeGrContextCurrent(); > > Is this the correct place to put this? I think you missed the SkDevice::kVector_Capability branch of this function. I'm also pretty sure that devices with vector capabilities don't have GrContexts, but that does seem a little dodgy to rely on. 446907 4 103006 benwells 2011-08-04 17:07:35 -0700 Created attachment 103006 Patch 449279 5 103006 jamesr 2011-08-10 11:57:56 -0700 Comment on attachment 103006 Patch OK 449316 6 103006 webkit.review.bot 2011-08-10 12:47:57 -0700 Comment on attachment 103006 Patch Clearing flags on attachment: 103006 Committed r92787: <http://trac.webkit.org/changeset/92787> 449317 7 webkit.review.bot 2011-08-10 12:48:02 -0700 All reviewed patches have been landed. Closing bug. 103002 2011-08-04 16:28:41 -0700 2011-08-04 17:07:28 -0700 Patch bug-65733-20110805092838.patch text/plain 2916 benwells U3VidmVyc2lvbiBSZXZpc2lvbjogOTIyNDUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhMjhiYmZjYTFhMzQzZjc2 ZmM4OTUyZWNkM2RlODA0ZTg3NTBkOTk0Li45NTQ2MmI3OWU1NWFmMDE3NDA1NTVjOGQ4MjhlMTdl M2ZlYzMxMjZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDgtMDQgIEJlbiBX ZWxscyAgPGJlbndlbGxzQGNocm9taXVtLm9yZz4KKworICAgICAgICBbc2tpYV0gTW92ZSBjYWxs cyB0byBtYWtlR3JDb250ZXh0Q3VycmVudCBpbnRvIGNsaXBQYXRoQW50aUFsaWFzZWQgZnJvbSBj YWxsZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02 NTczMworICAgICAgICAKKyAgICAgICAgVGhpcyBwcm90ZWN0cyBhZ2FpbnN0IGNhbGxlcnMgb2Yg Y2xpcFBhdGhBbnRpQWxpYXNlZCBmb3JnZXR0aW5nIHRvIGNhbGwgbWFrZUdyQ29udGV4dEN1cnJl bnQuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8g Y2hhbmdlIGluIGZ1bmN0aW9uYWxpdHksIG5vIG5ldyB0ZXN0cy4KKworICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL3NraWEvR3JhcGhpY3NDb250ZXh0U2tpYS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpHcmFwaGljc0NvbnRleHQ6OmFkZElubmVyUm91bmRlZFJlY3RDbGlwKToKKyAgICAgICAg KFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6Y2xpcCk6CisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3Mvc2tpYS9QbGF0Zm9ybUNvbnRleHRTa2lhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBs YXRmb3JtQ29udGV4dFNraWE6OmNsaXBQYXRoQW50aUFsaWFzZWQpOgorCiAyMDExLTA4LTAyICBK YW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVt XSBEZWNvdXBsZSBsYXllciB2aXNpYmlsaXR5IGNhbGN1bGF0aW9ucyBmcm9tIHJlbmRlciBzdXJm YWNlcyAvIGNvbXB1dGVkIGRyYXcgdHJhbnNmb3JtcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHRTa2lhLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhcGhpY3NDb250ZXh0U2tpYS5jcHAK aW5kZXggNWRjNzg0YTg3ZDcxZGYyMWJmN2YyNDQ5ZWVhMDQ0ZmViM2M5ZWZhNC4uZDBjY2MwMGY5 Y2QxMzFhYzRmOWM5NDMxMTU5YzRlZGU1ODBmZGQ4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHRTa2lhLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dyYXBoaWNzQ29udGV4dFNraWEu Y3BwCkBAIC0yOTYsNyArMjk2LDYgQEAgdm9pZCBHcmFwaGljc0NvbnRleHQ6OmFkZElubmVyUm91 bmRlZFJlY3RDbGlwKGNvbnN0IEludFJlY3QmIHJlY3QsIGludCB0aGlja25lc3MKICAgICBpZiAo IWlzUmVjdFNraWFTYWZlKGdldENUTSgpLCByKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgcGxh dGZvcm1Db250ZXh0KCktPm1ha2VHckNvbnRleHRDdXJyZW50KCk7CiAgICAgU2tQYXRoIHBhdGg7 CiAgICAgcGF0aC5hZGRPdmFsKHIsIFNrUGF0aDo6a0NXX0RpcmVjdGlvbik7CiAgICAgLy8gb25s eSBwZXJmb3JtIHRoZSBpbnNldCBpZiB3ZSB3b24ndCBpbnZlcnQgcgpAQCAtMzU2LDcgKzM1NSw2 IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0OjpjbGlwKGNvbnN0IFBhdGgmIHBhdGgpCiAgICAgaWYg KCFpc1BhdGhTa2lhU2FmZShnZXRDVE0oKSwgcCkpCiAgICAgICAgIHJldHVybjsKIAotICAgIHBs YXRmb3JtQ29udGV4dCgpLT5tYWtlR3JDb250ZXh0Q3VycmVudCgpOwogICAgIHBsYXRmb3JtQ29u dGV4dCgpLT5jbGlwUGF0aEFudGlBbGlhc2VkKHApOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BsYXRmb3JtQ29udGV4dFNraWEuY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QbGF0Zm9ybUNvbnRleHRTa2lh LmNwcAppbmRleCAxZTM4NWVkOWUyYjM2ZDhhOWQ5MGQwMWFiMWRjMjI3YmEzNDcxMjUyLi45NWFk ZmJjMzQ5NTdmMTAyMjZkMjY5OTRmNzRkMmQ4NTMxYTBkNWM4IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BsYXRmb3JtQ29udGV4dFNraWEuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGxhdGZvcm1Db250ZXh0 U2tpYS5jcHAKQEAgLTI4Myw2ICsyODMsNyBAQCB2b2lkIFBsYXRmb3JtQ29udGV4dFNraWE6OmNs aXBQYXRoQW50aUFsaWFzZWQoY29uc3QgU2tQYXRoJiBjbGlwUGF0aCkKICAgICBtX3N0YXRlLT5t X2FudGlBbGlhc0NsaXBQYXRocy5hcHBlbmQoY2xpcFBhdGgpOwogCiAgICAgaWYgKCFoYXZlTGF5 ZXJPdXRzdGFuZGluZykgeworICAgICAgICBtYWtlR3JDb250ZXh0Q3VycmVudCgpOwogICAgICAg ICBTa1JlY3QgYm91bmRzID0gY2xpcFBhdGguZ2V0Qm91bmRzKCk7CiAgICAgICAgIGNhbnZhcygp LT5zYXZlTGF5ZXJBbHBoYSgmYm91bmRzLCAyNTUsIHN0YXRpY19jYXN0PFNrQ2FudmFzOjpTYXZl RmxhZ3M+KFNrQ2FudmFzOjprSGFzQWxwaGFMYXllcl9TYXZlRmxhZyB8IFNrQ2FudmFzOjprRnVs bENvbG9yTGF5ZXJfU2F2ZUZsYWcgfCBTa0NhbnZhczo6a0NsaXBUb0xheWVyX1NhdmVGbGFnKSk7 CiAgICAgICAgIC8vIEd1YXJkcyBzdGF0ZSBtb2RpZmljYXRpb24gZHVyaW5nIGNsaXBwZWQgb3Bl cmF0aW9ucy4K 103006 2011-08-04 17:07:35 -0700 2011-08-10 12:47:57 -0700 Patch bug-65733-20110805100733.patch text/plain 2872 benwells U3VidmVyc2lvbiBSZXZpc2lvbjogOTIyNDUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhMjhiYmZjYTFhMzQzZjc2 ZmM4OTUyZWNkM2RlODA0ZTg3NTBkOTk0Li45NTQ2MmI3OWU1NWFmMDE3NDA1NTVjOGQ4MjhlMTdl M2ZlYzMxMjZkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDgtMDQgIEJlbiBX ZWxscyAgPGJlbndlbGxzQGNocm9taXVtLm9yZz4KKworICAgICAgICBbc2tpYV0gTW92ZSBjYWxs cyB0byBtYWtlR3JDb250ZXh0Q3VycmVudCBpbnRvIGNsaXBQYXRoQW50aUFsaWFzZWQgZnJvbSBj YWxsZXJzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02 NTczMworICAgICAgICAKKyAgICAgICAgVGhpcyBwcm90ZWN0cyBhZ2FpbnN0IGNhbGxlcnMgb2Yg Y2xpcFBhdGhBbnRpQWxpYXNlZCBmb3JnZXR0aW5nIHRvIGNhbGwgbWFrZUdyQ29udGV4dEN1cnJl bnQuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8g Y2hhbmdlIGluIGZ1bmN0aW9uYWxpdHksIG5vIG5ldyB0ZXN0cy4KKworICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL3NraWEvR3JhcGhpY3NDb250ZXh0U2tpYS5jcHA6CisgICAgICAgIChXZWJD b3JlOjpHcmFwaGljc0NvbnRleHQ6OmFkZElubmVyUm91bmRlZFJlY3RDbGlwKToKKyAgICAgICAg KFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDo6Y2xpcCk6CisgICAgICAgICogcGxhdGZvcm0vZ3Jh cGhpY3Mvc2tpYS9QbGF0Zm9ybUNvbnRleHRTa2lhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBs YXRmb3JtQ29udGV4dFNraWE6OmNsaXBQYXRoQW50aUFsaWFzZWQpOgorCiAyMDExLTA4LTAyICBK YW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVt XSBEZWNvdXBsZSBsYXllciB2aXNpYmlsaXR5IGNhbGN1bGF0aW9ucyBmcm9tIHJlbmRlciBzdXJm YWNlcyAvIGNvbXB1dGVkIGRyYXcgdHJhbnNmb3JtcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHRTa2lhLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhcGhpY3NDb250ZXh0U2tpYS5jcHAK aW5kZXggNWRjNzg0YTg3ZDcxZGYyMWJmN2YyNDQ5ZWVhMDQ0ZmViM2M5ZWZhNC4uZDBjY2MwMGY5 Y2QxMzFhYzRmOWM5NDMxMTU5YzRlZGU1ODBmZGQ4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHRTa2lhLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dyYXBoaWNzQ29udGV4dFNraWEu Y3BwCkBAIC0yOTYsNyArMjk2LDYgQEAgdm9pZCBHcmFwaGljc0NvbnRleHQ6OmFkZElubmVyUm91 bmRlZFJlY3RDbGlwKGNvbnN0IEludFJlY3QmIHJlY3QsIGludCB0aGlja25lc3MKICAgICBpZiAo IWlzUmVjdFNraWFTYWZlKGdldENUTSgpLCByKSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgcGxh dGZvcm1Db250ZXh0KCktPm1ha2VHckNvbnRleHRDdXJyZW50KCk7CiAgICAgU2tQYXRoIHBhdGg7 CiAgICAgcGF0aC5hZGRPdmFsKHIsIFNrUGF0aDo6a0NXX0RpcmVjdGlvbik7CiAgICAgLy8gb25s eSBwZXJmb3JtIHRoZSBpbnNldCBpZiB3ZSB3b24ndCBpbnZlcnQgcgpAQCAtMzU2LDcgKzM1NSw2 IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0OjpjbGlwKGNvbnN0IFBhdGgmIHBhdGgpCiAgICAgaWYg KCFpc1BhdGhTa2lhU2FmZShnZXRDVE0oKSwgcCkpCiAgICAgICAgIHJldHVybjsKIAotICAgIHBs YXRmb3JtQ29udGV4dCgpLT5tYWtlR3JDb250ZXh0Q3VycmVudCgpOwogICAgIHBsYXRmb3JtQ29u dGV4dCgpLT5jbGlwUGF0aEFudGlBbGlhc2VkKHApOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BsYXRmb3JtQ29udGV4dFNraWEuY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QbGF0Zm9ybUNvbnRleHRTa2lh LmNwcAppbmRleCAxZTM4NWVkOWUyYjM2ZDhhOWQ5MGQwMWFiMWRjMjI3YmEzNDcxMjUyLi41Mzk5 MGVjNWJjNTYzMjQwZGJlOGNhMzlkMjRlNGVhNGMyZmRlZmNhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BsYXRmb3JtQ29udGV4dFNraWEuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGxhdGZvcm1Db250ZXh0 U2tpYS5jcHAKQEAgLTI2Nyw2ICsyNjcsNyBAQCB2b2lkIFBsYXRmb3JtQ29udGV4dFNraWE6OmJl Z2luTGF5ZXJDbGlwcGVkVG9JbWFnZShjb25zdCBGbG9hdFJlY3QmIHJlY3QsCiAKIHZvaWQgUGxh dGZvcm1Db250ZXh0U2tpYTo6Y2xpcFBhdGhBbnRpQWxpYXNlZChjb25zdCBTa1BhdGgmIGNsaXBQ YXRoKQogeworICAgIG1ha2VHckNvbnRleHRDdXJyZW50KCk7CiAgICAgaWYgKG1fY2FudmFzLT5n ZXRUb3BEZXZpY2UoKS0+Z2V0RGV2aWNlQ2FwYWJpbGl0aWVzKCkgJiBTa0RldmljZTo6a1ZlY3Rv cl9DYXBhYmlsaXR5KSB7CiAgICAgICAgIC8vIFdoZW4gdGhlIG91dHB1dCBpcyBhIHZlY3RvciBk ZXZpY2UsIGxpa2UgUERGLCB3ZSBkb24ndCBuZWVkIGFudGlhbGlhc2VkIGNsaXBzLgogICAgICAg ICAvLyBJdCdzIHVwIHRvIHRoZSBQREYgcmVuZGVyaW5nIGVuZ2luZSB0byBkbyB0aGF0LiBXZSBj YW4gc2ltcGx5IGRpc2FibGUgdGhlCg==