65712 2011-08-04 12:53:14 -0700 REGRESSION (91931) - Two LocalStorage threads started, thread unsafe operations can cause crash or other problems later. 2011-08-04 13:14:50 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson oldest_to_newest 446701 0 beidson 2011-08-04 12:53:14 -0700 REGRESSION (91931) - Two LocalStorage threads started, thread unsafe operations can cause crash or other problems later. This is as simple as a bool that's not set correctly before some potentially-thread-launching-operations begin. Patch coming. In radar as <rdar://problem/9882581> and <rdar://problem/8186793> 446704 1 beidson 2011-08-04 12:54:08 -0700 (In reply to comment #0) > In radar as <rdar://problem/9882581> and <rdar://problem/8186793> That's actually 9868015 instead of 8186793 446706 2 102962 beidson 2011-08-04 12:56:22 -0700 Created attachment 102962 Patch v1 - Set a bool before it's value will be needed, not after. 446708 3 102962 darin 2011-08-04 12:57:29 -0700 Comment on attachment 102962 Patch v1 - Set a bool before it's value will be needed, not after. Any way to do a regression test on this? 446723 4 beidson 2011-08-04 13:14:01 -0700 (In reply to comment #3) > (From update of attachment 102962 [details]) > Any way to do a regression test on this? AFAIK it was seen precisely once in one of the local storage tests since I originally landed, so one could argue it's already "covered" That said, it's been quite elusive to reproduce even testing under the browser. It's only been seen a handful of times there. Very racy. I'm open to ideas but don't think it's worth holding up landing. 446727 5 beidson 2011-08-04 13:14:50 -0700 Landed in r92406 102962 2011-08-04 12:56:22 -0700 2011-08-04 12:57:29 -0700 Patch v1 - Set a bool before it's value will be needed, not after. patch.txt text/plain 1728 beidson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkyNDAyKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDgtMDQgIEJyYWR5IEVp ZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS85ODgy NTgxPiwgPHJkYXI6Ly9wcm9ibGVtLzk4NjgwMTU+LCBhbmQgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTY1NzEyCisgICAgICAgIFJFR1JFU1NJT04gKDkxOTMxKSAtIFR3 byBMb2NhbFN0b3JhZ2UgdGhyZWFkcyBzdGFydGVkLCB0aHJlYWQgdW5zYWZlIG9wZXJhdGlvbnMg Y2FuIGNhdXNlIGNyYXNoIG9yIG90aGVyIHByb2JsZW1zIGxhdGVyLgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3RvcmFnZS9TdG9yYWdlVHJhY2tl ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdG9yYWdlVHJhY2tlcjo6aW50ZXJuYWxJbml0aWFs aXplKTogU2V0IHRoZSAibmVlZHMgaW5pdGlhbGl6YXRpb24iIGZsYWcgYmVmb3JlIGRvaW5nIGEg CisgICAgICAgICAgd2hvbGUgYnVuY2ggb2Ygc3R1ZmYgdGhhdCBtaWdodCBuZWVkIHRvIGNoZWNr IGl0LgorCiAyMDExLTA4LTA0ICBKb2NoZW4gRWlzaW5nZXIgIDxqb2NoZW5AY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIEdldCByaWQgb2YgUmVzb3VyY2VSZXF1ZXN0QmFzZTo6bV90YXJnZXRUeXBl LiBNb3ZlIGl0IHRvIGNocm9taXVtJ3MgUmVzb3VyY2VSZXF1ZXN0LgpJbmRleDogU291cmNlL1dl YkNvcmUvc3RvcmFnZS9TdG9yYWdlVHJhY2tlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvc3RvcmFnZS9TdG9yYWdlVHJhY2tlci5jcHAJKHJldmlzaW9uIDkyMzgyKQorKysgU291 cmNlL1dlYkNvcmUvc3RvcmFnZS9TdG9yYWdlVHJhY2tlci5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTYyLDYgKzYyLDggQEAgdm9pZCBTdG9yYWdlVHJhY2tlcjo6aW5pdGlhbGl6ZVRyYWNrZXIoYwog CiB2b2lkIFN0b3JhZ2VUcmFja2VyOjppbnRlcm5hbEluaXRpYWxpemUoKQogeworICAgIG1fbmVl ZHNJbml0aWFsaXphdGlvbiA9IGZhbHNlOworCiAgICAgQVNTRVJUKGlzTWFpblRocmVhZCgpKTsK IAogICAgIC8vIE1ha2Ugc3VyZSB0ZXh0IGVuY29kaW5nIG1hcHMgaGF2ZSBiZWVuIGJ1aWx0IG9u IHRoZSBtYWluIHRocmVhZCwgYXMgdGhlIFN0b3JhZ2VUcmFja2VyIHRocmVhZCBtaWdodCB0cnkg dG8gZG8gaXQgdGhlcmUgaW5zdGVhZC4KQEAgLTcyLDggKzc0LDYgQEAgdm9pZCBTdG9yYWdlVHJh Y2tlcjo6aW50ZXJuYWxJbml0aWFsaXplKAogICAgIHN0b3JhZ2VUcmFja2VyLT5zZXRJc0FjdGl2 ZSh0cnVlKTsKICAgICBzdG9yYWdlVHJhY2tlci0+bV90aHJlYWQtPnN0YXJ0KCk7ICAKICAgICBz dG9yYWdlVHJhY2tlci0+aW1wb3J0T3JpZ2luSWRlbnRpZmllcnMoKTsKLSAgICAKLSAgICBtX25l ZWRzSW5pdGlhbGl6YXRpb24gPSBmYWxzZTsKIH0KIAogU3RvcmFnZVRyYWNrZXImIFN0b3JhZ2VU cmFja2VyOjp0cmFja2VyKCkK