65698 2011-08-04 09:51:28 -0700 REGRESSION: webkitRequestAnimationFrame's element argument needs to be marked optional 2011-08-04 12:41:33 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fishd fishd abarth dglazkov jamesr pilgrim webkit.review.bot oldest_to_newest 446578 0 fishd 2011-08-04 09:51:28 -0700 REGRESSION: webkitRequestAnimationFrame's element argument needs to be marked optional regressed from http://trac.webkit.org/changeset/92313 446602 1 102942 fishd 2011-08-04 10:28:56 -0700 Created attachment 102942 v1 patch 446607 2 102942 webkit.review.bot 2011-08-04 10:38:09 -0700 Comment on attachment 102942 v1 patch Attachment 102942 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9300730 446616 3 102945 fishd 2011-08-04 10:51:11 -0700 Created attachment 102945 v2 patch Whoops, this time with Optional=CallWithDefaultValue! 446631 4 102945 jamesr 2011-08-04 11:02:47 -0700 Comment on attachment 102945 v2 patch R=me 446638 5 102945 webkit.review.bot 2011-08-04 11:19:57 -0700 Comment on attachment 102945 v2 patch Clearing flags on attachment: 102945 Committed r92392: <http://trac.webkit.org/changeset/92392> 446639 6 webkit.review.bot 2011-08-04 11:20:02 -0700 All reviewed patches have been landed. Closing bug. 446657 7 102945 abarth 2011-08-04 11:51:20 -0700 Comment on attachment 102945 v2 patch No test? Thanks for fixing this issue. Sorry for the mess. 446687 8 fishd 2011-08-04 12:40:02 -0700 See fast/animation/request-animation-frame-*, which are all skipped on non-Chromium ports. It looks like I should indeed have added a test that does not pass the element parameter :( Will do that as a follow-up patch in a separate bug. 446689 9 fishd 2011-08-04 12:41:33 -0700 See bug 65710 for adding a test. 102942 2011-08-04 10:28:56 -0700 2011-08-04 10:51:11 -0700 v1 patch raf_1.txt text/plain 1274 fishd SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkyMzgzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDgtMDQgIERhcmluIEZp c2hlciAgPGRhcmluQGNocm9taXVtLm9yZz4KKworICAgICAgICB3ZWJraXRSZXF1ZXN0QW5pbWF0 aW9uRnJhbWUncyBlbGVtZW50IGFyZ3VtZW50IG5lZWRzIHRvIGJlIG1hcmtlZCBvcHRpb25hbAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjU2OTgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBhZ2UvRE9N V2luZG93LmlkbDoKKwogMjAxMS0wOC0wNCAgTHVrZSBNYWNwaGVyc29uICAgPG1hY3BoZXJzb25A Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFN1cHBvcnQgY2FzdCBiZXR3ZWVuIENTU1ByaW1pdGl2 ZVZhbHVlIGFuZCBFYm9yZGVyRml0LCB1c2UgaW4gQ1NTU3R5bGVTZWxlY3Rvci4KSW5kZXg6IFNv dXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmlkbAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9wYWdlL0RPTVdpbmRvdy5pZGwJKHJldmlzaW9uIDkyMzgyKQorKysgU291cmNlL1dlYkNv cmUvcGFnZS9ET01XaW5kb3cuaWRsCSh3b3JraW5nIGNvcHkpCkBAIC0yMzgsNyArMjM4LDcgQEAg bW9kdWxlIHdpbmRvdyB7CiAKICNpZiBkZWZpbmVkKEVOQUJMRV9SRVFVRVNUX0FOSU1BVElPTl9G UkFNRSkKICAgICAgICAgLy8gV2ViS2l0IGFuaW1hdGlvbiBleHRlbnNpb25zCi0gICAgICAgIGxv bmcgd2Via2l0UmVxdWVzdEFuaW1hdGlvbkZyYW1lKGluIFtDYWxsYmFja10gUmVxdWVzdEFuaW1h dGlvbkZyYW1lQ2FsbGJhY2sgY2FsbGJhY2ssIGluIEVsZW1lbnQgZWxlbWVudCk7CisgICAgICAg IGxvbmcgd2Via2l0UmVxdWVzdEFuaW1hdGlvbkZyYW1lKGluIFtDYWxsYmFja10gUmVxdWVzdEFu aW1hdGlvbkZyYW1lQ2FsbGJhY2sgY2FsbGJhY2ssIGluIFtPcHRpb25hbF0gRWxlbWVudCBlbGVt ZW50KTsKICAgICAgICAgdm9pZCB3ZWJraXRDYW5jZWxSZXF1ZXN0QW5pbWF0aW9uRnJhbWUoaW4g bG9uZyBpZCk7CiAjZW5kaWYKIAo= 102945 2011-08-04 10:51:11 -0700 2011-08-04 11:51:20 -0700 v2 patch raf_2.txt text/plain 1295 fishd SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkyMzgzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDgtMDQgIERhcmluIEZp c2hlciAgPGRhcmluQGNocm9taXVtLm9yZz4KKworICAgICAgICB3ZWJraXRSZXF1ZXN0QW5pbWF0 aW9uRnJhbWUncyBlbGVtZW50IGFyZ3VtZW50IG5lZWRzIHRvIGJlIG1hcmtlZCBvcHRpb25hbAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjU2OTgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBhZ2UvRE9N V2luZG93LmlkbDoKKwogMjAxMS0wOC0wNCAgTHVrZSBNYWNwaGVyc29uICAgPG1hY3BoZXJzb25A Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFN1cHBvcnQgY2FzdCBiZXR3ZWVuIENTU1ByaW1pdGl2 ZVZhbHVlIGFuZCBFYm9yZGVyRml0LCB1c2UgaW4gQ1NTU3R5bGVTZWxlY3Rvci4KSW5kZXg6IFNv dXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2luZG93LmlkbAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9wYWdlL0RPTVdpbmRvdy5pZGwJKHJldmlzaW9uIDkyMzgyKQorKysgU291cmNlL1dlYkNv cmUvcGFnZS9ET01XaW5kb3cuaWRsCSh3b3JraW5nIGNvcHkpCkBAIC0yMzgsNyArMjM4LDcgQEAg bW9kdWxlIHdpbmRvdyB7CiAKICNpZiBkZWZpbmVkKEVOQUJMRV9SRVFVRVNUX0FOSU1BVElPTl9G UkFNRSkKICAgICAgICAgLy8gV2ViS2l0IGFuaW1hdGlvbiBleHRlbnNpb25zCi0gICAgICAgIGxv bmcgd2Via2l0UmVxdWVzdEFuaW1hdGlvbkZyYW1lKGluIFtDYWxsYmFja10gUmVxdWVzdEFuaW1h dGlvbkZyYW1lQ2FsbGJhY2sgY2FsbGJhY2ssIGluIEVsZW1lbnQgZWxlbWVudCk7CisgICAgICAg IGxvbmcgd2Via2l0UmVxdWVzdEFuaW1hdGlvbkZyYW1lKGluIFtDYWxsYmFja10gUmVxdWVzdEFu aW1hdGlvbkZyYW1lQ2FsbGJhY2sgY2FsbGJhY2ssIGluIFtPcHRpb25hbD1DYWxsV2l0aERlZmF1 bHRWYWx1ZV0gRWxlbWVudCBlbGVtZW50KTsKICAgICAgICAgdm9pZCB3ZWJraXRDYW5jZWxSZXF1 ZXN0QW5pbWF0aW9uRnJhbWUoaW4gbG9uZyBpZCk7CiAjZW5kaWYKIAo=