65680 2011-08-04 03:39:45 -0700 [EFL] ewk_view_mode_get uses macro for NULL checks. 2011-10-21 01:31:13 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 0 g.czajkowski webkit-unassigned gyuyoung.kim gyuyoung.kim leandro lucas.de.marchi rakuco tkent webkit.review.bot oldest_to_newest 446428 0 g.czajkowski 2011-08-04 03:39:45 -0700 Function ewk_view_mode_get checks NULL through ewk_view' macros. 446429 1 102895 g.czajkowski 2011-08-04 03:40:55 -0700 Created attachment 102895 proposed patch 446466 2 leandro 2011-08-04 06:45:49 -0700 Code changes looks fine, but ChangeLog entry needs more work. 446486 3 102913 g.czajkowski 2011-08-04 07:19:13 -0700 Created attachment 102913 updated patch Description in ChangeLog has been changed. 447886 4 102913 gyuyoung.kim 2011-08-08 00:41:32 -0700 Comment on attachment 102913 updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=102913&action=review > Source/WebKit/efl/ChangeLog:10 > + - the code is smaller, It seems '-' is not unneeded. Kenneth pointed it before in other bug. 447889 5 gyuyoung.kim 2011-08-08 00:48:34 -0700 (In reply to comment #4) > It seems '-' is not unneeded. Oops. '-' is unneeded. wrong expression. :( 448060 6 102913 leandro 2011-08-08 10:04:21 -0700 Comment on attachment 102913 updated patch Informal r+. 455951 7 gyuyoung.kim 2011-08-23 20:48:24 -0700 Hello Kent, we hope to review this patch. :-) 488183 8 102913 rniwa 2011-10-20 23:14:08 -0700 Comment on attachment 102913 updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=102913&action=review >> Source/WebKit/efl/ChangeLog:10 >> + - the code is smaller, > > It seems '-' is not unneeded. Kenneth pointed it before in other bug. Yes remove '-' and put them all in a plain sentence. 488207 9 111910 g.czajkowski 2011-10-20 23:43:28 -0700 Created attachment 111910 updated patch 488212 10 111910 gyuyoung.kim 2011-10-20 23:47:24 -0700 Comment on attachment 111910 updated patch Attachment 111910 did not pass efl-ews (efl): Output: http://queues.webkit.org/results/10180793 488215 11 111910 gyuyoung.kim 2011-10-20 23:49:46 -0700 Comment on attachment 111910 updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=111910&action=review > Source/WebKit/efl/ewk/ewk_view.cpp:3791 > + EWK_VIEW_SD_GET_OR_RETURN(o, sd, mode); Why do you use *o* instead of ewkView ? And also, Bug 69988 is changing *sd* variable name with *smartData*. 488235 12 111917 g.czajkowski 2011-10-21 00:09:27 -0700 Created attachment 111917 updated patch to a new coding style of WebKit-EFL 488239 13 111917 gyuyoung.kim 2011-10-21 00:15:50 -0700 Comment on attachment 111917 updated patch to a new coding style of WebKit-EFL LGTM. 488255 14 111917 webkit.review.bot 2011-10-21 01:31:08 -0700 Comment on attachment 111917 updated patch to a new coding style of WebKit-EFL Clearing flags on attachment: 111917 Committed r98084: <http://trac.webkit.org/changeset/98084> 488256 15 webkit.review.bot 2011-10-21 01:31:13 -0700 All reviewed patches have been landed. Closing bug. 102895 2011-08-04 03:40:55 -0700 2011-08-04 07:19:13 -0700 proposed patch using_macros.patch text/plain 1312 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA1MTliNzllLi41NGE2NTQzIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTEtMDgtMDEgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWpr b3dza2lAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gZXdrX3ZpZXdfbW9kZV9nZXQgdXNl cyBtYWNybyBmb3IgTlVMTCBjaGVja3MuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD02NTY4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEZ1bmN0aW9uIGV3a192aWV3X21vZGVfZ2V0IGNoZWNrcyBOVUxMIHRo cm91Z2ggZXdrX3ZpZXcnIG1hY3Jvcy4KKworICAgICAgICAqIGV3ay9ld2tfdmlldy5jcHA6Cisg ICAgICAgIChld2tfdmlld19tb2RlX2dldCk6CisKIDIwMTEtMDctMjkgIE1pY2hhbCBQYWt1bGEg dmVsIFJ1dGthICA8bS5wYWt1bGFAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0gSW1wbGVt ZW50IEVkaXRvckNsaWVudEVmbDo6cmVzcG9uZFRvQ2hhbmdlZENvbnRlbnRzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwIGIvU291cmNlL1dlYktpdC9lZmwv ZXdrL2V3a192aWV3LmNwcAppbmRleCA1MDZiNDNiLi43MmY2ZmNjIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3 ay9ld2tfdmlldy5jcHAKQEAgLTM2MDcsMTIgKzM2MDcsOCBAQCBFd2tfVmlld19Nb2RlIGV3a192 aWV3X21vZGVfZ2V0KEV2YXNfT2JqZWN0ICpvKQogewogICAgIEV3a19WaWV3X01vZGUgbW9kZSA9 IEVXS19WSUVXX01PREVfV0lORE9XRUQ7CiAKLSAgICBFV0tfVklFV19TRF9HRVQobywgc2QpOwot ICAgIGlmICghc2QpCi0gICAgICAgIHJldHVybiBtb2RlOwotICAgIEVXS19WSUVXX1BSSVZfR0VU KHNkLCBwcml2KTsKLSAgICBpZiAoIXByaXYpCi0gICAgICAgIHJldHVybiBtb2RlOworICAgIEVX S19WSUVXX1NEX0dFVF9PUl9SRVRVUk4obywgc2QsIG1vZGUpOworICAgIEVXS19WSUVXX1BSSVZf R0VUX09SX1JFVFVSTihzZCwgcHJpdiwgbW9kZSk7CiAKICAgICBzd2l0Y2ggKHByaXYtPnBhZ2Ut PnZpZXdNb2RlKCkpIHsKICAgICBjYXNlIFdlYkNvcmU6OlBhZ2U6OlZpZXdNb2RlRmxvYXRpbmc6 Cg== 102913 2011-08-04 07:19:13 -0700 2011-10-20 23:43:28 -0700 updated patch using_macros.patch text/plain 1499 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCAwZDE1Y2YxLi4wNDRmYTg1IDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTEtMDgtMDQgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWpr b3dza2lAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gZXdrX3ZpZXdfbW9kZV9nZXQgdXNl cyBkZWRpY2F0ZWQgbWFjcm9zIGluc3RlYWQgb2Ygc3RhbmRhcmQgTlVMTCBjaGVja2luZy4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1NjgwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNpbmcgbWFjcm9z IGluIGV3a192aWV3X21vZGVfZ2V0IGZvciBOVUxMIGNoZWNraW5nLgorICAgICAgICBUaGVyZSBh cmUgdGhyZWUgYXJndW1lbnRzIGZvciB0aGlzOgorICAgICAgICAgLSB0aGUgY29kZSBpcyBzbWFs bGVyLAorICAgICAgICAgLSB2ZXJzaW9uIG9mIHZpZXcgb2JqZWN0IGlzIGNoZWNrZWQsCisgICAg ICAgICAtIGVycm9yIG1lc3NhZ2UgaXMgZGlzcGxheWVkIGlmIE5VTEwgaXMgcGFzc2VkCisKKyAg ICAgICAgKiBld2svZXdrX3ZpZXcuY3BwOgorICAgICAgICAoZXdrX3ZpZXdfbW9kZV9nZXQpOgor CiAyMDExLTA4LTAyICBSYXBoYWVsIEt1Ym8gZGEgQ29zdGEgIDxrdWJvQHByb2Z1c2lvbi5tb2Jp PgogCiAgICAgICAgIFtFRkxdIElnbm9yZSBlbXB0eSByZXF1ZXN0cyBvbiBwb2xpY3kgZGVjaXNp b25zLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcCBiL1Nv dXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKaW5kZXggMDk5NGJkMC4uNTNkYzg1NSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCkBAIC0zNjA1LDEyICszNjA1LDggQEAgRXdr X1ZpZXdfTW9kZSBld2tfdmlld19tb2RlX2dldChFdmFzX09iamVjdCAqbykKIHsKICAgICBFd2tf Vmlld19Nb2RlIG1vZGUgPSBFV0tfVklFV19NT0RFX1dJTkRPV0VEOwogCi0gICAgRVdLX1ZJRVdf U0RfR0VUKG8sIHNkKTsKLSAgICBpZiAoIXNkKQotICAgICAgICByZXR1cm4gbW9kZTsKLSAgICBF V0tfVklFV19QUklWX0dFVChzZCwgcHJpdik7Ci0gICAgaWYgKCFwcml2KQotICAgICAgICByZXR1 cm4gbW9kZTsKKyAgICBFV0tfVklFV19TRF9HRVRfT1JfUkVUVVJOKG8sIHNkLCBtb2RlKTsKKyAg ICBFV0tfVklFV19QUklWX0dFVF9PUl9SRVRVUk4oc2QsIHByaXYsIG1vZGUpOwogCiAgICAgc3dp dGNoIChwcml2LT5wYWdlLT52aWV3TW9kZSgpKSB7CiAgICAgY2FzZSBXZWJDb3JlOjpQYWdlOjpW aWV3TW9kZUZsb2F0aW5nOgo= 111910 2011-10-20 23:43:28 -0700 2011-10-21 00:09:27 -0700 updated patch using_macros.patch text/plain 1556 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA3NjJjZGNjLi5mY2VlMTQwIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTEtMTAtMjAgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWpr b3dza2lAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gZXdrX3ZpZXdfbW9kZV9nZXQgdXNl cyBkZWRpY2F0ZWQgbWFjcm9zIGluc3RlYWQgb2Ygc3RhbmRhcmQgTlVMTCBjaGVja2luZy4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1NjgwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR2VuZXJhbGx5IEFQ SSBtZXRob2RzIHVzaW5nIG1hY3JvcyBOVUxMIGNoZWNraW5nIGluIFdlYktpdC1FRkwuCisgICAg ICAgIFRoZSBtYWNyb3MgZW5zdXJlIHRoYXQgY29kZSBpcyBzbWFsbGVyLCB2ZXJzaW9uIG9mIHZp ZXcgb2JqZWN0CisgICAgICAgIGlzIGNoZWNrZWQgYW5kIGVycm9yIG1lc3NhZ2UgaXMgZGlzcGxh eWVkIGlmIE5VTEwgaXMgcGFzc2VkLgorCisgICAgICAgICogZXdrL2V3a192aWV3LmNwcDoKKyAg ICAgICAgKGV3a192aWV3X21vZGVfZ2V0KToKKwogMjAxMS0xMC0xOSAgUmFmYWVsIEFudG9nbm9s bGkgIDxhbnRvZ25vbGxpQHByb2Z1c2lvbi5tb2JpPgogCiAgICAgICAgIFtFRkxdIEZpeCB0eXBv cyBvbiBld2tfdmlldyBhbmQgZXdrX2pzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwv ZXdrL2V3a192aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKaW5k ZXggZDVlNmViZC4uYzA0MWRlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a192aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCkBAIC0z Nzg4LDEzICszNzg4LDggQEAgRWluYV9Cb29sIGV3a192aWV3X21vZGVfc2V0KEV2YXNfT2JqZWN0 KiBld2tWaWV3LCBFd2tfVmlld19Nb2RlIHZpZXdNb2RlKQogRXdrX1ZpZXdfTW9kZSBld2tfdmll d19tb2RlX2dldChjb25zdCBFdmFzX09iamVjdCogZXdrVmlldykKIHsKICAgICBFd2tfVmlld19N b2RlIG1vZGUgPSBFV0tfVklFV19NT0RFX1dJTkRPV0VEOwotCi0gICAgRVdLX1ZJRVdfU0RfR0VU KGV3a1ZpZXcsIHNkKTsKLSAgICBpZiAoIXNkKQotICAgICAgICByZXR1cm4gbW9kZTsKLSAgICBF V0tfVklFV19QUklWX0dFVChzZCwgcHJpdik7Ci0gICAgaWYgKCFwcml2KQotICAgICAgICByZXR1 cm4gbW9kZTsKKyAgICBFV0tfVklFV19TRF9HRVRfT1JfUkVUVVJOKG8sIHNkLCBtb2RlKTsKKyAg ICBFV0tfVklFV19QUklWX0dFVF9PUl9SRVRVUk4oc2QsIHByaXYsIG1vZGUpOwogCiAgICAgc3dp dGNoIChwcml2LT5wYWdlLT52aWV3TW9kZSgpKSB7CiAgICAgY2FzZSBXZWJDb3JlOjpQYWdlOjpW aWV3TW9kZUZsb2F0aW5nOgo= 111917 2011-10-21 00:09:27 -0700 2011-10-21 01:31:08 -0700 updated patch to a new coding style of WebKit-EFL using_macros.patch text/plain 1576 g.czajkowski ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvZWZsL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv ZWZsL0NoYW5nZUxvZwppbmRleCA3NjJjZGNjLi4wMWQ4YWJlIDEwMDc1NQotLS0gYS9Tb3VyY2Uv V2ViS2l0L2VmbC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9lZmwvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTEtMTAtMjAgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWpr b3dza2lAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VGTF0gZXdrX3ZpZXdfbW9kZV9nZXQgdXNl cyBkZWRpY2F0ZWQgbWFjcm9zIGluc3RlYWQgb2Ygc3RhbmRhcmQgTlVMTCBjaGVja2luZy4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1NjgwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR2VuZXJhbGx5IEFQ SSBtZXRob2RzIHVzaW5nIG1hY3JvcyBOVUxMIGNoZWNraW5nIGluIFdlYktpdC1FRkwuCisgICAg ICAgIFRoZSBtYWNyb3MgZW5zdXJlIHRoYXQgY29kZSBpcyBzbWFsbGVyLCB2ZXJzaW9uIG9mIHZp ZXcgb2JqZWN0CisgICAgICAgIGlzIGNoZWNrZWQgYW5kIGVycm9yIG1lc3NhZ2UgaXMgZGlzcGxh eWVkIGlmIE5VTEwgaXMgcGFzc2VkLgorCisgICAgICAgICogZXdrL2V3a192aWV3LmNwcDoKKyAg ICAgICAgKGV3a192aWV3X21vZGVfZ2V0KToKKwogMjAxMS0xMC0xOSAgUmFmYWVsIEFudG9nbm9s bGkgIDxhbnRvZ25vbGxpQHByb2Z1c2lvbi5tb2JpPgogCiAgICAgICAgIFtFRkxdIEZpeCB0eXBv cyBvbiBld2tfdmlldyBhbmQgZXdrX2pzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9lZmwv ZXdrL2V3a192aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKaW5k ZXggZDVlNmViZC4uNjQzNmNkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9lZmwvZXdrL2V3 a192aWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCkBAIC0z Nzg4LDEzICszNzg4LDggQEAgRWluYV9Cb29sIGV3a192aWV3X21vZGVfc2V0KEV2YXNfT2JqZWN0 KiBld2tWaWV3LCBFd2tfVmlld19Nb2RlIHZpZXdNb2RlKQogRXdrX1ZpZXdfTW9kZSBld2tfdmll d19tb2RlX2dldChjb25zdCBFdmFzX09iamVjdCogZXdrVmlldykKIHsKICAgICBFd2tfVmlld19N b2RlIG1vZGUgPSBFV0tfVklFV19NT0RFX1dJTkRPV0VEOwotCi0gICAgRVdLX1ZJRVdfU0RfR0VU KGV3a1ZpZXcsIHNkKTsKLSAgICBpZiAoIXNkKQotICAgICAgICByZXR1cm4gbW9kZTsKLSAgICBF V0tfVklFV19QUklWX0dFVChzZCwgcHJpdik7Ci0gICAgaWYgKCFwcml2KQotICAgICAgICByZXR1 cm4gbW9kZTsKKyAgICBFV0tfVklFV19TRF9HRVRfT1JfUkVUVVJOKGV3a1ZpZXcsIHNtYXJ0RGF0 YSwgbW9kZSk7CisgICAgRVdLX1ZJRVdfUFJJVl9HRVRfT1JfUkVUVVJOKHNtYXJ0RGF0YSwgcHJp diwgbW9kZSk7CiAKICAgICBzd2l0Y2ggKHByaXYtPnBhZ2UtPnZpZXdNb2RlKCkpIHsKICAgICBj YXNlIFdlYkNvcmU6OlBhZ2U6OlZpZXdNb2RlRmxvYXRpbmc6Cg==