65671 2011-08-04 01:43:08 -0700 checkout_unittest.js should have better coverage of checkout.js 2011-08-04 12:19:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 64188 1 abarth abarth webkit.review.bot oldest_to_newest 446390 0 abarth 2011-08-04 01:43:08 -0700 checkout_unittest.js should have better coverage of checkout.js 446391 1 102885 abarth 2011-08-04 01:43:47 -0700 Created attachment 102885 Patch 446677 2 102885 webkit.review.bot 2011-08-04 12:19:37 -0700 Comment on attachment 102885 Patch Clearing flags on attachment: 102885 Committed r92396: <http://trac.webkit.org/changeset/92396> 446678 3 webkit.review.bot 2011-08-04 12:19:41 -0700 All reviewed patches have been landed. Closing bug. 102885 2011-08-04 01:43:47 -0700 2011-08-04 12:19:37 -0700 Patch bug-65671-20110804014346.patch text/plain 5316 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogOTIzNjAKZGlmZiAtLWdpdCBhL1Rvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9j aGVja291dC5qcyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29u ZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9jaGVja291dC5qcwppbmRleCA1NjMzMDRlNGY4 NjhjZTNiMjVhODlhMzQzNjc3ODY5NGE0ZWMzMDFmLi40MWIyMWZhOTY3NDZlNjZhNGRlYjg2N2Jl OTAzYWExMGExNGIxMDhiIDEwMDY0NAotLS0gYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWls ZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvY2hlY2tvdXQuanMK KysrIGIvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVi bGljX2h0bWwvVGVzdEZhaWx1cmVzL2NoZWNrb3V0LmpzCkBAIC0yOSwzMCArMjksMTEgQEAgdmFy IGNoZWNrb3V0ID0gY2hlY2tvdXQgfHwge307CiAKIHZhciBrV2ViS2l0VHJ1bmsgPSAnaHR0cDov L3N2bi53ZWJraXQub3JnL3JlcG9zaXRvcnkvd2Via2l0L3RydW5rLyc7CiAKLWZ1bmN0aW9uIHN1 YnZlcnNpb25VUkxBdFJldmlzaW9uKHN1YnZlcnNpb25VUkwsIHJldmlzaW9uKQotewotICAgIHJl dHVybiBzdWJ2ZXJzaW9uVVJMICsgJz9yPScgKyByZXZpc2lvbjsKLX0KLQogY2hlY2tvdXQuc3Vi dmVyc2lvblVSTEZvclRlc3QgPSBmdW5jdGlvbih0ZXN0TmFtZSkKIHsKICAgICByZXR1cm4ga1dl YktpdFRydW5rICsgJ0xheW91dFRlc3RzLycgKyB0ZXN0TmFtZTsKIH0KIAotY2hlY2tvdXQuZXhp c3RzQXRSZXZpc2lvbiA9IGZ1bmN0aW9uKHN1YnZlcnNpb25VUkwsIHJldmlzaW9uLCBjYWxsYmFj aykKLXsKLSAgICBuZXQuYWpheCh7Ci0gICAgICAgIG1ldGhvZDogJ0hFQUQnLAotICAgICAgICB1 cmw6IHN1YnZlcnNpb25VUkxBdFJldmlzaW9uKHN1YnZlcnNpb25VUkwsIHJldmlzaW9uKSwgCi0g ICAgICAgIHN1Y2Nlc3M6IGZ1bmN0aW9uKCkgewotICAgICAgICAgICAgY2FsbGJhY2sodHJ1ZSk7 Ci0gICAgICAgIH0sCi0gICAgICAgIGVycm9yOiBmdW5jdGlvbigpIHsKLSAgICAgICAgICAgIGNh bGxiYWNrKGZhbHNlKTsKLSAgICAgICAgfQotICAgIH0pOwotfTsKLQogY2hlY2tvdXQudXBkYXRl RXhwZWN0YXRpb25zID0gZnVuY3Rpb24oZmFpbHVyZUluZm9MaXN0LCBjYWxsYmFjaykKIHsKICAg ICBuZXQucG9zdCgnL3VwZGF0ZWV4cGVjdGF0aW9ucycsIEpTT04uc3RyaW5naWZ5KGZhaWx1cmVJ bmZvTGlzdCksIGZ1bmN0aW9uKCkgewpkaWZmIC0tZ2l0IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBv cnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL2NoZWNr b3V0X3VuaXR0ZXN0cy5qcyBiL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5v cmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9jaGVja291dF91bml0dGVzdHMuanMK aW5kZXggNDU3YTljYjgyODFkNzRkODJhMTUyMjhhNDYwYmE0ZWZhNDRlMDM4Ni4uNzZmMDJlZjhj M2Y0MDIzNzI1MzA0NjMxMjgzODQ2Nzk3MzY4NWJjNCAxMDA2NDQKLS0tIGEvVG9vbHMvQnVpbGRT bGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1 cmVzL2NoZWNrb3V0X3VuaXR0ZXN0cy5qcworKysgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9i dWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvY2hlY2tvdXRf dW5pdHRlc3RzLmpzCkBAIC0zMSw0ICszMSw3NyBAQCB0ZXN0KCJzdWJ2ZXJzaW9uVVJMRm9yVGVz dCIsIDEsIGZ1bmN0aW9uKCkgewogICAgIGVxdWFscyhjaGVja291dC5zdWJ2ZXJzaW9uVVJMRm9y VGVzdCgicGF0aC90by90ZXN0Lmh0bWwiKSwgImh0dHA6Ly9zdm4ud2Via2l0Lm9yZy9yZXBvc2l0 b3J5L3dlYmtpdC90cnVuay9MYXlvdXRUZXN0cy9wYXRoL3RvL3Rlc3QuaHRtbCIpOwogfSk7CiAK K3Rlc3QoInVwZGF0ZUV4cGVjdGF0aW9ucyIsIDQsIGZ1bmN0aW9uKCkgeworICAgIHZhciBzaW11 bGF0b3IgPSBuZXcgTmV0d29ya1NpbXVsYXRvcigpOworICAgIHNpbXVsYXRvci5wb3N0ID0gZnVu Y3Rpb24odXJsLCBkYXRhLCBjYWxsYmFjaykKKyAgICB7CisgICAgICAgIGVxdWFscyh1cmwsICcv dXBkYXRlZXhwZWN0YXRpb25zJyk7CisgICAgICAgIGVxdWFscyhkYXRhLCAnW3siYnVpbGRlck5h bWUiOiJXZWJLaXQgTGludXgiLCJ0ZXN0TmFtZSI6ImFub3RoZXIvdGVzdC5zdmciLCJmYWlsdXJl VHlwZUxpc3QiOlsiSU1BR0UiXX1dJyk7CisgICAgICAgIHNpbXVsYXRvci5zY2hlZHVsZUNhbGxi YWNrKGNhbGxiYWNrKTsKKyAgICB9OworCisgICAgc2ltdWxhdG9yLnJ1blRlc3QoZnVuY3Rpb24o KSB7CisgICAgICAgIGNoZWNrb3V0LnVwZGF0ZUV4cGVjdGF0aW9ucyhbeworICAgICAgICAgICAg J2J1aWxkZXJOYW1lJzogJ1dlYktpdCBMaW51eCcsCisgICAgICAgICAgICAndGVzdE5hbWUnOiAn YW5vdGhlci90ZXN0LnN2ZycsCisgICAgICAgICAgICAnZmFpbHVyZVR5cGVMaXN0JzogWydJTUFH RSddLAorICAgICAgICB9XSwgZnVuY3Rpb24oKSB7CisgICAgICAgICAgICBvayh0cnVlKTsKKyAg ICAgICAgfSk7CisgICAgfSk7Cit9KTsKKwordGVzdCgib3B0aW1pemVCYXNlbGluZXMiLCAzLCBm dW5jdGlvbigpIHsKKyAgICB2YXIgc2ltdWxhdG9yID0gbmV3IE5ldHdvcmtTaW11bGF0b3IoKTsK KyAgICBzaW11bGF0b3IucG9zdCA9IGZ1bmN0aW9uKHVybCwgY2FsbGJhY2spCisgICAgeworICAg ICAgICBlcXVhbHModXJsLCAnL29wdGltaXplYmFzZWxpbmVzP3Rlc3Q9YW5vdGhlciUyRnRlc3Qu c3ZnJyk7CisgICAgICAgIHNpbXVsYXRvci5zY2hlZHVsZUNhbGxiYWNrKGNhbGxiYWNrKTsKKyAg ICB9OworCisgICAgc2ltdWxhdG9yLnJ1blRlc3QoZnVuY3Rpb24oKSB7CisgICAgICAgIGNoZWNr b3V0Lm9wdGltaXplQmFzZWxpbmVzKCdhbm90aGVyL3Rlc3Quc3ZnJywgZnVuY3Rpb24oKSB7Cisg ICAgICAgICAgICBvayh0cnVlKTsKKyAgICAgICAgfSk7CisgICAgfSk7Cit9KTsKKwordGVzdCgi cmViYXNlbGluZSIsIDMsIGZ1bmN0aW9uKCkgeworICAgIHZhciBzaW11bGF0b3IgPSBuZXcgTmV0 d29ya1NpbXVsYXRvcigpOworCisgICAgdmFyIHJlcXVlc3RlZFVSTHMgPSBbXTsKKyAgICBzaW11 bGF0b3IucG9zdCA9IGZ1bmN0aW9uKHVybCwgY2FsbGJhY2spCisgICAgeworICAgICAgICByZXF1 ZXN0ZWRVUkxzLnB1c2godXJsKTsKKyAgICAgICAgc2ltdWxhdG9yLnNjaGVkdWxlQ2FsbGJhY2so Y2FsbGJhY2spOworICAgIH07CisKKyAgICBzaW11bGF0b3IucnVuVGVzdChmdW5jdGlvbigpIHsK KyAgICAgICAgY2hlY2tvdXQucmViYXNlbGluZShbeworICAgICAgICAgICAgJ2J1aWxkZXJOYW1l JzogJ1dlYktpdCBMaW51eCcsCisgICAgICAgICAgICAndGVzdE5hbWUnOiAnYW5vdGhlci90ZXN0 LnN2ZycsCisgICAgICAgICAgICAnZmFpbHVyZVR5cGVMaXN0JzogWydJTUFHRSddLAorICAgICAg ICB9LCB7CisgICAgICAgICAgICAnYnVpbGRlck5hbWUnOiAnV2ViS2l0IE1hYzEwLjYnLAorICAg ICAgICAgICAgJ3Rlc3ROYW1lJzogJ2Fub3RoZXIvdGVzdC5zdmcnLAorICAgICAgICAgICAgJ2Zh aWx1cmVUeXBlTGlzdCc6IFsnSU1BR0UrVEVYVCddLAorICAgICAgICB9LCB7CisgICAgICAgICAg ICAnYnVpbGRlck5hbWUnOiAnV2Via2l0IFZpc3RhJywKKyAgICAgICAgICAgICd0ZXN0TmFtZSc6 ICdmYXN0L3Rlc3QuaHRtbCcsCisgICAgICAgICAgICAnZmFpbHVyZVR5cGVMaXN0JzogWydURVhU J10sCisgICAgICAgIH1dLCBmdW5jdGlvbigpIHsKKyAgICAgICAgICAgIG9rKHRydWUpOworICAg ICAgICB9KTsKKyAgICB9KTsKKworICAgIGRlZXBFcXVhbChyZXF1ZXN0ZWRVUkxzLCBbCisgICAg ICAgICIvcmViYXNlbGluZT9idWlsZGVyPVdlYktpdCtMaW51eCZ0ZXN0PWFub3RoZXIlMkZ0ZXN0 LnN2ZyZleHRlbnNpb249cG5nIiwKKyAgICAgICAgIi9yZWJhc2VsaW5lP2J1aWxkZXI9V2ViS2l0 K01hYzEwLjYmdGVzdD1hbm90aGVyJTJGdGVzdC5zdmcmZXh0ZW5zaW9uPXR4dCIsCisgICAgICAg ICIvcmViYXNlbGluZT9idWlsZGVyPVdlYktpdCtNYWMxMC42JnRlc3Q9YW5vdGhlciUyRnRlc3Qu c3ZnJmV4dGVuc2lvbj1wbmciLAorICAgICAgICAiL3JlYmFzZWxpbmU/YnVpbGRlcj1XZWJraXQr VmlzdGEmdGVzdD1mYXN0JTJGdGVzdC5odG1sJmV4dGVuc2lvbj10eHQiLAorICAgICAgICAiL29w dGltaXplYmFzZWxpbmVzP3Rlc3Q9YW5vdGhlciUyRnRlc3Quc3ZnIiwKKyAgICAgICAgIi9vcHRp bWl6ZWJhc2VsaW5lcz90ZXN0PWZhc3QlMkZ0ZXN0Lmh0bWwiCisgICAgXSk7Cit9KTsKKwogfSko KTsKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBh MGM1ZTA3NzMzNGQyNDAxYzJkYzFmYzI0MDI0OGI5ZjJmY2I5MWRiLi4yYmQyZjI5YWQwMmExY2Yw OTFhMWE0MzY2Mjc0Y2NhMDE2ZjQyMTMzIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysr IGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAKIDIwMTEtMDgtMDQgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAorICAgICAgICBjaGVja291dF91bml0dGVzdC5qcyBz aG91bGQgaGF2ZSBiZXR0ZXIgY292ZXJhZ2Ugb2YgY2hlY2tvdXQuanMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1NjcxCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBCdWlsZFNsYXZlU3VwcG9ydC9idWls ZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvY2hlY2tvdXQuanM6 CisgICAgICAgICAgICAtIFJlbW92ZSB1bnVzZWQgZnVuY3Rpb25zLgorICAgICAgICAqIEJ1aWxk U2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWls dXJlcy9jaGVja291dF91bml0dGVzdHMuanM6CisgICAgICAgICAgICAtIFRlc3QgcmVtYWluaW5n IHB1YmxpYyBmdW5jdGlvbnMgaW4gdGhlIGNoZWNrb3V0IG1vZHVsZS4KKworMjAxMS0wOC0wNCAg QWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCiAgICAgICAgIGJ1aWxkZXJzLmpzIG5l ZWRzIHVuaXQgdGVzdHMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTY1NjcwCiAK