65659 2011-08-03 18:24:39 -0700 Chromium Mac: Make ScrollbarOverlayUtilitiesChromiumMac.h c++ compatible 2011-08-03 19:35:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sail sail jam jamesr thakis webkit.review.bot oldest_to_newest 446259 0 sail 2011-08-03 18:24:39 -0700 Chromium Mac: Make ScrollbarOverlayUtilitiesChromiumMac.h c++ compatible 446262 1 102867 sail 2011-08-03 18:27:09 -0700 Created attachment 102867 Patch 446265 2 102867 jamesr 2011-08-03 18:32:18 -0700 Comment on attachment 102867 Patch OK 446268 3 102867 thakis 2011-08-03 18:36:53 -0700 Comment on attachment 102867 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102867&action=review > Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:40 > typedef NSInteger NSScrollerStyle; is this used anywhere? > Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:44 > +typedef uint32 wkScrollerStyle; this is now different from before on 64bit builds. is that significant? 446270 4 102867 jamesr 2011-08-03 18:39:36 -0700 Comment on attachment 102867 Patch clearing cq, thakis' question seems relevant. he can flip cq+ when he's satisfied 446279 5 102867 sail 2011-08-03 18:50:19 -0700 Comment on attachment 102867 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102867&action=review >> Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:40 >> typedef NSInteger NSScrollerStyle; > > is this used anywhere? This is used inside ScrollAnimatorChromiumMac.mm and ScrollbarOverlayUtilitiesChromiumMac.mm. Having it here seemed better than having to duplicate it in both .mm files. >> Source/WebCore/platform/chromium/ScrollbarOverlayUtilitiesChromiumMac.h:44 >> +typedef uint32 wkScrollerStyle; > > this is now different from before on 64bit builds. is that significant? It's not because I'm only using it for the wk* function. All delegate callback functions and private cocoa classes still use NSScrollerStyle. 446290 6 102867 webkit.review.bot 2011-08-03 19:35:54 -0700 Comment on attachment 102867 Patch Clearing flags on attachment: 102867 Committed r92343: <http://trac.webkit.org/changeset/92343> 446291 7 webkit.review.bot 2011-08-03 19:35:59 -0700 All reviewed patches have been landed. Closing bug. 102867 2011-08-03 18:27:09 -0700 2011-08-03 19:35:54 -0700 Patch bug-65659-20110803182708.patch text/plain 4057 sail U3VidmVyc2lvbiBSZXZpc2lvbjogOTIxOTcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0MDBlYzZjMGNhZWVhNzVh OWMwZjM4MTM1ZDYyZjdkOTFmM2UxMjJkLi40MGI1NDEzZTY5YTY0MWE3MThhMTYwNWUzZWY2MjRk NTgzYTI4YWFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDgtMDMgIFNhaWxl c2ggQWdyYXdhbCAgPHNhaWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIENocm9taXVtIE1hYzog TWFrZSBTY3JvbGxiYXJPdmVybGF5VXRpbGl0aWVzQ2hyb21pdW1NYWMuaCBjKysgY29tcGF0aWJs ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjU2NTkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTY3JvbGxi YXJPdmVybGF5VXRpbGl0aWVzQ2hyb21pdW1NYWMuaCBjb3VsZG4ndCBiZSBpbmNsdWRlZCBmcm9t IHB1cmUgYysrIGNvZGUgYmVjYXVzZSBpdCB1c2VkIE5TSW50ZWdlci4gSSBmaXhlZCB0aGlzIGJ5 IGNoZWNraW5nIGZvciBfX09CSkNfXyBiZWZvcmUgdXNpbmcgTlNJbnRlZ2VyLgorCisgICAgICAg IEN1cnJlbnRseSBubyBwdXJlIGMrKyBmaWxlcyBhcmUgaW5jbHVkaW5nIFNjcm9sbGJhck92ZXJs YXlVdGlsaXRpZXNDaHJvbWl1bU1hYy5oIGJ1dCB0aGlzIHdpbGwgY2hhbmdlIGluIGZ1dHVyZSBw YXRjaGVzIGZyb20gamFtQGNocm9taXVtLm9yZy4KKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9t aXVtL1Njcm9sbGJhck92ZXJsYXlVdGlsaXRpZXNDaHJvbWl1bU1hYy5oOgorICAgICAgICAqIHBs YXRmb3JtL2Nocm9taXVtL1Njcm9sbGJhck92ZXJsYXlVdGlsaXRpZXNDaHJvbWl1bU1hYy5tbToK KyAgICAgICAgKHdrU2Nyb2xsYmFyUGFpbnRlckNvbnRyb2xsZXJTdHlsZSk6CisgICAgICAgICh3 a1NldFNjcm9sbGJhclBhaW50ZXJDb250cm9sbGVyU3R5bGUpOgorCiAyMDExLTA4LTAyICBBbmRy ZWFzIEtsaW5nICA8a2xpbmdAd2Via2l0Lm9yZz4KIAogICAgICAgICBbUXRdIFNpbXBsaWZ5IFBh dGg6OnRyYW5zbGF0ZSgpIGltcGxlbWVudGF0aW9uLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vY2hyb21pdW0vU2Nyb2xsYmFyT3ZlcmxheVV0aWxpdGllc0Nocm9taXVtTWFj LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9TY3JvbGxiYXJPdmVybGF5VXRp bGl0aWVzQ2hyb21pdW1NYWMuaAppbmRleCBiMThhMDQ4YmQzOWVlNjcwY2QwYmMzY2YzMzU4NDg5 NDJiOGUwMGYxLi45YmNiMzBhMWYwNzE4MTVmNDUzNDBhODFhNmViM2JhNjM3YjcwNzFlIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9TY3JvbGxiYXJPdmVybGF5 VXRpbGl0aWVzQ2hyb21pdW1NYWMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJv bWl1bS9TY3JvbGxiYXJPdmVybGF5VXRpbGl0aWVzQ2hyb21pdW1NYWMuaApAQCAtMzUsOCArMzUs MTMgQEAgZW51bSB7CiAgICAgTlNTY3JvbGxlclN0eWxlTGVnYWN5ICAgICAgID0gMCwKICAgICBO U1Njcm9sbGVyU3R5bGVPdmVybGF5ICAgICAgPSAxCiB9OworCisjaWZkZWYgX19PQkpDX18KIHR5 cGVkZWYgTlNJbnRlZ2VyIE5TU2Nyb2xsZXJTdHlsZTsKICNlbmRpZgorI2VuZGlmCisKK3R5cGVk ZWYgdWludDMyIHdrU2Nyb2xsZXJTdHlsZTsKIAogI2lmZGVmIF9fT0JKQ19fCiBAY2xhc3MgTlNT Y3JvbGxlckltcDsKQEAgLTkzLDExICs5OCwxMSBAQCB2b2lkIHdrQ29udGVudEFyZWFEaWRIaWRl KFdLU2Nyb2xsYmFyUGFpbnRlckNvbnRyb2xsZXJSZWYpOwogdm9pZCB3a0RpZEJlZ2luU2Nyb2xs R2VzdHVyZShXS1Njcm9sbGJhclBhaW50ZXJDb250cm9sbGVyUmVmKTsKIHZvaWQgd2tEaWRFbmRT Y3JvbGxHZXN0dXJlKFdLU2Nyb2xsYmFyUGFpbnRlckNvbnRyb2xsZXJSZWYpOwogdm9pZCB3a1Nj cm9sbGJhclBhaW50ZXJGb3JjZUZsYXNoU2Nyb2xsZXJzKFdLU2Nyb2xsYmFyUGFpbnRlckNvbnRy b2xsZXJSZWYpOwotdm9pZCB3a1NldFNjcm9sbGJhclBhaW50ZXJDb250cm9sbGVyU3R5bGUoV0tT Y3JvbGxiYXJQYWludGVyQ29udHJvbGxlclJlZiwgaW50IG5ld1N0eWxlKTsKK3ZvaWQgd2tTZXRT Y3JvbGxiYXJQYWludGVyQ29udHJvbGxlclN0eWxlKFdLU2Nyb2xsYmFyUGFpbnRlckNvbnRyb2xs ZXJSZWYsIHdrU2Nyb2xsZXJTdHlsZSBuZXdTdHlsZSk7CiB2b2lkIHdrU2V0UGFpbnRlckZvclBh aW50ZXJDb250cm9sbGVyKFdLU2Nyb2xsYmFyUGFpbnRlckNvbnRyb2xsZXJSZWYsIFdLU2Nyb2xs YmFyUGFpbnRlclJlZiwgYm9vbCBpc0hvcml6b250YWwpOwogV0tTY3JvbGxiYXJQYWludGVyUmVm IHdrVmVydGljYWxTY3JvbGxiYXJQYWludGVyRm9yQ29udHJvbGxlcihXS1Njcm9sbGJhclBhaW50 ZXJDb250cm9sbGVyUmVmKTsKIFdLU2Nyb2xsYmFyUGFpbnRlclJlZiB3a0hvcml6b250YWxTY3Jv bGxiYXJQYWludGVyRm9yQ29udHJvbGxlcihXS1Njcm9sbGJhclBhaW50ZXJDb250cm9sbGVyUmVm KTsKLU5TU2Nyb2xsZXJTdHlsZSB3a1Njcm9sbGJhclBhaW50ZXJDb250cm9sbGVyU3R5bGUoV0tT Y3JvbGxiYXJQYWludGVyQ29udHJvbGxlclJlZik7Cit3a1Njcm9sbGVyU3R5bGUgd2tTY3JvbGxi YXJQYWludGVyQ29udHJvbGxlclN0eWxlKFdLU2Nyb2xsYmFyUGFpbnRlckNvbnRyb2xsZXJSZWYp OwogCiAjZW5kaWYgLy8gVVNFKFdLX1NDUk9MTEJBUl9QQUlOVEVSKQogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9TY3JvbGxiYXJPdmVybGF5VXRpbGl0aWVz Q2hyb21pdW1NYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9TY3JvbGxi YXJPdmVybGF5VXRpbGl0aWVzQ2hyb21pdW1NYWMubW0KaW5kZXggYTAwYTY1MmExM2VkNDZkODg2 YTkwMzIyZGYyYzJhYTE1MjYwNTM5ZC4uNjQwM2YwNzcyODFiY2MxODM5M2VjMWZmMWFkYzY4YTM5 MTBlZGIwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vU2Ny b2xsYmFyT3ZlcmxheVV0aWxpdGllc0Nocm9taXVtTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2Nocm9taXVtL1Njcm9sbGJhck92ZXJsYXlVdGlsaXRpZXNDaHJvbWl1bU1hYy5t bQpAQCAtMjE4LDcgKzIxOCw3IEBAIFdLU2Nyb2xsYmFyUGFpbnRlclJlZiB3a0hvcml6b250YWxT Y3JvbGxiYXJQYWludGVyRm9yQ29udHJvbGxlcihXS1Njcm9sbGJhclBhaW50CiAgICAgcmV0dXJu IFtjb250cm9sbGVyIGhvcml6b250YWxTY3JvbGxlckltcF07CiB9CiAKLU5TU2Nyb2xsZXJTdHls ZSB3a1Njcm9sbGJhclBhaW50ZXJDb250cm9sbGVyU3R5bGUoV0tTY3JvbGxiYXJQYWludGVyQ29u dHJvbGxlclJlZiBjb250cm9sbGVyKQord2tTY3JvbGxlclN0eWxlIHdrU2Nyb2xsYmFyUGFpbnRl ckNvbnRyb2xsZXJTdHlsZShXS1Njcm9sbGJhclBhaW50ZXJDb250cm9sbGVyUmVmIGNvbnRyb2xs ZXIpCiB7CiAgICAgcmV0dXJuIFtjb250cm9sbGVyIHNjcm9sbGVyU3R5bGVdOwogfQpAQCAtMjQx LDcgKzI0MSw3IEBAIHZvaWQgd2tTZXRQYWludGVyRm9yUGFpbnRlckNvbnRyb2xsZXIoV0tTY3Jv bGxiYXJQYWludGVyQ29udHJvbGxlclJlZiBjb250cm9sbGVyCiAgICAgICAgIFtjb250cm9sbGVy IHNldFZlcnRpY2FsU2Nyb2xsZXJJbXA6cGFpbnRlcl07CiB9CiAKLXZvaWQgd2tTZXRTY3JvbGxi YXJQYWludGVyQ29udHJvbGxlclN0eWxlKFdLU2Nyb2xsYmFyUGFpbnRlckNvbnRyb2xsZXJSZWYg cGFpbnRlciwgaW50IG5ld1N0eWxlKQordm9pZCB3a1NldFNjcm9sbGJhclBhaW50ZXJDb250cm9s bGVyU3R5bGUoV0tTY3JvbGxiYXJQYWludGVyQ29udHJvbGxlclJlZiBwYWludGVyLCB3a1Njcm9s bGVyU3R5bGUgbmV3U3R5bGUpCiB7CiAgICAgW3BhaW50ZXIgc2V0U2Nyb2xsZXJTdHlsZTpuZXdT dHlsZV07CiB9Cg==