65657 2011-08-03 17:23:38 -0700 Support cast between CSSPrimitiveValue and EBoxSizing, use in CSSStyleSelector. 2011-08-03 20:47:01 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 macpherson macpherson eric macpherson simon.fraser webkit.review.bot oldest_to_newest 446236 0 macpherson 2011-08-03 17:23:38 -0700 Support cast between CSSPrimitiveValue and EBoxSizing, use in CSSStyleSelector. 446241 1 102864 macpherson 2011-08-03 17:38:06 -0700 Created attachment 102864 Patch 446286 2 102864 webkit.review.bot 2011-08-03 19:09:34 -0700 Comment on attachment 102864 Patch Clearing flags on attachment: 102864 Committed r92342: <http://trac.webkit.org/changeset/92342> 446287 3 webkit.review.bot 2011-08-03 19:09:38 -0700 All reviewed patches have been landed. Closing bug. 446304 4 macpherson 2011-08-03 20:47:01 -0700 Thanks for the review Simon! 102864 2011-08-03 17:38:06 -0700 2011-08-03 19:09:34 -0700 Patch bug-65657-20110804103804.patch text/plain 3062 macpherson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkyMzM3KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTEtMDgtMDMgIEx1a2UgTWFj cGhlcnNvbiAgIDxtYWNwaGVyc29uQGNocm9taXVtLm9yZz4KKworICAgICAgICBTdXBwb3J0IGNh c3QgYmV0d2VlbiBDU1NQcmltaXRpdmVWYWx1ZSBhbmQgRUJveFNpemluZywgdXNlIGluIENTU1N0 eWxlU2VsZWN0b3IuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD02NTY1NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cyAvIHJlZmFjdG9yaW5nIG9ubHkuCisKKyAgICAgICAgKiBjc3MvQ1NT UHJpbWl0aXZlVmFsdWVNYXBwaW5ncy5oOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUHJpbWl0aXZl VmFsdWU6OkNTU1ByaW1pdGl2ZVZhbHVlKToKKyAgICAgICAgSW1wbGVtZW50IGNhc3QgZnJvbSBF Qm94U2l6aW5nLgorICAgICAgICAoV2ViQ29yZTo6Q1NTUHJpbWl0aXZlVmFsdWU6Om9wZXJhdG9y IEVCb3hTaXppbmcpOgorICAgICAgICBJbXBsZW1lbnQgY2FzdCB0byBFQm94U2l6aW5nLgorICAg ICAgICAqIGNzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1N0 eWxlU2VsZWN0b3I6OmFwcGx5UHJvcGVydHkpOgorICAgICAgICBVc2UgYXBwcm9wcmlhdGUgbWFj cm8gdG8gc2ltcGxpZnkgY29kZSB1c2luZyBjYXN0LgorCiAyMDExLTA4LTAzICBObydhbSBSb3Nl bnRoYWwgIDxub2FtLnJvc2VudGhhbEBub2tpYS5jb20+CiAKICAgICAgICAgW1F0XVtUZXhtYXBd W1JFR1JFU1NJT05dIGh0dHA6Ly93ZWJraXQub3JnL2Jsb2ctZmlsZXMvdHJhbnNmb3JtLXN0eWxl Lmh0bWwgZG9lc24ndCBzaG93IGNvbXBvc2l0ZWQgY29udGVudApJbmRleDogU291cmNlL1dlYkNv cmUvY3NzL0NTU1ByaW1pdGl2ZVZhbHVlTWFwcGluZ3MuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9jc3MvQ1NTUHJpbWl0aXZlVmFsdWVNYXBwaW5ncy5oCShyZXZpc2lvbiA5MjMzMSkK KysrIFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQcmltaXRpdmVWYWx1ZU1hcHBpbmdzLmgJKHdvcmtp bmcgY29weSkKQEAgLTU5Nyw2ICs1OTcsMzMgQEAgdGVtcGxhdGU8PiBpbmxpbmUgQ1NTUHJpbWl0 aXZlVmFsdWU6Om9wZQogICAgIH0KIH0KIAordGVtcGxhdGU8PiBpbmxpbmUgQ1NTUHJpbWl0aXZl VmFsdWU6OkNTU1ByaW1pdGl2ZVZhbHVlKEVCb3hTaXppbmcgZSkKKyAgICA6IG1fdHlwZShDU1Nf SURFTlQpCisgICAgLCBtX2hhc0NhY2hlZENTU1RleHQoZmFsc2UpCit7CisgICAgc3dpdGNoIChl KSB7CisgICAgY2FzZSBCT1JERVJfQk9YOgorICAgICAgICBtX3ZhbHVlLmlkZW50ID0gQ1NTVmFs dWVCb3JkZXJCb3g7CisgICAgICAgIGJyZWFrOworICAgIGNhc2UgQ09OVEVOVF9CT1g6CisgICAg ICAgIG1fdmFsdWUuaWRlbnQgPSBDU1NWYWx1ZUNvbnRlbnRCb3g7CisgICAgICAgIGJyZWFrOwor ICAgIH0KK30KKwordGVtcGxhdGU8PiBpbmxpbmUgQ1NTUHJpbWl0aXZlVmFsdWU6Om9wZXJhdG9y IEVCb3hTaXppbmcoKSBjb25zdAoreworICAgIHN3aXRjaCAobV92YWx1ZS5pZGVudCkgeworICAg IGNhc2UgQ1NTVmFsdWVCb3JkZXJCb3g6CisgICAgICAgIHJldHVybiBCT1JERVJfQk9YOworICAg IGNhc2UgQ1NTVmFsdWVDb250ZW50Qm94OgorICAgICAgICByZXR1cm4gQ09OVEVOVF9CT1g7Cisg ICAgZGVmYXVsdDoKKyAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgICAgIHJldHVy biBCT1JERVJfQk9YOworICAgIH0KK30KKwogdGVtcGxhdGU8PiBpbmxpbmUgQ1NTUHJpbWl0aXZl VmFsdWU6OkNTU1ByaW1pdGl2ZVZhbHVlKEVCb3hEaXJlY3Rpb24gZSkKICAgICA6IG1fdHlwZShD U1NfSURFTlQpCiAgICAgLCBtX2hhc0NhY2hlZENTU1RleHQoZmFsc2UpCkluZGV4OiBTb3VyY2Uv V2ViQ29yZS9jc3MvQ1NTU3R5bGVTZWxlY3Rvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YkNvcmUvY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwCShyZXZpc2lvbiA5MjMzMSkKKysrIFNvdXJj ZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZVNlbGVjdG9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDU0 NiwxMyArNDU0Niw3IEBAIHZvaWQgQ1NTU3R5bGVTZWxlY3Rvcjo6YXBwbHlQcm9wZXJ0eShpbnQK ICAgICAgICAgbV9zdHlsZS0+c2V0Qm94T3JkaW5hbEdyb3VwKCh1bnNpZ25lZCBpbnQpKHByaW1p dGl2ZVZhbHVlLT5nZXREb3VibGVWYWx1ZSgpKSk7CiAgICAgICAgIHJldHVybjsKICAgICBjYXNl IENTU1Byb3BlcnR5Qm94U2l6aW5nOgotICAgICAgICBIQU5ETEVfSU5IRVJJVF9BTkRfSU5JVElB TChib3hTaXppbmcsIEJveFNpemluZykKLSAgICAgICAgaWYgKCFwcmltaXRpdmVWYWx1ZSkKLSAg ICAgICAgICAgIHJldHVybjsKLSAgICAgICAgaWYgKHByaW1pdGl2ZVZhbHVlLT5nZXRJZGVudCgp ID09IENTU1ZhbHVlQ29udGVudEJveCkKLSAgICAgICAgICAgIG1fc3R5bGUtPnNldEJveFNpemlu ZyhDT05URU5UX0JPWCk7Ci0gICAgICAgIGVsc2UKLSAgICAgICAgICAgIG1fc3R5bGUtPnNldEJv eFNpemluZyhCT1JERVJfQk9YKTsKKyAgICAgICAgSEFORExFX0lOSEVSSVRfQU5EX0lOSVRJQUxf QU5EX1BSSU1JVElWRShib3hTaXppbmcsIEJveFNpemluZyk7CiAgICAgICAgIHJldHVybjsKICAg ICBjYXNlIENTU1Byb3BlcnR5V2Via2l0Q29sdW1uU3BhbjogewogICAgICAgICBIQU5ETEVfSU5I RVJJVF9BTkRfSU5JVElBTChjb2x1bW5TcGFuLCBDb2x1bW5TcGFuKQo=