65641 2011-08-03 14:07:10 -0700 JSC GC heap size improvement breaks build on some platforms due to unused parameter 2011-08-03 16:35:21 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo webkit-unassigned fpizlo lforschler oliver webkit.review.bot oldest_to_newest 446075 0 fpizlo 2011-08-03 14:07:10 -0700 The JSC GC heapSizeForHint() internal function does not use the heapSize parameter if !ENABLE(LARGE_HEAP), causing an unused parameter warning. 446078 1 102824 fpizlo 2011-08-03 14:15:43 -0700 Created attachment 102824 the patch Tests still running. Will set r=? when they finish. 446085 2 102824 fpizlo 2011-08-03 14:31:18 -0700 Comment on attachment 102824 the patch Tests pass, ready for review. 446092 3 102824 darin 2011-08-03 14:37:44 -0700 Comment on attachment 102824 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=102824&action=review > Source/JavaScriptCore/heap/Heap.cpp:51 > + ASSERT_UNUSED(heapSize, heapSize == LargeHeap || heapSize == SmallHeap); Using ASSERT_UNUSED with an argument that actually is used might cause problems in the future even if it doesn’t right now. It would be better to structure the ifdefs so the ASSERT_UNUSED is inside the #else. 446177 4 102847 fpizlo 2011-08-03 16:07:44 -0700 Created attachment 102847 the patch 446178 5 102847 webkit.review.bot 2011-08-03 16:08:26 -0700 Comment on attachment 102847 the patch Rejecting attachment 102847 from commit-queue. fpizlo@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights. 446210 6 102847 webkit.review.bot 2011-08-03 16:35:16 -0700 Comment on attachment 102847 the patch Clearing flags on attachment: 102847 Committed r92329: <http://trac.webkit.org/changeset/92329> 446211 7 webkit.review.bot 2011-08-03 16:35:21 -0700 All reviewed patches have been landed. Closing bug. 102824 2011-08-03 14:15:43 -0700 2011-08-03 16:07:44 -0700 the patch fixppcbuild_patch_1.diff text/plain 1271 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTIzMTApCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTEtMDgtMDMgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBK U0MgR0MgaGVhcCBzaXplIGltcHJvdmVtZW50IGJyZWFrcyBidWlsZCBvbiBzb21lIHBsYXRmb3Jt cyBkdWUgdG8KKyAgICAgICAgdW51c2VkIHBhcmFtZXRlcgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjU2NDEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIEZpeCBidWlsZCBvbiBub24teDg2IHBs YXRmb3JtcywgYnkgZW5zdXJpbmcgdGhhdCB0aGUgcmVsZXZhbnQKKyAgICAgICAgcGFyYW1ldGVy IGFsd2F5cyBhcHBlYXJzIHRvIGJlIHVzZWQgZXZlbiB3aGVuIGl0IGlzbid0LgorCisgICAgICAg ICogaGVhcC9IZWFwLmNwcDoKKwogMjAxMS0wOC0wMyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxj Z2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gUmVvcmdhbml6ZSBwa2ctY29uZmln IGZpbGVzCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNwcAkocmV2aXNpb24gOTIz MTApCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNwcAkod29ya2luZyBjb3B5 KQpAQCAtNDcsOCArNDcsOCBAQCBzdGF0aWMgc2l6ZV90IGhlYXBTaXplRm9ySGludChIZWFwU2l6 ZSBoCiAjaWYgRU5BQkxFKExBUkdFX0hFQVApCiAgICAgaWYgKGhlYXBTaXplID09IExhcmdlSGVh cCkKICAgICAgICAgcmV0dXJuIDE2ICogMTAyNCAqIDEwMjQ7Ci0gICAgQVNTRVJUKGhlYXBTaXpl ID09IFNtYWxsSGVhcCk7CiAjZW5kaWYKKyAgICBBU1NFUlRfVU5VU0VEKGhlYXBTaXplLCBoZWFw U2l6ZSA9PSBMYXJnZUhlYXAgfHwgaGVhcFNpemUgPT0gU21hbGxIZWFwKTsKICAgICByZXR1cm4g NTEyICogMTAyNDsKIH0KIAo= 102847 2011-08-03 16:07:44 -0700 2011-08-03 16:35:16 -0700 the patch fixppcbuild_patch_2.diff text/plain 1569 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTIzMTIpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTEtMDgtMDMgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBK U0MgR0MgaGVhcCBzaXplIGltcHJvdmVtZW50IGJyZWFrcyBidWlsZCBvbiBzb21lIHBsYXRmb3Jt cyBkdWUgdG8KKyAgICAgICAgdW51c2VkIHBhcmFtZXRlcgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjU2NDEKKworICAgICAgICBSZXZpZXdlZCBieSBE YXJpbiBBZGxlci4KKyAgICAgICAgCisgICAgICAgIEZpeCBidWlsZCBvbiBub24teDg2IHBsYXRm b3JtcywgYnkgZW5zdXJpbmcgdGhhdCB0aGUgcmVsZXZhbnQKKyAgICAgICAgcGFyYW1ldGVyIGFs d2F5cyBhcHBlYXJzIHRvIGJlIHVzZWQgZXZlbiB3aGVuIGl0IGlzbid0LgorCisgICAgICAgICog aGVhcC9IZWFwLmNwcDoKKwogMjAxMS0wOC0wMyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2Fy Y2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gUmVvcmdhbml6ZSBwa2ctY29uZmlnIGZp bGVzCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNwcAkocmV2aXNpb24gOTIzMTIp CisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9IZWFwLmNwcAkod29ya2luZyBjb3B5KQpA QCAtNDIsMTQgKzQyLDIwIEBAIG5hbWVzcGFjZSBKU0MgewogCiBuYW1lc3BhY2UgeyAKIAorc3Rh dGljIGNvbnN0IHNpemVfdCBsYXJnZUhlYXBTaXplID0gMTYgKiAxMDI0ICogMTAyNDsKK3N0YXRp YyBjb25zdCBzaXplX3Qgc21hbGxIZWFwU2l6ZSA9IDUxMiAqIDEwMjQ7CisKIHN0YXRpYyBzaXpl X3QgaGVhcFNpemVGb3JIaW50KEhlYXBTaXplIGhlYXBTaXplKQogewogI2lmIEVOQUJMRShMQVJH RV9IRUFQKQogICAgIGlmIChoZWFwU2l6ZSA9PSBMYXJnZUhlYXApCi0gICAgICAgIHJldHVybiAx NiAqIDEwMjQgKiAxMDI0OworICAgICAgICByZXR1cm4gbGFyZ2VIZWFwU2l6ZTsKICAgICBBU1NF UlQoaGVhcFNpemUgPT0gU21hbGxIZWFwKTsKKyAgICByZXR1cm4gc21hbGxIZWFwU2l6ZTsKKyNl bHNlCisgICAgQVNTRVJUX1VOVVNFRChoZWFwU2l6ZSwgaGVhcFNpemUgPT0gTGFyZ2VIZWFwIHx8 IGhlYXBTaXplID09IFNtYWxsSGVhcCk7CisgICAgcmV0dXJuIHNtYWxsSGVhcFNpemU7CiAjZW5k aWYKLSAgICByZXR1cm4gNTEyICogMTAyNDsKIH0KIAogc3RhdGljIGlubGluZSBib29sIGlzVmFs aWRTaGFyZWRJbnN0YW5jZVRocmVhZFN0YXRlKCkK