65634 2011-08-03 12:14:41 -0700 Generate WebCoreHeaderDetection.h on Windows to define HAVE_AVCF 2011-08-04 13:08:32 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 65400 1 jeffm jeffm oldest_to_newest 445998 0 jeffm 2011-08-03 12:14:41 -0700 Generate WebCoreHeaderDetection.h on Windows to define WTF_USE_AVFOUNDATION 446007 1 102810 jeffm 2011-08-03 12:26:15 -0700 Created attachment 102810 Patch 446010 2 102810 aroben 2011-08-03 12:29:53 -0700 Comment on attachment 102810 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102810&action=review > Source/WebCore/DerivedSources.make:984 > + if [ -f "$(WEBKITLIBRARIESDIR)/include/AVFoundationCF/AVCFBase.h" ]; then echo "#define WTF_USE_AVFOUNDATION 0" > $@; else echo > $@; fi I think we want to define a HAVE_* macro in WebCoreHeaderDetection.h, rather than a WTF_USE_* macro. WebCoreHeaderDetection.h should be all about what headers are available, not about policy decisions for which headers to use. config.h should have some logic like #if PLATFORM(WIN) && HAVE(AVCF) #define WTF_USE_AVFOUNDATION #endif 446025 3 102816 jeffm 2011-08-03 12:48:31 -0700 Created attachment 102816 Patch 446028 4 102816 aroben 2011-08-03 12:51:05 -0700 Comment on attachment 102816 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102816&action=review > Source/WebCore/config.h:229 > +// FIXME(65400): Adopt AVCF media back end on Windows I think we normally include the WebKit bug URL rather than just the bug number. Something like: // FIXME: Adopt AVCF media back end on Windows http://webkit.org/b/65400 446047 5 jeffm 2011-08-03 13:16:17 -0700 Committed r92308: <http://trac.webkit.org/changeset/92308> 446048 6 jeffm 2011-08-03 13:16:57 -0700 <rdar://problem/9891394> 102810 2011-08-03 12:26:15 -0700 2011-08-03 12:48:28 -0700 Patch bug-65634-20110803122613.patch text/plain 3206 jeffm SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkyMzAwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjggQEAKKzIwMTEtMDgtMDMgIEplZmYgTWls bGVyICA8amVmZm1AYXBwbGUuY29tPgorCisgICAgICAgIEdlbmVyYXRlIFdlYkNvcmVIZWFkZXJE ZXRlY3Rpb24uaCBvbiBXaW5kb3dzIHRvIGRlZmluZSBXVEZfVVNFX0FWRk9VTkRBVElPTgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjU2MzQKKyAgICAg ICAgCisgICAgICAgIEFWRm91bmRhdGlvbiBzdXBwb3J0IG9uIFdpbmRvd3Mgd2lsbCAoZXZlbnR1 YWxseSkgYmUgcHJlZGljYXRlZCBvbiB0aGUKKyAgICAgICAgYXZhaWxhYmlsaXR5IG9mIEFWRm91 bmRhdGlvbiBoZWFkZXJzIGFuZCBsaWJyYXJpZXMgaW4gdGhlIFdlYktpdCBTdXBwb3J0CisgICAg ICAgIExpYnJhcmllcywgc28gd2UgdGVzdCBmb3IgdGhlIGV4aXN0ZW5jZSBvZiBvbmUgb2YgdGhl IGhlYWRlciBmaWxlcyAoQVZDRkJhc2UuaCkKKyAgICAgICAgdG8gZGV0ZXJtaW5lIHdoZXRoZXIg dG8gZW5hYmxlIHRoaXMgZmVhdHVyZS4KKyAgICAgICAgCisgICAgICAgIEZvciBub3csIGV2ZW4g aWYgQVZGb3VuZGF0aW9uIGlzIGF2YWlsYWJsZSwgbGVhdmUgdGhpcyBmZWF0dXJlIG9mZiwgc2lu Y2UKKyAgICAgICAgaXQncyBub3QgcmVhZHkgdG8gYmUgdHVybmVkIG9uIHlldCAod2hpY2ggaXMg Y292ZXJlZCBieSBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjU0MDAp LgorICAgICAgICAKKyAgICAgICAgSWRlYWxseSwgd2Ugd291bGQgZ2VuZXJhdGUgV2ViQ29yZUhl YWRlckRldGVjdGlvbi5oIG9uIGFsbCBwbGF0Zm9ybXMgc28gd2UgY291bGQKKyAgICAgICAgaW5j bHVkZSBpdCB1bmNvbmRpdGlvbmFsbHkgaW4gV2ViQ29yZSdzIGNvbmZpZy5oLCBidXQgdW5mb3J0 dW5hdGVseSB0aGUgTWFjLW9ubHkgZmlsZQorICAgICAgICBFeHBvcnRGaWxlR2VuZXJhdG9yLmNw cCBkZXBlbmRzIG9uIFdURl9VU0VfQVZGT1VOREFUSU9OIGJlaW5nIHNldCBjb3JyZWN0bHksIGFu ZCBzaW5jZSB0aGlzCisgICAgICAgIC5jcHAgZmlsZSBpcyBhbHNvIGdlbmVyYXRlZCBpdCBkb2Vz bid0IGhhdmUgYWNjZXNzIHRvIFdlYkNvcmVIZWFkZXJEZXRlY3Rpb24uaC4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBjaGFuZ2UgaW4gZnVuY3Rp b25hbGl0eSwgc28gbmV3IHRlc3RzLgorCisgICAgICAgICogRGVyaXZlZFNvdXJjZXMubWFrZTog QWRkIHJ1bGUgdG8gZ2VuZXJhdGUgV2ViQ29yZUhlYWRlckRldGVjdGlvbi5oIG9uIFdpbmRvd3Mu CisgICAgICAgICogY29uZmlnLmg6IEluY2x1ZGUgV2ViQ29yZUhlYWRlckRldGVjdGlvbi5oIG9u IFdpbmRvd3MsIGFkZCBjb21tZW50IGFib3V0IFdURl9VU0VfQVZGT1VOREFUSU9OIGJlaW5nIGRl ZmluZWQgdGhlcmUuCisKIDIwMTEtMDgtMDMgIEpvc2VwaCBQZWNvcmFybyAgPGpvZXBlY2tAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBSZW1vdmUgSW5zcGVjdG9yRnJvbnRl bmRIb3N0IGxvYWQvc2F2ZVNlc3Npb25TZXR0aW5nCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9EZXJp dmVkU291cmNlcy5tYWtlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL0Rlcml2ZWRTb3Vy Y2VzLm1ha2UJKHJldmlzaW9uIDkyMjc2KQorKysgU291cmNlL1dlYkNvcmUvRGVyaXZlZFNvdXJj ZXMubWFrZQkod29ya2luZyBjb3B5KQpAQCAtOTcwLDMgKzk3MCwxNyBAQCBET00lLmggOiAlLmlk bCAkKERPTV9CSU5ESU5HU19TQ1JJUFRTKSBiCiAjIC0tLS0tLS0tCiAKIGVuZGlmICMgTUFDT1MK KworIyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KKworIyBIZWFkZXIgZGV0ZWN0aW9uCisKK2lm ZXEgKCQoT1MpLFdpbmRvd3NfTlQpCisKK2FsbCA6IFdlYkNvcmVIZWFkZXJEZXRlY3Rpb24uaAor CisjIFdURl9VU0VfQVZGT1VOREFUSU9OIHdpbGwgYmUgZGVmaW5lZCwgaWYgbmVlZGVkLCBpbiBj b25maWcuaCBvbiBub24tV2luZG93cyBwbGF0Zm9ybXMuCitXZWJDb3JlSGVhZGVyRGV0ZWN0aW9u LmggOiBEZXJpdmVkU291cmNlcy5tYWtlCisJaWYgWyAtZiAiJChXRUJLSVRMSUJSQVJJRVNESVIp L2luY2x1ZGUvQVZGb3VuZGF0aW9uQ0YvQVZDRkJhc2UuaCIgXTsgdGhlbiBlY2hvICIjZGVmaW5l IFdURl9VU0VfQVZGT1VOREFUSU9OIDAiID4gJEA7IGVsc2UgZWNobyA+ICRAOyBmaQorCitlbmRp ZiAjIFdpbmRvd3NfTlQKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2NvbmZpZy5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJDb3JlL2NvbmZpZy5oCShyZXZpc2lvbiA5MjI3NikKKysrIFNvdXJjZS9X ZWJDb3JlL2NvbmZpZy5oCSh3b3JraW5nIGNvcHkpCkBAIC0yOSw2ICsyOSwxMCBAQAogCiAjaW5j bHVkZSA8d3RmL1BsYXRmb3JtLmg+CiAKKyNpZiBPUyhXSU5ET1dTKQorI2luY2x1ZGUgPFdlYkNv cmUvV2ViQ29yZUhlYWRlckRldGVjdGlvbi5oPgorI2VuZGlmCisKIC8qIFNlZSBub3RlIGluIHd0 Zi9QbGF0Zm9ybS5oIGZvciBtb3JlIGluZm8gb24gRVhQT1JUX01BQ1JPUy4gKi8KICNpZiBVU0Uo RVhQT1JUX01BQ1JPUykKIApAQCAtMjE3LDcgKzIyMSw3IEBAIHR5cGVkZWYgZmxvYXQgQ0dGbG9h dDsKICNpbmNsdWRlIDxicmlkZ2UvbnBydW50aW1lX2ludGVybmFsLmg+CiAjZW5kaWYKIAorLy8g V1RGX1VTRV9BVkZPVU5EQVRJT04gaXMgZGVmaW5lZCAoaWYgbmVlZGVkKSBieSB0aGUgZ2VuZXJh dGVkIGhlYWRlciBmaWxlIFdlYkNvcmVIZWFkZXJEZXRlY3Rpb24uaCBvbiBXaW5kb3dzLgogI2lm IFBMQVRGT1JNKE1BQykgJiYgIWRlZmluZWQoQlVJTERJTkdfT05fTEVPUEFSRCkgJiYgIWRlZmlu ZWQoQlVJTERJTkdfT05fU05PV19MRU9QQVJEKQogI2RlZmluZSBXVEZfVVNFX0FWRk9VTkRBVElP TiAxCiAjZW5kaWYKLQo= 102816 2011-08-03 12:48:31 -0700 2011-08-03 12:51:05 -0700 Patch bug-65634-20110803124830.patch text/plain 3018 jeffm SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkyMzAzKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjggQEAKKzIwMTEtMDgtMDMgIEplZmYgTWls bGVyICA8amVmZm1AYXBwbGUuY29tPgorCisgICAgICAgIEdlbmVyYXRlIFdlYkNvcmVIZWFkZXJE ZXRlY3Rpb24uaCBvbiBXaW5kb3dzIHRvIGRlZmluZSBIQVZFX0FWQ0YKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1NjM0CisgICAgICAgIAorICAgICAg ICBBVkZvdW5kYXRpb24gc3VwcG9ydCBvbiBXaW5kb3dzIHdpbGwgKGV2ZW50dWFsbHkpIGJlIHBy ZWRpY2F0ZWQgb24gdGhlCisgICAgICAgIGF2YWlsYWJpbGl0eSBvZiBBVkZvdW5kYXRpb25DRiBo ZWFkZXJzIGFuZCBsaWJyYXJpZXMgaW4gdGhlIFdlYktpdCBTdXBwb3J0CisgICAgICAgIExpYnJh cmllcywgc28gd2UgdGVzdCBmb3IgdGhlIGV4aXN0ZW5jZSBvZiBvbmUgb2YgdGhlIGhlYWRlciBm aWxlcyAoQVZDRkJhc2UuaCkKKyAgICAgICAgdG8gZGV0ZXJtaW5lIHdoZXRoZXIgdG8gQVZDRiBp cyBhdmFpbGFibGUuCisgICAgICAgIAorICAgICAgICBGb3Igbm93LCBldmVuIGlmIEFWRm91bmRh dGlvbkNGIGlzIGF2YWlsYWJsZSwgbGVhdmUgV1RGX1VTRV9BVkZPVU5EQVRJT04gb2ZmLCBzaW5j ZQorICAgICAgICBpdCdzIG5vdCByZWFkeSB0byBiZSB0dXJuZWQgb24geWV0ICh3aGljaCBpcyBj b3ZlcmVkIGJ5IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTQwMCku CisgICAgICAgIAorICAgICAgICBJZGVhbGx5LCB3ZSB3b3VsZCBnZW5lcmF0ZSBXZWJDb3JlSGVh ZGVyRGV0ZWN0aW9uLmggb24gYWxsIHBsYXRmb3JtcyBzbyB3ZSBjb3VsZAorICAgICAgICBpbmNs dWRlIGl0IHVuY29uZGl0aW9uYWxseSBpbiBXZWJDb3JlJ3MgY29uZmlnLmgsIGJ1dCB1bmZvcnR1 bmF0ZWx5IHRoZSBNYWMtb25seSBmaWxlCisgICAgICAgIEV4cG9ydEZpbGVHZW5lcmF0b3IuY3Bw IGRlcGVuZHMgb24gV1RGX1VTRV9BVkZPVU5EQVRJT04gYmVpbmcgc2V0IGNvcnJlY3RseSwgYW5k IHNpbmNlIHRoaXMKKyAgICAgICAgLmNwcCBmaWxlIGlzIGFsc28gZ2VuZXJhdGVkIGl0IGRvZXNu J3QgaGF2ZSBhY2Nlc3MgdG8gV2ViQ29yZUhlYWRlckRldGVjdGlvbi5oLgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIGNoYW5nZSBpbiBmdW5jdGlv bmFsaXR5LCBzbyBuZXcgdGVzdHMuCisKKyAgICAgICAgKiBEZXJpdmVkU291cmNlcy5tYWtlOiBB ZGQgcnVsZSB0byBnZW5lcmF0ZSBXZWJDb3JlSGVhZGVyRGV0ZWN0aW9uLmggdG8gc2V0IEhBVkVf QVZDRiBvbiBXaW5kb3dzLgorICAgICAgICAqIGNvbmZpZy5oOiBJbmNsdWRlIFdlYkNvcmVIZWFk ZXJEZXRlY3Rpb24uaCBvbiBXaW5kb3dzLCBjaGVjayBmb3IgSEFWRShBVkNGKSBidXQgYWx3YXlz IGxlYXZlIFdURl9VU0VfQVZGT1VOREFUSU9OIG9mZiBvbiBXaW5kb3dzIGZvciBub3cuCisKIDIw MTEtMDgtMDMgIEpvc2VwaCBQZWNvcmFybyAgPGpvZXBlY2tAd2Via2l0Lm9yZz4KIAogICAgICAg ICBXZWIgSW5zcGVjdG9yOiBSZW1vdmUgSW5zcGVjdG9yRnJvbnRlbmRIb3N0IGxvYWQvc2F2ZVNl c3Npb25TZXR0aW5nCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9EZXJpdmVkU291cmNlcy5tYWtlCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL0Rlcml2ZWRTb3VyY2VzLm1ha2UJKHJldmlzaW9u IDkyMjc2KQorKysgU291cmNlL1dlYkNvcmUvRGVyaXZlZFNvdXJjZXMubWFrZQkod29ya2luZyBj b3B5KQpAQCAtOTcwLDMgKzk3MCwxNiBAQCBET00lLmggOiAlLmlkbCAkKERPTV9CSU5ESU5HU19T Q1JJUFRTKSBiCiAjIC0tLS0tLS0tCiAKIGVuZGlmICMgTUFDT1MKKworIyAtLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0KKworIyBIZWFkZXIgZGV0ZWN0aW9uCisKK2lmZXEgKCQoT1MpLFdpbmRvd3Nf TlQpCisKK2FsbCA6IFdlYkNvcmVIZWFkZXJEZXRlY3Rpb24uaAorCitXZWJDb3JlSGVhZGVyRGV0 ZWN0aW9uLmggOiBEZXJpdmVkU291cmNlcy5tYWtlCisJaWYgWyAtZiAiJChXRUJLSVRMSUJSQVJJ RVNESVIpL2luY2x1ZGUvQVZGb3VuZGF0aW9uQ0YvQVZDRkJhc2UuaCIgXTsgdGhlbiBlY2hvICIj ZGVmaW5lIEhBVkVfQVZDRiAxIiA+ICRAOyBlbHNlIGVjaG8gPiAkQDsgZmkKKworZW5kaWYgIyBX aW5kb3dzX05UCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9jb25maWcuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9jb25maWcuaAkocmV2aXNpb24gOTIyNzYpCisrKyBTb3VyY2UvV2ViQ29y ZS9jb25maWcuaAkod29ya2luZyBjb3B5KQpAQCAtMjksNiArMjksMTAgQEAKIAogI2luY2x1ZGUg PHd0Zi9QbGF0Zm9ybS5oPgogCisjaWYgT1MoV0lORE9XUykKKyNpbmNsdWRlIDxXZWJDb3JlL1dl YkNvcmVIZWFkZXJEZXRlY3Rpb24uaD4KKyNlbmRpZgorCiAvKiBTZWUgbm90ZSBpbiB3dGYvUGxh dGZvcm0uaCBmb3IgbW9yZSBpbmZvIG9uIEVYUE9SVF9NQUNST1MuICovCiAjaWYgVVNFKEVYUE9S VF9NQUNST1MpCiAKQEAgLTIyMSwzICsyMjUsNyBAQCB0eXBlZGVmIGZsb2F0IENHRmxvYXQ7CiAj ZGVmaW5lIFdURl9VU0VfQVZGT1VOREFUSU9OIDEKICNlbmRpZgogCisjaWYgUExBVEZPUk0oV0lO KSAmJiBIQVZFKEFWQ0YpCisvLyBGSVhNRSg2NTQwMCk6IEFkb3B0IEFWQ0YgbWVkaWEgYmFjayBl bmQgb24gV2luZG93cworI2RlZmluZSBXVEZfVVNFX0FWRk9VTkRBVElPTiAwCisjZW5kaWYK