65628 2011-08-03 11:05:03 -0700 Teach BuilderToPort to distinguish between Release and Debug builders. 2011-08-03 11:11:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dglazkov dglazkov webkit.review.bot oldest_to_newest 445947 0 dglazkov 2011-08-03 11:05:03 -0700 Teach BuilderToPort to distinguish between Release and Debug builders. 445948 1 102794 dglazkov 2011-08-03 11:06:44 -0700 Created attachment 102794 Patch 445951 2 102794 abarth 2011-08-03 11:08:52 -0700 Comment on attachment 102794 Patch Ok. BuilderToPort is really a hack. I don't want to add too much complexity to it because that will make it harder to unwind later, but this patch seems fine... 445955 3 102794 dglazkov 2011-08-03 11:11:25 -0700 Comment on attachment 102794 Patch Clearing flags on attachment: 102794 Committed r92294: <http://trac.webkit.org/changeset/92294> 445956 4 dglazkov 2011-08-03 11:11:29 -0700 All reviewed patches have been landed. Closing bug. 102794 2011-08-03 11:06:44 -0700 2011-08-03 11:11:25 -0700 Patch bug-65628-20110803110643.patch text/plain 3832 dglazkov U3VidmVyc2lvbiBSZXZpc2lvbjogOTIyODIKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBi L1Rvb2xzL0NoYW5nZUxvZwppbmRleCA3NGUwNDFiMmFkOWMxZGJiYmI0ZGVkY2Q5MzI3NjEzOTE0 MzNmOGUwLi45NTM3YTJlNDZlNWVlOWI1Y2M1ZWRiMDQ3Zjc2NmE1YTBjMTU5MmNhIDEwMDY0NAot LS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTEtMDgtMDMgIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4K KworICAgICAgICBUZWFjaCBCdWlsZGVyVG9Qb3J0IHRvIGRpc3Rpbmd1aXNoIGJldHdlZW4gUmVs ZWFzZSBhbmQgRGVidWcgYnVpbGRlcnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD02NTYyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3JlYmFzZWxp bmUucHk6IEFkZGVkIGEgc21hcnQgb3B0aW9ucyBvYmplY3QgYW5kIHBhc3NlZCBpdCB0byBwb3J0 IGZhY3RvcnkuCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRzL3JlYmFz ZWxpbmVfdW5pdHRlc3QucHk6IEFkZGVkIHRlc3RzLgorCiAyMDExLTA4LTAyICBEaW1pdHJpIEds YXprb3YgIDxkZ2xhemtvdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgQWRkIGEgd2F5IHRvIGVk aXQgdGVzdCBleHBlY3RhdGlvbnMuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3Rvb2wvY29tbWFuZHMvcmViYXNlbGluZS5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9v bC9jb21tYW5kcy9yZWJhc2VsaW5lLnB5CmluZGV4IDA0YjI0ZTcwOTlkMDliZDFmNjRjNzQ5MzMz ZTVkMjkwNDliMjJmNmIuLmMxOWY3ODBjOTc1ZDMwZWU2M2JmYTM0NTk5ZWQzZTZmNjU0NjZhMTYg MTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9yZWJhc2Vs aW5lLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy9yZWJhc2Vs aW5lLnB5CkBAIC00Myw4ICs0MywxOCBAQCBmcm9tIHdlYmtpdHB5LnRvb2wuZ3JhbW1hciBpbXBv cnQgcGx1cmFsaXplCiBmcm9tIHdlYmtpdHB5LnRvb2wubXVsdGljb21tYW5kdG9vbCBpbXBvcnQg QWJzdHJhY3REZWNsYXJhdGl2ZUNvbW1hbmQKIAogCitjbGFzcyBSZWJhc2VsaW5pbmdPcHRpb25z KG9iamVjdCk6CisKKyAgICBERUJVR19DT05GSUdVUkFUSU9OX1JFR0VYID0gciJbZHxEXShlYnV8 YilnIgorCisgICAgZGVmIF9faW5pdF9fKHNlbGYsIGJ1aWxkZXJfbmFtZSk6CisgICAgICAgIHNl bGYuY29uZmlndXJhdGlvbiA9ICJEZWJ1ZyIgaWYgcmUuc2VhcmNoKHNlbGYuREVCVUdfQ09ORklH VVJBVElPTl9SRUdFWCwgYnVpbGRlcl9uYW1lKSBlbHNlICJSZWxlYXNlIgorICAgICAgICBzZWxm LmJ1aWxkZXJfbmFtZSA9IGJ1aWxkZXJfbmFtZQorCisKICMgRklYTUU6IFRoaXMgbG9naWMgc2hv dWxkIGJlIG1vdmVkIHRvIGJ1aWxkZXJzLnB5LgogY2xhc3MgQnVpbGRlclRvUG9ydChvYmplY3Qp OgorCiAgICAgX2J1aWxkZXJfbmFtZV90b19wb3J0X25hbWUgPSB7CiAgICAgICAgICMgVGhlc2Ug YnVpbGRlcnMgYXJlIG9uIGJ1aWxkLndlYmtpdC5vcmcuCiAgICAgICAgIHIiU25vd0xlb3BhcmQi OiAibWFjLXNub3dsZW9wYXJkIiwKQEAgLTYwLDggKzcwLDggQEAgY2xhc3MgQnVpbGRlclRvUG9y dChvYmplY3QpOgogICAgICAgICByIldlYmtpdCBXaW4kIjogImNocm9taXVtLXdpbi14cCIsCiAg ICAgICAgIHIiV2Via2l0IFZpc3RhIjogImNocm9taXVtLXdpbi12aXN0YSIsCiAgICAgICAgIHIi V2Via2l0IFdpbjciOiAiY2hyb21pdW0td2luLXdpbjciLAotICAgICAgICByIldlYmtpdCBXaW4g XChkYmdcKVwoMVwpIjogImNocm9taXVtLXdpbi13aW43IiwgICMgRklYTUU6IElzIHRoaXMgY29y cmVjdD8KLSAgICAgICAgciJXZWJraXQgV2luIFwoZGJnXClcKDJcKSI6ICJjaHJvbWl1bS13aW4t d2luNyIsICAjIEZJWE1FOiBJcyB0aGlzIGNvcnJlY3Q/CisgICAgICAgIHIiV2Via2l0IFdpbiBc KGRiZ1wpXCgxXCkiOiAiY2hyb21pdW0td2luLXhwIiwKKyAgICAgICAgciJXZWJraXQgV2luIFwo ZGJnXClcKDJcKSI6ICJjaHJvbWl1bS13aW4teHAiLAogICAgICAgICByIldlYmtpdCBMaW51eCI6 ICJjaHJvbWl1bS1saW51eC14ODZfNjQiLAogICAgICAgICByIldlYmtpdCBMaW51eCAzMiI6ICJj aHJvbWl1bS1saW51eC14ODYiLAogICAgICAgICByIldlYmtpdCBMaW51eCBcKGRiZ1wpXCgxXCki OiAiY2hyb21pdW0tbGludXgteDg2XzY0IiwKQEAgLTgxLDcgKzkxLDcgQEAgY2xhc3MgQnVpbGRl clRvUG9ydChvYmplY3QpOgogICAgIGRlZiBwb3J0X2Zvcl9idWlsZGVyKHNlbGYsIGJ1aWxkZXJf bmFtZSk6CiAgICAgICAgIHBvcnRfbmFtZSA9IHNlbGYuX3BvcnRfbmFtZV9mb3JfYnVpbGRlcl9u YW1lKGJ1aWxkZXJfbmFtZSkKICAgICAgICAgYXNzZXJ0KHBvcnRfbmFtZSkgICMgTmVlZCB0byB1 cGRhdGUgX2J1aWxkZXJfbmFtZV90b19wb3J0X25hbWUKLSAgICAgICAgcG9ydCA9IGZhY3Rvcnku Z2V0KHBvcnRfbmFtZSkKKyAgICAgICAgcG9ydCA9IGZhY3RvcnkuZ2V0KHBvcnRfbmFtZSwgUmVi YXNlbGluaW5nT3B0aW9ucyhidWlsZGVyX25hbWUpKQogICAgICAgICBhc3NlcnQocG9ydCkgICMg TmVlZCB0byB1cGRhdGUgX2J1aWxkZXJfbmFtZV90b19wb3J0X25hbWUKICAgICAgICAgcmV0dXJu IHBvcnQKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL2NvbW1hbmRz L3JlYmFzZWxpbmVfdW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29t bWFuZHMvcmViYXNlbGluZV91bml0dGVzdC5weQppbmRleCAyM2QyZDBlNTllYzI1MGI1ODNlMGM3 YzBhNDJjMmVhNzI4NjNkM2JhLi5kNDlmMDAzMTExZTNiYzg3MWFlYzA5ZWU2MjMzNzljMTk1OWIx MTk2IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvcmVi YXNlbGluZV91bml0dGVzdC5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29t bWFuZHMvcmViYXNlbGluZV91bml0dGVzdC5weQpAQCAtNTYsNCArNTYsOCBAQCBjbGFzcyBCdWls ZGVyVG9Qb3J0VGVzdCh1bml0dGVzdC5UZXN0Q2FzZSk6CiAgICAgZGVmIHRlc3RfcG9ydF9mb3Jf YnVpbGRlcihzZWxmKToKICAgICAgICAgY29udmVydGVyID0gQnVpbGRlclRvUG9ydCgpCiAgICAg ICAgIHBvcnQgPSBjb252ZXJ0ZXIucG9ydF9mb3JfYnVpbGRlcigiTGVvcGFyZCBJbnRlbCBEZWJ1 ZyAoVGVzdHMpIikKLSAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChwb3J0Lm5hbWUoKSwgIm1hYy1s ZW9wYXJkIikKKyAgICAgICAgc2VsZi5hc3NlcnRFcXVhbChzdHIocG9ydC50ZXN0X2NvbmZpZ3Vy YXRpb24oKSksICI8bGVvcGFyZCwgeDg2LCBkZWJ1ZywgY3B1PiIpCisgICAgICAgIHBvcnQgPSBj b252ZXJ0ZXIucG9ydF9mb3JfYnVpbGRlcigiTGVvcGFyZCBJbnRlbCBSZWxlYXNlIChUZXN0cyki KQorICAgICAgICBzZWxmLmFzc2VydEVxdWFsKHN0cihwb3J0LnRlc3RfY29uZmlndXJhdGlvbigp KSwgIjxsZW9wYXJkLCB4ODYsIHJlbGVhc2UsIGNwdT4iKQorICAgICAgICBwb3J0ID0gY29udmVy dGVyLnBvcnRfZm9yX2J1aWxkZXIoIldlYmtpdCBXaW4gKGRiZykoMSkiKQorICAgICAgICBzZWxm LmFzc2VydEVxdWFsKHN0cihwb3J0LnRlc3RfY29uZmlndXJhdGlvbigpKSwgIjx4cCwgeDg2LCBk ZWJ1ZywgY3B1PiIpCg==