65618 2011-08-03 06:57:51 -0700 [GTK] fullscreen/video-controls-override.html fails 2011-08-05 02:23:52 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned gustavo webkit.review.bot xan.lopez zoltan oldest_to_newest 445852 0 pnormand 2011-08-03 06:57:51 -0700 Because the test implicitely depends on the fullscreenQuickTime.css file which GTK doesn't use. EVENT(webkitfullscreenchange) EXPECTED (shadowRoot = internals.shadowRoot(video) != 'null') OK EXPECTED (panel = shadowRoot.firstChild.firstChild != 'null') OK EXPECTED (internals.shadowPseudoId(panel) == '-webkit-media-controls-panel') OK EXPECTED (document.defaultView.getComputedStyle(panel)['display'] != 'none') OK EXPECTED (document.defaultView.getComputedStyle(panel)['height'] == '48px'), OBSERVED '600px' FAIL EVENT(webkitfullscreenchange) EXPECTED (document.defaultView.getComputedStyle(panel)['display'] == 'none') OK END OF TEST 445857 1 102782 pnormand 2011-08-03 07:17:00 -0700 Created attachment 102782 proposed patch 445859 2 pnormand 2011-08-03 07:17:56 -0700 Before landing this we should remove: DerivedSources/WebCore/UserAgentStyleSheetsData.cpp DerivedSources/WebCore/UserAgentStyleSheets.h on the bots. Or trigger a full-rebuild. 445861 3 webkit.review.bot 2011-08-03 07:20:04 -0700 Attachment 102782 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/gtk/RenderThemeGtk.cpp:482: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 445862 4 102784 pnormand 2011-08-03 07:23:39 -0700 Created attachment 102784 proposed patch 445866 5 102784 mrobinson 2011-08-03 07:36:59 -0700 Comment on attachment 102784 proposed patch Okay. 446091 6 102784 gustavo 2011-08-03 14:37:26 -0700 Comment on attachment 102784 proposed patch Attachment 102784 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/9306088 446437 7 pnormand 2011-08-04 05:16:22 -0700 (In reply to comment #6) > (From update of attachment 102784 [details]) > Attachment 102784 [details] did not pass gtk-ews (gtk): > Output: http://queues.webkit.org/results/9306088 This was expected. :) Gustavo, I'm ready to land this, but it requires to remove 2 files in the build directory, as mentioned in comment 2. It'd be nice to synchronize ourselves on this patch-landing! 446465 8 pnormand 2011-08-04 06:45:07 -0700 Committed r92370: <http://trac.webkit.org/changeset/92370> 447128 9 zoltan 2011-08-05 02:23:52 -0700 I triggered http://build.webkit.sed.hu/builders/ARMv5%20Linux%20Gtk%20Release to make clean build after r92469. 102782 2011-08-03 07:17:00 -0700 2011-08-03 07:23:39 -0700 proposed patch proposed-patch.patch text/plain 3219 pnormand RnJvbSAzZjZjNWFkMGYyYjg5YWY0MDAxYTczZDJkZDg1YWY5ZDczOTYzMjgyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBXZWQsIDMgQXVnIDIwMTEgMTY6MTY6MjEgKzAyMDAKU3ViamVjdDogW1BBVENIXSBw cm9wb3NlZCBwYXRjaAoKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAg ICAgICAgICAgIHwgICAxNSArKysrKysrKysrKysrKysKIFNvdXJjZS9XZWJDb3JlL0dOVW1ha2Vm aWxlLmFtICAgICAgICAgICAgICAgICAgfCAgICAzICsrLQogU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3RrL1JlbmRlclRoZW1lR3RrLmNwcCB8ICAgIDYgKysrKysrCiBTb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGsuaCAgIHwgICAgNCArKysrCiA0IGZpbGVzIGNoYW5n ZWQsIDI3IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGFlZDM1 NDcuLjhmZmQ2NmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMCBAQAogMjAxMS0wOC0wMyAgUGhp bGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKKyAgICAgICAgW0dUS10gZnVs bHNjcmVlbi92aWRlby1jb250cm9scy1vdmVycmlkZS5odG1sIGZhaWxzCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTYxOAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEltcGxlbWVudCBleHRyYUZ1bGxTY3Jl ZW5TdHlsZVNoZWV0KCkgYW5kIHByb3ZpZGUgdGhlIFF1aWNrVGltZQorICAgICAgICBzdHlsZXNo ZWV0IGZvciBub3csIGxhdGVyIHdlIG1pZ2h0IHdhbnQgb3VyIG93biBzdHlsZXNoZWV0LgorCisg ICAgICAgICogR05VbWFrZWZpbGUuYW06CisgICAgICAgICogcGxhdGZvcm0vZ3RrL1JlbmRlclRo ZW1lR3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lR3RrOjpleHRyYUZ1bGxT Y3JlZW5TdHlsZVNoZWV0KToKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGsu aDoKKworMjAxMS0wOC0wMyAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+ CisKICAgICAgICAgbGlic291cC1DUklUSUNBTCAqKjogc291cF9tZXNzYWdlX2lvX3BhdXNlOiBh c3NlcnRpb24gYGlvICE9IE5VTEwnIGZhaWxlZAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQyNjMKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv R05VbWFrZWZpbGUuYW0gYi9Tb3VyY2UvV2ViQ29yZS9HTlVtYWtlZmlsZS5hbQppbmRleCBjYzc1 NTNhLi5jNGY0ZWQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9HTlVtYWtlZmlsZS5hbQor KysgYi9Tb3VyY2UvV2ViQ29yZS9HTlVtYWtlZmlsZS5hbQpAQCAtNjczLDcgKzY3Myw4IEBAIFVT RVJfQUdFTlRfU1RZTEVfU0hFRVRTID0gXAogCSQoV2ViQ29yZSkvY3NzL3N2Zy5jc3MgXAogCSQo V2ViQ29yZSkvY3NzL21lZGlhQ29udHJvbHMuY3NzIFwKIAkkKFdlYkNvcmUpL2Nzcy9tZWRpYUNv bnRyb2xzR3RrLmNzcyBcCi0JJChXZWJDb3JlKS9jc3MvZnVsbHNjcmVlbi5jc3MKKwkkKFdlYkNv cmUpL2Nzcy9mdWxsc2NyZWVuLmNzcyBcCisJJChXZWJDb3JlKS9jc3MvZnVsbHNjcmVlblF1aWNr VGltZS5jc3MKIAogIyBuZXctc3R5bGUgSmF2YVNjcmlwdCBiaW5kaW5ncwogU0NSSVBUU19CSU5E SU5HUyA9IFwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJU aGVtZUd0ay5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGsu Y3BwCmluZGV4IDg4NjcwOTguLmUwZGE1OGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0ay5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3RrL1JlbmRlclRoZW1lR3RrLmNwcApAQCAtNDc4LDYgKzQ3OCwxMiBAQCBTdHJpbmcgUmVu ZGVyVGhlbWVHdGs6OmV4dHJhTWVkaWFDb250cm9sc1N0eWxlU2hlZXQoKQogICAgIHJldHVybiBT dHJpbmcobWVkaWFDb250cm9sc0d0a1VzZXJBZ2VudFN0eWxlU2hlZXQsIHNpemVvZihtZWRpYUNv bnRyb2xzR3RrVXNlckFnZW50U3R5bGVTaGVldCkpOwogfQogCisjaWYgRU5BQkxFKEZVTExTQ1JF RU5fQVBJKQorU3RyaW5nIFJlbmRlclRoZW1lR3RrOjpleHRyYUZ1bGxTY3JlZW5TdHlsZVNoZWV0 KCkgeworICAgIHJldHVybiBTdHJpbmcoZnVsbHNjcmVlblF1aWNrVGltZVVzZXJBZ2VudFN0eWxl U2hlZXQsIHNpemVvZihmdWxsc2NyZWVuUXVpY2tUaW1lVXNlckFnZW50U3R5bGVTaGVldCkpOwor fQorI2VuZGlmCisKIHZvaWQgUmVuZGVyVGhlbWVHdGs6OmFkanVzdE1lZGlhU2xpZGVyVGh1bWJT aXplKFJlbmRlclN0eWxlKiBzdHlsZSkgY29uc3QKIHsKICAgICBBU1NFUlQoc3R5bGUtPmFwcGVh cmFuY2UoKSA9PSBNZWRpYVNsaWRlclRodW1iUGFydCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGsuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2d0ay9SZW5kZXJUaGVtZUd0ay5oCmluZGV4IDcyYzAzYmYuLmIzYjE0OGYgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0ay5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0ay5oCkBAIC04Nyw2ICs4Nywx MCBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCBTdHJpbmcgZm9ybWF0TWVkaWFDb250cm9sc0N1cnJl bnRUaW1lKGZsb2F0IGN1cnJlbnRUaW1lLCBmbG9hdCBkdXJhdGlvbikgY29uc3Q7CiAjZW5kaWYK IAorI2lmIEVOQUJMRShGVUxMU0NSRUVOX0FQSSkKKyAgICB2aXJ0dWFsIFN0cmluZyBleHRyYUZ1 bGxTY3JlZW5TdHlsZVNoZWV0KCk7CisjZW5kaWYKKwogI2lmZGVmIEdUS19BUElfVkVSU0lPTl8y CiAgICAgR3RrV2lkZ2V0KiBndGtDb250YWluZXIoKSBjb25zdDsKICAgICBHdGtXaWRnZXQqIGd0 a0VudHJ5KCkgY29uc3Q7Ci0tIAoxLjcuNS40 102784 2011-08-03 07:23:39 -0700 2011-08-03 14:37:26 -0700 proposed patch proposed-patch.patch text/plain 3221 pnormand RnJvbSAxNDU5NDU3NTM2MTZlZGU3ZGZhOWNlZjE3ODA4NDNjYTczYzA1M2U1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBXZWQsIDMgQXVnIDIwMTEgMTY6MTY6MjEgKzAyMDAKU3ViamVjdDogW1BBVENIXSBw cm9wb3NlZCBwYXRjaAoKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAg ICAgICAgICAgIHwgICAxNSArKysrKysrKysrKysrKysKIFNvdXJjZS9XZWJDb3JlL0dOVW1ha2Vm aWxlLmFtICAgICAgICAgICAgICAgICAgfCAgICAzICsrLQogU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3RrL1JlbmRlclRoZW1lR3RrLmNwcCB8ICAgIDcgKysrKysrKwogU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3RrLmggICB8ICAgIDQgKysrKwogNCBmaWxlcyBjaGFu Z2VkLCAyOCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBhZWQz NTQ3Li44ZmZkNjZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAgQEAKIDIwMTEtMDgtMDMgIFBo aWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgogCisgICAgICAgIFtHVEtdIGZ1 bGxzY3JlZW4vdmlkZW8tY29udHJvbHMtb3ZlcnJpZGUuaHRtbCBmYWlscworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjU2MTgKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbXBsZW1lbnQgZXh0cmFGdWxsU2Ny ZWVuU3R5bGVTaGVldCgpIGFuZCBwcm92aWRlIHRoZSBRdWlja1RpbWUKKyAgICAgICAgc3R5bGVz aGVldCBmb3Igbm93LCBsYXRlciB3ZSBtaWdodCB3YW50IG91ciBvd24gc3R5bGVzaGVldC4KKwor ICAgICAgICAqIEdOVW1ha2VmaWxlLmFtOgorICAgICAgICAqIHBsYXRmb3JtL2d0ay9SZW5kZXJU aGVtZUd0ay5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJUaGVtZUd0azo6ZXh0cmFGdWxs U2NyZWVuU3R5bGVTaGVldCk6CisgICAgICAgICogcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3Rr Lmg6CisKKzIwMTEtMDgtMDMgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgorCiAgICAgICAgIGxpYnNvdXAtQ1JJVElDQUwgKio6IHNvdXBfbWVzc2FnZV9pb19wYXVzZTog YXNzZXJ0aW9uIGBpbyAhPSBOVUxMJyBmYWlsZWQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTY0MjYzCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L0dOVW1ha2VmaWxlLmFtIGIvU291cmNlL1dlYkNvcmUvR05VbWFrZWZpbGUuYW0KaW5kZXggY2M3 NTUzYS4uYzRmNGVkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvR05VbWFrZWZpbGUuYW0K KysrIGIvU291cmNlL1dlYkNvcmUvR05VbWFrZWZpbGUuYW0KQEAgLTY3Myw3ICs2NzMsOCBAQCBV U0VSX0FHRU5UX1NUWUxFX1NIRUVUUyA9IFwKIAkkKFdlYkNvcmUpL2Nzcy9zdmcuY3NzIFwKIAkk KFdlYkNvcmUpL2Nzcy9tZWRpYUNvbnRyb2xzLmNzcyBcCiAJJChXZWJDb3JlKS9jc3MvbWVkaWFD b250cm9sc0d0ay5jc3MgXAotCSQoV2ViQ29yZSkvY3NzL2Z1bGxzY3JlZW4uY3NzCisJJChXZWJD b3JlKS9jc3MvZnVsbHNjcmVlbi5jc3MgXAorCSQoV2ViQ29yZSkvY3NzL2Z1bGxzY3JlZW5RdWlj a1RpbWUuY3NzCiAKICMgbmV3LXN0eWxlIEphdmFTY3JpcHQgYmluZGluZ3MKIFNDUklQVFNfQklO RElOR1MgPSBcCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUmVuZGVy VGhlbWVHdGsuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3Rr LmNwcAppbmRleCA4ODY3MDk4Li5jYTZmMzBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ndGsvUmVuZGVyVGhlbWVHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2d0ay9SZW5kZXJUaGVtZUd0ay5jcHAKQEAgLTQ3OCw2ICs0NzgsMTMgQEAgU3RyaW5nIFJl bmRlclRoZW1lR3RrOjpleHRyYU1lZGlhQ29udHJvbHNTdHlsZVNoZWV0KCkKICAgICByZXR1cm4g U3RyaW5nKG1lZGlhQ29udHJvbHNHdGtVc2VyQWdlbnRTdHlsZVNoZWV0LCBzaXplb2YobWVkaWFD b250cm9sc0d0a1VzZXJBZ2VudFN0eWxlU2hlZXQpKTsKIH0KIAorI2lmIEVOQUJMRShGVUxMU0NS RUVOX0FQSSkKK1N0cmluZyBSZW5kZXJUaGVtZUd0azo6ZXh0cmFGdWxsU2NyZWVuU3R5bGVTaGVl dCgpCit7CisgICAgcmV0dXJuIFN0cmluZyhmdWxsc2NyZWVuUXVpY2tUaW1lVXNlckFnZW50U3R5 bGVTaGVldCwgc2l6ZW9mKGZ1bGxzY3JlZW5RdWlja1RpbWVVc2VyQWdlbnRTdHlsZVNoZWV0KSk7 Cit9CisjZW5kaWYKKwogdm9pZCBSZW5kZXJUaGVtZUd0azo6YWRqdXN0TWVkaWFTbGlkZXJUaHVt YlNpemUoUmVuZGVyU3R5bGUqIHN0eWxlKSBjb25zdAogewogICAgIEFTU0VSVChzdHlsZS0+YXBw ZWFyYW5jZSgpID09IE1lZGlhU2xpZGVyVGh1bWJQYXJ0KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2d0ay9SZW5kZXJUaGVtZUd0ay5oIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3RrL1JlbmRlclRoZW1lR3RrLmgKaW5kZXggNzJjMDNiZi4uYjNiMTQ4ZiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3RrLmgKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1JlbmRlclRoZW1lR3RrLmgKQEAgLTg3LDYgKzg3 LDEwIEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIFN0cmluZyBmb3JtYXRNZWRpYUNvbnRyb2xzQ3Vy cmVudFRpbWUoZmxvYXQgY3VycmVudFRpbWUsIGZsb2F0IGR1cmF0aW9uKSBjb25zdDsKICNlbmRp ZgogCisjaWYgRU5BQkxFKEZVTExTQ1JFRU5fQVBJKQorICAgIHZpcnR1YWwgU3RyaW5nIGV4dHJh RnVsbFNjcmVlblN0eWxlU2hlZXQoKTsKKyNlbmRpZgorCiAjaWZkZWYgR1RLX0FQSV9WRVJTSU9O XzIKICAgICBHdGtXaWRnZXQqIGd0a0NvbnRhaW5lcigpIGNvbnN0OwogICAgIEd0a1dpZGdldCog Z3RrRW50cnkoKSBjb25zdDsKLS0gCjEuNy41LjQ=