65607 2011-08-03 04:23:23 -0700 Web Inspector: Console scroll position should be saved when switching panels. 2011-08-03 07:33:47 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vsevik vsevik apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 445805 0 vsevik 2011-08-03 04:23:23 -0700 Console scroll position should be saved when switching panels. 445807 1 102766 vsevik 2011-08-03 04:27:05 -0700 Created attachment 102766 Patch 445811 2 102766 pfeldman 2011-08-03 04:44:58 -0700 Comment on attachment 102766 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102766&action=review > Source/WebCore/inspector/front-end/ConsoleView.js:746 > + return this.messagesElement ? this.messagesElement.scrollLeft : 0; no need to check > Source/WebCore/inspector/front-end/ConsoleView.js:751 > + if (this.messagesElement) no need to check. > Source/WebCore/inspector/front-end/ConsoleView.js:757 > + return this.messagesElement ? this.messagesElement.scrollTop : 0; ditto > Source/WebCore/inspector/front-end/ConsoleView.js:762 > + if (this.messagesElement) ditto 445864 3 vsevik 2011-08-03 07:33:47 -0700 Committed r92278: <http://trac.webkit.org/changeset/92278> 102766 2011-08-03 04:27:05 -0700 2011-08-03 04:44:58 -0700 Patch bug-65607-20110803152703.patch text/plain 3649 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogOTIyNjUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2ZDcyNzkxODczNDA3MDcx ODk3MmJiNGQxMDU1ZjZmM2Y1MDgwNjMxLi5lNDM0NjczZDZhMjVhZTJiMGQzZGY4YzZjZjM4Mjgw OTRkZTU4NmFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTEtMDgtMDMgIFZzZXZv bG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogQ29uc29sZSBzY3JvbGwgcG9zaXRpb24gc2hvdWxkIGJlIHNhdmVkIHdoZW4gc3dpdGNoaW5n IHBhbmVscy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTY1NjA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBpbnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVj dG9yLkNvbnNvbGVWaWV3LnByb3RvdHlwZS5fZm9ybWF0QXNBcnJheUVudHJ5KToKKyAgICAgICAg KFdlYkluc3BlY3Rvci5Db25zb2xlVmlldy5wcm90b3R5cGUuZ2V0IHNjcm9sbExlZnQpOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLkNvbnNvbGVWaWV3LnByb3RvdHlwZS5zZXQgc2Nyb2xsTGVmdCk6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuQ29uc29sZVZpZXcucHJvdG90eXBlLmdldCBzY3JvbGxU b3ApOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNvbnNvbGVWaWV3LnByb3RvdHlwZS5zZXQgc2Ny b2xsVG9wKToKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0RyYXdlci5qczoKKyAgICAg ICAgKFdlYkluc3BlY3Rvci5EcmF3ZXIucHJvdG90eXBlLnNob3cpOgorICAgICAgICAoV2ViSW5z cGVjdG9yLkRyYXdlci5wcm90b3R5cGUuX2VuZFN0YXR1c0JhckRyYWdnaW5nKToKKyAgICAgICAg KFdlYkluc3BlY3Rvci5EcmF3ZXIucHJvdG90eXBlLmdldCBzY3JvbGxMZWZ0KToKKyAgICAgICAg KFdlYkluc3BlY3Rvci5EcmF3ZXIucHJvdG90eXBlLnNldCBzY3JvbGxMZWZ0KToKKyAgICAgICAg KFdlYkluc3BlY3Rvci5EcmF3ZXIucHJvdG90eXBlLmdldCBzY3JvbGxUb3ApOgorICAgICAgICAo V2ViSW5zcGVjdG9yLkRyYXdlci5wcm90b3R5cGUuc2V0IHNjcm9sbFRvcCk6CisKIDIwMTEtMDgt MDMgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogcmVtb3ZlIE5vZGUgcGFyYW1ldGVyIGZyb20gdGhlIEluc3BlY3RvckNsaWVu dDo6aGlnaGxpZ2h0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQt ZW5kL0NvbnNvbGVWaWV3LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9D b25zb2xlVmlldy5qcwppbmRleCBlYTVlZjY5N2QzNWUwZmU1MGY3MDAxMzEyMzBiNWY2MDYyZDYw NTk3Li5lY2E0NTY1YWJlYmEzZTAyZDNhMmYxNGE1OTgyOTRmMDYyNmY2Y2EyIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0NvbnNvbGVWaWV3LmpzCisrKyBi L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQ29uc29sZVZpZXcuanMKQEAgLTcz OSw2ICs3MzksMjggQEAgV2ViSW5zcGVjdG9yLkNvbnNvbGVWaWV3LnByb3RvdHlwZSA9IHsKICAg ICB7CiAgICAgICAgIC8vIFByZXZlbnQgaW5maW5pdGUgZXhwYW5zaW9uIG9mIGNyb3NzLXJlZmVy ZW5jaW5nIGFycmF5cy4KICAgICAgICAgcmV0dXJuIHRoaXMuX2Zvcm1hdChvdXRwdXQsIG91dHB1 dC5zdWJ0eXBlICYmIG91dHB1dC5zdWJ0eXBlID09PSAiYXJyYXkiKTsKKyAgICB9LAorICAgIAor ICAgIGdldCBzY3JvbGxMZWZ0KCkKKyAgICB7CisgICAgICAgIHJldHVybiB0aGlzLm1lc3NhZ2Vz RWxlbWVudCA/IHRoaXMubWVzc2FnZXNFbGVtZW50LnNjcm9sbExlZnQgOiAwOworICAgIH0sCisK KyAgICBzZXQgc2Nyb2xsTGVmdChzY3JvbGxMZWZ0KQorICAgIHsKKyAgICAgICAgaWYgKHRoaXMu bWVzc2FnZXNFbGVtZW50KQorICAgICAgICAgICAgdGhpcy5tZXNzYWdlc0VsZW1lbnQuc2Nyb2xs TGVmdCA9IHNjcm9sbExlZnQ7CisgICAgfSwKKworICAgIGdldCBzY3JvbGxUb3AoKQorICAgIHsK KyAgICAgICAgcmV0dXJuIHRoaXMubWVzc2FnZXNFbGVtZW50ID8gdGhpcy5tZXNzYWdlc0VsZW1l bnQuc2Nyb2xsVG9wIDogMDsKKyAgICB9LAorCisgICAgc2V0IHNjcm9sbFRvcChzY3JvbGxUb3Ap CisgICAgeworICAgICAgICBpZiAodGhpcy5tZXNzYWdlc0VsZW1lbnQpCisgICAgICAgICAgICB0 aGlzLm1lc3NhZ2VzRWxlbWVudC5zY3JvbGxUb3AgPSBzY3JvbGxUb3A7CiAgICAgfQogfQogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RyYXdlci5qcyBi L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRHJhd2VyLmpzCmluZGV4IDk4MTMy OTU0ZTBjYzk3OGU4MjVhMjM1YjYzNTMxODBjYzNhM2M4ZjYuLjM4MDQ2ZjA4MGY5MWY0MGM2MmQ2 OGIzMmIyODhlNTA2YzMyYTFjZWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvRHJhd2VyLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvRHJhd2VyLmpzCkBAIC0xMzQsNiArMTM0LDcgQEAgV2ViSW5zcGVjdG9yLkRyYXdlci5w cm90b3R5cGUgPSB7CiAgICAgICAgIH0KIAogICAgICAgICB0aGlzLl9jdXJyZW50QW5pbWF0aW9u ID0gV2ViSW5zcGVjdG9yLmFuaW1hdGVTdHlsZShhbmltYXRpb25zLCB0aGlzLl9hbmltYXRpb25E dXJhdGlvbigpLCBhbmltYXRpb25GaW5pc2hlZC5iaW5kKHRoaXMpKTsKKyAgICAgICAgdGhpcy5y ZXN0b3JlU2Nyb2xsUG9zaXRpb25zKCk7CiAgICAgfSwKIAogICAgIGhpZGU6IGZ1bmN0aW9uKCkK QEAgLTM1OCw2ICszNTksMjggQEAgV2ViSW5zcGVjdG9yLkRyYXdlci5wcm90b3R5cGUgPSB7CiAg ICAgICAgIGRlbGV0ZSB0aGlzLl9zdGF0dXNCYXJEcmFnT2Zmc2V0OwogCiAgICAgICAgIGV2ZW50 LnN0b3BQcm9wYWdhdGlvbigpOworICAgIH0sCisgICAgCisgICAgZ2V0IHNjcm9sbExlZnQoKQor ICAgIHsKKyAgICAgICAgcmV0dXJuIHRoaXMudmlzaWJsZVZpZXcgPyB0aGlzLnZpc2libGVWaWV3 LnNjcm9sbExlZnQgOiAwOworICAgIH0sCisKKyAgICBzZXQgc2Nyb2xsTGVmdChzY3JvbGxMZWZ0 KQorICAgIHsKKyAgICAgICAgaWYgKHRoaXMudmlzaWJsZVZpZXcpCisgICAgICAgICAgICB0aGlz LnZpc2libGVWaWV3LnNjcm9sbExlZnQgPSBzY3JvbGxMZWZ0OworICAgIH0sCisKKyAgICBnZXQg c2Nyb2xsVG9wKCkKKyAgICB7CisgICAgICAgIHJldHVybiB0aGlzLnZpc2libGVWaWV3ID8gdGhp cy52aXNpYmxlVmlldy5zY3JvbGxUb3AgOiAwOworICAgIH0sCisKKyAgICBzZXQgc2Nyb2xsVG9w KHNjcm9sbFRvcCkKKyAgICB7CisgICAgICAgIGlmICh0aGlzLnZpc2libGVWaWV3KQorICAgICAg ICAgICAgdGhpcy52aXNpYmxlVmlldy5zY3JvbGxUb3AgPSBzY3JvbGxUb3A7CiAgICAgfQogfQog Cg==