65606 2011-08-03 04:17:21 -0700 [webkitpy] missing log import in common/net/resultsjsonparser.py 2011-08-30 23:59:14 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned oldest_to_newest 445803 0 pnormand 2011-08-03 04:17:21 -0700 Traceback (most recent call last): File "/home/phil/gst/jhbuild/build/WebKit/Tools/Scripts/webkit-patch", line 66, in <module> main() File "/home/phil/gst/jhbuild/build/WebKit/Tools/Scripts/webkit-patch", line 61, in main WebKitPatch(__file__).main() File "/wk/gst/jhbuild/build/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 308, in main result = command.check_arguments_and_execute(options, args, self) File "/wk/gst/jhbuild/build/WebKit/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 117, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/wk/gst/jhbuild/build/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 186, in execute for test in self._tests_to_update(build): File "/wk/gst/jhbuild/build/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 173, in _tests_to_update failing_tests = build.layout_test_results().tests_matching_failure_types([test_failures.FailureTextMismatch]) File "/wk/gst/jhbuild/build/WebKit/Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py", line 269, in layout_test_results self._layout_test_results = LayoutTestResults.results_from_string(results_file) File "/wk/gst/jhbuild/build/WebKit/Tools/Scripts/webkitpy/common/net/layouttestresults.py", line 137, in results_from_string test_results = ResultsJSONParser.parse_results_json(string) File "/wk/gst/jhbuild/build/WebKit/Tools/Scripts/webkitpy/common/net/resultsjsonparser.py", line 149, in parse_results_json unexpected_failures = [result.test_result() for result in json_results if not result.did_pass_or_run_as_expected()] File "/wk/gst/jhbuild/build/WebKit/Tools/Scripts/webkitpy/common/net/resultsjsonparser.py", line 132, in test_result return test_results.TestResult(self._test_name, self._failures()) File "/wk/gst/jhbuild/build/WebKit/Tools/Scripts/webkitpy/common/net/resultsjsonparser.py", line 128, in _failures return sum(map(self._failure_types_from_actual_result, self._actual_as_tokens()), []) File "/wk/gst/jhbuild/build/WebKit/Tools/Scripts/webkitpy/common/net/resultsjsonparser.py", line 122, in _failure_types_from_actual_result log("Failed to handle: %s" % self._result_dict['actual']) NameError: global name 'log' is not defined 445804 1 102764 pnormand 2011-08-03 04:19:06 -0700 Created attachment 102764 proposed patch 459476 2 pnormand 2011-08-30 23:59:14 -0700 Committed r94154: <http://trac.webkit.org/changeset/94154> 102764 2011-08-03 04:19:06 -0700 2011-08-30 10:52:08 -0700 proposed patch proposed-patch.patch text/plain 1678 pnormand RnJvbSA3NmVhZGFiYzRlNzE2ODczODI1NzY0MDc5MGJlMjEzM2YwN2Q1ZWY5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBXZWQsIDMgQXVnIDIwMTEgMTM6MTg6MzIgKzAyMDAKU3ViamVjdDogW1BBVENIXSBw cm9wb3NlZCBwYXRjaAoKLS0tCiBUb29scy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB8ICAgIDkgKysrKysrKysrCiAuLi4vd2Via2l0cHkvY29tbW9uL25ldC9y ZXN1bHRzanNvbnBhcnNlci5weSAgICAgICB8ICAgIDEgKwogMiBmaWxlcyBjaGFuZ2VkLCAxMCBp bnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxv ZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzNGQ3ZTIyLi5jMGY0ZTFlIDEwMDY0NAotLS0gYS9U b29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIw MTEtMDgtMDMgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAg ICAgIFt3ZWJraXRweV0gbWlzc2luZyBsb2cgaW1wb3J0IGluIGNvbW1vbi9uZXQvcmVzdWx0c2pz b25wYXJzZXIucHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTY1NjA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvcmVzdWx0c2pzb25wYXJzZXIucHk6IElt cG9ydCB0aGUgbG9nZ2luZyBtb2R1bGUuCisKIDIwMTEtMDgtMDIgIEFuZGVycyBDYXJsc3NvbiAg PGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgbWFjLWxpb24gcGxhdGZvcm0gdG8g b2xkLXJ1bi13ZWJraXQtdGVzdHMKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv Y29tbW9uL25ldC9yZXN1bHRzanNvbnBhcnNlci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv Y29tbW9uL25ldC9yZXN1bHRzanNvbnBhcnNlci5weQppbmRleCBlMzExMDg5Li4xMzg4Zjg4IDEw MDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvcmVzdWx0c2pzb25w YXJzZXIucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L3Jlc3VsdHNq c29ucGFyc2VyLnB5CkBAIC0zNCw2ICszNCw3IEBAIGV4Y2VwdCBJbXBvcnRFcnJvcjoKICAgICBp bXBvcnQgd2Via2l0cHkudGhpcmRwYXJ0eS5zaW1wbGVqc29uIGFzIGpzb24KIAogZnJvbSB3ZWJr aXRweS5jb21tb24ubWVtb2l6ZWQgaW1wb3J0IG1lbW9pemVkCitmcm9tIHdlYmtpdHB5LmNvbW1v bi5zeXN0ZW0uZGVwcmVjYXRlZF9sb2dnaW5nIGltcG9ydCBsb2cKICMgRklYTUU6IGNvbW1vbiBz aG91bGQgbmV2ZXIgaW1wb3J0IGZyb20gbmV3LXJ1bi13ZWJraXQtdGVzdHMsIG9uZSBvZiB0aGVz ZSBmaWxlcyBuZWVkcyB0byBtb3ZlLgogZnJvbSB3ZWJraXRweS5sYXlvdXRfdGVzdHMubGF5b3V0 X3BhY2thZ2UgaW1wb3J0IGpzb25fcmVzdWx0c19nZW5lcmF0b3IKIGZyb20gd2Via2l0cHkubGF5 b3V0X3Rlc3RzLm1vZGVscyBpbXBvcnQgdGVzdF9leHBlY3RhdGlvbnMsIHRlc3RfcmVzdWx0cywg dGVzdF9mYWlsdXJlcwotLSAKMS43LjUuNA==