65600 2011-08-03 02:28:05 -0700 [GTK] Install web and plugin processes in libexecdir instead of bindir 2011-08-03 05:20:37 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned oldest_to_newest 445775 0 cgarcia 2011-08-03 02:28:05 -0700 I think processes should be installed in libexecdir since we are a library not a program. 445777 1 102757 cgarcia 2011-08-03 02:37:38 -0700 Created attachment 102757 Patch An env var is used to allow MiniBrowser and unit tests (when we add them) to use web and plugin processes without having to install them. 445796 2 102757 mrobinson 2011-08-03 03:27:50 -0700 Comment on attachment 102757 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102757&action=review > Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:80 > - GOwnPtr<gchar> binaryPath(g_build_filename(applicationDirectoryPath().data(), > + const gchar* execDirectory = g_getenv("WEBKIT_EXEC_PATH"); > + GOwnPtr<gchar> binaryPath(g_build_filename(execDirectory ? execDirectory : LIBEXECDIR, Eventually we're just going to need to break down and write a cross-platform method to get the current binary path. 445799 3 102757 cgarcia 2011-08-03 03:50:46 -0700 Comment on attachment 102757 Patch I've noticed this patch breaks the tests, I'm working on a new patch. 445816 4 cgarcia 2011-08-03 05:20:37 -0700 Committed r92273: <http://trac.webkit.org/changeset/92273> 102757 2011-08-03 02:37:38 -0700 2011-08-03 03:50:46 -0700 Patch wk2-libexecdir.diff text/plain 5451 cgarcia ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBjZjNkOTQwLi5kZGQ3YWJm IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUgQEAK IDIwMTEtMDgtMDMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgog CisgICAgICAgIFtHVEtdIEluc3RhbGwgd2ViIGFuZCBwbHVnaW4gcHJvY2Vzc2VzIGluIGxpYmV4 ZWNkaXIgaW5zdGVhZCBvZiBiaW5kaXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTY1NjAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBHTlVtYWtlZmlsZS5hbTogSW5pdGlhbGl6ZSBsaWJleGVjX1BST0dS QU1TLCBvbmx5IHVzZWQgYnkKKyAgICAgICAgV2ViS2l0MiBpbiB0aGlzIG1vbWVudC4KKworMjAx MS0wOC0wMyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKICAg ICAgICAgW0dUS10gUmVvcmdhbml6ZSBwa2ctY29uZmlnIGZpbGVzCiAgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTU0OAogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZWY0 NDJhYi4uMzA1Nzg5YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDExLTA4LTAzICBD YXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAorICAgICAgICBbR1RL XSBJbnN0YWxsIHdlYiBhbmQgcGx1Z2luIHByb2Nlc3NlcyBpbiBsaWJleGVjZGlyIGluc3RlYWQg b2YgYmluZGlyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD02NTYwMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IExhdW5jaCBwcm9jZXNzZXMgZnJvbSBsaWJleGVjZGlyIG9yIFdFQktJVF9FWEVDX1BBVEgKKyAg ICAgICAgZW52aXJvbm1lbnQgdmFyaWFibGUgd2hlbiBpdCdzIHNldC4gVGhpcyB2YXJpYWJsZSB3 aWxsIGJlIHVzZWQgYnkKKyAgICAgICAgTWluaUJyb3dzZXIgYW5kIHVuaXQgdGVzdHMgdG8gZmlu ZCBwcm9jZXNzZXMgd2l0aG91dCBoYXZpbmcgdG8KKyAgICAgICAgaW5zdGFsbCB0aGVtLgorCisg ICAgICAgICogR05VbWFrZWZpbGUuYW06CisgICAgICAgICogVUlQcm9jZXNzL0xhdW5jaGVyL2d0 ay9Qcm9jZXNzTGF1bmNoZXJHdGsuY3BwOgorICAgICAgICAoV2ViS2l0OjpQcm9jZXNzTGF1bmNo ZXI6OmxhdW5jaFByb2Nlc3MpOgorCisyMDExLTA4LTAzICBDYXJsb3MgR2FyY2lhIENhbXBvcyAg PGNnYXJjaWFAaWdhbGlhLmNvbT4KKwogICAgICAgICBbR1RLXSBSZW9yZ2FuaXplIHBrZy1jb25m aWcgZmlsZXMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTY1NTQ4CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwpp bmRleCAzNGQ3ZTIyLi4zMWYxYzI0IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIv VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDgtMDMgIENhcmxvcyBHYXJj aWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEluc3RhbGwg d2ViIGFuZCBwbHVnaW4gcHJvY2Vzc2VzIGluIGxpYmV4ZWNkaXIgaW5zdGVhZCBvZiBiaW5kaXIK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1NjAwCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2V0IFdFQktJ VF9FWEVDX1BBVEggZW52aXJvbm1lbnQgdmFyaWFibGUgdG8gdXNlIHdlYiBhbmQgcGx1Z2luCisg ICAgICAgIHByb2Nlc3MgZnJvbSBjdXJyZW50IGRpcmVjdG9yeSBpbnN0ZWFkIG9mIHRoZSBpbnRh bGxlZCBvbmVzLgorCisgICAgICAgICogTWluaUJyb3dzZXIvZ3RrL0dOVW1ha2VmaWxlLmFtOgor ICAgICAgICAqIE1pbmlCcm93c2VyL2d0ay9tYWluLmM6CisgICAgICAgIChtYWluKToKKwogMjAx MS0wOC0wMiAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAg IEFkZCBtYWMtbGlvbiBwbGF0Zm9ybSB0byBvbGQtcnVuLXdlYmtpdC10ZXN0cwpkaWZmIC0tZ2l0 IGEvR05VbWFrZWZpbGUuYW0gYi9HTlVtYWtlZmlsZS5hbQppbmRleCA2OTVjZDRjLi5kMjFmN2Vl IDEwMDY0NAotLS0gYS9HTlVtYWtlZmlsZS5hbQorKysgYi9HTlVtYWtlZmlsZS5hbQpAQCAtNDUs NiArNDUsNyBAQCBwa2djb25maWdkaXIgOj0gJChsaWJkaXIpL3BrZ2NvbmZpZwogIyBMaWJyYXJp ZXMgYW5kIHN1cHBvcnQgY29tcG9uZW50cwogYmluX1BST0dSQU1TIDo9CiBub2luc3RfUFJPR1JB TVMgOj0KK2xpYmV4ZWNfUFJPR1JBTVMgOj0KIG5vaW5zdF9IRUFERVJTIDo9CiBub2luc3RfTFRM SUJSQVJJRVMgOj0KIGxpYl9MVExJQlJBUklFUyA6PQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvR05VbWFrZWZpbGUuYW0gYi9Tb3VyY2UvV2ViS2l0Mi9HTlVtYWtlZmlsZS5hbQppbmRleCBm MjUxMjNjLi4zMzgzMTk4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9HTlVtYWtlZmlsZS5h bQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9HTlVtYWtlZmlsZS5hbQpAQCAtODQ0LDYgKzg0NCw3IEBA IGxpYndlYmtpdDJndGtfQFdFQktJVEdUS19BUElfTUFKT1JfVkVSU0lPTkBfQFdFQktJVEdUS19B UElfTUlOT1JfVkVSU0lPTkBfbGFfQ1BQCiAJLUkkKHRvcF9idWlsZGRpcikvRGVyaXZlZFNvdXJj ZXMvV2ViS2l0Mi9pbmNsdWRlL0phdmFTY3JpcHRDb3JlIFwKIAktSSQodG9wX2J1aWxkZGlyKS9E ZXJpdmVkU291cmNlcy9XZWJLaXQyL2luY2x1ZGUvV2ViQ29yZSBcCiAJLUkkKHRvcF9idWlsZGRp cikvRGVyaXZlZFNvdXJjZXMvV2ViS2l0Mi9pbmNsdWRlL1dlYktpdDIgXAorCS1ETElCRVhFQ0RJ Uj1cIiIkKGxpYmV4ZWNkaXIpIlwiIFwKIAkkKHdlYmNvcmVfY3BwZmxhZ3MpIFwKIAkkKHdlYmNv cmVndGtfY3BwZmxhZ3MpIFwKIAkkKGphdmFzY3JpcHRjb3JlX2NwcGZsYWdzKSBcCkBAIC05NjAs NyArOTYxLDcgQEAgRElTVENMRUFORklMRVMgKz0gXAogCSQodG9wX2J1aWxkZGlyKS9XZWJLaXQy L3dlYmtpdDJndGstQFdFQktJVEdUS19BUElfVkVSU0lPTkAucGMKIAogIyBXZWJLaXRXZWJQcm9j ZXNzCi1iaW5fUFJPR1JBTVMgKz0gXAorbGliZXhlY19QUk9HUkFNUyArPSBcCiAJUHJvZ3JhbXMv V2ViS2l0V2ViUHJvY2VzcwogCiBQcm9ncmFtc19XZWJLaXRXZWJQcm9jZXNzX0NQUEZMQUdTID0g XApAQCAtMTAzNyw3ICsxMDM4LDcgQEAgbGliV2ViQ29yZUd0azJfbGFfQ1BQRkxBR1MgPSBcCiAJ JChYVF9DRkxBR1MpIFwKIAkkKFpMSUJfTElCUykKIAotYmluX1BST0dSQU1TICs9IFwKK2xpYmV4 ZWNfUFJPR1JBTVMgKz0gXAogCVByb2dyYW1zL1dlYktpdFBsdWdpblByb2Nlc3MKIAogUHJvZ3Jh bXNfV2ViS2l0UGx1Z2luUHJvY2Vzc19DUFBGTEFHUyA9IFwKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQyL1VJUHJvY2Vzcy9MYXVuY2hlci9ndGsvUHJvY2Vzc0xhdW5jaGVyR3RrLmNwcCBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9MYXVuY2hlci9ndGsvUHJvY2Vzc0xhdW5jaGVyR3RrLmNw cAppbmRleCAyYTM5OGMzLi5mMmQzMjYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvTGF1bmNoZXIvZ3RrL1Byb2Nlc3NMYXVuY2hlckd0ay5jcHAKKysrIGIvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0xhdW5jaGVyL2d0ay9Qcm9jZXNzTGF1bmNoZXJHdGsuY3BwCkBAIC03 Niw3ICs3Niw4IEBAIHZvaWQgUHJvY2Vzc0xhdW5jaGVyOjpsYXVuY2hQcm9jZXNzKCkKICAgICAg ICAgcmV0dXJuOwogICAgIH0KIAotICAgIEdPd25QdHI8Z2NoYXI+IGJpbmFyeVBhdGgoZ19idWls ZF9maWxlbmFtZShhcHBsaWNhdGlvbkRpcmVjdG9yeVBhdGgoKS5kYXRhKCksCisgICAgY29uc3Qg Z2NoYXIqIGV4ZWNEaXJlY3RvcnkgPSBnX2dldGVudigiV0VCS0lUX0VYRUNfUEFUSCIpOworICAg IEdPd25QdHI8Z2NoYXI+IGJpbmFyeVBhdGgoZ19idWlsZF9maWxlbmFtZShleGVjRGlyZWN0b3J5 ID8gZXhlY0RpcmVjdG9yeSA6IExJQkVYRUNESVIsCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIG1fbGF1bmNoT3B0aW9ucy5wcm9jZXNzVHlwZSA9PSBQcm9j ZXNzTGF1bmNoZXI6OldlYlByb2Nlc3MgPyBnV2ViS2l0V2ViUHJvY2Vzc05hbWUgOiBnV2ViS2l0 UGx1Z2luUHJvY2Vzc05hbWUsIE5VTEwpKTsKICAgICBHT3duUHRyPGdjaGFyPiBzb2NrZXQoZ19z dHJkdXBfcHJpbnRmKCIlZCIsIHNvY2tldHNbMF0pKTsKICAgICBjaGFyKiBhcmd2WzNdOwpkaWZm IC0tZ2l0IGEvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0dOVW1ha2VmaWxlLmFtIGIvVG9vbHMvTWlu aUJyb3dzZXIvZ3RrL0dOVW1ha2VmaWxlLmFtCmluZGV4IDYwZWUwZGMuLjhiYWYxNzYgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9HTlVtYWtlZmlsZS5hbQorKysgYi9Ub29scy9N aW5pQnJvd3Nlci9ndGsvR05VbWFrZWZpbGUuYW0KQEAgLTQsNiArNCw3IEBAIGJpbl9QUk9HUkFN UyArPSBcCiBQcm9ncmFtc19NaW5pQnJvd3Nlcl9DUFBGTEFHUyA9IFwKIAktSSQoc3JjZGlyKS9T b3VyY2UgXAogCS1JJCh0b3BfYnVpbGRkaXIpL0Rlcml2ZWRTb3VyY2VzL1dlYktpdDIvaW5jbHVk ZSBcCisJLURXRUJLSVRfRVhFQ19QQVRIPVwiJCh0b3BfYnVpbGRkaXIpL1Byb2dyYW1zL1wiIFwK IAkkKGdsb2JhbF9jcHBmbGFncykgXAogCSQoR0xJQl9DRkxBR1MpIFwKIAkkKEdUS19DRkxBR1Mp CmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9ndGsvbWFpbi5jIGIvVG9vbHMvTWluaUJy b3dzZXIvZ3RrL21haW4uYwppbmRleCBhMGM1MTRmLi4zY2JmMmJjIDEwMDY0NAotLS0gYS9Ub29s cy9NaW5pQnJvd3Nlci9ndGsvbWFpbi5jCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9tYWlu LmMKQEAgLTkzLDYgKzkzLDkgQEAgaW50IG1haW4oaW50IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkKICAg ICB9CiAgICAgZ19vcHRpb25fY29udGV4dF9mcmVlIChjb250ZXh0KTsKIAorICAgIC8vIFByZWZl ciB0aGUgbm90IGluc3RhbGxlZCB3ZWIgYW5kIHBsdWdpbiBwcm9jZXNzZXMuCisgICAgZ19zZXRl bnYoIldFQktJVF9FWEVDX1BBVEgiLCBXRUJLSVRfRVhFQ19QQVRILCBGQUxTRSk7CisKICAgICBX S0NvbnRleHRSZWYgcHJvY2Vzc0NvbnRleHQgPSBjcmVhdGVXS0NvbnRleHRXaXRoSW5qZWN0ZWRC dW5kbGUoKTsKIAogICAgIGlmICh1cmlBcmd1bWVudHMpIHsK