65586 2011-08-02 18:11:16 -0700 Chromium Mac: Make sure scrollbars flash when web page loads 2011-08-03 15:24:30 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sail sail jamesr thakis webkit.review.bot oldest_to_newest 445654 0 sail 2011-08-02 18:11:16 -0700 Chromium Mac: Make sure scrollbars flash when web page loads 445655 1 102726 sail 2011-08-02 18:14:27 -0700 Created attachment 102726 Patch 445656 2 sail 2011-08-02 18:15:16 -0700 This patch fixes the following Chromium bug: http://code.google.com/p/chromium/issues/detail?id=90522 446080 3 102726 jamesr 2011-08-03 14:27:33 -0700 Comment on attachment 102726 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102726&action=review > Source/WebCore/ChangeLog:6 > + https://bugs.webkit.org/show_bug.cgi?id=65586 > + > + On slow web pages scrollbars wouldn't flash when the page was done loading. The problem was that we were flashing the scrollbar 0.1 second after the load operation had started. If the page was slow to load then we might not have scrollbars to flash. To work around this I added an extra check to make sure that we had indeed finished loading the page before flashing the scrollbars. You need a 'Reviewed by' line here or the commit bot will reject you. 446089 4 102828 sail 2011-08-03 14:36:39 -0700 Created attachment 102828 Patch 446090 5 sail 2011-08-03 14:37:10 -0700 > You need a 'Reviewed by' line here or the commit bot will reject you. Fixed. 446132 6 102828 webkit.review.bot 2011-08-03 15:24:26 -0700 Comment on attachment 102828 Patch Clearing flags on attachment: 102828 Committed r92316: <http://trac.webkit.org/changeset/92316> 446134 7 webkit.review.bot 2011-08-03 15:24:30 -0700 All reviewed patches have been landed. Closing bug. 102726 2011-08-02 18:14:27 -0700 2011-08-03 14:36:36 -0700 Patch bug-65586-20110802181426.patch text/plain 1928 sail U3VidmVyc2lvbiBSZXZpc2lvbjogOTIxOTcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0MDBlYzZjMGNhZWVhNzVh OWMwZjM4MTM1ZDYyZjdkOTFmM2UxMjJkLi5kOGJiMDM0ZjkzOTc3M2NlMjgwMTk0ZTEwN2NhOTQ1 ODgyMTY3NzkwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDgtMDIgIFNhaWxl c2ggQWdyYXdhbCAgPHNhaWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIENocm9taXVtIE1hYzog TWFrZSBzdXJlIHNjcm9sbGJhcnMgZmxhc2ggd2hlbiB3ZWIgcGFnZSBsb2FkcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjU1ODYKKworICAgICAgICBP biBzbG93IHdlYiBwYWdlcyBzY3JvbGxiYXJzIHdvdWxkbid0IGZsYXNoIHdoZW4gdGhlIHBhZ2Ug d2FzIGRvbmUgbG9hZGluZy4gVGhlIHByb2JsZW0gd2FzIHRoYXQgd2Ugd2VyZSBmbGFzaGluZyB0 aGUgc2Nyb2xsYmFyIDAuMSBzZWNvbmQgYWZ0ZXIgdGhlIGxvYWQgb3BlcmF0aW9uIGhhZCBzdGFy dGVkLiBJZiB0aGUgcGFnZSB3YXMgc2xvdyB0byBsb2FkIHRoZW4gd2UgbWlnaHQgbm90IGhhdmUg c2Nyb2xsYmFycyB0byBmbGFzaC4gVG8gd29yayBhcm91bmQgdGhpcyBJIGFkZGVkIGFuIGV4dHJh IGNoZWNrIHRvIG1ha2Ugc3VyZSB0aGF0IHdlIGhhZCBpbmRlZWQgZmluaXNoZWQgbG9hZGluZyB0 aGUgcGFnZSBiZWZvcmUgZmxhc2hpbmcgdGhlIHNjcm9sbGJhcnMuCisKKyAgICAgICAgKiBwbGF0 Zm9ybS9jaHJvbWl1bS9TY3JvbGxBbmltYXRvckNocm9taXVtTWFjLm1tOgorICAgICAgICAoV2Vi Q29yZTo6U2Nyb2xsQW5pbWF0b3JDaHJvbWl1bU1hYzo6aW5pdGlhbFNjcm9sbGJhclBhaW50VGlt ZXJGaXJlZCk6CisKIDIwMTEtMDgtMDIgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3Jn PgogCiAgICAgICAgIFtRdF0gU2ltcGxpZnkgUGF0aDo6dHJhbnNsYXRlKCkgaW1wbGVtZW50YXRp b24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9TY3JvbGxB bmltYXRvckNocm9taXVtTWFjLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0v U2Nyb2xsQW5pbWF0b3JDaHJvbWl1bU1hYy5tbQppbmRleCA5MjkwYTdjMWJiYzY2YjdjYzVmMGMx ZmZkNjYyNjRkNjcyMDA0ZjNiLi4zYWIwMGEzZjA0NWJkOWY2ZGY1ODZkZjQ5ZjcyNzhiODYwYzZm NmEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9TY3JvbGxB bmltYXRvckNocm9taXVtTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9t aXVtL1Njcm9sbEFuaW1hdG9yQ2hyb21pdW1NYWMubW0KQEAgLTEyODksNyArMTI4OSwxMCBAQCB2 b2lkIFNjcm9sbEFuaW1hdG9yQ2hyb21pdW1NYWM6OnN0b3BTY3JvbGxiYXJQYWludFRpbWVyKCkK IAogdm9pZCBTY3JvbGxBbmltYXRvckNocm9taXVtTWFjOjppbml0aWFsU2Nyb2xsYmFyUGFpbnRU aW1lckZpcmVkKFRpbWVyPFNjcm9sbEFuaW1hdG9yQ2hyb21pdW1NYWM+KikKIHsKLSAgICB3a1Nj cm9sbGJhclBhaW50ZXJGb3JjZUZsYXNoU2Nyb2xsZXJzKG1fc2Nyb2xsYmFyUGFpbnRlckNvbnRy b2xsZXIuZ2V0KCkpOworICAgIGlmIChzY3JvbGxhYmxlQXJlYSgpLT5zaG91bGRTdXNwZW5kU2Ny b2xsQW5pbWF0aW9ucygpKQorICAgICAgICBzdGFydFNjcm9sbGJhclBhaW50VGltZXIoKTsKKyAg ICBlbHNlCisgICAgICAgIHdrU2Nyb2xsYmFyUGFpbnRlckZvcmNlRmxhc2hTY3JvbGxlcnMobV9z Y3JvbGxiYXJQYWludGVyQ29udHJvbGxlci5nZXQoKSk7CiB9CiAjZW5kaWYKIAo= 102828 2011-08-03 14:36:39 -0700 2011-08-03 15:24:26 -0700 Patch bug-65586-20110803143638.patch text/plain 1967 sail U3VidmVyc2lvbiBSZXZpc2lvbjogOTIxOTcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0MDBlYzZjMGNhZWVhNzVh OWMwZjM4MTM1ZDYyZjdkOTFmM2UxMjJkLi45Mzk0NWZlNDg2MjZmZWZjMDkyNjA3MmFiZDljZTUw YjM2ZTdhMzA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDgtMDIgIFNhaWxl c2ggQWdyYXdhbCAgPHNhaWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIENocm9taXVtIE1hYzog TWFrZSBzdXJlIHNjcm9sbGJhcnMgZmxhc2ggd2hlbiB3ZWIgcGFnZSBsb2FkcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjU1ODYKKworICAgICAgICBP biBzbG93IHdlYiBwYWdlcyBzY3JvbGxiYXJzIHdvdWxkbid0IGZsYXNoIHdoZW4gdGhlIHBhZ2Ug d2FzIGRvbmUgbG9hZGluZy4gVGhlIHByb2JsZW0gd2FzIHRoYXQgd2Ugd2VyZSBmbGFzaGluZyB0 aGUgc2Nyb2xsYmFyIDAuMSBzZWNvbmQgYWZ0ZXIgdGhlIGxvYWQgb3BlcmF0aW9uIGhhZCBzdGFy dGVkLiBJZiB0aGUgcGFnZSB3YXMgc2xvdyB0byBsb2FkIHRoZW4gd2UgbWlnaHQgbm90IGhhdmUg c2Nyb2xsYmFycyB0byBmbGFzaC4gVG8gd29yayBhcm91bmQgdGhpcyBJIGFkZGVkIGFuIGV4dHJh IGNoZWNrIHRvIG1ha2Ugc3VyZSB0aGF0IHdlIGhhZCBpbmRlZWQgZmluaXNoZWQgbG9hZGluZyB0 aGUgcGFnZSBiZWZvcmUgZmxhc2hpbmcgdGhlIHNjcm9sbGJhcnMuCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jaHJvbWl1bS9TY3Jv bGxBbmltYXRvckNocm9taXVtTWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsQW5pbWF0 b3JDaHJvbWl1bU1hYzo6aW5pdGlhbFNjcm9sbGJhclBhaW50VGltZXJGaXJlZCk6CisKIDIwMTEt MDgtMDIgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCiAgICAgICAgIFtRdF0g U2ltcGxpZnkgUGF0aDo6dHJhbnNsYXRlKCkgaW1wbGVtZW50YXRpb24uCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9TY3JvbGxBbmltYXRvckNocm9taXVtTWFj Lm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vU2Nyb2xsQW5pbWF0b3JDaHJv bWl1bU1hYy5tbQppbmRleCA5MjkwYTdjMWJiYzY2YjdjYzVmMGMxZmZkNjYyNjRkNjcyMDA0ZjNi Li4zYWIwMGEzZjA0NWJkOWY2ZGY1ODZkZjQ5ZjcyNzhiODYwYzZmNmEwIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9TY3JvbGxBbmltYXRvckNocm9taXVtTWFj Lm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL1Njcm9sbEFuaW1hdG9y Q2hyb21pdW1NYWMubW0KQEAgLTEyODksNyArMTI4OSwxMCBAQCB2b2lkIFNjcm9sbEFuaW1hdG9y Q2hyb21pdW1NYWM6OnN0b3BTY3JvbGxiYXJQYWludFRpbWVyKCkKIAogdm9pZCBTY3JvbGxBbmlt YXRvckNocm9taXVtTWFjOjppbml0aWFsU2Nyb2xsYmFyUGFpbnRUaW1lckZpcmVkKFRpbWVyPFNj cm9sbEFuaW1hdG9yQ2hyb21pdW1NYWM+KikKIHsKLSAgICB3a1Njcm9sbGJhclBhaW50ZXJGb3Jj ZUZsYXNoU2Nyb2xsZXJzKG1fc2Nyb2xsYmFyUGFpbnRlckNvbnRyb2xsZXIuZ2V0KCkpOworICAg IGlmIChzY3JvbGxhYmxlQXJlYSgpLT5zaG91bGRTdXNwZW5kU2Nyb2xsQW5pbWF0aW9ucygpKQor ICAgICAgICBzdGFydFNjcm9sbGJhclBhaW50VGltZXIoKTsKKyAgICBlbHNlCisgICAgICAgIHdr U2Nyb2xsYmFyUGFpbnRlckZvcmNlRmxhc2hTY3JvbGxlcnMobV9zY3JvbGxiYXJQYWludGVyQ29u dHJvbGxlci5nZXQoKSk7CiB9CiAjZW5kaWYKIAo=