65584 2011-08-02 17:26:04 -0700 Crash in ResourceResponse::platformCompare() with USE(CFNETWORK) 2011-08-02 22:08:28 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 psolanki psolanki ddkilzer jberlin psolanki oldest_to_newest 445630 0 psolanki 2011-08-02 17:26:04 -0700 Code does return CFEqual(a.cfURLResponse(), b.cfURLResponse()); And it crashes the cfURLResponses are 0 and CFEqual doesn't like that. This is fine on the Foundation side since we do return a.nsURLResponse() == b.nsURLResponse(); 445632 1 102718 psolanki 2011-08-02 17:29:10 -0700 Created attachment 102718 Patch 445634 2 psolanki 2011-08-02 17:30:04 -0700 <rdar://problem/9878360> 445645 3 102718 darin 2011-08-02 17:49:05 -0700 Comment on attachment 102718 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102718&action=review > Source/WebCore/platform/network/cf/ResourceResponseCFNet.cpp:144 > +#if PLATFORM(MAC) > + // CFEqual crashes if you pass it 0 and on Mac we can end up with cfURLResponse() being 0. > + if (!a.cfURLResponse() || !b.cfURLResponse()) > + return a.cfURLResponse() == b.cfURLResponse(); > +#endif This should be unconditional, not inside #if PLATFORM(MAC) 445649 4 102724 psolanki 2011-08-02 18:02:05 -0700 Created attachment 102724 Patch 445651 5 psolanki 2011-08-02 18:02:21 -0700 Updated patch to make it unconditional. 445693 6 102724 ddkilzer 2011-08-02 19:31:22 -0700 Comment on attachment 102724 Patch r=me 445718 7 psolanki 2011-08-02 22:08:28 -0700 Committed r92261: <http://trac.webkit.org/changeset/92261> 102718 2011-08-02 17:29:10 -0700 2011-08-02 18:02:02 -0700 Patch bug-65584-20110802172909.patch text/plain 1599 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogOTE1NTQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlODQ5MzBkZGI4N2FiNmQ0 NGZmNjBkZjJiNGVmNGM2NzAzZTlmM2YxLi5hMTRmYWZlMjZmOTc4MjAzYzIxOWVhOWZjYThkNzY5 ODEwMWIzMjE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDgtMDIgIFByYXRp ayBTb2xhbmtpICA8cHNvbGFua2lAYXBwbGUuY29tPgorCisgICAgICAgIENyYXNoIGluIFJlc291 cmNlUmVzcG9uc2U6OnBsYXRmb3JtQ29tcGFyZSgpIHdpdGggVVNFKENGTkVUV09SSykKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1NTg0CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3 b3JrL2NmL1Jlc291cmNlUmVzcG9uc2VDRk5ldC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZXNv dXJjZVJlc3BvbnNlOjpwbGF0Zm9ybUNvbXBhcmUpOiBEb24ndCBjYWxsIENGRXF1YWwgd2l0aCAw IGFzIGFuIGFyZ3VtZW50LgorCiAyMDExLTA3LTIxICBQcmF0aWsgU29sYW5raSAgPHBzb2xhbmtp QGFwcGxlLmNvbT4KIAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NjUwMDIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv Y2YvUmVzb3VyY2VSZXNwb25zZUNGTmV0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25l dHdvcmsvY2YvUmVzb3VyY2VSZXNwb25zZUNGTmV0LmNwcAppbmRleCA4MTNmNjU4MzczYjY5ODU4 MjZlNGZlMjE2Y2FiYWM4MjhkMzBiNzE5Li42Nzc5MTYyYWI0ZjZmYzMxNjM3NjVkZmRiZGE2ODk5 ODllZmY5NDA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2Nm L1Jlc291cmNlUmVzcG9uc2VDRk5ldC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9jZi9SZXNvdXJjZVJlc3BvbnNlQ0ZOZXQuY3BwCkBAIC0xMzcsNiArMTM3LDExIEBA IHZvaWQgUmVzb3VyY2VSZXNwb25zZTo6cGxhdGZvcm1MYXp5SW5pdChJbml0TGV2ZWwgaW5pdExl dmVsKQogICAgIAogYm9vbCBSZXNvdXJjZVJlc3BvbnNlOjpwbGF0Zm9ybUNvbXBhcmUoY29uc3Qg UmVzb3VyY2VSZXNwb25zZSYgYSwgY29uc3QgUmVzb3VyY2VSZXNwb25zZSYgYikKIHsKKyNpZiBQ TEFURk9STShNQUMpCisgICAgLy8gQ0ZFcXVhbCBjcmFzaGVzIGlmIHlvdSBwYXNzIGl0IDAgYW5k IG9uIE1hYyB3ZSBjYW4gZW5kIHVwIHdpdGggY2ZVUkxSZXNwb25zZSgpIGJlaW5nIDAuCisgICAg aWYgKCFhLmNmVVJMUmVzcG9uc2UoKSB8fCAhYi5jZlVSTFJlc3BvbnNlKCkpCisgICAgICAgIHJl dHVybiBhLmNmVVJMUmVzcG9uc2UoKSA9PSBiLmNmVVJMUmVzcG9uc2UoKTsKKyNlbmRpZgogICAg IHJldHVybiBDRkVxdWFsKGEuY2ZVUkxSZXNwb25zZSgpLCBiLmNmVVJMUmVzcG9uc2UoKSk7CiB9 CiAK 102724 2011-08-02 18:02:05 -0700 2011-08-02 19:31:22 -0700 Patch bug-65584-20110802180204.patch text/plain 1551 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogOTIyNDkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiNzk3YjIzOWM3OTdlM2Ux OTM4N2I1NWIwMzJjNmZjNjRjZDBmNTkzLi5lOGM3MGEzYjUyNWQ2NTdlODAwM2Q4MjUyOGQ5MTE2 ZmRkY2JkOWEwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDgtMDIgIFByYXRp ayBTb2xhbmtpICA8cHNvbGFua2lAYXBwbGUuY29tPgorCisgICAgICAgIENyYXNoIGluIFJlc291 cmNlUmVzcG9uc2U6OnBsYXRmb3JtQ29tcGFyZSgpIHdpdGggVVNFKENGTkVUV09SSykKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1NTg0CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3 b3JrL2NmL1Jlc291cmNlUmVzcG9uc2VDRk5ldC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZXNv dXJjZVJlc3BvbnNlOjpwbGF0Zm9ybUNvbXBhcmUpOiBEb24ndCBjYWxsIENGRXF1YWwgd2l0aCAw IGFzIGFuIGFyZ3VtZW50LgorCiAyMDExLTA4LTAyICBKZWZmcmV5IFBmYXUgIDxqcGZhdUBhcHBs ZS5jb20+CiAKICAgICAgICAgQWRkIG5hbWVzcGFjZSBwcmVmaXggc3VwcG9ydCBpbiBYTUwgdG9r ZW5pemVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL1Jl c291cmNlUmVzcG9uc2VDRk5ldC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L2NmL1Jlc291cmNlUmVzcG9uc2VDRk5ldC5jcHAKaW5kZXggODEzZjY1ODM3M2I2OTg1ODI2ZTRm ZTIxNmNhYmFjODI4ZDMwYjcxOS4uYTQ1YmVlZGM0MzMwMDc3MmIzOWNhZWUyYjM5NDZjYWMzZGYw YmYzMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9SZXNv dXJjZVJlc3BvbnNlQ0ZOZXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvY2YvUmVzb3VyY2VSZXNwb25zZUNGTmV0LmNwcApAQCAtMTM3LDYgKzEzNyw5IEBAIHZvaWQg UmVzb3VyY2VSZXNwb25zZTo6cGxhdGZvcm1MYXp5SW5pdChJbml0TGV2ZWwgaW5pdExldmVsKQog ICAgIAogYm9vbCBSZXNvdXJjZVJlc3BvbnNlOjpwbGF0Zm9ybUNvbXBhcmUoY29uc3QgUmVzb3Vy Y2VSZXNwb25zZSYgYSwgY29uc3QgUmVzb3VyY2VSZXNwb25zZSYgYikKIHsKKyAgICAvLyBDRkVx dWFsIGNyYXNoZXMgaWYgeW91IHBhc3MgaXQgMCBzbyBkbyBhbiBlYXJseSBjaGVjayBiZWZvcmUg Y2FsbGluZyBpdC4KKyAgICBpZiAoIWEuY2ZVUkxSZXNwb25zZSgpIHx8ICFiLmNmVVJMUmVzcG9u c2UoKSkKKyAgICAgICAgcmV0dXJuIGEuY2ZVUkxSZXNwb25zZSgpID09IGIuY2ZVUkxSZXNwb25z ZSgpOwogICAgIHJldHVybiBDRkVxdWFsKGEuY2ZVUkxSZXNwb25zZSgpLCBiLmNmVVJMUmVzcG9u c2UoKSk7CiB9CiAK