65581 2011-08-02 16:42:44 -0700 Crash in DocumentWriter::endIfNotLoadingMainResource 2011-09-07 18:14:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth ap japhet ossy rniwa webkit.review.bot wez zmo oldest_to_newest 445610 0 abarth 2011-08-02 16:42:44 -0700 Crash in DocumentWriter::endIfNotLoadingMainResource 445614 1 102714 abarth 2011-08-02 16:48:02 -0700 Created attachment 102714 Patch 445627 2 102714 darin 2011-08-02 17:14:32 -0700 Comment on attachment 102714 Patch Can you run that test case on a computer without Flash installed? 445629 3 abarth 2011-08-02 17:18:44 -0700 > Can you run that test case on a computer without Flash installed? Let me try with the test plugin. 445638 4 102721 abarth 2011-08-02 17:36:27 -0700 Created attachment 102721 Patch 445884 5 102721 japhet 2011-08-03 08:36:19 -0700 Comment on attachment 102721 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102721&action=review > Source/WebCore/ChangeLog:10 > + This function is poorly designed because isLoadingMainResource is a > + poor proxy for determing whether to flush/finish the parser. Really, > + we should how loads complete to match the model in HTML5, but that's Typo: I think you're missing a word, "we should change how loads..."? Also, FIXME in endIfNotLoadingMainResource to this effect? > LayoutTests/fast/loader/reload-zero-byte-plugin.html:16 > + }, 100); > +}, 100); Can we do this without setTimeout, or with shorter timeouts? 200ms isn't too bad, but I feel honor-bound to ask. 445918 6 102721 abarth 2011-08-03 09:59:40 -0700 Comment on attachment 102721 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102721&action=review >> LayoutTests/fast/loader/reload-zero-byte-plugin.html:16 >> +}, 100); > > Can we do this without setTimeout, or with shorter timeouts? 200ms isn't too bad, but I feel honor-bound to ask. The underlying problem is that opening content in a new window doesn't generate any sort of events. Normally we could load some HTML that sent use a postMessage, but in this case we need to load this empty plugin. It's possible we could teach the test plugin to send us a message on load... 445920 7 japhet 2011-08-03 10:04:39 -0700 (In reply to comment #6) > (From update of attachment 102721 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=102721&action=review > > >> LayoutTests/fast/loader/reload-zero-byte-plugin.html:16 > >> +}, 100); > > > > Can we do this without setTimeout, or with shorter timeouts? 200ms isn't too bad, but I feel honor-bound to ask. > > The underlying problem is that opening content in a new window doesn't generate any sort of events. Normally we could load some HTML that sent use a postMessage, but in this case we need to load this empty plugin. It's possible we could teach the test plugin to send us a message on load... Eh, I won't ask you to do that. the test plugin has way too much bolted onto it already imo. 445940 8 ap 2011-08-03 10:42:34 -0700 When I run this test with r92135 on Mac, I don't get any crash, but get empty test results. That's surprising. run-webkit-tests fast/loader/reload-zero-byte-plugin.html --repeat 100 445941 9 ap 2011-08-03 10:46:58 -0700 > but get empty test results Strike that - I applied the patch incorrectly. But still no crash. 445943 10 abarth 2011-08-03 10:56:19 -0700 Perhaps the crash is limited to Chromium? The Gtk folks have also asked for this null-check, but I can't find the bug atm. 445944 11 102793 abarth 2011-08-03 10:58:14 -0700 Created attachment 102793 Patch for landing 445945 12 abarth 2011-08-03 11:00:14 -0700 > Strike that - I applied the patch incorrectly. But still no crash. (I assume you tested in DRT and not just in Safari.) 445983 13 102793 webkit.review.bot 2011-08-03 11:56:52 -0700 Comment on attachment 102793 Patch for landing Clearing flags on attachment: 102793 Committed r92298: <http://trac.webkit.org/changeset/92298> 445984 14 webkit.review.bot 2011-08-03 11:56:57 -0700 All reviewed patches have been landed. Closing bug. 446034 15 zmo 2011-08-03 12:59:13 -0700 Skipped the added fast/loader/reload-zero-byte-plugin.html in r92306 because of fast/loader/repeat-same-document-navigation.html crashing 446254 16 rniwa 2011-08-03 18:11:39 -0700 fast/loader/reload-zero-byte-plugin.html started crashing after this patch was landed: http://build.webkit.org/builders/Qt%20Linux%20Release/builds/36101 446368 17 abarth 2011-08-04 00:33:58 -0700 I added it to the skipped list for Qt. 462753 18 abarth 2011-09-06 12:42:53 -0700 I'm not sure why this bug is open. Is there more to do here? Should we file another issue about the Qt crash? 102714 2011-08-02 16:48:02 -0700 2011-08-02 17:36:23 -0700 Patch bug-65581-20110802164801.patch text/plain 3812 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkyMjQ2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTEtMDgtMDIgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBDcmFzaCBpbiBEb2N1bWVudFdyaXRl cjo6ZW5kSWZOb3RMb2FkaW5nTWFpblJlc291cmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTU4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgZnVuY3Rpb24gaXMgcG9vcmx5IGRlc2lnbmVkIGJl Y2F1c2UgaXNMb2FkaW5nTWFpblJlc291cmNlIGlzIGEKKyAgICAgICAgcG9vciBwcm94eSBmb3Ig ZGV0ZXJtaW5nIHdoZXRoZXIgdG8gZmx1c2gvZmluaXNoIHRoZSBwYXJzZXIuICBSZWFsbHksCisg ICAgICAgIHdlIHNob3VsZCBob3cgbG9hZHMgY29tcGxldGUgdG8gbWF0Y2ggdGhlIG1vZGVsIGlu IEhUTUw1LCBidXQgdGhhdCdzCisgICAgICAgIHByZXR0eSB0cmlja3kuICBJbiB0aGUgbWVhbnRp bWUsIHRoaXMgbnVsbCBjaGVjayBmaXhlcyB0aGUgY3Jhc2guCisKKyAgICAgICAgSSdtIHN1cmUg dGhlcmUncyBhbm90aGVyIGJ1ZyBvbiBmaWxlIGFib3V0IHRoaXMgY3Jhc2gsIGJ1dCB3ZSd2ZSBu ZXZlcgorICAgICAgICBiZWVuIGFibGUgdG8gcmVwcm9kdWNlIGl0LiAgVGhhbmtzIHRvIEJlcmVu ZC1KYW4gV2V2ZXIgZm9yIHRoZSB0ZXN0CisgICAgICAgIGNhc2UhCisKKyAgICAgICAgVGVzdDog ZmFzdC9sb2FkZXIvcmVsb2FkLXplcm8tYnl0ZS1zd2YuaHRtbAorCisgICAgICAgICogbG9hZGVy L0RvY3VtZW50V3JpdGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50V3JpdGVyOjpl bmRJZk5vdExvYWRpbmdNYWluUmVzb3VyY2UpOgorCiAyMDExLTA4LTAyICBNYXJrIFBpbGdyaW0g IDxwaWxncmltQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZW1vdmUgTGVnYWN5RGVmYXVsdE9w dGlvbmFsQXJndW1lbnRzIGZsYWcgZnJvbSBXZWJLaXRBbmltYXRpb25MaXN0LmlkbApJbmRleDog U291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50V3JpdGVyLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRXcml0ZXIuY3BwCShyZXZpc2lvbiA5MjIxNCkK KysrIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudFdyaXRlci5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTIxOSw2ICsyMTksOCBAQCB2b2lkIERvY3VtZW50V3JpdGVyOjplbmRJZk5vdExvYWRp bmdNYWluCiAgICAgLy8gc28gd2UnbGwgYWRkIGEgcHJvdGVjdGl2ZSByZWZjb3VudAogICAgIFJl ZlB0cjxGcmFtZT4gcHJvdGVjdG9yKG1fZnJhbWUpOwogCisgICAgaWYgKCFtX3BhcnNlcikKKyAg ICAgICAgcmV0dXJuOwogICAgIC8vIEZJWE1FOiBtX3BhcnNlci0+ZmluaXNoKCkgc2hvdWxkIGlt cGx5IG1fcGFyc2VyLT5mbHVzaCgpLgogICAgIG1fcGFyc2VyLT5mbHVzaCh0aGlzKTsKICAgICBp ZiAoIW1fcGFyc2VyKQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gOTIyNDYpCisrKyBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxMS0wOC0wMiAgQWRh bSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAgIENyYXNoIGluIERvY3VtZW50 V3JpdGVyOjplbmRJZk5vdExvYWRpbmdNYWluUmVzb3VyY2UKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1NTgxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2xvYWRlci9yZWxvYWQtemVyby1ieXRl LXN3Zi1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvbG9hZGVyL3JlbG9hZC16 ZXJvLWJ5dGUtc3dmLmh0bWw6IEFkZGVkLgorICAgICAgICAqIGZhc3QvbG9hZGVyL3Jlc291cmNl cy9lbXB0eS5zd2Y6IEFkZGVkLgorCiAyMDExLTA4LTAyICBaaGVueWFvIE1vICA8em1vQGdvb2ds ZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgdGVzdCBleHBlY3RhdGlvbnMgdXBkYXRlLCBn YXJkZW5lciBzdHVmZi4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvbG9hZGVyL3JlbG9hZC16ZXJv LWJ5dGUtc3dmLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2xv YWRlci9yZWxvYWQtemVyby1ieXRlLXN3Zi1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBM YXlvdXRUZXN0cy9mYXN0L2xvYWRlci9yZWxvYWQtemVyby1ieXRlLXN3Zi1leHBlY3RlZC50eHQJ KHJldmlzaW9uIDApCkBAIC0wLDAgKzEgQEAKK1RoaXMgdGVzdCBwYXNzZXMgaWYgaXQgZG9lc24n dCBjcmFzaC4gVG8gcnVuIG1hbnVhbGx5LCBwbGVhc2UgZGlzYWJsZSB5b3VyIHBvcHVwIGJsb2Nr ZXIuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2xvYWRlci9yZWxvYWQtemVyby1ieXRlLXN3Zi5o dG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvbG9hZGVyL3JlbG9hZC16ZXJvLWJ5 dGUtc3dmLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2xvYWRlci9yZWxv YWQtemVyby1ieXRlLXN3Zi5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDE5IEBACis8c2Ny aXB0Pg0KK2lmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpIHsNCisgICAgbGF5b3V0VGVz dENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOw0KKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0 VW50aWxEb25lKCk7DQorICAgIGxheW91dFRlc3RDb250cm9sbGVyLnNldENhbk9wZW5XaW5kb3dz KHRydWUpOw0KKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5zZXRDbG9zZVJlbWFpbmluZ1dpbmRv d3NXaGVuQ29tcGxldGUodHJ1ZSk7DQorfQ0KKw0KK3ZhciB3aW4gPSB3aW5kb3cub3BlbigncmVz b3VyY2VzL2VtcHR5LnN3ZicpOw0KK3NldFRpbWVvdXQoZnVuY3Rpb24oKSB7DQorICAgIHdpbi5s b2NhdGlvbi5yZWxvYWQoKTsNCisgICAgc2V0VGltZW91dChmdW5jdGlvbigpIHsNCisgICAgICAg IGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpDQorICAgICAgICAgICAgbGF5b3V0VGVz dENvbnRyb2xsZXIubm90aWZ5RG9uZSgpOw0KKyAgICB9LCAxMDApOw0KK30sIDEwMCk7DQorPC9z Y3JpcHQ+DQorVGhpcyB0ZXN0IHBhc3NlcyBpZiBpdCBkb2Vzbid0IGNyYXNoLiBUbyBydW4gbWFu dWFsbHksIHBsZWFzZSBkaXNhYmxlIHlvdXINCitwb3B1cCBibG9ja2VyLg0KSW5kZXg6IExheW91 dFRlc3RzL2Zhc3QvbG9hZGVyL3Jlc291cmNlcy9lbXB0eS5zd2YKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQo= 102721 2011-08-02 17:36:27 -0700 2011-08-03 10:58:11 -0700 Patch bug-65581-20110802173626.patch text/plain 3671 abarth SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkyMjQ2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjQgQEAKKzIwMTEtMDgtMDIgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBDcmFzaCBpbiBEb2N1bWVudFdyaXRl cjo6ZW5kSWZOb3RMb2FkaW5nTWFpblJlc291cmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTU4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgZnVuY3Rpb24gaXMgcG9vcmx5IGRlc2lnbmVkIGJl Y2F1c2UgaXNMb2FkaW5nTWFpblJlc291cmNlIGlzIGEKKyAgICAgICAgcG9vciBwcm94eSBmb3Ig ZGV0ZXJtaW5nIHdoZXRoZXIgdG8gZmx1c2gvZmluaXNoIHRoZSBwYXJzZXIuICBSZWFsbHksCisg ICAgICAgIHdlIHNob3VsZCBob3cgbG9hZHMgY29tcGxldGUgdG8gbWF0Y2ggdGhlIG1vZGVsIGlu IEhUTUw1LCBidXQgdGhhdCdzCisgICAgICAgIHByZXR0eSB0cmlja3kuICBJbiB0aGUgbWVhbnRp bWUsIHRoaXMgbnVsbCBjaGVjayBmaXhlcyB0aGUgY3Jhc2guCisKKyAgICAgICAgSSdtIHN1cmUg dGhlcmUncyBhbm90aGVyIGJ1ZyBvbiBmaWxlIGFib3V0IHRoaXMgY3Jhc2gsIGJ1dCB3ZSd2ZSBu ZXZlcgorICAgICAgICBiZWVuIGFibGUgdG8gcmVwcm9kdWNlIGl0LiAgVGhhbmtzIHRvIEJlcmVu ZC1KYW4gV2V2ZXIgZm9yIHRoZSB0ZXN0CisgICAgICAgIGNhc2UhCisKKyAgICAgICAgVGVzdDog ZmFzdC9sb2FkZXIvcmVsb2FkLXplcm8tYnl0ZS1wbHVnaW4uaHRtbAorCisgICAgICAgICogbG9h ZGVyL0RvY3VtZW50V3JpdGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50V3JpdGVy OjplbmRJZk5vdExvYWRpbmdNYWluUmVzb3VyY2UpOgorCiAyMDExLTA4LTAyICBNYXJrIFBpbGdy aW0gIDxwaWxncmltQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZW1vdmUgTGVnYWN5RGVmYXVs dE9wdGlvbmFsQXJndW1lbnRzIGZsYWcgZnJvbSBXZWJLaXRBbmltYXRpb25MaXN0LmlkbApJbmRl eDogU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50V3JpdGVyLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRXcml0ZXIuY3BwCShyZXZpc2lvbiA5MjIx NCkKKysrIFNvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudFdyaXRlci5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTIxOSw2ICsyMTksOCBAQCB2b2lkIERvY3VtZW50V3JpdGVyOjplbmRJZk5vdExv YWRpbmdNYWluCiAgICAgLy8gc28gd2UnbGwgYWRkIGEgcHJvdGVjdGl2ZSByZWZjb3VudAogICAg IFJlZlB0cjxGcmFtZT4gcHJvdGVjdG9yKG1fZnJhbWUpOwogCisgICAgaWYgKCFtX3BhcnNlcikK KyAgICAgICAgcmV0dXJuOwogICAgIC8vIEZJWE1FOiBtX3BhcnNlci0+ZmluaXNoKCkgc2hvdWxk IGltcGx5IG1fcGFyc2VyLT5mbHVzaCgpLgogICAgIG1fcGFyc2VyLT5mbHVzaCh0aGlzKTsKICAg ICBpZiAoIW1fcGFyc2VyKQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gOTIyNDYpCisrKyBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMS0wOC0wMiAg QWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAgIENyYXNoIGluIERvY3Vt ZW50V3JpdGVyOjplbmRJZk5vdExvYWRpbmdNYWluUmVzb3VyY2UKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1NTgxCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBmYXN0L2xvYWRlci9yZWxvYWQtemVyby1i eXRlLXBsdWdpbi1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvbG9hZGVyL3Jl bG9hZC16ZXJvLWJ5dGUtcGx1Z2luLmh0bWw6IEFkZGVkLgorCiAyMDExLTA4LTAyICBaaGVueWFv IE1vICA8em1vQGdvb2dsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgdGVzdCBleHBlY3Rh dGlvbnMgdXBkYXRlLCBnYXJkZW5lciBzdHVmZi4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvbG9h ZGVyL3JlbG9hZC16ZXJvLWJ5dGUtcGx1Z2luLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9mYXN0L2xvYWRlci9yZWxvYWQtemVyby1ieXRlLXBsdWdpbi1leHBlY3RlZC50 eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2xvYWRlci9yZWxvYWQtemVyby1i eXRlLXBsdWdpbi1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEgQEAKK1RoaXMg dGVzdCBwYXNzZXMgaWYgaXQgZG9lc24ndCBjcmFzaC4gVG8gcnVuIG1hbnVhbGx5LCBwbGVhc2Ug ZGlzYWJsZSB5b3VyIHBvcHVwIGJsb2NrZXIuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2xvYWRl ci9yZWxvYWQtemVyby1ieXRlLXBsdWdpbi5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L2Zhc3QvbG9hZGVyL3JlbG9hZC16ZXJvLWJ5dGUtcGx1Z2luLmh0bWwJKHJldmlzaW9uIDApCisr KyBMYXlvdXRUZXN0cy9mYXN0L2xvYWRlci9yZWxvYWQtemVyby1ieXRlLXBsdWdpbi5odG1sCShy ZXZpc2lvbiAwKQpAQCAtMCwwICsxLDE5IEBACis8c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRU ZXN0Q29udHJvbGxlcikgeworICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsK KyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53YWl0VW50aWxEb25lKCk7CisgICAgbGF5b3V0VGVz dENvbnRyb2xsZXIuc2V0Q2FuT3BlbldpbmRvd3ModHJ1ZSk7CisgICAgbGF5b3V0VGVzdENvbnRy b2xsZXIuc2V0Q2xvc2VSZW1haW5pbmdXaW5kb3dzV2hlbkNvbXBsZXRlKHRydWUpOworfQorCit2 YXIgd2luID0gd2luZG93Lm9wZW4oJ2RhdGE6YXBwbGljYXRpb24veC13ZWJraXQtdGVzdC1uZXRz Y2FwZSwnKTsKK3NldFRpbWVvdXQoZnVuY3Rpb24oKSB7CisgICAgd2luLmxvY2F0aW9uLnJlbG9h ZCgpOworICAgIHNldFRpbWVvdXQoZnVuY3Rpb24oKSB7CisgICAgICAgIGlmICh3aW5kb3cubGF5 b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3Rp ZnlEb25lKCk7CisgICAgfSwgMTAwKTsKK30sIDEwMCk7Cis8L3NjcmlwdD4KK1RoaXMgdGVzdCBw YXNzZXMgaWYgaXQgZG9lc24ndCBjcmFzaC4gVG8gcnVuIG1hbnVhbGx5LCBwbGVhc2UgZGlzYWJs ZSB5b3VyCitwb3B1cCBibG9ja2VyLgo= 102793 2011-08-03 10:58:14 -0700 2011-08-03 11:56:52 -0700 Patch for landing bug-65581-20110803105813.patch text/plain 4231 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogOTIyOTEKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCAxMjhjZGE4MTlhYjhjYWY0ZGMyY2Zi ODQ4OTgxZjc3ZDUzMjEyMGFmLi45Njg0MjEwMjVlZTUyM2Q5MzBiOWYyZThlYzM3ZTRkMzJkZTU1 Yzk5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDgtMDMgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBDcmFzaCBpbiBEb2N1bWVudFdyaXRlcjo6ZW5kSWZO b3RMb2FkaW5nTWFpblJlc291cmNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD02NTU4MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5hdGUgQ2hhcGluLgor CisgICAgICAgICogZmFzdC9sb2FkZXIvcmVsb2FkLXplcm8tYnl0ZS1wbHVnaW4tZXhwZWN0ZWQu dHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2xvYWRlci9yZWxvYWQtemVyby1ieXRlLXBsdWdp bi5odG1sOiBBZGRlZC4KKwogMjAxMS0wOC0wMyAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FA YXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBhIE1hYyBMaW9uIHNraXBwZWQgbGlzdC4KZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvbG9hZGVyL3JlbG9hZC16ZXJvLWJ5dGUtcGx1Z2luLWV4 cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvbG9hZGVyL3JlbG9hZC16ZXJvLWJ5dGUtcGx1 Z2luLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5kYmI5NzNhMzYzOGNiM2U3YjI3NjY0ODM3YWVi MGRlMzNiZGE5OGQ1Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIv cmVsb2FkLXplcm8tYnl0ZS1wbHVnaW4tZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEgQEAKK1RoaXMg dGVzdCBwYXNzZXMgaWYgaXQgZG9lc24ndCBjcmFzaC4gVG8gcnVuIG1hbnVhbGx5LCBwbGVhc2Ug ZGlzYWJsZSB5b3VyIHBvcHVwIGJsb2NrZXIuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0 L2xvYWRlci9yZWxvYWQtemVyby1ieXRlLXBsdWdpbi5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9s b2FkZXIvcmVsb2FkLXplcm8tYnl0ZS1wbHVnaW4uaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi43MTRlMzRlMGMz MWE5NDg5YjRhM2Y3ZTc0OGE1ZjRiOTBiNWMzNDg3Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvZmFzdC9sb2FkZXIvcmVsb2FkLXplcm8tYnl0ZS1wbHVnaW4uaHRtbApAQCAtMCwwICsx LDE5IEBACis8c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgeworICAg IGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKyAgICBsYXlvdXRUZXN0Q29udHJv bGxlci53YWl0VW50aWxEb25lKCk7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuc2V0Q2FuT3Bl bldpbmRvd3ModHJ1ZSk7CisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuc2V0Q2xvc2VSZW1haW5p bmdXaW5kb3dzV2hlbkNvbXBsZXRlKHRydWUpOworfQorCit2YXIgd2luID0gd2luZG93Lm9wZW4o J2RhdGE6YXBwbGljYXRpb24veC13ZWJraXQtdGVzdC1uZXRzY2FwZSwnKTsKK3NldFRpbWVvdXQo ZnVuY3Rpb24oKSB7CisgICAgd2luLmxvY2F0aW9uLnJlbG9hZCgpOworICAgIHNldFRpbWVvdXQo ZnVuY3Rpb24oKSB7CisgICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisg ICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CisgICAgfSwgMTAw KTsKK30sIDEwMCk7Cis8L3NjcmlwdD4KK1RoaXMgdGVzdCBwYXNzZXMgaWYgaXQgZG9lc24ndCBj cmFzaC4gVG8gcnVuIG1hbnVhbGx5LCBwbGVhc2UgZGlzYWJsZSB5b3VyCitwb3B1cCBibG9ja2Vy LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCmluZGV4IDU1NTZmOWJjNGNhZGNhYzdhMjkwMjdiZTgxNDAzOWVjZjM5MDIyNWUu Ljg5MWNjNmQxNmFlNjQzYWI1OWQyMjI5MGIxZTY2YTBkNzM4NGQ2NDMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwyNSBAQAorMjAxMS0wOC0wMyAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3Jn PgorCisgICAgICAgIENyYXNoIGluIERvY3VtZW50V3JpdGVyOjplbmRJZk5vdExvYWRpbmdNYWlu UmVzb3VyY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTY1NTgxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTmF0ZSBDaGFwaW4uCisKKyAgICAgICAgVGhp cyBmdW5jdGlvbiBpcyBwb29ybHkgZGVzaWduZWQgYmVjYXVzZSBpc0xvYWRpbmdNYWluUmVzb3Vy Y2UgaXMgYQorICAgICAgICBwb29yIHByb3h5IGZvciBkZXRlcm1pbmcgd2hldGhlciB0byBmbHVz aC9maW5pc2ggdGhlIHBhcnNlci4gIFJlYWxseSwKKyAgICAgICAgd2Ugc2hvdWxkIGNoYW5nZSBo b3cgbG9hZHMgY29tcGxldGUgdG8gbWF0Y2ggdGhlIG1vZGVsIGluIEhUTUw1LCBidXQKKyAgICAg ICAgdGhhdCdzIHByZXR0eSB0cmlja3kuICBJbiB0aGUgbWVhbnRpbWUsIHRoaXMgbnVsbCBjaGVj ayBmaXhlcyB0aGUKKyAgICAgICAgY3Jhc2guCisKKyAgICAgICAgSSdtIHN1cmUgdGhlcmUncyBh bm90aGVyIGJ1ZyBvbiBmaWxlIGFib3V0IHRoaXMgY3Jhc2gsIGJ1dCB3ZSd2ZSBuZXZlcgorICAg ICAgICBiZWVuIGFibGUgdG8gcmVwcm9kdWNlIGl0LiAgVGhhbmtzIHRvIEJlcmVuZC1KYW4gV2V2 ZXIgZm9yIHRoZSB0ZXN0CisgICAgICAgIGNhc2UhCisKKyAgICAgICAgVGVzdDogZmFzdC9sb2Fk ZXIvcmVsb2FkLXplcm8tYnl0ZS1wbHVnaW4uaHRtbAorCisgICAgICAgICogbG9hZGVyL0RvY3Vt ZW50V3JpdGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50V3JpdGVyOjplbmRJZk5v dExvYWRpbmdNYWluUmVzb3VyY2UpOgorCiAyMDExLTA4LTAzICBMdWtlIE1hY3BoZXJzb24gICA8 bWFjcGhlcnNvbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVXNlIGFwcHJvcHJpYXRlIG1hY3Jv IGZvciBDU1NQcm9wZXJ0eUltYWdlUmVuZGVyaW5nLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvbG9hZGVyL0RvY3VtZW50V3JpdGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1 bWVudFdyaXRlci5jcHAKaW5kZXggMzk4Njk2ODQ2OTE2YmZlNTA4MTM1Njk1OTE1OTQ0NzYyMjdj OGExMC4uNzcxZmUxMzVlOThiNTE3YzNmMDZmMTUzZWJiMDc4NWJkMjQwYWJjNiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50V3JpdGVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRXcml0ZXIuY3BwCkBAIC0yMTEsNiArMjExLDggQEAgdm9p ZCBEb2N1bWVudFdyaXRlcjo6ZW5kKCkKIAogdm9pZCBEb2N1bWVudFdyaXRlcjo6ZW5kSWZOb3RM b2FkaW5nTWFpblJlc291cmNlKCkKIHsKKyAgICAvLyBGSVhNRTogVGhpcyBpc24ndCByZWFsbHkg dGhlIGNoZWNrIHdlIHNob3VsZCBiZSBkb2luZy4gV2Ugc2hvdWxkIHJlLXdvcmsKKyAgICAvLyBo b3cgd2UgZW5kIHBhcnNpbmcgdG8gbWF0Y2ggdGhlIG1vZGVsIGluIEhUTUw1LgogICAgIGlmICht X2ZyYW1lLT5sb2FkZXIoKS0+aXNMb2FkaW5nTWFpblJlc291cmNlKCkgfHwgIW1fZnJhbWUtPnBh Z2UoKSB8fCAhbV9mcmFtZS0+ZG9jdW1lbnQoKSkKICAgICAgICAgcmV0dXJuOwogCkBAIC0yMTks NiArMjIxLDggQEAgdm9pZCBEb2N1bWVudFdyaXRlcjo6ZW5kSWZOb3RMb2FkaW5nTWFpblJlc291 cmNlKCkKICAgICAvLyBzbyB3ZSdsbCBhZGQgYSBwcm90ZWN0aXZlIHJlZmNvdW50CiAgICAgUmVm UHRyPEZyYW1lPiBwcm90ZWN0b3IobV9mcmFtZSk7CiAKKyAgICBpZiAoIW1fcGFyc2VyKQorICAg ICAgICByZXR1cm47CiAgICAgLy8gRklYTUU6IG1fcGFyc2VyLT5maW5pc2goKSBzaG91bGQgaW1w bHkgbV9wYXJzZXItPmZsdXNoKCkuCiAgICAgbV9wYXJzZXItPmZsdXNoKHRoaXMpOwogICAgIGlm ICghbV9wYXJzZXIpCg==