65575 2011-08-02 14:59:15 -0700 Chromium Mac: Fix position of search tickmarks 2011-08-03 15:43:02 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sail sail jamesr thakis webkit.review.bot oldest_to_newest 445556 0 sail 2011-08-02 14:59:15 -0700 Chromium Mac: Fix position of search tickmarks 445558 1 102704 sail 2011-08-02 15:04:25 -0700 Created attachment 102704 Patch 446081 2 102704 jamesr 2011-08-03 14:28:19 -0700 Comment on attachment 102704 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102704&action=review > Source/WebCore/ChangeLog:8 > + https://bugs.webkit.org/show_bug.cgi?id=65575 > + > + This change adjusts the position of search tickmarks so that they are correctly centered. > + > + Also, insetting the tickmark rect by 5 pixels caused tickmarks on the overlay scrollbar to look very small. I changed this to inset by 4 pixels instead. The tickmark is the same width as the overlay scrollbar which looks much better. You need a 'Reviewed by' line. Is this behavior different from the mac scrollbar theme? 446082 3 sail 2011-08-03 14:30:08 -0700 > Is this behavior different from the mac scrollbar theme? Tickmarks are specific to chromium, the mac theme doesn't have them. 446087 4 102827 sail 2011-08-03 14:34:18 -0700 Created attachment 102827 Patch 446088 5 102704 sail 2011-08-03 14:35:00 -0700 Comment on attachment 102704 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102704&action=review >> Source/WebCore/ChangeLog:8 >> + Also, insetting the tickmark rect by 5 pixels caused tickmarks on the overlay scrollbar to look very small. I changed this to inset by 4 pixels instead. The tickmark is the same width as the overlay scrollbar which looks much better. > > You need a 'Reviewed by' line. Is this behavior different from the mac scrollbar theme? Fixed. 446095 6 102827 jamesr 2011-08-03 14:43:21 -0700 Comment on attachment 102827 Patch The Reviewed by line really should be just below the bug URL, but whatever 446152 7 102827 webkit.review.bot 2011-08-03 15:42:58 -0700 Comment on attachment 102827 Patch Clearing flags on attachment: 102827 Committed r92319: <http://trac.webkit.org/changeset/92319> 446153 8 webkit.review.bot 2011-08-03 15:43:02 -0700 All reviewed patches have been landed. Closing bug. 102704 2011-08-02 15:04:25 -0700 2011-08-03 14:35:00 -0700 Patch bug-65575-20110802150424.patch text/plain 2933 sail U3VidmVyc2lvbiBSZXZpc2lvbjogOTIxOTcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0MDBlYzZjMGNhZWVhNzVh OWMwZjM4MTM1ZDYyZjdkOTFmM2UxMjJkLi44YWQ4YmI5NzIwMDAwOTRjZGE0NjI4NWY4ZmY1NzAw NjIwNjg4M2E0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDgtMDIgIFNhaWxl c2ggQWdyYXdhbCAgPHNhaWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIENocm9taXVtIE1hYzog Rml4IHBvc2l0aW9uIG9mIHNlYXJjaCB0aWNrbWFya3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1NTc1CisKKyAgICAgICAgVGhpcyBjaGFuZ2UgYWRq dXN0cyB0aGUgcG9zaXRpb24gb2Ygc2VhcmNoIHRpY2ttYXJrcyBzbyB0aGF0IHRoZXkgYXJlIGNv cnJlY3RseSBjZW50ZXJlZC4KKworICAgICAgICBBbHNvLCBpbnNldHRpbmcgdGhlIHRpY2ttYXJr IHJlY3QgYnkgNSBwaXhlbHMgY2F1c2VkIHRpY2ttYXJrcyBvbiB0aGUgb3ZlcmxheSBzY3JvbGxi YXIgdG8gbG9vayB2ZXJ5IHNtYWxsLiBJIGNoYW5nZWQgdGhpcyB0byBpbnNldCBieSA0IHBpeGVs cyBpbnN0ZWFkLiBUaGUgdGlja21hcmsgaXMgdGhlIHNhbWUgd2lkdGggYXMgdGhlIG92ZXJsYXkg c2Nyb2xsYmFyIHdoaWNoIGxvb2tzIG11Y2ggYmV0dGVyLgorCisgICAgICAgICogcGxhdGZvcm0v Y2hyb21pdW0vU2Nyb2xsYmFyVGhlbWVDaHJvbWl1bU1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6 OlNjcm9sbGJhclRoZW1lQ2hyb21pdW1NYWM6OnBhaW50KToKKwogMjAxMS0wOC0wMiAgQW5kcmVh cyBLbGluZyAgPGtsaW5nQHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1F0XSBTaW1wbGlmeSBQYXRo Ojp0cmFuc2xhdGUoKSBpbXBsZW1lbnRhdGlvbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2Nocm9taXVtL1Njcm9sbGJhclRoZW1lQ2hyb21pdW1NYWMubW0gYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9TY3JvbGxiYXJUaGVtZUNocm9taXVtTWFjLm1tCmlu ZGV4IDZmYjg4N2M3MTE1ZTY1Njk0NjJmMzZkOThjMTNjNWEzYzcwZTk2ZjYuLjMxYWQwYTg4MTll OWMyMGExMzJiZjA5MmU3MmQyMzk3Mjk2OGUyZTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2Nocm9taXVtL1Njcm9sbGJhclRoZW1lQ2hyb21pdW1NYWMubW0KKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vU2Nyb2xsYmFyVGhlbWVDaHJvbWl1bU1hYy5t bQpAQCAtNDkxLDkgKzQ5MSwxNSBAQCBib29sIFNjcm9sbGJhclRoZW1lQ2hyb21pdW1NYWM6OnBh aW50KFNjcm9sbGJhciogc2Nyb2xsYmFyLCBHcmFwaGljc0NvbnRleHQqIGNvbgogICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNjcm9sbGJhci0+ZnJhbWVSZWN0KCkpOwogCiAg ICAgICAgIEludFJlY3QgdGlja21hcmtUcmFja1JlY3QoSW50UG9pbnQoKSwgdHJhY2tSZWN0KHNj cm9sbGJhciwgZmFsc2UpLnNpemUoKSk7Ci0gICAgICAgIC8vIEluc2V0IGJ5IDIgb24gdGhlIGxl ZnQgYW5kIDMgb24gdGhlIHJpZ2h0LgotICAgICAgICB0aWNrbWFya1RyYWNrUmVjdC5zZXRYKHRp Y2ttYXJrVHJhY2tSZWN0LngoKSArIDIpOwotICAgICAgICB0aWNrbWFya1RyYWNrUmVjdC5zZXRX aWR0aCh0aWNrbWFya1RyYWNrUmVjdC53aWR0aCgpIC0gMyk7CisgICAgICAgIGlmICh0aWNrbWFy a1RyYWNrUmVjdC53aWR0aCgpIDw9IDEwKSB7CisgICAgICAgICAgICAvLyBGb3IgbmFycm93IHNj cm9sbGJhcnMgaW5zZXQgYnkgMSBvbiB0aGUgbGVmdCBhbmQgMyBvbiB0aGUgcmlnaHQuCisgICAg ICAgICAgICB0aWNrbWFya1RyYWNrUmVjdC5zZXRYKHRpY2ttYXJrVHJhY2tSZWN0LngoKSArIDEp OworICAgICAgICAgICAgdGlja21hcmtUcmFja1JlY3Quc2V0V2lkdGgodGlja21hcmtUcmFja1Jl Y3Qud2lkdGgoKSAtIDQpOworICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAgLy8gRm9yIHdp ZGUgc2Nyb2xsYmFycyBpbnNldCBieSAyIG9uIHRoZSBsZWZ0IGFuZCAzIG9uIHRoZSByaWdodC4K KyAgICAgICAgICAgIHRpY2ttYXJrVHJhY2tSZWN0LnNldFgodGlja21hcmtUcmFja1JlY3QueCgp ICsgMik7CisgICAgICAgICAgICB0aWNrbWFya1RyYWNrUmVjdC5zZXRXaWR0aCh0aWNrbWFya1Ry YWNrUmVjdC53aWR0aCgpIC0gNSk7CisgICAgICAgIH0KICAgICAgICAgcGFpbnRUaWNrbWFya3Mo Y29udGV4dCwgc2Nyb2xsYmFyLCB0aWNrbWFya1RyYWNrUmVjdCk7CiAKICAgICAgICAgd2tTY3Jv bGxiYXJQYWludGVyUGFpbnRLbm9iKHNjcm9sbGJhclBhaW50ZXIpOwpAQCAtNTY2LDcgKzU3Miw3 IEBAIGJvb2wgU2Nyb2xsYmFyVGhlbWVDaHJvbWl1bU1hYzo6cGFpbnQoU2Nyb2xsYmFyKiBzY3Jv bGxiYXIsIEdyYXBoaWNzQ29udGV4dCogY29uCiAgICAgdGlja21hcmtUcmFja1JlY3QuaW5mbGF0 ZVkoLXRpY2ttYXJrVHJhY2tSZWN0LndpZHRoKCkpOwogICAgIC8vIEluc2V0IGJ5IDIgb24gdGhl IGxlZnQgYW5kIDMgb24gdGhlIHJpZ2h0LgogICAgIHRpY2ttYXJrVHJhY2tSZWN0LnNldFgodGlj a21hcmtUcmFja1JlY3QueCgpICsgMik7Ci0gICAgdGlja21hcmtUcmFja1JlY3Quc2V0V2lkdGgo dGlja21hcmtUcmFja1JlY3Qud2lkdGgoKSAtIDMpOworICAgIHRpY2ttYXJrVHJhY2tSZWN0LnNl dFdpZHRoKHRpY2ttYXJrVHJhY2tSZWN0LndpZHRoKCkgLSA1KTsKICAgICBwYWludFRpY2ttYXJr cyhkcmF3aW5nQ29udGV4dCwgc2Nyb2xsYmFyLCB0aWNrbWFya1RyYWNrUmVjdCk7CiAKICAgICBp ZiAoaGFzVGh1bWIoc2Nyb2xsYmFyKSkgewo= 102827 2011-08-03 14:34:18 -0700 2011-08-03 15:42:58 -0700 Patch bug-65575-20110803143417.patch text/plain 2972 sail U3VidmVyc2lvbiBSZXZpc2lvbjogOTIxOTcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0MDBlYzZjMGNhZWVhNzVh OWMwZjM4MTM1ZDYyZjdkOTFmM2UxMjJkLi5mMmY2OTUwM2QyMGY0MmYxYmUxYjgyNGUwNzg2Y2Zm MTI4MGY2MGVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTEtMDgtMDIgIFNhaWxl c2ggQWdyYXdhbCAgPHNhaWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIENocm9taXVtIE1hYzog Rml4IHBvc2l0aW9uIG9mIHNlYXJjaCB0aWNrbWFya3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1NTc1CisKKyAgICAgICAgVGhpcyBjaGFuZ2UgYWRq dXN0cyB0aGUgcG9zaXRpb24gb2Ygc2VhcmNoIHRpY2ttYXJrcyBzbyB0aGF0IHRoZXkgYXJlIGNv cnJlY3RseSBjZW50ZXJlZC4KKworICAgICAgICBBbHNvLCBpbnNldHRpbmcgdGhlIHRpY2ttYXJr IHJlY3QgYnkgNSBwaXhlbHMgY2F1c2VkIHRpY2ttYXJrcyBvbiB0aGUgb3ZlcmxheSBzY3JvbGxi YXIgdG8gbG9vayB2ZXJ5IHNtYWxsLiBJIGNoYW5nZWQgdGhpcyB0byBpbnNldCBieSA0IHBpeGVs cyBpbnN0ZWFkLiBUaGUgdGlja21hcmsgaXMgdGhlIHNhbWUgd2lkdGggYXMgdGhlIG92ZXJsYXkg c2Nyb2xsYmFyIHdoaWNoIGxvb2tzIG11Y2ggYmV0dGVyLgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vU2Nyb2xsYmFy VGhlbWVDaHJvbWl1bU1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGJhclRoZW1lQ2hy b21pdW1NYWM6OnBhaW50KToKKwogMjAxMS0wOC0wMiAgQW5kcmVhcyBLbGluZyAgPGtsaW5nQHdl YmtpdC5vcmc+CiAKICAgICAgICAgW1F0XSBTaW1wbGlmeSBQYXRoOjp0cmFuc2xhdGUoKSBpbXBs ZW1lbnRhdGlvbi4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVt L1Njcm9sbGJhclRoZW1lQ2hyb21pdW1NYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9j aHJvbWl1bS9TY3JvbGxiYXJUaGVtZUNocm9taXVtTWFjLm1tCmluZGV4IDZmYjg4N2M3MTE1ZTY1 Njk0NjJmMzZkOThjMTNjNWEzYzcwZTk2ZjYuLjMxYWQwYTg4MTllOWMyMGExMzJiZjA5MmU3MmQy Mzk3Mjk2OGUyZTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVt L1Njcm9sbGJhclRoZW1lQ2hyb21pdW1NYWMubW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vY2hyb21pdW0vU2Nyb2xsYmFyVGhlbWVDaHJvbWl1bU1hYy5tbQpAQCAtNDkxLDkgKzQ5MSwx NSBAQCBib29sIFNjcm9sbGJhclRoZW1lQ2hyb21pdW1NYWM6OnBhaW50KFNjcm9sbGJhciogc2Ny b2xsYmFyLCBHcmFwaGljc0NvbnRleHQqIGNvbgogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHNjcm9sbGJhci0+ZnJhbWVSZWN0KCkpOwogCiAgICAgICAgIEludFJlY3QgdGlj a21hcmtUcmFja1JlY3QoSW50UG9pbnQoKSwgdHJhY2tSZWN0KHNjcm9sbGJhciwgZmFsc2UpLnNp emUoKSk7Ci0gICAgICAgIC8vIEluc2V0IGJ5IDIgb24gdGhlIGxlZnQgYW5kIDMgb24gdGhlIHJp Z2h0LgotICAgICAgICB0aWNrbWFya1RyYWNrUmVjdC5zZXRYKHRpY2ttYXJrVHJhY2tSZWN0Lngo KSArIDIpOwotICAgICAgICB0aWNrbWFya1RyYWNrUmVjdC5zZXRXaWR0aCh0aWNrbWFya1RyYWNr UmVjdC53aWR0aCgpIC0gMyk7CisgICAgICAgIGlmICh0aWNrbWFya1RyYWNrUmVjdC53aWR0aCgp IDw9IDEwKSB7CisgICAgICAgICAgICAvLyBGb3IgbmFycm93IHNjcm9sbGJhcnMgaW5zZXQgYnkg MSBvbiB0aGUgbGVmdCBhbmQgMyBvbiB0aGUgcmlnaHQuCisgICAgICAgICAgICB0aWNrbWFya1Ry YWNrUmVjdC5zZXRYKHRpY2ttYXJrVHJhY2tSZWN0LngoKSArIDEpOworICAgICAgICAgICAgdGlj a21hcmtUcmFja1JlY3Quc2V0V2lkdGgodGlja21hcmtUcmFja1JlY3Qud2lkdGgoKSAtIDQpOwor ICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAgLy8gRm9yIHdpZGUgc2Nyb2xsYmFycyBpbnNl dCBieSAyIG9uIHRoZSBsZWZ0IGFuZCAzIG9uIHRoZSByaWdodC4KKyAgICAgICAgICAgIHRpY2tt YXJrVHJhY2tSZWN0LnNldFgodGlja21hcmtUcmFja1JlY3QueCgpICsgMik7CisgICAgICAgICAg ICB0aWNrbWFya1RyYWNrUmVjdC5zZXRXaWR0aCh0aWNrbWFya1RyYWNrUmVjdC53aWR0aCgpIC0g NSk7CisgICAgICAgIH0KICAgICAgICAgcGFpbnRUaWNrbWFya3MoY29udGV4dCwgc2Nyb2xsYmFy LCB0aWNrbWFya1RyYWNrUmVjdCk7CiAKICAgICAgICAgd2tTY3JvbGxiYXJQYWludGVyUGFpbnRL bm9iKHNjcm9sbGJhclBhaW50ZXIpOwpAQCAtNTY2LDcgKzU3Miw3IEBAIGJvb2wgU2Nyb2xsYmFy VGhlbWVDaHJvbWl1bU1hYzo6cGFpbnQoU2Nyb2xsYmFyKiBzY3JvbGxiYXIsIEdyYXBoaWNzQ29u dGV4dCogY29uCiAgICAgdGlja21hcmtUcmFja1JlY3QuaW5mbGF0ZVkoLXRpY2ttYXJrVHJhY2tS ZWN0LndpZHRoKCkpOwogICAgIC8vIEluc2V0IGJ5IDIgb24gdGhlIGxlZnQgYW5kIDMgb24gdGhl IHJpZ2h0LgogICAgIHRpY2ttYXJrVHJhY2tSZWN0LnNldFgodGlja21hcmtUcmFja1JlY3QueCgp ICsgMik7Ci0gICAgdGlja21hcmtUcmFja1JlY3Quc2V0V2lkdGgodGlja21hcmtUcmFja1JlY3Qu d2lkdGgoKSAtIDMpOworICAgIHRpY2ttYXJrVHJhY2tSZWN0LnNldFdpZHRoKHRpY2ttYXJrVHJh Y2tSZWN0LndpZHRoKCkgLSA1KTsKICAgICBwYWludFRpY2ttYXJrcyhkcmF3aW5nQ29udGV4dCwg c2Nyb2xsYmFyLCB0aWNrbWFya1RyYWNrUmVjdCk7CiAKICAgICBpZiAoaGFzVGh1bWIoc2Nyb2xs YmFyKSkgewo=