65569 2011-08-02 14:10:00 -0700 Remove LegacyDefaultOptionalArguments flag from Console.idl 2011-08-03 16:32:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 pilgrim webkit-unassigned abarth webkit.review.bot oldest_to_newest 445515 0 pilgrim 2011-08-02 14:10:00 -0700 As discussed in IRC, we are migrating our IDL files away from the interface-level "LegacyDefaultOptionalArguments" flag and onto argument-level [Optional] or [Optional=CallWithDefaultValue] flags. This patch migrates Console.idl. It does not change any behavior, i.e. it does not make any arguments required that were previously optional, nor vice-versa. 445516 1 102697 pilgrim 2011-08-02 14:10:38 -0700 Created attachment 102697 Patch 445568 2 102697 abarth 2011-08-02 15:34:20 -0700 Comment on attachment 102697 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102697&action=review > Source/WebCore/page/Console.idl:44 > - [V8Custom, CustomArgumentHandling, ImplementationFunction=assertCondition] void assert(in boolean condition); > + [V8Custom, CustomArgumentHandling, ImplementationFunction=assertCondition] void assert(in [Optional=CallWithDefaultValue] boolean condition); I suspect this attribute doesn't do anything here either because this function has CustomArgumentHandling. > Source/WebCore/page/Console.idl:51 > + [Custom] void profile(in [Optional=CallWithDefaultValue] DOMString title); > + [Custom] void profileEnd(in [Optional=CallWithDefaultValue] DOMString title); This attribute doesn't do anything for [Custom] bindings. We can omit it. > Source/WebCore/page/Console.idl:55 > + void time(in [ConvertUndefinedOrNullToNullString,Optional=CallWithDefaultValue] DOMString title); > + [CustomArgumentHandling] void timeEnd(in [ConvertUndefinedOrNullToNullString,Optional=CallWithDefaultValue] DOMString title); This one might need to stay though. I'm not sure how CustomArgumentHandling works on V8. 446086 3 102826 pilgrim 2011-08-03 14:32:55 -0700 Created attachment 102826 Patch 446203 4 102826 webkit.review.bot 2011-08-03 16:32:03 -0700 Comment on attachment 102826 Patch Clearing flags on attachment: 102826 Committed r92328: <http://trac.webkit.org/changeset/92328> 446204 5 webkit.review.bot 2011-08-03 16:32:08 -0700 All reviewed patches have been landed. Closing bug. 102697 2011-08-02 14:10:38 -0700 2011-08-03 14:32:49 -0700 Patch bug-65569-20110802171106.patch text/plain 2584 pilgrim SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkyMjI5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDgtMDIgIE1hcmsgUGls Z3JpbSAgPHBpbGdyaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSBMZWdhY3lEZWZh dWx0T3B0aW9uYWxBcmd1bWVudHMgZmxhZyBmcm9tIENvbnNvbGUuaWRsCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTU2OQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYWxsIGV4aXN0 aW5nIHRlc3RzIHBhc3MuCisKKyAgICAgICAgKiBwYWdlL0NvbnNvbGUuaWRsOgorCiAyMDExLTA4 LTAyICBTdGVwaGVuIFdoaXRlICA8c2Vub3JibGFuY29AY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFtDaHJvbWl1bV0gUmVtb3ZlIGFuIHVubmVjZXNzYXJ5IHJlYWRiYWNrIGR1cmluZyBhY2NlbGVy YXRlZCAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3BhZ2UvQ29uc29sZS5pZGwKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYkNvcmUvcGFnZS9Db25zb2xlLmlkbAkocmV2aXNpb24gOTE5NTApCisrKyBT b3VyY2UvV2ViQ29yZS9wYWdlL0NvbnNvbGUuaWRsCSh3b3JraW5nIGNvcHkpCkBAIC0yOSw3ICsy OSw2IEBACiBtb2R1bGUgd2luZG93IHsKIAogICAgIGludGVyZmFjZSBbCi0gICAgICAgIExlZ2Fj eURlZmF1bHRPcHRpb25hbEFyZ3VtZW50cywKICAgICAgICAgR2VuZXJhdGVJc1JlYWNoYWJsZT1J bXBsRnJhbWUsCiAgICAgICAgIE9taXRDb25zdHJ1Y3RvcgogICAgIF0gQ29uc29sZSB7CkBAIC00 MiwxOCArNDEsMTggQEAgbW9kdWxlIHdpbmRvdyB7CiAgICAgICAgIFtDdXN0b21Bcmd1bWVudEhh bmRsaW5nXSB2b2lkIGRpcigpOwogICAgICAgICBbQ3VzdG9tQXJndW1lbnRIYW5kbGluZ10gdm9p ZCBkaXJ4bWwoKTsKICAgICAgICAgW1Y4Q3VzdG9tLCBDdXN0b21Bcmd1bWVudEhhbmRsaW5nXSB2 b2lkIHRyYWNlKCk7Ci0gICAgICAgIFtWOEN1c3RvbSwgQ3VzdG9tQXJndW1lbnRIYW5kbGluZywg SW1wbGVtZW50YXRpb25GdW5jdGlvbj1hc3NlcnRDb25kaXRpb25dIHZvaWQgYXNzZXJ0KGluIGJv b2xlYW4gY29uZGl0aW9uKTsKKyAgICAgICAgW1Y4Q3VzdG9tLCBDdXN0b21Bcmd1bWVudEhhbmRs aW5nLCBJbXBsZW1lbnRhdGlvbkZ1bmN0aW9uPWFzc2VydENvbmRpdGlvbl0gdm9pZCBhc3NlcnQo aW4gW09wdGlvbmFsPUNhbGxXaXRoRGVmYXVsdFZhbHVlXSBib29sZWFuIGNvbmRpdGlvbik7CiAg ICAgICAgIFtDdXN0b21Bcmd1bWVudEhhbmRsaW5nXSB2b2lkIGNvdW50KCk7CiAgICAgICAgIFtD dXN0b21Bcmd1bWVudEhhbmRsaW5nXSB2b2lkIG1hcmtUaW1lbGluZSgpOwogCiAjaWYgZGVmaW5l ZChFTkFCTEVfSkFWQVNDUklQVF9ERUJVR0dFUikgJiYgRU5BQkxFX0pBVkFTQ1JJUFRfREVCVUdH RVIKICAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIFtDdXN0b21HZXR0ZXJdIEFycmF5IHByb2Zp bGVzOwotICAgICAgICBbQ3VzdG9tXSB2b2lkIHByb2ZpbGUoaW4gRE9NU3RyaW5nIHRpdGxlKTsK LSAgICAgICAgW0N1c3RvbV0gdm9pZCBwcm9maWxlRW5kKGluIERPTVN0cmluZyB0aXRsZSk7Cisg ICAgICAgIFtDdXN0b21dIHZvaWQgcHJvZmlsZShpbiBbT3B0aW9uYWw9Q2FsbFdpdGhEZWZhdWx0 VmFsdWVdIERPTVN0cmluZyB0aXRsZSk7CisgICAgICAgIFtDdXN0b21dIHZvaWQgcHJvZmlsZUVu ZChpbiBbT3B0aW9uYWw9Q2FsbFdpdGhEZWZhdWx0VmFsdWVdIERPTVN0cmluZyB0aXRsZSk7CiAj ZW5kaWYKIAotICAgICAgICB2b2lkIHRpbWUoaW4gW0NvbnZlcnRVbmRlZmluZWRPck51bGxUb051 bGxTdHJpbmddIERPTVN0cmluZyB0aXRsZSk7Ci0gICAgICAgIFtDdXN0b21Bcmd1bWVudEhhbmRs aW5nXSB2b2lkIHRpbWVFbmQoaW4gW0NvbnZlcnRVbmRlZmluZWRPck51bGxUb051bGxTdHJpbmdd IERPTVN0cmluZyB0aXRsZSk7CisgICAgICAgIHZvaWQgdGltZShpbiBbQ29udmVydFVuZGVmaW5l ZE9yTnVsbFRvTnVsbFN0cmluZyxPcHRpb25hbD1DYWxsV2l0aERlZmF1bHRWYWx1ZV0gRE9NU3Ry aW5nIHRpdGxlKTsKKyAgICAgICAgW0N1c3RvbUFyZ3VtZW50SGFuZGxpbmddIHZvaWQgdGltZUVu ZChpbiBbQ29udmVydFVuZGVmaW5lZE9yTnVsbFRvTnVsbFN0cmluZyxPcHRpb25hbD1DYWxsV2l0 aERlZmF1bHRWYWx1ZV0gRE9NU3RyaW5nIHRpdGxlKTsKICAgICAgICAgW0N1c3RvbUFyZ3VtZW50 SGFuZGxpbmddIHZvaWQgdGltZVN0YW1wKCk7CiAgICAgICAgIFtDdXN0b21Bcmd1bWVudEhhbmRs aW5nXSB2b2lkIGdyb3VwKCk7CiAgICAgICAgIFtDdXN0b21Bcmd1bWVudEhhbmRsaW5nXSB2b2lk IGdyb3VwQ29sbGFwc2VkKCk7Cg== 102826 2011-08-03 14:32:55 -0700 2011-08-03 16:32:03 -0700 Patch bug-65569-20110803173305.patch text/plain 1501 pilgrim SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkyMzA4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDgtMDMgIE1hcmsgUGls Z3JpbSAgPHBpbGdyaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSBMZWdhY3lEZWZh dWx0T3B0aW9uYWxBcmd1bWVudHMgZmxhZyBmcm9tIENvbnNvbGUuaWRsCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTU2OQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYWxsIGV4aXN0 aW5nIHRlc3RzIHBhc3MuCisKKyAgICAgICAgKiBwYWdlL0NvbnNvbGUuaWRsOgorCiAyMDExLTA4 LTAzICBKZWZmIE1pbGxlciAgPGplZmZtQGFwcGxlLmNvbT4KIAogICAgICAgICBHZW5lcmF0ZSBX ZWJDb3JlSGVhZGVyRGV0ZWN0aW9uLmggb24gV2luZG93cyB0byBkZWZpbmUgSEFWRV9BVkNGCklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9wYWdlL0NvbnNvbGUuaWRsCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL3BhZ2UvQ29uc29sZS5pZGwJKHJldmlzaW9uIDkyMjM3KQorKysgU291cmNlL1dl YkNvcmUvcGFnZS9Db25zb2xlLmlkbAkod29ya2luZyBjb3B5KQpAQCAtMjksNyArMjksNiBAQAog bW9kdWxlIHdpbmRvdyB7CiAKICAgICBpbnRlcmZhY2UgWwotICAgICAgICBMZWdhY3lEZWZhdWx0 T3B0aW9uYWxBcmd1bWVudHMsCiAgICAgICAgIEdlbmVyYXRlSXNSZWFjaGFibGU9SW1wbEZyYW1l LAogICAgICAgICBPbWl0Q29uc3RydWN0b3IKICAgICBdIENvbnNvbGUgewpAQCAtNTIsNyArNTEs NyBAQCBtb2R1bGUgd2luZG93IHsKICAgICAgICAgW0N1c3RvbV0gdm9pZCBwcm9maWxlRW5kKGlu IERPTVN0cmluZyB0aXRsZSk7CiAjZW5kaWYKIAotICAgICAgICB2b2lkIHRpbWUoaW4gW0NvbnZl cnRVbmRlZmluZWRPck51bGxUb051bGxTdHJpbmddIERPTVN0cmluZyB0aXRsZSk7CisgICAgICAg IHZvaWQgdGltZShpbiBbQ29udmVydFVuZGVmaW5lZE9yTnVsbFRvTnVsbFN0cmluZyxPcHRpb25h bD1DYWxsV2l0aERlZmF1bHRWYWx1ZV0gRE9NU3RyaW5nIHRpdGxlKTsKICAgICAgICAgW0N1c3Rv bUFyZ3VtZW50SGFuZGxpbmddIHZvaWQgdGltZUVuZChpbiBbQ29udmVydFVuZGVmaW5lZE9yTnVs bFRvTnVsbFN0cmluZ10gRE9NU3RyaW5nIHRpdGxlKTsKICAgICAgICAgW0N1c3RvbUFyZ3VtZW50 SGFuZGxpbmddIHZvaWQgdGltZVN0YW1wKCk7CiAgICAgICAgIFtDdXN0b21Bcmd1bWVudEhhbmRs aW5nXSB2b2lkIGdyb3VwKCk7Cg==