65566 2011-08-02 13:57:26 -0700 Remove LegacyDefaultOptionalArguments flag from DOMSelection.idl 2011-08-03 15:50:38 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 pilgrim webkit-unassigned abarth webkit.review.bot oldest_to_newest 445504 0 pilgrim 2011-08-02 13:57:26 -0700 As discussed in IRC, we are migrating our IDL files away from the interface-level "LegacyDefaultOptionalArguments" flag and onto argument-level [Optional] or [Optional=CallWithDefaultValue] flags. This patch migrates DOMSelection.idl. It does not change any behavior, i.e. it does not make any arguments required that were previously optional, nor vice-versa. 445505 1 102694 pilgrim 2011-08-02 13:58:14 -0700 Created attachment 102694 Patch 446118 2 102694 abarth 2011-08-03 15:03:32 -0700 Comment on attachment 102694 Patch Aren't you a committer? If so, you should add yourself to committers.py and then you'll be able to set the cq flag yourself. 446138 3 pilgrim 2011-08-03 15:31:01 -0700 The paperwork is still in progress. 446149 4 abarth 2011-08-03 15:38:41 -0700 Slow paperwork is slow. :( 446159 5 102694 webkit.review.bot 2011-08-03 15:50:33 -0700 Comment on attachment 102694 Patch Clearing flags on attachment: 102694 Committed r92321: <http://trac.webkit.org/changeset/92321> 446160 6 webkit.review.bot 2011-08-03 15:50:38 -0700 All reviewed patches have been landed. Closing bug. 102694 2011-08-02 13:58:14 -0700 2011-08-03 15:50:33 -0700 Patch bug-65566-20110802165842.patch text/plain 3931 pilgrim SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkyMjI2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTEtMDgtMDIgIE1hcmsgUGls Z3JpbSAgPHBpbGdyaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSBMZWdhY3lEZWZh dWx0T3B0aW9uYWxBcmd1bWVudHMgZmxhZyBmcm9tIERPTVNlbGVjdGlvbi5pZGwKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1NTY2CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBhbGwg ZXhpc3RpbmcgdGVzdHMgcGFzcy4KKworICAgICAgICAqIHBhZ2UvRE9NU2VsZWN0aW9uLmlkbDoK KwogMjAxMS0wOC0wMiAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAg IEpTQyBHQyBpcyBmYXIgdG9vIGNvbnNlcnZhdGl2ZSBhYm91dCBncm93aW5nIHRoZSBoZWFwIHNp emUsIHBhcnRpY3VsYXJseQpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9ET01TZWxlY3Rpb24u aWRsCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NU2VsZWN0aW9uLmlkbAko cmV2aXNpb24gOTE5NTApCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVNlbGVjdGlvbi5pZGwJ KHdvcmtpbmcgY29weSkKQEAgLTMyLDcgKzMyLDYgQEAgbW9kdWxlIHdpbmRvdyB7CiAgICAgLy8g VGhpcyBpcyBiYXNlZCBvZmYgb2YgTW96aWxsYSdzIFNlbGVjdGlvbiBpbnRlcmZhY2UKICAgICAv LyBodHRwczovL2RldmVsb3Blci5tb3ppbGxhLm9yZy9Fbi9ET00vU2VsZWN0aW9uCiAgICAgaW50 ZXJmYWNlIFsKLSAgICAgICAgTGVnYWN5RGVmYXVsdE9wdGlvbmFsQXJndW1lbnRzLAogICAgICAg ICBHZW5lcmF0ZUlzUmVhY2hhYmxlPUltcGxGcmFtZSwKICAgICAgICAgT21pdENvbnN0cnVjdG9y CiAgICAgXSBET01TZWxlY3Rpb24gewpAQCAtNDQsNyArNDMsOCBAQCBtb2R1bGUgd2luZG93IHsK ICAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIGJvb2xlYW4gaXNDb2xsYXBzZWQ7CiAgICAgICAg IHJlYWRvbmx5IGF0dHJpYnV0ZSBsb25nIHJhbmdlQ291bnQ7CiAKLSAgICAgICAgdm9pZCBjb2xs YXBzZShpbiBOb2RlIG5vZGUsIGluIGxvbmcgaW5kZXgpCisgICAgICAgIHZvaWQgY29sbGFwc2Uo aW4gW09wdGlvbmFsPUNhbGxXaXRoRGVmYXVsdFZhbHVlXSBOb2RlIG5vZGUsIAorICAgICAgICAg ICAgICAgICAgICAgIGluIFtPcHRpb25hbD1DYWxsV2l0aERlZmF1bHRWYWx1ZV0gbG9uZyBpbmRl eCkKICAgICAgICAgICAgIHJhaXNlcyhET01FeGNlcHRpb24pOwogICAgICAgICB2b2lkIGNvbGxh cHNlVG9FbmQoKQogICAgICAgICAgICAgcmFpc2VzKERPTUV4Y2VwdGlvbik7CkBAIC01MiwxNyAr NTIsMTkgQEAgbW9kdWxlIHdpbmRvdyB7CiAgICAgICAgICAgICByYWlzZXMoRE9NRXhjZXB0aW9u KTsKIAogICAgICAgICB2b2lkIGRlbGV0ZUZyb21Eb2N1bWVudCgpOwotICAgICAgICBib29sZWFu IGNvbnRhaW5zTm9kZShpbiBOb2RlIG5vZGUsIGluIGJvb2xlYW4gYWxsb3dQYXJ0aWFsKTsKLSAg ICAgICAgdm9pZCBzZWxlY3RBbGxDaGlsZHJlbihpbiBOb2RlIG5vZGUpCisgICAgICAgIGJvb2xl YW4gY29udGFpbnNOb2RlKGluIFtPcHRpb25hbD1DYWxsV2l0aERlZmF1bHRWYWx1ZV0gTm9kZSBu b2RlLCAKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW4gW09wdGlvbmFsPUNhbGxXaXRo RGVmYXVsdFZhbHVlXSBib29sZWFuIGFsbG93UGFydGlhbCk7CisgICAgICAgIHZvaWQgc2VsZWN0 QWxsQ2hpbGRyZW4oaW4gW09wdGlvbmFsPUNhbGxXaXRoRGVmYXVsdFZhbHVlXSBOb2RlIG5vZGUp CiAgICAgICAgICAgICByYWlzZXMoRE9NRXhjZXB0aW9uKTsKIAotICAgICAgICB2b2lkIGV4dGVu ZChpbiBOb2RlIG5vZGUsIGluIGxvbmcgb2Zmc2V0KQorICAgICAgICB2b2lkIGV4dGVuZChpbiBb T3B0aW9uYWw9Q2FsbFdpdGhEZWZhdWx0VmFsdWVdIE5vZGUgbm9kZSwgCisgICAgICAgICAgICAg ICAgICAgIGluIFtPcHRpb25hbD1DYWxsV2l0aERlZmF1bHRWYWx1ZV0gbG9uZyBvZmZzZXQpCiAg ICAgICAgICAgICByYWlzZXMoRE9NRXhjZXB0aW9uKTsKIAotICAgICAgICBSYW5nZSBnZXRSYW5n ZUF0KGluIGxvbmcgaW5kZXgpCisgICAgICAgIFJhbmdlIGdldFJhbmdlQXQoaW4gW09wdGlvbmFs PUNhbGxXaXRoRGVmYXVsdFZhbHVlXSBsb25nIGluZGV4KQogICAgICAgICAgICAgcmFpc2VzKERP TUV4Y2VwdGlvbik7CiAgICAgICAgIHZvaWQgcmVtb3ZlQWxsUmFuZ2VzKCk7Ci0gICAgICAgIHZv aWQgYWRkUmFuZ2UoaW4gUmFuZ2UgcmFuZ2UpOworICAgICAgICB2b2lkIGFkZFJhbmdlKGluIFtP cHRpb25hbD1DYWxsV2l0aERlZmF1bHRWYWx1ZV0gUmFuZ2UgcmFuZ2UpOwogCiAjaWYgZGVmaW5l ZChMQU5HVUFHRV9KQVZBU0NSSVBUKSAmJiBMQU5HVUFHRV9KQVZBU0NSSVBUCiAgICAgICAgIFtE b250RW51bV0gRE9NU3RyaW5nIHRvU3RyaW5nKCk7CkBAIC03OCwxMCArODAsMTYgQEAgbW9kdWxl IHdpbmRvdyB7CiAgICAgICAgIC8vIElFJ3MgdHlwZSBhY2Nlc3NvciByZXR1cm5zICJub25lIiwg InRleHQiIGFuZCAiY29udHJvbCIKICAgICAgICAgcmVhZG9ubHkgYXR0cmlidXRlIERPTVN0cmlu ZyB0eXBlOwogCi0gICAgICAgIHZvaWQgbW9kaWZ5KGluIERPTVN0cmluZyBhbHRlciwgaW4gRE9N U3RyaW5nIGRpcmVjdGlvbiwgaW4gRE9NU3RyaW5nIGdyYW51bGFyaXR5KTsKLSAgICAgICAgdm9p ZCBzZXRCYXNlQW5kRXh0ZW50KGluIE5vZGUgYmFzZU5vZGUsIGluIGxvbmcgYmFzZU9mZnNldCwg aW4gTm9kZSBleHRlbnROb2RlLCBpbiBsb25nIGV4dGVudE9mZnNldCkKKyAgICAgICAgdm9pZCBt b2RpZnkoaW4gW09wdGlvbmFsPUNhbGxXaXRoRGVmYXVsdFZhbHVlXSBET01TdHJpbmcgYWx0ZXIs IAorICAgICAgICAgICAgICAgICAgICBpbiBbT3B0aW9uYWw9Q2FsbFdpdGhEZWZhdWx0VmFsdWVd IERPTVN0cmluZyBkaXJlY3Rpb24sIAorICAgICAgICAgICAgICAgICAgICBpbiBbT3B0aW9uYWw9 Q2FsbFdpdGhEZWZhdWx0VmFsdWVdIERPTVN0cmluZyBncmFudWxhcml0eSk7CisgICAgICAgIHZv aWQgc2V0QmFzZUFuZEV4dGVudChpbiBbT3B0aW9uYWw9Q2FsbFdpdGhEZWZhdWx0VmFsdWVdIE5v ZGUgYmFzZU5vZGUsIAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW4gW09wdGlvbmFs PUNhbGxXaXRoRGVmYXVsdFZhbHVlXSBsb25nIGJhc2VPZmZzZXQsIAorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgaW4gW09wdGlvbmFsPUNhbGxXaXRoRGVmYXVsdFZhbHVlXSBOb2RlIGV4 dGVudE5vZGUsIAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW4gW09wdGlvbmFsPUNh bGxXaXRoRGVmYXVsdFZhbHVlXSBsb25nIGV4dGVudE9mZnNldCkKICAgICAgICAgICAgIHJhaXNl cyhET01FeGNlcHRpb24pOwotICAgICAgICB2b2lkIHNldFBvc2l0aW9uKGluIE5vZGUgbm9kZSwg aW4gbG9uZyBvZmZzZXQpCisgICAgICAgIHZvaWQgc2V0UG9zaXRpb24oaW4gW09wdGlvbmFsPUNh bGxXaXRoRGVmYXVsdFZhbHVlXSBOb2RlIG5vZGUsIAorICAgICAgICAgICAgICAgICAgICAgICAg IGluIFtPcHRpb25hbD1DYWxsV2l0aERlZmF1bHRWYWx1ZV0gbG9uZyBvZmZzZXQpCiAgICAgICAg ICAgICByYWlzZXMoRE9NRXhjZXB0aW9uKTsKIAogICAgICAgICAvLyBJRSBleHRlbnRpb25zCg==