65561 2011-08-02 12:31:34 -0700 Missing null check in WebViewImpl::selectionRange 2011-08-02 15:19:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 varunjain webkit-unassigned fishd webkit.review.bot oldest_to_newest 445428 0 varunjain 2011-08-02 12:31:34 -0700 Missing null check in WebViewImpl::selectionRange 445430 1 102681 varunjain 2011-08-02 12:32:25 -0700 Created attachment 102681 Patch 445464 2 102681 fishd 2011-08-02 13:02:44 -0700 Comment on attachment 102681 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102681&action=review > Source/WebKit/chromium/src/WebViewImpl.cpp:1534 > + return false; nit: indentation should be 4 spaces 445475 3 102688 varunjain 2011-08-02 13:08:55 -0700 Created attachment 102688 Patch 445476 4 varunjain 2011-08-02 13:09:15 -0700 (In reply to comment #2) > (From update of attachment 102681 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=102681&action=review > > > Source/WebKit/chromium/src/WebViewImpl.cpp:1534 > > + return false; > > nit: indentation should be 4 spaces Done 445564 5 102688 webkit.review.bot 2011-08-02 15:19:37 -0700 Comment on attachment 102688 Patch Clearing flags on attachment: 102688 Committed r92240: <http://trac.webkit.org/changeset/92240> 445565 6 webkit.review.bot 2011-08-02 15:19:41 -0700 All reviewed patches have been landed. Closing bug. 102681 2011-08-02 12:32:25 -0700 2011-08-02 13:08:47 -0700 Patch bug-65561-20110802153239.patch text/plain 1407 varunjain U3VidmVyc2lvbiBSZXZpc2lvbjogOTIyMTMKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5n ZUxvZwppbmRleCBiNDlhNTk2YjdlZjM3Yjc3MWMyYTk0YWMxNzY1NTU3YjJlYWY3YjZiLi4zMTM3 MTcyNzRkZTliMjYxMGMzMGQyNzc2MGEyMWNkZTA0MzUxMjM4IDEwMDY0NAotLS0gYS9DaGFuZ2VM b2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDgtMDIgIFZhcnVuIEph aW4gIDx2YXJ1bmphaW5AZ29vZ2xlLmNvbT4KKworICAgICAgICBNaXNzaW5nIG51bGwgY2hlY2sg aW4gV2ViVmlld0ltcGw6OnNlbGVjdGlvblJhbmdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTU2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZp ZXdJbXBsLmNwcDoKKwogMjAxMS0wOC0wMSAgU2NvdHQgR3JhaGFtICA8c2NvdHRtZ0BjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjM5NzI1Pyk6IFJlc291cmNlcyByZW1vdmVk IGZyb20gZG9jdW1lbnQgY2FuIG5vdCBiZSBmcmVlZCB1bnRpbCB0aGUgZG9jdW1lbnQgaXMgZGVs ZXRlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwu Y3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCmluZGV4IGZi ODcxOWI1YmM5M2FiMWY3M2JmMDVjNGIxNWEyOTNiZTI5MDdkYTMuLjE2NTc2ZTA2ZjExYTdkNzgy ZmQxZjY0MjAyZjZlMGE3NGYzZDMwOWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYlZpZXdJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJWaWV3SW1wbC5jcHAKQEAgLTE1MzAsNiArMTUzMCw4IEBAIGJvb2wgV2ViVmlld0ltcGw6OnNl bGVjdGlvblJhbmdlKFdlYlBvaW50JiBzdGFydCwgV2ViUG9pbnQmIGVuZCkgY29uc3QKICAgICBp ZiAoIWZyYW1lKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgUmVmUHRyPFJhbmdlPiBzZWxl Y3RlZFJhbmdlID0gZnJhbWUtPnNlbGVjdGlvbigpLT50b05vcm1hbGl6ZWRSYW5nZSgpOworICAg IGlmICghc2VsZWN0ZWRSYW5nZSkKKyAgICAgIHJldHVybiBmYWxzZTsKICAgICBSZWZQdHI8UmFu Z2U+IHJhbmdlKFJhbmdlOjpjcmVhdGUoc2VsZWN0ZWRSYW5nZS0+c3RhcnRDb250YWluZXIoKS0+ ZG9jdW1lbnQoKSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc2VsZWN0 ZWRSYW5nZS0+c3RhcnRDb250YWluZXIoKSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgc2VsZWN0ZWRSYW5nZS0+c3RhcnRPZmZzZXQoKSwK 102688 2011-08-02 13:08:55 -0700 2011-08-02 15:19:37 -0700 Patch bug-65561-20110802160909.patch text/plain 1409 varunjain U3VidmVyc2lvbiBSZXZpc2lvbjogOTIyMTMKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5n ZUxvZwppbmRleCBiNDlhNTk2YjdlZjM3Yjc3MWMyYTk0YWMxNzY1NTU3YjJlYWY3YjZiLi4zMTM3 MTcyNzRkZTliMjYxMGMzMGQyNzc2MGEyMWNkZTA0MzUxMjM4IDEwMDY0NAotLS0gYS9DaGFuZ2VM b2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDgtMDIgIFZhcnVuIEph aW4gIDx2YXJ1bmphaW5AZ29vZ2xlLmNvbT4KKworICAgICAgICBNaXNzaW5nIG51bGwgY2hlY2sg aW4gV2ViVmlld0ltcGw6OnNlbGVjdGlvblJhbmdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTU2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlZp ZXdJbXBsLmNwcDoKKwogMjAxMS0wOC0wMSAgU2NvdHQgR3JhaGFtICA8c2NvdHRtZ0BjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjM5NzI1Pyk6IFJlc291cmNlcyByZW1vdmVk IGZyb20gZG9jdW1lbnQgY2FuIG5vdCBiZSBmcmVlZCB1bnRpbCB0aGUgZG9jdW1lbnQgaXMgZGVs ZXRlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwu Y3BwIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmlld0ltcGwuY3BwCmluZGV4IGZi ODcxOWI1YmM5M2FiMWY3M2JmMDVjNGIxNWEyOTNiZTI5MDdkYTMuLjQ0ZTYxMDA2NTc3NjkzOWFh NDk1ZmZkYzhkZGE5NDNmM2U4YjJiMDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYlZpZXdJbXBsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJWaWV3SW1wbC5jcHAKQEAgLTE1MzAsNiArMTUzMCw4IEBAIGJvb2wgV2ViVmlld0ltcGw6OnNl bGVjdGlvblJhbmdlKFdlYlBvaW50JiBzdGFydCwgV2ViUG9pbnQmIGVuZCkgY29uc3QKICAgICBp ZiAoIWZyYW1lKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgUmVmUHRyPFJhbmdlPiBzZWxl Y3RlZFJhbmdlID0gZnJhbWUtPnNlbGVjdGlvbigpLT50b05vcm1hbGl6ZWRSYW5nZSgpOworICAg IGlmICghc2VsZWN0ZWRSYW5nZSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIFJlZlB0cjxS YW5nZT4gcmFuZ2UoUmFuZ2U6OmNyZWF0ZShzZWxlY3RlZFJhbmdlLT5zdGFydENvbnRhaW5lcigp LT5kb2N1bWVudCgpLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBzZWxl Y3RlZFJhbmdlLT5zdGFydENvbnRhaW5lcigpLAogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBzZWxlY3RlZFJhbmdlLT5zdGFydE9mZnNldCgpLAo=