65560 2011-08-02 12:22:40 -0700 [chromium] accelerated canvas-to-canvas draws incur an unnecessary readback 2011-08-02 14:09:53 -0700 1 1 1 Unclassified WebKit Canvas 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 senorblanco senorblanco jamesr kbr mdelaney7 vangelis oldest_to_newest 445419 0 senorblanco 2011-08-02 12:22:40 -0700 In http://trac.webkit.org/changeset/91870, I added a lockPixels() call to ImageBuffer[Skia]::draw() in order to fix printing, which draws from accelerated->non-accelerated contexts. However, this causes a readback even in the accelerated->accelerated case, causing a performance slowdown. 445425 1 102680 senorblanco 2011-08-02 12:26:51 -0700 Created attachment 102680 Patch 445429 2 102680 jamesr 2011-08-02 12:32:05 -0700 Comment on attachment 102680 Patch R=me 445514 3 senorblanco 2011-08-02 14:09:53 -0700 Committed r92227: <http://trac.webkit.org/changeset/92227> 102680 2011-08-02 12:26:51 -0700 2011-08-02 12:32:05 -0700 Patch bug-65560-20110802152650.patch text/plain 2643 senorblanco SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkyMjE1KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDgtMDIgIFN0ZXBoZW4g V2hpdGUgIDxzZW5vcmJsYW5jb0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW0Nocm9taXVtXSBS ZW1vdmUgYW4gdW5uZWNlc3NhcnkgcmVhZGJhY2sgZHVyaW5nIGFjY2VsZXJhdGVkIAorICAgICAg ICBjYW52YXMtdG8tY2FudmFzIGRyYXdzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NjU1NjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuICAoUHJpbnRpbmcgaGFzIGZldyB0ZXN0cywg c2FkbHkuKQorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZUJ1ZmZlclNr aWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VCdWZmZXI6OmRyYXcpOgorICAgICAgICBS ZXZlcnQgbW9zdCBvZiB0aGUgY2hhbmdlcyB0byB0aGlzIGZpbGUgZnJvbQorICAgICAgICBodHRw Oi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC85MTg3MCwgZXhjZXB0IGZvciB0aGUgY2FsbCB3 aGljaCBtYWtlcworICAgICAgICB0aGUgc291cmNlIGNvbnRleHQgY3VycmVudCwgc28gdGhhdCB0 aGUgcmVhZFBpeGVscygpIHN0aWxsIHdvcmtzLgorCisKIDIwMTEtMDgtMDIgIFZzZXZvbG9kIFZs YXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogUmVt b3ZlIGluaXRhdG9yIGNvbHVtbiBmb3IgSlNDLCBmaXggbmV0d29yayByZXNvdXJjZSBpbml0aWF0 b3IgdGVzdHMuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0lt YWdlQnVmZmVyU2tpYS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3Mvc2tpYS9JbWFnZUJ1ZmZlclNraWEuY3BwCShyZXZpc2lvbiA5MjE4OCkKKysrIFNv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VCdWZmZXJTa2lhLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMTEyLDEyICsxMTIsMTUgQEAgdm9pZCBJbWFnZUJ1ZmZlcjo6Y2xp cChHcmFwaGljc0NvbnRleHQqIAogdm9pZCBJbWFnZUJ1ZmZlcjo6ZHJhdyhHcmFwaGljc0NvbnRl eHQqIGNvbnRleHQsIENvbG9yU3BhY2Ugc3R5bGVDb2xvclNwYWNlLCBjb25zdCBGbG9hdFJlY3Qm IGRlc3RSZWN0LCBjb25zdCBGbG9hdFJlY3QmIHNyY1JlY3QsCiAgICAgICAgICAgICAgICAgICAg ICAgIENvbXBvc2l0ZU9wZXJhdG9yIG9wLCBib29sIHVzZUxvd1F1YWxpdHlTY2FsZSkKIHsKLSAg ICBtX2NvbnRleHQtPnBsYXRmb3JtQ29udGV4dCgpLT5tYWtlR3JDb250ZXh0Q3VycmVudCgpOwot ICAgIFNrRGV2aWNlKiBzcmNEZXZpY2UgPSBtX2NvbnRleHQtPnBsYXRmb3JtQ29udGV4dCgpLT5j YW52YXMoKS0+Z2V0RGV2aWNlKCk7Ci0gICAgU2tCaXRtYXAgYml0bWFwID0gc3JjRGV2aWNlLT5h Y2Nlc3NCaXRtYXAoZmFsc2UpOwotICAgIFNrQXV0b0xvY2tQaXhlbHMgYml0bWFwTG9jayhiaXRt YXApOworICAgIC8vIFNldCBib3RoIGdyYXBoaWNzIGNvbnRleHRzIGN1cnJlbnQuIFRoaXMgbG9v a3MgYSBsaXR0bGUgd2VpcmQsIGJ1dCBpcworICAgIC8vIG5lY2Vzc2FyeSBzaW5jZSB3ZSBtYXkg YmUgZHJhd2luZyBmcm9tIGFuIGFjY2VsZXJhdGVkIHRvCisgICAgLy8gbm9uLWFjY2VsZXJhdGVk IGNvbnRleHQgKGUuZy4sIHByaW50aW5nKSwgb3IgdmljZSB2ZXJzYS4gTm90ZSB0aGF0IGl0Cisg ICAgLy8gb25seSB3b3JrcyBiZWNhdXNlIHRoZSBjb250ZXh0IGlzIGFjdHVhbGx5IHRoZSBzYW1l IHVuZGVybHlpbmcgY29udGV4dAorICAgIC8vIChvciBudWxsKSwgc2luY2Ugd2UgdXNlIG9uZSBj b250ZXh0IGZvciBhY2NlbGVyYXRlZCBkcmF3aW5nLiBJZiB0aGF0CisgICAgLy8gYXNzdW1wdGlv biBjaGFuZ2VzLCB3ZSdsbCBoYXZlIHRvIHJldmlzaXQgdGhpcyBjb2RlLgogICAgIGNvbnRleHQt PnBsYXRmb3JtQ29udGV4dCgpLT5tYWtlR3JDb250ZXh0Q3VycmVudCgpOwotICAgIFJlZlB0cjxJ bWFnZT4gaW1hZ2UgPSBCaXRtYXBJbWFnZVNpbmdsZUZyYW1lU2tpYTo6Y3JlYXRlKGJpdG1hcCwg Y29udGV4dCA9PSBtX2NvbnRleHQpOworICAgIG1fY29udGV4dC0+cGxhdGZvcm1Db250ZXh0KCkt Pm1ha2VHckNvbnRleHRDdXJyZW50KCk7CisgICAgUmVmUHRyPEltYWdlPiBpbWFnZSA9IEJpdG1h cEltYWdlU2luZ2xlRnJhbWVTa2lhOjpjcmVhdGUoKm1fZGF0YS5tX3BsYXRmb3JtQ29udGV4dC5i aXRtYXAoKSwgY29udGV4dCA9PSBtX2NvbnRleHQpOwogICAgIGNvbnRleHQtPmRyYXdJbWFnZShp bWFnZS5nZXQoKSwgc3R5bGVDb2xvclNwYWNlLCBkZXN0UmVjdCwgc3JjUmVjdCwgb3AsIHVzZUxv d1F1YWxpdHlTY2FsZSk7CiB9CiAK