65541 2011-08-02 08:08:12 -0700 [Qt][WK2] Prevent fractional positions for unscaled tiles with QTouchWebPage. 2013-03-19 11:35:26 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 83770 Qt P2 Normal --- 65528 1 jturcotte jturcotte benjamin jturcotte ostap73 oldest_to_newest 445268 0 jturcotte 2011-08-02 08:08:12 -0700 [Qt][WK2] Prevent fractional positions for unscaled tiles with QTouchWebPage. 445290 1 102657 jturcotte 2011-08-02 08:43:18 -0700 Created attachment 102657 Patch 445332 2 102657 benjamin 2011-08-02 10:07:06 -0700 Comment on attachment 102657 Patch Why is this only for pinch? I would think TouchViewInterface::pinchGestureRequestUpdate() can be in float coordinate. Then TouchViewInterface::pinchGestureEnded() would reset the coordinate to int. And the scroll() should have the same treatment. I don't really like the idea of doing this but if that is the only way to get something looking nice...no choice :( 445350 3 jturcotte 2011-08-02 10:37:02 -0700 (In reply to comment #2) > Why is this only for pinch? > I would think TouchViewInterface::pinchGestureRequestUpdate() can be in float coordinate. Then TouchViewInterface::pinchGestureEnded() would reset the coordinate to int. > And the scroll() should have the same treatment. panGestureRequestScroll always gets us int-aligned deltas since the touch events come from the viewport's coordinates which is the page's parent. I'll change scroll to take int parameters and do the same conversion to make it clearer. I tried to do the alignment in pinchGestureEnded like you say, but this would not make the pinching feel any smoother and you would get this glitch-looking frame just after releasing the finger and moving the page by 0.345px. > I don't really like the idea of doing this but if that is the only way to get something looking nice...no choice :( Samuel told me that QGraphicsView did the int-alignment itself in similar conditions, tell me if you think of a better way. 445668 4 102657 benjamin 2011-08-02 18:52:54 -0700 Comment on attachment 102657 Patch Clearing the review flag for now. Jocelyn will see if we can simply get the feature in the framework. 858525 5 jturcotte 2013-03-19 11:35:26 -0700 Fixed using QQuickFlickable::setPixelAligned instead. *** This bug has been marked as a duplicate of bug 83770 *** 102657 2011-08-02 08:43:18 -0700 2011-08-02 18:52:54 -0700 Patch bug-65541-20110802174318.patch text/plain 3240 jturcotte U3VidmVyc2lvbiBSZXZpc2lvbjogOTE5OTcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCBhYjc3YzcxYzk5OWQxMTE4 MTA0Nzg0NWVkYjNkNGI3NWI1NGE2YzNhLi5lNmJiY2M4MmIwYWU0NTA5NGJkOTFlMTNhNTk4MzE1 MzU5NmJmMzYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAgQEAKIDIwMTEtMDgtMDIgIEpvY2Vs eW4gVHVyY290dGUgIDxqb2NlbHluLnR1cmNvdHRlQG5va2lhLmNvbT4KIAorICAgICAgICBbUXRd W1dLMl0gUHJldmVudCBmcmFjdGlvbmFsIHBvc2l0aW9ucyBmb3IgdW5zY2FsZWQgdGlsZXMgd2l0 aCBRVG91Y2hXZWJQYWdlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjU1NDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBTZXQgdGhlIHRyYW5zZm9ybSBvcmlnaW4gb2YgdGhlIHBhZ2UgdG8gaXQncyBUb3BM ZWZ0IGFuZCByZS1pbnQtYWxpZ24gaXQncworICAgICAgICBwb3NpdGlvbiBhZnRlciBzY2FsaW5n LgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xdG91Y2h3ZWJwYWdlLmNwcDoKKyAgICAg ICAgKFFUb3VjaFdlYlBhZ2U6OlFUb3VjaFdlYlBhZ2UpOgorICAgICAgICAqIFVJUHJvY2Vzcy9x dC9Ub3VjaFZpZXdJbnRlcmZhY2UuY3BwOgorICAgICAgICAoV2ViS2l0OjpUb3VjaFZpZXdJbnRl cmZhY2U6OnBpbmNoR2VzdHVyZVJlcXVlc3RVcGRhdGUpOgorCisyMDExLTA4LTAyICBKb2NlbHlu IFR1cmNvdHRlICA8am9jZWx5bi50dXJjb3R0ZUBub2tpYS5jb20+CisKICAgICAgICAgW1F0XVtX SzJdIENyZWF0ZSBzY2VuZSBncmFwaCBub2RlcyBmb3IgdGlsZXMgaW4gUVRvdWNoV2ViVmlldyBp bnN0ZWFkIG9mIHVzaW5nIGltcGVyYXRpdmUgcGFpbnRpbmcuCiAgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTUyOAogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F0b3VjaHdlYnBhZ2UuY3BwIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9xdC9xdG91Y2h3ZWJwYWdlLmNwcAppbmRleCAzOTE3ZTkyMGZhYjg2 YjVkZjcxNzU4ZWM2MDM0ODNiYWFiNWI2NjFlLi43ZjYwZDg1Yzk3NWNlN2YxZmI3MzIyMzVhZTdm NzE2NDEzMzEyMmQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0 L3F0b3VjaHdlYnBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQv cXRvdWNod2VicGFnZS5jcHAKQEAgLTM1LDYgKzM1LDE1IEBAIFFUb3VjaFdlYlBhZ2U6OlFUb3Vj aFdlYlBhZ2UoUVNHSXRlbSogcGFyZW50KQogICAgICwgZChuZXcgUVRvdWNoV2ViUGFnZVByaXZh dGUodGhpcykpCiB7CiAgICAgc2V0RmxhZyhJdGVtSGFzQ29udGVudHMpOworICAgIC8vIFdlIHJl dmVydCB0aGUgc2NhbGluZyBvZiB0aGUgcGFnZSB3aGVuIHJlbmRlcmluZyB0aWxlcyBzbyB0aGF0 IHdlIGNhbiBnZXQKKyAgICAvLyBhICgxLDEsMSkgc2NhbGUgdHJhbnNmb3JtIHdoZW4gcGluY2gt em9vbWluZyBpc24ndCBpbiBwcm9ncmVzcy4KKyAgICAvLyBUaGlzIG1heSBjYXVzZSB0aGUgdHJh bnNsYXRpb24gbm90IHRvIGJlIGludC1hbGlnbmVkIGFuZCB0aGUgY29tcG9zaXRvciB3aWxsCisg ICAgLy8gYXBwbHkgZmlsdGVyaW5nIG9uIHRoZSB0ZXh0dXJlIHRvIGNvcnJlY3RseSByZW5kZXIg dGhlIGZyYWN0aW9uYWwgcG9zaXRpb24uCisgICAgLy8gRnJvbSB0aGUgcGFnZSdzIHBvaW50IG9m IHZpZXcgdGhlcmUgYXJlIDMgZmFjdG9ycyBuZWVkZWQgdG8gcHJldmVudCB0aGlzOgorICAgIC8v IC0gT3VyIHBhcmVudCdzIHRyYW5zZm9ybSBtdXN0IGJlIGludC1hbGlnbmVkIChvdXQgb2Ygb3Vy IGNvbnRyb2wpCisgICAgLy8gLSBPdXIgcG9zaXRpb24gbXVzdCBiZSBpbnQtYWxpZ25lZAorICAg IC8vIC0gQW5kIHRvIGdldCB0byB0aGUgcG9pbnQsIG91ciB0cmFuc2Zvcm0gb3JpZ2luIG11c3Qg YmUgaW50LWFsaWduZWQgKG9ubHkgVG9wTGVmdCBndWFyYW50ZWVzIHRoaXMpCisgICAgc2V0VHJh bnNmb3JtT3JpZ2luKFFTR0l0ZW06OlRvcExlZnQpOwogfQogCiBRVG91Y2hXZWJQYWdlOjp+UVRv dWNoV2ViUGFnZSgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvVG91 Y2hWaWV3SW50ZXJmYWNlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9Ub3VjaFZp ZXdJbnRlcmZhY2UuY3BwCmluZGV4IDIyMGNlOWRiN2FmMTYxMzM0NzM0OGQ2NThlY2Y1ZjlmNzkw NTliODQuLjFkYjQxNDI1MmJiZjcwNDQwYzU0MDEzZmVjOGY5NWQ4YThmYmI1ZjkgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9Ub3VjaFZpZXdJbnRlcmZhY2UuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9Ub3VjaFZpZXdJbnRlcmZhY2UuY3BwCkBA IC03OSw3ICs3OSw4IEBAIHZvaWQgVG91Y2hWaWV3SW50ZXJmYWNlOjpwaW5jaEdlc3R1cmVSZXF1 ZXN0VXBkYXRlKGNvbnN0IFFQb2ludEYmIHBpbmNoQ2VudGVySW5QCiAgICAgUVBvaW50RiBvbGRQ aW5jaENlbnRlck9uUGFyZW50ID0gbV9wYWdlVmlldy0+bWFwVG9JdGVtKG1fcGFnZVZpZXctPnBh cmVudEl0ZW0oKSwgcGluY2hDZW50ZXJJblBhZ2VWaWV3Q29vcmRpbmF0ZSk7CiAgICAgbV9wYWdl Vmlldy0+c2V0U2NhbGUoc2NhbGUpOwogICAgIFFQb2ludEYgbmV3UGluY2hDZW50ZXJPblBhcmVu dCA9IG1fcGFnZVZpZXctPm1hcFRvSXRlbShtX3BhZ2VWaWV3LT5wYXJlbnRJdGVtKCksIHBpbmNo Q2VudGVySW5QYWdlVmlld0Nvb3JkaW5hdGUpOwotICAgIG1fcGFnZVZpZXctPnNldFBvcyhtX3Bh Z2VWaWV3LT5wb3MoKSAtIChuZXdQaW5jaENlbnRlck9uUGFyZW50IC0gb2xkUGluY2hDZW50ZXJP blBhcmVudCkpOworICAgIFFQb2ludCBpbnRBbGlnbmVkTmV3UG9zID0gKG1fcGFnZVZpZXctPnBv cygpIC0gKG5ld1BpbmNoQ2VudGVyT25QYXJlbnQgLSBvbGRQaW5jaENlbnRlck9uUGFyZW50KSku dG9Qb2ludCgpOworICAgIG1fcGFnZVZpZXctPnNldFBvcyhpbnRBbGlnbmVkTmV3UG9zKTsKIH0K IAogdm9pZCBUb3VjaFZpZXdJbnRlcmZhY2U6OnBpbmNoR2VzdHVyZUVuZGVkKCkK