65532 2011-08-02 05:58:29 -0700 Web Inspector: [JSC] //@ sourceURL is not respected. 2012-01-12 09:07:29 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman podivilov apavlov bweinstein domenic joepeck keishi kris.kowal loislo pfeldman pmuellr podivilov rik timothy yurys oldest_to_newest 445222 0 pfeldman 2011-08-02 05:58:29 -0700 Type eval("window.ff = (function foo() { debugger; }) //@ sourceURL = foo.js") in console. Expected: new script in the debugger scripts drop down Actual: no scripts. 531468 1 kris.kowal 2012-01-06 15:44:25 -0800 I can confirm that this issues exists with Safari 5.1. This is an apt reduction of the general problem that programs using XHR+eval code loaders are not presently debuggable in Safari, but Chrome is fine. There are related comments here https://bugs.webkit.org/show_bug.cgi?id=57454 534196 2 kris.kowal 2012-01-11 13:16:24 -0800 At https://bugs.webkit.org/show_bug.cgi?id=38662 > [sourceURL handling code] became dead when we stopped pushing script source to frontend to make loading faster. SourceURL values are now extracted on backend side by JS engine. It was implemented in V8 but not in JSC. 534764 3 pmuellr 2012-01-12 05:39:53 -0800 It doesn't appear anyone is working on this. I have an interest, but could use some hints. First thing I'd need to do is to make sure this fixable in WebKit code (which I can fix) and not Safari code (which I can't). Then pointers to how to fix this would be useful, but I can likely figure it out myself if no one else knows. 534835 4 pmuellr 2012-01-12 07:46:17 -0800 Got a Twitter message from tobie to not repeat the mistake found here, when implementing this. Not sure if it's appropriate or not, but figured I'd post it here just in case: http://code.google.com/p/chromium/issues/detail?id=109362 534873 5 122252 podivilov 2012-01-12 08:40:49 -0800 Created attachment 122252 Patch 534879 6 122252 yurys 2012-01-12 08:49:31 -0800 Comment on attachment 122252 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122252&action=review > Source/WebCore/bindings/js/ScriptDebugServer.cpp:240 > + script.url = ContentSearchUtils::findSourceURL(script.source); We may want to use it for both engines for consistency. 534889 7 podivilov 2012-01-12 09:07:29 -0800 Committed r104831: <http://trac.webkit.org/changeset/104831> 122252 2012-01-12 08:40:49 -0800 2012-01-12 08:49:31 -0800 Patch bug-65532-20120112204047.patch text/plain 6846 podivilov U3VidmVyc2lvbiBSZXZpc2lvbjogMTA0ODI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjk3YzUxZTkxNzdlOTFl ZDExNjY5OTY0OWJhNTY0OWI2YjNlNjRjOS4uNTg5YzQ4MTBkMjkwODUyMDI4NGNlYjkzYmE1ODZh NDQ4ZmVjNDAzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTAxLTEyICBQYXZl bCBQb2Rpdmlsb3YgIDxwb2Rpdmlsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFtKU0NdIC8vQCBzb3VyY2VVUkwgaXMgbm90IHJlc3BlY3RlZC4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1NTMyCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogaW5zcGVjdG9yL2RlYnVn Z2VyL3NvdXJjZS11cmwtY29tbWVudC5odG1sCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9TY3Jp cHREZWJ1Z1NlcnZlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JpcHREZWJ1Z1NlcnZlcjo6 ZGlzcGF0Y2hEaWRQYXJzZVNvdXJjZSk6CisgICAgICAgICogaW5zcGVjdG9yL0NvbnRlbnRTZWFy Y2hVdGlscy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb250ZW50U2VhcmNoVXRpbHM6OmZpbmRN YWdpY0NvbW1lbnQpOgorICAgICAgICAoV2ViQ29yZTo6Q29udGVudFNlYXJjaFV0aWxzOjpmaW5k U291cmNlVVJMKToKKyAgICAgICAgKFdlYkNvcmU6OkNvbnRlbnRTZWFyY2hVdGlsczo6ZmluZFNv dXJjZU1hcFVSTCk6CisgICAgICAgICogaW5zcGVjdG9yL0NvbnRlbnRTZWFyY2hVdGlscy5oOgor CiAyMDEyLTAxLTEyICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4K IAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTA0ODA1LgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0RGVidWdTZXJ2ZXIuY3BwIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0RGVidWdTZXJ2ZXIuY3BwCmluZGV4IGY1MzkxN2M0 ODk0ZDNkODkzNTM5NzhmZWNhZTk0NWZkNjdhMWJkN2EuLmU4YWViNDJjNjkyMGI0NjUyNzUzYjcw OTg5NmI0ZmYyMjdiODAwMWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pz L1NjcmlwdERlYnVnU2VydmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9T Y3JpcHREZWJ1Z1NlcnZlci5jcHAKQEAgLTMzLDYgKzMzLDcgQEAKIAogI2luY2x1ZGUgIlNjcmlw dERlYnVnU2VydmVyLmgiCiAKKyNpbmNsdWRlICJDb250ZW50U2VhcmNoVXRpbHMuaCIKICNpbmNs dWRlICJFdmVudExvb3AuaCIKICNpbmNsdWRlICJGcmFtZS5oIgogI2luY2x1ZGUgIkpTSmF2YVNj cmlwdENhbGxGcmFtZS5oIgpAQCAtMjM1LDYgKzIzNiw5IEBAIHZvaWQgU2NyaXB0RGVidWdTZXJ2 ZXI6OmRpc3BhdGNoRGlkUGFyc2VTb3VyY2UoY29uc3QgTGlzdGVuZXJTZXQmIGxpc3RlbmVycywg U291CiAgICAgc2NyaXB0LnN0YXJ0Q29sdW1uID0gc291cmNlUHJvdmlkZXItPnN0YXJ0UG9zaXRp b24oKS5tX2NvbHVtbi56ZXJvQmFzZWRJbnQoKTsKICAgICBzY3JpcHQuaXNDb250ZW50U2NyaXB0 ID0gaXNDb250ZW50U2NyaXB0OwogCisgICAgaWYgKHNjcmlwdC51cmwuaXNFbXB0eSgpKQorICAg ICAgICBzY3JpcHQudXJsID0gQ29udGVudFNlYXJjaFV0aWxzOjpmaW5kU291cmNlVVJMKHNjcmlw dC5zb3VyY2UpOworCiAgICAgaW50IHNvdXJjZUxlbmd0aCA9IHNjcmlwdC5zb3VyY2UubGVuZ3Ro KCk7CiAgICAgaW50IGxpbmVDb3VudCA9IDE7CiAgICAgaW50IGxhc3RMaW5lU3RhcnQgPSAwOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0NvbnRlbnRTZWFyY2hVdGlscy5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvQ29udGVudFNlYXJjaFV0aWxzLmNwcAppbmRl eCA4MTA2ZWNiNzA2M2RlM2FjYmQzOWMzNGFiNTFmMGFmNTA2NzFkN2U0Li41ZDY3OGM1ZmU3ZGNl ZGM5NTg1ODhjODY4MmU1MDkwOGM2OWQ0M2EyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvQ29udGVudFNlYXJjaFV0aWxzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNw ZWN0b3IvQ29udGVudFNlYXJjaFV0aWxzLmNwcApAQCAtMTQwLDExICsxNDAsMTEgQEAgUGFzc1Jl ZlB0cjxJbnNwZWN0b3JBcnJheT4gc2VhcmNoSW5UZXh0QnlMaW5lcyhjb25zdCBTdHJpbmcmIHRl eHQsIGNvbnN0IFN0cmluZyYKICAgICByZXR1cm4gcmVzdWx0OwogfQogCi1TdHJpbmcgZmluZFNv dXJjZU1hcFVSTChjb25zdCBTdHJpbmcmIGNvbnRlbnQpCitzdGF0aWMgU3RyaW5nIGZpbmRNYWdp Y0NvbW1lbnQoY29uc3QgU3RyaW5nJiBjb250ZW50LCBjb25zdCBTdHJpbmcmIG5hbWUpCiB7Ci0g ICAgREVGSU5FX1NUQVRJQ19MT0NBTChTdHJpbmcsIHBhdHRlcm5TdHJpbmcsICgiLy9AW1wwNDBc dF1zb3VyY2VNYXBwaW5nVVJMPVtcMDQwXHRdKihbXlxcc1wnXCJdKikiKSk7Ci0gICAgY29uc3Qg Y2hhciogZXJyb3I7Ci0gICAgSlNDOjpZYXJyOjpZYXJyUGF0dGVybiBwYXR0ZXJuKEpTQzo6VVN0 cmluZyhwYXR0ZXJuU3RyaW5nLmltcGwoKSksIGZhbHNlLCBmYWxzZSwgJmVycm9yKTsKKyAgICBT dHJpbmcgcGF0dGVyblN0cmluZyA9ICIvL0BbXDA0MFx0XSIgKyBuYW1lICsgIj1bXDA0MFx0XSoo W15cXHNcJ1wiXSopW1wwNDBcdF0qJCI7CisgICAgY29uc3QgY2hhciogZXJyb3IgPSAwOworICAg IEpTQzo6WWFycjo6WWFyclBhdHRlcm4gcGF0dGVybihKU0M6OlVTdHJpbmcocGF0dGVyblN0cmlu Zy5pbXBsKCkpLCBmYWxzZSwgdHJ1ZSwgJmVycm9yKTsKICAgICBBU1NFUlQoIWVycm9yKTsKICAg ICBCdW1wUG9pbnRlckFsbG9jYXRvciByZWdleEFsbG9jYXRvcjsKICAgICBPd25QdHI8SlNDOjpZ YXJyOjpCeXRlY29kZVBhdHRlcm4+IGJ5dGVjb2RlUGF0dGVybiA9IEpTQzo6WWFycjo6Ynl0ZUNv bXBpbGUocGF0dGVybiwgJnJlZ2V4QWxsb2NhdG9yKTsKQEAgLTE1Nyw3ICsxNTcsMTcgQEAgU3Ry aW5nIGZpbmRTb3VyY2VNYXBVUkwoY29uc3QgU3RyaW5nJiBjb250ZW50KQogICAgIGlmIChyZXN1 bHQgPCAwKQogICAgICAgICByZXR1cm4gU3RyaW5nKCk7CiAgICAgQVNTRVJUKG1hdGNoZXNbMl0g PiAwICYmIG1hdGNoZXNbM10gPiAwKTsKLSAgICByZXR1cm4gY29udGVudC5zdWJzdHJpbmcobWF0 Y2hlc1syXSwgbWF0Y2hlc1szXSk7CisgICAgcmV0dXJuIGNvbnRlbnQuc3Vic3RyaW5nKG1hdGNo ZXNbMl0sIG1hdGNoZXNbM10gLSBtYXRjaGVzWzJdKTsKK30KKworU3RyaW5nIGZpbmRTb3VyY2VV UkwoY29uc3QgU3RyaW5nJiBjb250ZW50KQoreworICAgIHJldHVybiBmaW5kTWFnaWNDb21tZW50 KGNvbnRlbnQsICJzb3VyY2VVUkwiKTsKK30KKworU3RyaW5nIGZpbmRTb3VyY2VNYXBVUkwoY29u c3QgU3RyaW5nJiBjb250ZW50KQoreworICAgIHJldHVybiBmaW5kTWFnaWNDb21tZW50KGNvbnRl bnQsICJzb3VyY2VNYXBwaW5nVVJMIik7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIENvbnRlbnRTZWFy Y2hVdGlscwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0NvbnRlbnRTZWFy Y2hVdGlscy5oIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0NvbnRlbnRTZWFyY2hVdGlscy5o CmluZGV4IDk2OTg3YWM5ZmEwMzkxNmU3Y2FmNGVlMmFhMjlhYmNhOGUwNTEwYzYuLmY0YjFlZGEy ZDM1ZGFlOGRiMTkxOWVkMmYzY2UwNDkyYjdhNmMwZGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2luc3BlY3Rvci9Db250ZW50U2VhcmNoVXRpbHMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvQ29udGVudFNlYXJjaFV0aWxzLmgKQEAgLTQ0LDYgKzQ0LDcgQEAgUmVndWxhckV4 cHJlc3Npb24gY3JlYXRlU2VhcmNoUmVnZXgoY29uc3QgU3RyaW5nJiBxdWVyeSwgYm9vbCBjYXNl U2Vuc2l0aXZlLCBib28KIGludCBjb3VudFJlZ3VsYXJFeHByZXNzaW9uTWF0Y2hlcyhjb25zdCBS ZWd1bGFyRXhwcmVzc2lvbiYsIGNvbnN0IFN0cmluZyYpOwogUGFzc1JlZlB0cjxJbnNwZWN0b3JB cnJheT4gc2VhcmNoSW5UZXh0QnlMaW5lcyhjb25zdCBTdHJpbmcmIHRleHQsIGNvbnN0IFN0cmlu ZyYgcXVlcnksIGNvbnN0IGJvb2wgY2FzZVNlbnNpdGl2ZSwgY29uc3QgYm9vbCBpc1JlZ2V4KTsK IAorU3RyaW5nIGZpbmRTb3VyY2VVUkwoY29uc3QgU3RyaW5nJiBjb250ZW50KTsKIFN0cmluZyBm aW5kU291cmNlTWFwVVJMKGNvbnN0IFN0cmluZyYgY29udGVudCk7CiAKIH0gLy8gbmFtZXNwYWNl IENvbnRlbnRTZWFyY2hVdGlscwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDZiZGNkOWMxOTY2MzdhNDk1NmZjNDQzNWJjNGQ2 OTA5YmViNTFjYmEuLjFkMTRhZGE0NDc4ODU0ZDkwM2Y3YzU5OGRiYWZkYWNhZDU2NTIwMTMgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0wMS0xMiAgUGF2ZWwgUG9kaXZpbG92ICA8cG9kaXZp bG92QGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBbSlNDXSAvL0Agc291 cmNlVVJMIGlzIG5vdCByZXNwZWN0ZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD02NTUzMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL2RlYnVnZ2VyL3NvdXJjZS11cmwtY29tbWVudC1l eHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGluc3BlY3Rvci9kZWJ1Z2dlci9zb3VyY2Ut dXJsLWNvbW1lbnQuaHRtbDogQWRkZWQuCisKIDIwMTItMDEtMTIgIFNoZXJpZmYgQm90ICA8d2Vi a2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcg b3V0IHIxMDQ4MDUuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZGVidWdnZXIv c291cmNlLXVybC1jb21tZW50LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9k ZWJ1Z2dlci9zb3VyY2UtdXJsLWNvbW1lbnQtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjA0YmJj MTlhYzM4YzU0YzQyM2NiYTcyN2M0ZmYwMWI2MDE1N2UwOTIKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9pbnNwZWN0b3IvZGVidWdnZXIvc291cmNlLXVybC1jb21tZW50LWV4cGVjdGVk LnR4dApAQCAtMCwwICsxLDkgQEAKK1Rlc3RzIHRoYXQgZXZhbHMgd2l0aCBzb3VyY2VVUkwgY29t bWVudCBhcmUgc2hvd24gaW4gc2NyaXB0cyBwYW5lbC4KKworRGVidWdnZXIgd2FzIGVuYWJsZWQu CisKK1J1bm5pbmc6IHRlc3RTb3VyY2VVUkxDb21tZW50CitmdW5jdGlvbiBrZWVwQWxpdmUoKSB7 fQorLy9AIHNvdXJjZVVSTD1ldmFsVVJMLmpzCitEZWJ1Z2dlciB3YXMgZGlzYWJsZWQuCisKZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9kZWJ1Z2dlci9zb3VyY2UtdXJsLWNvbW1l bnQuaHRtbCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9kZWJ1Z2dlci9zb3VyY2UtdXJsLWNvbW1l bnQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwLi42NDE2MjU2ZjFhMzE2MTk1N2ViZDI0OTMyMjNkZTM3YTMyYzEz OGRhCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2RlYnVnZ2VyL3Nv dXJjZS11cmwtY29tbWVudC5odG1sCkBAIC0wLDAgKzEsMzcgQEAKKzxodG1sPgorPGhlYWQ+Cis8 c2NyaXB0IHNyYz0iLi4vLi4vaHR0cC90ZXN0cy9pbnNwZWN0b3IvaW5zcGVjdG9yLXRlc3QuanMi Pjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4uL2h0dHAvdGVzdHMvaW5zcGVjdG9yL2RlYnVn Z2VyLXRlc3QuanMiPjwvc2NyaXB0PgorCis8c2NyaXB0PgorCitmdW5jdGlvbiBkb0V2YWwoKQor eworICAgIGV2YWwoImZ1bmN0aW9uIGtlZXBBbGl2ZSgpIHt9XG4vL0Agc291cmNlVVJMPWV2YWxV UkwuanMiKTsKK30KKworZnVuY3Rpb24gdGVzdCgpCit7CisgICAgSW5zcGVjdG9yVGVzdC5ydW5E ZWJ1Z2dlclRlc3RTdWl0ZShbCisgICAgICAgIGZ1bmN0aW9uIHRlc3RTb3VyY2VVUkxDb21tZW50 KG5leHQpCisgICAgICAgIHsKKyAgICAgICAgICAgIEluc3BlY3RvclRlc3Quc2hvd1NjcmlwdFNv dXJjZSgiZXZhbFVSTC5qcyIsIGRpZFNob3dTY3JpcHRTb3VyY2UpOworICAgICAgICAgICAgSW5z cGVjdG9yVGVzdC5ldmFsdWF0ZUluUGFnZSgic2V0VGltZW91dChkb0V2YWwsIDApIik7CisKKyAg ICAgICAgICAgIGZ1bmN0aW9uIGRpZFNob3dTY3JpcHRTb3VyY2Uoc291cmNlRnJhbWUpCisgICAg ICAgICAgICB7CisgICAgICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5hZGRSZXN1bHQoc291cmNl RnJhbWUudGV4dE1vZGVsLnRleHQpOworICAgICAgICAgICAgICAgIG5leHQoKTsKKyAgICAgICAg ICAgIH0KKyAgICAgICAgfQorICAgIF0pOworfTsKKworPC9zY3JpcHQ+CisKKzwvaGVhZD4KKwor PGJvZHkgb25sb2FkPSJydW5UZXN0KCkiPgorPHA+VGVzdHMgdGhhdCBldmFscyB3aXRoIHNvdXJj ZVVSTCBjb21tZW50IGFyZSBzaG93biBpbiBzY3JpcHRzIHBhbmVsLjwvcD4KKzwvYm9keT4KKzwv aHRtbD4K