<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>65531</bug_id>
          
          <creation_ts>2011-08-02 05:30:21 -0700</creation_ts>
          <short_desc>[Qt] Fix tst_QWebPage::viewModes() API test</short_desc>
          <delta_ts>2012-11-09 06:43:10 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Qt</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt, QtTriaged</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>38654</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Kristóf Kosztyó">kkristof</reporter>
          <assigned_to name="Jocelyn Turcotte">jturcotte</assigned_to>
          <cc>jturcotte</cc>
    
    <cc>ossy</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>445209</commentid>
    <comment_count>0</comment_count>
    <who name="Kristóf Kosztyó">kkristof</who>
    <bug_when>2011-08-02 05:30:21 -0700</bug_when>
    <thetext>FAIL! : tst_QWebPage::viewModes() &apos;empty.type() == QVariant::Bool &amp;&amp; empty.toBool()&apos; returned FALSE. () Loc: [/home/kosztyo/WebKit/Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(496)] 
FAIL! : tst_QWebPage::viewModes() &apos;minimized.type() == QVariant::Bool &amp;&amp; minimized.toBool()&apos; returned FALSE. () Loc: [/home/kosztyo/WebKit/Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(500)] 
FAIL! : tst_QWebPage::viewModes() &apos;maximized.type() == QVariant::Bool &amp;&amp; !maximized.toBool()&apos; returned FALSE. () Loc: [/home/kosztyo/WebKit/Source/WebKit/qt/tests/qwebpage/tst_qwebpage.cpp(504)]</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>445213</commentid>
    <comment_count>1</comment_count>
      <attachid>102639</attachid>
    <who name="Kristóf Kosztyó">kkristof</who>
    <bug_when>2011-08-02 05:35:48 -0700</bug_when>
    <thetext>Created attachment 102639
mark failing test cases as expected fail</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>445214</commentid>
    <comment_count>2</comment_count>
      <attachid>102639</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-08-02 05:37:20 -0700</bug_when>
    <thetext>Comment on attachment 102639
mark failing test cases as expected fail 

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>445215</commentid>
    <comment_count>3</comment_count>
      <attachid>102639</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2011-08-02 05:38:43 -0700</bug_when>
    <thetext>Comment on attachment 102639
mark failing test cases as expected fail 

landed in https://trac.webkit.org/changeset/92182</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>762918</commentid>
    <comment_count>4</comment_count>
      <attachid>173283</attachid>
    <who name="Jocelyn Turcotte">jturcotte</who>
    <bug_when>2012-11-09 05:56:30 -0800</bug_when>
    <thetext>Created attachment 173283
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>762964</commentid>
    <comment_count>5</comment_count>
      <attachid>173283</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-11-09 06:43:06 -0800</bug_when>
    <thetext>Comment on attachment 173283
Patch

Clearing flags on attachment: 173283

Committed r134062: &lt;http://trac.webkit.org/changeset/134062&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>762965</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-11-09 06:43:10 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>102639</attachid>
            <date>2011-08-02 05:35:48 -0700</date>
            <delta_ts>2011-08-02 05:38:43 -0700</delta_ts>
            <desc>mark failing test cases as expected fail </desc>
            <filename>view.patch</filename>
            <type>text/plain</type>
            <size>1932</size>
            <attacher name="Kristóf Kosztyó">kkristof</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9x
dC9DaGFuZ2VMb2cKaW5kZXggMzM5YWVjNC4uMDUyNmEwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dl
YktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEs
NSArMSwxNSBAQAogMjAxMS0wOC0wMiAgS3Jpc3TDs2YgS29zenR5w7MgIDxLb3N6dHlvLktyaXN0
b2ZAc3R1ZC51LXN6ZWdlZC5odT4KIAorICAgICAgICBbUXRdIEZpeCB0c3RfUVdlYlBhZ2U6OnZp
ZXdNb2RlcygpIEFQSSB0ZXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df
YnVnLmNnaT9pZD02NTUzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor
CisgICAgICAgICogdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcDogTWFyayBmYWlsaW5n
IHRlc3QgY2FzZSBhcyBleHBlY3RlZCBmYWlsCisgICAgICAgICh0c3RfUVdlYlBhZ2U6OnZpZXdN
b2Rlcyk6CisKKzIwMTEtMDgtMDIgIEtyaXN0w7NmIEtvc3p0ecOzICA8S29zenR5by5LcmlzdG9m
QHN0dWQudS1zemVnZWQuaHU+CisKICAgICAgICAgW1F0XSBGaXggdHN0X1FXZWJGcmFtZTo6Y29u
bmVjdEFuZERpc2Nvbm5lY3QoKSBBUEkgdGVzdAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjUxNzAKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9x
dC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwIGIvU291cmNlL1dlYktpdC9xdC90ZXN0
cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwCmluZGV4IDJlOTU4N2QuLmUxZjg1YzggMTAwNjQ0
Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcAor
KysgYi9Tb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAKQEAg
LTQ5MywxMiArNDkzLDE1IEBAIHZvaWQgdHN0X1FXZWJQYWdlOjp2aWV3TW9kZXMoKQogICAgIG1f
cGFnZS0+c2V0UHJvcGVydHkoIl9xX3ZpZXdNb2RlIiwgIm1pbmltaXplZCIpOwogCiAgICAgUVZh
cmlhbnQgZW1wdHkgPSBtX3BhZ2UtPm1haW5GcmFtZSgpLT5ldmFsdWF0ZUphdmFTY3JpcHQoIndp
bmRvdy5zdHlsZU1lZGlhLm1hdGNoTWVkaXVtKFwiKC13ZWJraXQtdmlldy1tb2RlKVwiKSIpOwor
ICAgIFFFWFBFQ1RfRkFJTCgiIiwgImh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD02NTUzMSIsIENvbnRpbnVlKTsKICAgICBRVkVSSUZZKGVtcHR5LnR5cGUoKSA9PSBRVmFy
aWFudDo6Qm9vbCAmJiBlbXB0eS50b0Jvb2woKSk7CiAKICAgICBRVmFyaWFudCBtaW5pbWl6ZWQg
PSBtX3BhZ2UtPm1haW5GcmFtZSgpLT5ldmFsdWF0ZUphdmFTY3JpcHQoIndpbmRvdy5zdHlsZU1l
ZGlhLm1hdGNoTWVkaXVtKFwiKC13ZWJraXQtdmlldy1tb2RlOiBtaW5pbWl6ZWQpXCIpIik7Cisg
ICAgUUVYUEVDVF9GQUlMKCIiLCAiaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp
P2lkPTY1NTMxIiwgQ29udGludWUpOwogICAgIFFWRVJJRlkobWluaW1pemVkLnR5cGUoKSA9PSBR
VmFyaWFudDo6Qm9vbCAmJiBtaW5pbWl6ZWQudG9Cb29sKCkpOwogCiAgICAgUVZhcmlhbnQgbWF4
aW1pemVkID0gbV9wYWdlLT5tYWluRnJhbWUoKS0+ZXZhbHVhdGVKYXZhU2NyaXB0KCJ3aW5kb3cu
c3R5bGVNZWRpYS5tYXRjaE1lZGl1bShcIigtd2Via2l0LXZpZXctbW9kZTogbWF4aW1pemVkKVwi
KSIpOworICAgIFFFWFBFQ1RfRkFJTCgiIiwgImh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df
YnVnLmNnaT9pZD02NTUzMSIsIENvbnRpbnVlKTsKICAgICBRVkVSSUZZKG1heGltaXplZC50eXBl
KCkgPT0gUVZhcmlhbnQ6OkJvb2wgJiYgIW1heGltaXplZC50b0Jvb2woKSk7CiB9CiAK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>173283</attachid>
            <date>2012-11-09 05:56:30 -0800</date>
            <delta_ts>2012-11-09 06:43:06 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-65531-20121109145437.patch</filename>
            <type>text/plain</type>
            <size>2006</size>
            <attacher name="Jocelyn Turcotte">jturcotte</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTMzMjg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0
L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IGViNzk1MGRkYmY0
MTQzOTkzOTJlY2I4ZTY3NmQzNGRkMzgzNTEwZTMuLmM3YjBjZjA4NjgwNDQwMjRmNGEwM2IyMDVl
ZWVhYzY1OTc5YWMzY2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr
KyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUgQEAKIDIwMTItMTEt
MDkgIEpvY2VseW4gVHVyY290dGUgIDxqb2NlbHluLnR1cmNvdHRlQGRpZ2lhLmNvbT4KIAorICAg
ICAgICBbUXRdIFVubWFyayBub3cgcGFzc2luZyB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjU1MzEKKworICAgICAgICBSZXZpZXdlZCBieSBO
T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHRlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5j
cHA6CisgICAgICAgICh0c3RfUVdlYlBhZ2U6OnZpZXdNb2Rlcyk6CisKKzIwMTItMTEtMDkgIEpv
Y2VseW4gVHVyY290dGUgIDxqb2NlbHluLnR1cmNvdHRlQGRpZ2lhLmNvbT4KKwogICAgICAgICBb
UXRdIEZpeCBVUkwgaXNzdWVzIGluIHRzdF9xd2ViZnJhbWUKICAgICAgICAgaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMTc0MQogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv
V2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAgYi9Tb3VyY2UvV2ViS2l0
L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAKaW5kZXggN2MxNjEzMzg4YzMyNWFk
ZWQ5OGI1NTEzZjUyYzdkMjI0ZmRiYTgwNy4uMjY0MzU5OTMzOGU2MzlhNzkxYjVhOWM4ODFhMjU2
M2FhOTc5NmJhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9xdC90ZXN0cy9xd2VicGFnZS90
c3RfcXdlYnBhZ2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvdHN0
X3F3ZWJwYWdlLmNwcApAQCAtNTYyLDE1ICs1NjIsMTIgQEAgdm9pZCB0c3RfUVdlYlBhZ2U6OnZp
ZXdNb2RlcygpCiAgICAgbV9wYWdlLT5zZXRQcm9wZXJ0eSgiX3Ffdmlld01vZGUiLCAibWluaW1p
emVkIik7CiAKICAgICBRVmFyaWFudCBlbXB0eSA9IG1fcGFnZS0+bWFpbkZyYW1lKCktPmV2YWx1
YXRlSmF2YVNjcmlwdCgid2luZG93LnN0eWxlTWVkaWEubWF0Y2hNZWRpdW0oXCIoLXdlYmtpdC12
aWV3LW1vZGUpXCIpIik7Ci0gICAgUUVYUEVDVF9GQUlMKCIiLCAiaHR0cHM6Ly9idWdzLndlYmtp
dC5vcmcvc2hvd19idWcuY2dpP2lkPTY1NTMxIiwgQ29udGludWUpOwogICAgIFFWRVJJRlkoZW1w
dHkudHlwZSgpID09IFFWYXJpYW50OjpCb29sICYmIGVtcHR5LnRvQm9vbCgpKTsKIAogICAgIFFW
YXJpYW50IG1pbmltaXplZCA9IG1fcGFnZS0+bWFpbkZyYW1lKCktPmV2YWx1YXRlSmF2YVNjcmlw
dCgid2luZG93LnN0eWxlTWVkaWEubWF0Y2hNZWRpdW0oXCIoLXdlYmtpdC12aWV3LW1vZGU6IG1p
bmltaXplZClcIikiKTsKLSAgICBRRVhQRUNUX0ZBSUwoIiIsICJodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjU1MzEiLCBDb250aW51ZSk7CiAgICAgUVZFUklGWShtaW5p
bWl6ZWQudHlwZSgpID09IFFWYXJpYW50OjpCb29sICYmIG1pbmltaXplZC50b0Jvb2woKSk7CiAK
ICAgICBRVmFyaWFudCBtYXhpbWl6ZWQgPSBtX3BhZ2UtPm1haW5GcmFtZSgpLT5ldmFsdWF0ZUph
dmFTY3JpcHQoIndpbmRvdy5zdHlsZU1lZGlhLm1hdGNoTWVkaXVtKFwiKC13ZWJraXQtdmlldy1t
b2RlOiBtYXhpbWl6ZWQpXCIpIik7Ci0gICAgUUVYUEVDVF9GQUlMKCIiLCAiaHR0cHM6Ly9idWdz
LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1NTMxIiwgQ29udGludWUpOwogICAgIFFWRVJJ
RlkobWF4aW1pemVkLnR5cGUoKSA9PSBRVmFyaWFudDo6Qm9vbCAmJiAhbWF4aW1pemVkLnRvQm9v
bCgpKTsKIH0KIAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>