65527 2011-08-02 05:09:00 -0700 WebSocket should be closed by receiving unexpected continuation frame without any leading text or binary frames 2011-08-02 21:38:09 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 toyoshim webkit-unassigned abarth ap tkent webkit.review.bot yutak oldest_to_newest 445193 0 toyoshim 2011-08-02 05:09:00 -0700 In current implement, WebSocket just ignores invalid continuation frames which have no leading frame with FIN=0. cf.) Chromium side issue report: http://code.google.com/p/chromium/issues/detail?id=91193 445221 1 102641 toyoshim 2011-08-02 05:57:37 -0700 Created attachment 102641 Patch 445699 2 102641 tkent 2011-08-02 20:38:12 -0700 Comment on attachment 102641 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102641&action=review Looks ok. > LayoutTests/ChangeLog:5 > + WebSocket: Should be closed by receiving invalid continuation frame. > + > + https://bugs.webkit.org/show_bug.cgi?id=65527 nit: We don't need a blank line between the summary line and the bug URL. > Source/WebCore/ChangeLog:5 > + WebSocket: Should be closed by receiving invalid continuation frame. > + > + https://bugs.webkit.org/show_bug.cgi?id=65527 ditto. 445713 3 102641 webkit.review.bot 2011-08-02 21:38:04 -0700 Comment on attachment 102641 Patch Clearing flags on attachment: 102641 Committed r92260: <http://trac.webkit.org/changeset/92260> 445714 4 webkit.review.bot 2011-08-02 21:38:09 -0700 All reviewed patches have been landed. Closing bug. 102641 2011-08-02 05:57:37 -0700 2011-08-02 21:38:04 -0700 Patch bug-65527-20110802215735.patch text/plain 5989 toyoshim U3VidmVyc2lvbiBSZXZpc2lvbjogOTIxNjIKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5n ZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA4YWUyYjNiZjlmYTJhYTRhODUxZjBi MTVkNWNhOGU5OTBjZTQ4MmE3Li43ZjgxYzUxZjY3YTAwNjA0NTlhNzZhNDdlNTczMjljNDlhMGYw MjcyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMDgtMDIgIFRha2FzaGkgVG95b3NoaW1h ICA8dG95b3NoaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYlNvY2tldDogU2hvdWxkIGJl IGNsb3NlZCBieSByZWNlaXZpbmcgaW52YWxpZCBjb250aW51YXRpb24gZnJhbWUuCisKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1NTI3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL3dl YnNvY2tldC90ZXN0cy9oeWJpL2ludmFsaWQtY29udGludWF0aW9uLWV4cGVjdGVkLnR4dDogQWRk ZWQuCisgICAgICAgICogaHR0cC90ZXN0cy93ZWJzb2NrZXQvdGVzdHMvaHliaS9pbnZhbGlkLWNv bnRpbnVhdGlvbi5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBodHRwL3Rlc3RzL3dlYnNvY2tldC90 ZXN0cy9oeWJpL2ludmFsaWQtY29udGludWF0aW9uX3dzaC5weTogQWRkZWQuCisKIDIwMTEtMDgt MDEgIFpoZW55YW8gTW8gIDx6bW9AZ29vZ2xlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBy ZWJhc2VsaW5lLCB3ZWJraXQgZ2FyZGVuZXIgc3R1ZmYuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9odHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9oeWJpL2ludmFsaWQtY29udGludWF0aW9uLWV4 cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2h5Ymkv aW52YWxpZC1jb250aW51YXRpb24tZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjA4N2EzN2E3N2I1 ZDgxM2MwYjZmNjZlMjJmNzMyNDFiZTM4NzM0NDEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9odHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9oeWJpL2ludmFsaWQtY29udGludWF0aW9u LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDEyIEBACitDT05TT0xFIE1FU1NBR0U6IGxpbmUgMDog UmVjZWl2ZWQgdW5leHBlY3RlZCBjb250aW51YXRpb24gZnJhbWUuCitUZXN0IHdoZXRoZXIgV2Vi U29ja2V0IGFib3J0cyB0aGUgY29ubmVjdGlvbiB3aGVuIGl0IHJlY2VpdmVzIGFuIHVuZXhwZWN0 ZWQgY29udGludWF0aW9uIGZyYW1lIHdpdGhvdXQgYW55IGxlYWRpbmcgdGV4dCBvciBiaW5hcnkg ZnJhbWUuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVz c2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworb25vcGVuKCkgd2FzIGNhbGxl ZC4KK29uY2xvc2UoKSB3YXMgY2FsbGVkLgorUEFTUyBjbG9zZUV2ZW50Lndhc0NsZWFuIGlzIGZh bHNlCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1QgQ09NUExFVEUKKwpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy93ZWJzb2NrZXQvdGVzdHMvaHliaS9p bnZhbGlkLWNvbnRpbnVhdGlvbi5odG1sIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy93ZWJzb2Nr ZXQvdGVzdHMvaHliaS9pbnZhbGlkLWNvbnRpbnVhdGlvbi5odG1sCm5ldyBmaWxlIG1vZGUgMTAw NjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjQyNjVh MjI2NGFjZjgzZWIxNjEwODQ3YjU5MTdmMTdlMGJkMWQ4NDYKLS0tIC9kZXYvbnVsbAorKysgYi9M YXlvdXRUZXN0cy9odHRwL3Rlc3RzL3dlYnNvY2tldC90ZXN0cy9oeWJpL2ludmFsaWQtY29udGlu dWF0aW9uLmh0bWwKQEAgLTAsMCArMSw0MyBAQAorPCFET0NUWVBFIEhUTUw+Cis8aHRtbD4KKzxo ZWFkPgorPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBocmVmPSIuLi8uLi8uLi8uLi9qcy10ZXN0LXJl c291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vLi4vanMt dGVzdC1yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+ Cis8ZGl2IGlkPSJkZXNjcmlwdGlvbiI+PC9kaXY+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4K KzxzY3JpcHQ+CitkZXNjcmlwdGlvbigiVGVzdCB3aGV0aGVyIFdlYlNvY2tldCBhYm9ydHMgdGhl IGNvbm5lY3Rpb24gd2hlbiBpdCByZWNlaXZlcyBhbiB1bmV4cGVjdGVkIGNvbnRpbnVhdGlvbiBm cmFtZSB3aXRob3V0IGFueSBsZWFkaW5nIHRleHQgb3IgYmluYXJ5IGZyYW1lLiIpOworCit3aW5k b3cuanNUZXN0SXNBc3luYyA9IHRydWU7CitpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVy KQorICAgIGxheW91dFRlc3RDb250cm9sbGVyLm92ZXJyaWRlUHJlZmVyZW5jZSgiV2ViS2l0SGl4 aWU3NldlYlNvY2tldFByb3RvY29sRW5hYmxlZCIsIDApOworCit2YXIgd3MgPSBuZXcgV2ViU29j a2V0KCJ3czovLzEyNy4wLjAuMTo4ODgwL3dlYnNvY2tldC90ZXN0cy9oeWJpL2ludmFsaWQtY29u dGludWF0aW9uIik7Cit2YXIgY2xvc2VFdmVudDsKKword3Mub25vcGVuID0gZnVuY3Rpb24oKQor eworICAgIGRlYnVnKCJvbm9wZW4oKSB3YXMgY2FsbGVkLiIpOworfTsKKword3Mub25tZXNzYWdl ID0gZnVuY3Rpb24oZXZlbnQpCit7CisgICAgdmFyIG1lc3NhZ2UgPSBldmVudC5kYXRhOworICAg IHRlc3RGYWlsZWQoIm9ubWVzc2FnZSgpIHdhcyBjYWxsZWQuIChtZXNzYWdlID0gXCIiICsgbWVz c2FnZSArICJcIikiKTsKK307CisKK3dzLm9uY2xvc2UgPSBmdW5jdGlvbihldmVudCkKK3sKKyAg ICBkZWJ1Zygib25jbG9zZSgpIHdhcyBjYWxsZWQuIik7CisgICAgY2xvc2VFdmVudCA9IGV2ZW50 OworICAgIHNob3VsZEJlRmFsc2UoImNsb3NlRXZlbnQud2FzQ2xlYW4iKTsKKyAgICBmaW5pc2hK U1Rlc3QoKTsKK307CisKK3ZhciBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOworPC9zY3JpcHQ+ Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vLi4vanMtdGVzdC1yZXNvdXJjZXMvanMtdGVzdC1wb3N0 LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2h0dHAvdGVzdHMvd2Vic29ja2V0L3Rlc3RzL2h5YmkvaW52YWxpZC1jb250aW51YXRpb25fd3No LnB5IGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy93ZWJzb2NrZXQvdGVzdHMvaHliaS9pbnZhbGlk LWNvbnRpbnVhdGlvbl93c2gucHkKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNzBlMDI5NmY1NmM0ZmY4OTUxYmY3YTVm ZTQ3MDg2MGEyM2U1MTk2MwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVz dHMvd2Vic29ja2V0L3Rlc3RzL2h5YmkvaW52YWxpZC1jb250aW51YXRpb25fd3NoLnB5CkBAIC0w LDAgKzEsMTYgQEAKK2Zyb20gbW9kX3B5d2Vic29ja2V0IGltcG9ydCBjb21tb24KK2Zyb20gbW9k X3B5d2Vic29ja2V0IGltcG9ydCBzdHJlYW0KKworZGVmIHdlYl9zb2NrZXRfZG9fZXh0cmFfaGFu ZHNoYWtlKHJlcXVlc3QpOgorICAgIHBhc3MKKworCitkZWYgd2ViX3NvY2tldF90cmFuc2Zlcl9k YXRhKHJlcXVlc3QpOgorICAgIHBheWxvYWQxID0gJ0ludmFsaWQgY29udGludWF0aW9uIGZyYW1l IHRvIGJlIGlnbm9yZWQuJworICAgIHBheWxvYWQyID0gJ1ZhbGlkIGZyYW1lIGFmdGVyIGNsb3Np bmcgc2hvdWxkIGJlIGRpc3Bvc2VkLicKKyAgICByZXF1ZXN0LmNvbm5lY3Rpb24ud3JpdGUoc3Ry ZWFtLmNyZWF0ZV9oZWFkZXIoY29tbW9uLk9QQ09ERV9DT05USU5VQVRJT04sCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxlbihwYXlsb2FkMSksCisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDEsIDAsIDAs IDAsIDApICsgcGF5bG9hZDEpCisgICAgcmVxdWVzdC5jb25uZWN0aW9uLndyaXRlKHN0cmVhbS5j cmVhdGVfaGVhZGVyKGNvbW1vbi5PUENPREVfVEVYVCwKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgbGVuKHBheWxvYWQyKSwKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgMSwgMCwgMCwgMCwgMCkgKyBwYXls b2FkMikKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJD b3JlL0NoYW5nZUxvZwppbmRleCA0N2E4NjFlMmE1ODczZGIyOGUwY2ViYjc0NDI5NWM1NTA5MjZk ZWIwLi45NzZkNTAxYzcwNjVjY2YxYzEwMzcyMWUxZmZhOTJiZTlhZGQzODQ4IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDgtMDIgIFRha2FzaGkgVG95b3NoaW1hICA8dG95b3No aW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYlNvY2tldDogU2hvdWxkIGJlIGNsb3NlZCBi eSByZWNlaXZpbmcgaW52YWxpZCBjb250aW51YXRpb24gZnJhbWUuCisKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1NTI3CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdDogaHR0cC90ZXN0cy93ZWJzb2Nr ZXQvdGVzdHMvaHliaS9pbnZhbGlkLWNvbnRpbnVhdGlvbi5odG1sCisKKyAgICAgICAgKiB3ZWJz b2NrZXRzL1dlYlNvY2tldENoYW5uZWwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2ViU29ja2V0 Q2hhbm5lbDo6cHJvY2Vzc0ZyYW1lKToKKwogMjAxMS0wOC0wMSAgSmVhbi1sdWMgQnJvdWlsbGV0 ICA8amVhbmx1Y0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmVtb3Zpbmcgb2xkIHNvdXJjZSBm aWxlcyBpbiBneXAgZmlsZXMgdGhhdCBzbG93IGJ1aWxkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS93ZWJzb2NrZXRzL1dlYlNvY2tldENoYW5uZWwuY3BwIGIvU291cmNlL1dlYkNvcmUvd2Vi c29ja2V0cy9XZWJTb2NrZXRDaGFubmVsLmNwcAppbmRleCA3NjcxZDcyZmUxNjkyMGM1MjlkOWRj OWNmYjY1YWM2ZmE1MmRhMTBkLi5hNzhiNDVjMmJjNGFmMDJlYmNlYzZlM2JmMzI0NGY5ZTZiZjIz ZDkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS93ZWJzb2NrZXRzL1dlYlNvY2tldENoYW5u ZWwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3dlYnNvY2tldHMvV2ViU29ja2V0Q2hhbm5lbC5j cHAKQEAgLTU0Miw2ICs1NDIsMTEgQEAgYm9vbCBXZWJTb2NrZXRDaGFubmVsOjpwcm9jZXNzRnJh bWUoKQogCiAgICAgc3dpdGNoIChmcmFtZS5vcENvZGUpIHsKICAgICBjYXNlIE9wQ29kZUNvbnRp bnVhdGlvbjoKKyAgICAgICAgLy8gQW4gdW5leHBlY3RlZCBjb250aW51YXRpb24gZnJhbWUgaXMg cmVjZWl2ZWQgd2l0aG91dCBhbnkgbGVhZGluZyBmcmFtZS4KKyAgICAgICAgaWYgKCFtX2hhc0Nv bnRpbnVvdXNGcmFtZSkgeworICAgICAgICAgICAgZmFpbCgiUmVjZWl2ZWQgdW5leHBlY3RlZCBj b250aW51YXRpb24gZnJhbWUuIik7CisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAg IH0KICAgICAgICAgLy8gVGhyb3cgYXdheSBjb250ZW50IG9mIGEgYmluYXJ5IG1lc3NhZ2UgYmVj YXVzZSBiaW5hcnkgbWVzc2FnZXMgYXJlIG5vdCBzdXBwb3J0ZWQgeWV0LgogICAgICAgICBpZiAo bV9jb250aW51b3VzRnJhbWVPcENvZGUgPT0gT3BDb2RlVGV4dCkKICAgICAgICAgICAgIG1fY29u dGludW91c0ZyYW1lRGF0YS5hcHBlbmQoZnJhbWUucGF5bG9hZCwgZnJhbWUucGF5bG9hZExlbmd0 aCk7Cg==