65498 2011-08-01 17:12:28 -0700 [chromium] Fix unresolved symbols error when linking to libwebkit.dylib 2011-08-02 10:34:04 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thakis thakis dglazkov jamesr webkit.review.bot oldest_to_newest 445009 0 thakis 2011-08-01 17:12:28 -0700 [chromium] Fix unresolved symbols error when linking to libwebkit.dylib 445010 1 102595 thakis 2011-08-01 17:13:17 -0700 Created attachment 102595 Patch 445026 2 thakis 2011-08-01 17:30:19 -0700 I can has stamp? Mento says LG over email. 445307 3 102595 dglazkov 2011-08-02 09:12:15 -0700 Comment on attachment 102595 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102595&action=review > Source/WebCore/WebCore.gyp/mac/adjust_visibility.sh:89 > + # __ZN8Security12KeychainCore6Schema27X509CrlSchemaAttributeCountE$non_lazy_ptr Please avoid using the word "lazy". It sounds demeaning. Perhaps "thoughtful" or "well-timed"? 445312 4 thakis 2011-08-02 09:19:16 -0700 (In reply to comment #3) > > Source/WebCore/WebCore.gyp/mac/adjust_visibility.sh:89 > > + # __ZN8Security12KeychainCore6Schema27X509CrlSchemaAttributeCountE$non_lazy_ptr > > Please avoid using the word "lazy". It sounds demeaning. Perhaps "thoughtful" or "well-timed"? But it's "non_lazy". Isn't the negation of a demeaning word more world-improving than the negation of a kinder word? 445313 5 dglazkov 2011-08-02 09:20:37 -0700 (In reply to comment #4) > (In reply to comment #3) > > > Source/WebCore/WebCore.gyp/mac/adjust_visibility.sh:89 > > > + # __ZN8Security12KeychainCore6Schema27X509CrlSchemaAttributeCountE$non_lazy_ptr > > > > Please avoid using the word "lazy". It sounds demeaning. Perhaps "thoughtful" or "well-timed"? > > But it's "non_lazy". Isn't the negation of a demeaning word more world-improving than the negation of a kinder word? Ah. I missed that. LGTM. 445348 6 102595 webkit.review.bot 2011-08-02 10:33:59 -0700 Comment on attachment 102595 Patch Clearing flags on attachment: 102595 Committed r92203: <http://trac.webkit.org/changeset/92203> 445349 7 webkit.review.bot 2011-08-02 10:34:04 -0700 All reviewed patches have been landed. Closing bug. 102595 2011-08-01 17:13:17 -0700 2011-08-02 10:33:59 -0700 Patch bug-65498-20110801171316.patch text/plain 2034 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogOTIwMzMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA5OTdkMjVhM2ZkYmRjZjll ZmNmMTliZDI0NTY0Nzc4Nzc4YzhkNTljLi43ZWVjY2U1NGRkNzkxNDQzNzVjZmY2MDM0Y2MxMGRh OTZiZmRkYTdjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTEtMDgtMDEgIE5pY28g V2ViZXIgIDx0aGFraXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gRml4IHVu cmVzb2x2ZWQgc3ltYm9scyBlcnJvciB3aGVuIGxpbmtpbmcgdG8gbGlid2Via2l0LmR5bGliCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTQ5OAorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViQ29yZS5n eXAvbWFjL2FkanVzdF92aXNpYmlsaXR5LnNoOgorCiAyMDExLTA3LTI5ICBaaGVueWFvIE1vICA8 em1vQGdvb2dsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjkyMDEx LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvbWFjL2FkanVzdF92aXNp YmlsaXR5LnNoIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvbWFjL2FkanVzdF92aXNpYmls aXR5LnNoCmluZGV4IDQ0YTUwYjdmYTQwNTE5ZjljZjU1NGY0YjQwNGI5OGY5YzI4YTE5MmIuLmM4 NTIyYmY2NGNlYWMxNDA1ZGU0Y2YyY2E4NzU2NWQ5NWU0ZmE0ZmEgMTAwNzU1Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL1dlYkNvcmUuZ3lwL21hYy9hZGp1c3RfdmlzaWJpbGl0eS5zaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9tYWMvYWRqdXN0X3Zpc2liaWxpdHkuc2gKQEAgLTc5LDYg Kzc5LDE3IEBAIGZvciBBUkNIIGluICR7QVJDSFN9IDsgZG8KICAgIyBDaGFuZ2UgZGlyZWN0b3Jp ZXMgdG8gZXh0cmFjdCB0aGUgYXJjaGl2ZSB0byBlbnN1cmUgY29ycmVjdCBwYXRobmFtZXMuCiAg IChjZCAiJHtBUkNIX0RJUn0iICYmIGFyIC14ICIke0lOUFVUX05BTUV9IikKIAorICAjIGxpYldl YktpdFN5c3RlbUludGVyZmFjZUxlb3BhcmQuYSdzIGN1RGJVdGlscy5vIHJlZmVyZW5jZXMgYSBm ZXcgc3ltYm9scworICAjIHRoYXQgYXJlIG5vdCBkZWZpbmVkIGluIGFueSBmcmFtZXdvcmsgaW4g T1MgWCAxMC41LiBJZiBpdCdzIGxpbmtlZCBpbnRvIGEKKyAgIyBsaWJ3ZWJraXQuZHlsaWIgd2l0 aCAtV2wsLWFsbF9sb2FkLCBsaW5raW5nIHRvIGxpYndlYmtpdC5keWxpYiB3aWxsIHJlc3VsdAor ICAjIGluIHRoZXNlIHVucmVzb2x2ZWQgc3ltYm9sczoKKyAgIyBfX1pOOFNlY3VyaXR5MTJLZXlj aGFpbkNvcmU2U2NoZW1hMjJYNTA5Q3JsU2NoZW1hSW5kZXhMaXN0RSRub25fbGF6eV9wdHIKKyAg IyBfX1pOOFNlY3VyaXR5MTJLZXljaGFpbkNvcmU2U2NoZW1hMjNYNTA5Q3JsU2NoZW1hSW5kZXhD b3VudEUkbm9uX2xhenlfcHRyCisgICMgX19aTjhTZWN1cml0eTEyS2V5Y2hhaW5Db3JlNlNjaGVt YTI2WDUwOUNybFNjaGVtYUF0dHJpYnV0ZUxpc3RFJG5vbl9sYXp5X3B0cgorICAjIF9fWk44U2Vj dXJpdHkxMktleWNoYWluQ29yZTZTY2hlbWEyN1g1MDlDcmxTY2hlbWFBdHRyaWJ1dGVDb3VudEUk bm9uX2xhenlfcHRyCisgICMgU2luY2Ugbm90aGluZyBpbiBjdURiVXRpbHMubyBpcyBuZWVkZWQs IGp1c3QgcmVtb3ZlIGl0LgorICBybSAiJHtBUkNIX0RJUn0iL2N1RGJVdGlscy5vCisKICAgIyBV c2UgbGQgLXIgdG8gcmVsaW5rIGVhY2ggb2JqZWN0IHRoYXQgd2FzIGluIHRoZSBhcmNoaXZlLiAg UHJvdmlkaW5nIGFuCiAgICMgZW1wdHkgLWV4cG9ydGVkX3N5bWJvbHNfbGlzdCB3aWxsIHRyYW5z Zm9ybSBhbGwgc3ltYm9scyB0byBwcml2YXRlX2V4dGVybjsKICAgIyB0aGVzZSBzeW1ib2xzIGFy ZSByZXRhaW5lZCB3aXRoIC1rZWVwX3ByaXZhdGVfZXh0ZXJucy4K