65476 2011-08-01 10:09:04 -0700 Web Inspector: [Extensions API] webInspector.inspectedPage.reload() is broken 2011-11-30 09:37:04 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caseq caseq apavlov bweinstein dglazkov joepeck keishi loislo pfeldman pmuellr rik steveblock webkit.review.bot yurys oldest_to_newest 444740 0 caseq 2011-08-01 10:09:04 -0700 Somehow, the test for webInspector.inspectedPage.reload() added in Bug 51485 wasn't landed. This lead to webInspector.inspectedPage.reload() being eventaully broken by a change in inspector backend interface (PageAgent.setUserAgentOverride() -> NetworkAgent.setUserAgentOverride()). 444754 1 102533 caseq 2011-08-01 10:28:10 -0700 Created attachment 102533 patch - Fixed webInspector.inspectedPage.reload() - Broguht back tests for the above - Removed redundant user-agent override from FrameLoader::loadResourceSynchronously(), this should happen indirectly via a call to addExtraFieldsToSubresourceRequest() 444780 2 102533 webkit.review.bot 2011-08-01 11:12:31 -0700 Comment on attachment 102533 patch Attachment 102533 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9290455 New failing tests: http/tests/inspector/extensions-useragent.html 511817 3 caseq 2011-11-30 09:37:04 -0800 Manually committed r92187: http://trac.webkit.org/changeset/92187 102533 2011-08-01 10:28:10 -0700 2011-08-02 01:25:24 -0700 patch reload-tests.diff text/plain 6105 caseq ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyODQxM2UyLi44ZGQyNjBmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTEtMDgt MDEgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIg SW5zcGVjdG9yOiBbRXh0ZW5zaW9ucyBBUEldIHdlYkluc3BlY3Rvci5pbnNwZWN0ZWRQYWdlLnJl bG9hZCgpIGlzIGJyb2tlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NjU0NzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIGh0dHAvdGVzdHMvaW5zcGVjdG9yL2V4dGVuc2lvbnMtdXNlcmFnZW50LWV4cGVj dGVkLnR4dDogQWRkZWQuCisgICAgICAgICogaHR0cC90ZXN0cy9pbnNwZWN0b3IvZXh0ZW5zaW9u cy11c2VyYWdlbnQuaHRtbDogQWRkZWQuCisKIDIwMTEtMDgtMDEgIFl1cnkgU2VtaWtoYXRza3kg IDx5dXJ5c0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogdHlwaW5nIGFu IGV4cHJlc3Npb24gaW4gYW4gaWZyYW1lIGxlYWRzIHRvIG11bHRpcGxlICJVbnNhZmUgSmF2YVNj cmlwdCBhdHRlbXB0IHRvIGFjY2VzcyBmcmFtZS4uLiIgZXJyb3JzCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rvci9leHRlbnNpb25zLXVzZXJhZ2VudC1leHBlY3Rl ZC50eHQgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rvci9leHRlbnNpb25zLXVzZXJh Z2VudC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uMmZj YmEwMgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvaW5zcGVjdG9y L2V4dGVuc2lvbnMtdXNlcmFnZW50LWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDEyIEBACitUZXN0 cyBXZWJJbnNwZWN0b3IgZXh0ZW5zaW9uIEFQSQorCitTdGFydGVkIGV4dGVuc2lvbi4KK1J1bm5p bmcgdGVzdHMuLi4KK1JVTk5JTkcgVEVTVDogZXh0ZW5zaW9uX3Rlc3RVc2VyQWdlbnQKK1BhZ2Ug cmVsb2FkZWQuCitQYWdlIHJlbG9hZGVkLgordXNlci1hZ2VudCBoZWFkZXIgZm9yIGV4dGVuc2lv bnMtdXNlcmFnZW50Lmh0bWw6IE1vemlsbGEvNC4wIChjb21wYXRpYmxlOyBXZWJJbnNwZWN0b3Ig RXh0ZW5zaW9uIFVzZXItQWdlbnQgb3ZlcnJpZGU7IFJTWC0xMU0pCit1c2VyLWFnZW50IGhlYWRl ciBmb3IgeGhyLWV4aXN0cy5odG1sOiBNb3ppbGxhLzQuMCAoY29tcGF0aWJsZTsgV2ViSW5zcGVj dG9yIEV4dGVuc2lvbiBVc2VyLUFnZW50IG92ZXJyaWRlOyBSU1gtMTFNKQorbmF2aWdhdG9yLnVz ZXJBZ2VudDogTW96aWxsYS80LjAgKGNvbXBhdGlibGU7IFdlYkluc3BlY3RvciBFeHRlbnNpb24g VXNlci1BZ2VudCBvdmVycmlkZTsgUlNYLTExTSkKK0FsbCB0ZXN0cyBkb25lLgorCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2luc3BlY3Rvci9leHRlbnNpb25zLXVzZXJhZ2Vu dC5odG1sIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3IvZXh0ZW5zaW9ucy11c2Vy YWdlbnQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDc1NQppbmRleCAwMDAwMDAwLi40NGE1NWQwCi0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3IvZXh0ZW5z aW9ucy11c2VyYWdlbnQuaHRtbApAQCAtMCwwICsxLDY4IEBACis8aHRtbD4KKzxoZWFkPgorPHNj cmlwdCBzcmM9Imluc3BlY3Rvci10ZXN0LmpzIj48L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSJleHRl bnNpb25zLXRlc3QuanMiPjwvc2NyaXB0PgorPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQi PgorCitmdW5jdGlvbiBleHRlbnNpb25fdGVzdFVzZXJBZ2VudChuZXh0VGVzdCkKK3sKKyAgICBj b25zdCByZXNvdXJjZXNUb0NoZWNrID0gWworICAgICAgICAiZXh0ZW5zaW9ucy11c2VyYWdlbnQu aHRtbCIsCisgICAgICAgICJ4aHItZXhpc3RzLmh0bWwiCisgICAgXTsKKyAgICB2YXIgcmVzb3Vy Y2VDb3VudCA9IDA7CisgICAgdmFyIHF1ZXVlZE91dHB1dCA9IFtdOworCisgICAgZnVuY3Rpb24g b25SZXNvdXJjZShyZXNvdXJjZSkKKyAgICB7CisgICAgICAgIHZhciB1cmwgPSByZXNvdXJjZS5y ZXF1ZXN0LnVybC5yZXBsYWNlKC9eLipbL10vLCAiIik7CisgICAgICAgIGlmIChyZXNvdXJjZXNU b0NoZWNrLmluZGV4T2YodXJsKSA8IDApCisgICAgICAgICAgICByZXR1cm47CisKKyAgICAgICAg cXVldWVkT3V0cHV0LnB1c2goInVzZXItYWdlbnQgaGVhZGVyIGZvciAiICsgdXJsICsgIjogIiAr IGdldEhlYWRlcihyZXNvdXJjZS5yZXF1ZXN0LmhlYWRlcnMsICJ1c2VyLWFnZW50IikpOworICAg ICAgICBpZiAoKytyZXNvdXJjZUNvdW50IDwgcmVzb3VyY2VzVG9DaGVjay5sZW5ndGgpCisgICAg ICAgICAgICByZXR1cm47CisgICAgICAgIHdlYkluc3BlY3Rvci5yZXNvdXJjZXMub25GaW5pc2hl ZC5yZW1vdmVMaXN0ZW5lcihvblJlc291cmNlKTsKKyAgICAgICAgd2ViSW5zcGVjdG9yLmluc3Bl Y3RlZFdpbmRvdy5ldmFsKCJuYXZpZ2F0b3IudXNlckFnZW50Iiwgb25FdmFsKTsKKyAgICB9Cisg ICAgZnVuY3Rpb24gZ2V0SGVhZGVyKGhlYWRlcnMsIG5hbWUpCisgICAgeworICAgICAgICBmb3Ig KHZhciBpID0gMDsgaSA8IGhlYWRlcnMubGVuZ3RoOyArK2kpIHsKKyAgICAgICAgICAgIGlmICho ZWFkZXJzW2ldLm5hbWUudG9Mb3dlckNhc2UoKSA9PT0gbmFtZSkKKyAgICAgICAgICAgICAgICBy ZXR1cm4gaGVhZGVyc1tpXS52YWx1ZTsKKyAgICAgICAgfQorICAgIH0KKyAgICBmdW5jdGlvbiBv bkV2YWwocmVzdWx0KQorICAgIHsKKyAgICAgICAgcXVldWVkT3V0cHV0LnB1c2goIm5hdmlnYXRv ci51c2VyQWdlbnQ6ICIgKyByZXN1bHQpOworICAgICAgICB3ZWJJbnNwZWN0b3IuaW5zcGVjdGVk V2luZG93LmV2YWwoIiIsIGNsZWFuVXApOworICAgIH0KKyAgICBmdW5jdGlvbiBjbGVhblVwKCkK KyAgICB7CisgICAgICAgIGV2YWx1YXRlT25Gcm9udGVuZCgiSW5zcGVjdG9yVGVzdC5ydW5XaGVu UGFnZUxvYWRzKHJlcGx5KSIsIG9uUGFnZUxvYWRlZCk7CisgICAgICAgIHdlYkluc3BlY3Rvci5p bnNwZWN0ZWRXaW5kb3cucmVsb2FkKCIiKTsKKyAgICB9CisgICAgZnVuY3Rpb24gb25QYWdlTG9h ZGVkKCkKKyAgICB7CisgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgcXVldWVkT3V0cHV0Lmxl bmd0aDsgKytpKQorICAgICAgICAgICAgb3V0cHV0KHF1ZXVlZE91dHB1dFtpXSk7CisgICAgICAg IG5leHRUZXN0KCk7ICAgICAgIAorICAgIH0KKworICAgIHdlYkluc3BlY3Rvci5yZXNvdXJjZXMu b25GaW5pc2hlZC5hZGRMaXN0ZW5lcihvblJlc291cmNlKTsKKyAgICB3ZWJJbnNwZWN0b3IuaW5z cGVjdGVkV2luZG93LnJlbG9hZCgiTW96aWxsYS80LjAgKGNvbXBhdGlibGU7IFdlYkluc3BlY3Rv ciBFeHRlbnNpb24gVXNlci1BZ2VudCBvdmVycmlkZTsgUlNYLTExTSkiKTsKK30KKworKGZ1bmN0 aW9uKCkKK3sKKyAgICB2YXIgeGhyID0gbmV3IFhNTEh0dHBSZXF1ZXN0KCk7CisgICAgeGhyLm9w ZW4oIkdFVCIsICJyZXNvdXJjZXMveGhyLWV4aXN0cy5odG1sIiwgZmFsc2UpOworICAgIHhoci5z ZW5kKG51bGwpOworfSkoKTsKKworPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keSBvbmxvYWQ9InJ1 blRlc3QoKSI+Cis8cD5UZXN0cyBXZWJJbnNwZWN0b3IgZXh0ZW5zaW9uIEFQSTwvcD4KKzwvYm9k eT4KKzwvaHRtbD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlM2E1Zjk1Li44ODVlODViIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTEtMDgtMDEgIEFuZHJleSBLb3N5YWtvdiAgPGNhc2VxQGNocm9t aXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBbRXh0ZW5zaW9ucyBBUEldIHdlYklu c3BlY3Rvci5pbnNwZWN0ZWRQYWdlLnJlbG9hZCgpIGlzIGJyb2tlbgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjU0NzYKKworICAgICAgICAtIGZpeGVk IHdlYkluc3BlY3Rvci5pbnNwZWN0ZWRXaW5kb3cucmVsb2FkKCksIGJyb3VnaHQgdGVzdHMgYmFj ay4KKyAgICAgICAgLSByZW1vdmVkIHJlZHVuZGFudCBzZXR0aW5nIG9mIHVzZXIgYWdlbnQgaW4g RnJhbWVMb2FkZXI6OmFkZEV4dHJhRmllbGRzVG9SZXF1ZXN0KCkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBodHRwL3Rlc3RzL2luc3BlY3Rv ci9leHRlbnNpb25zLXVzZXJhZ2VudC5odG1sCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQt ZW5kL0V4dGVuc2lvblNlcnZlci5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5FeHRlbnNpb25T ZXJ2ZXIucHJvdG90eXBlLl9vblJlbG9hZCk6CisgICAgICAgICogbG9hZGVyL0ZyYW1lTG9hZGVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyOjpsb2FkUmVzb3VyY2VTeW5jaHJv bm91c2x5KToKKwogMjAxMS0wOC0wMSAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiB0eXBpbmcgYW4gZXhwcmVzc2lvbiBpbiBh biBpZnJhbWUgbGVhZHMgdG8gbXVsdGlwbGUgIlVuc2FmZSBKYXZhU2NyaXB0IGF0dGVtcHQgdG8g YWNjZXNzIGZyYW1lLi4uIiBlcnJvcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvRXh0ZW5zaW9uU2VydmVyLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9FeHRlbnNpb25TZXJ2ZXIuanMKaW5kZXggNTFkMDk5OC4uYjQ3MDM4NSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FeHRlbnNpb25T ZXJ2ZXIuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9FeHRlbnNp b25TZXJ2ZXIuanMKQEAgLTI3Myw3ICsyNzMsNyBAQCBXZWJJbnNwZWN0b3IuRXh0ZW5zaW9uU2Vy dmVyLnByb3RvdHlwZSA9IHsKICAgICBfb25SZWxvYWQ6IGZ1bmN0aW9uKG1lc3NhZ2UpCiAgICAg ewogICAgICAgICBpZiAodHlwZW9mIG1lc3NhZ2UudXNlckFnZW50ID09PSAic3RyaW5nIikKLSAg ICAgICAgICAgIFBhZ2VBZ2VudC5zZXRVc2VyQWdlbnRPdmVycmlkZShtZXNzYWdlLnVzZXJBZ2Vu dCk7CisgICAgICAgICAgICBOZXR3b3JrQWdlbnQuc2V0VXNlckFnZW50T3ZlcnJpZGUobWVzc2Fn ZS51c2VyQWdlbnQpOwogCiAgICAgICAgIFBhZ2VBZ2VudC5yZWxvYWQoZmFsc2UpOwogICAgICAg ICByZXR1cm4gdGhpcy5fc3RhdHVzLk9LKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9s b2FkZXIvRnJhbWVMb2FkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVy LmNwcAppbmRleCA0N2JiMjIwLi45ZGExNzhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9s b2FkZXIvRnJhbWVMb2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxv YWRlci5jcHAKQEAgLTI1NzksNyArMjU3OSw2IEBAIHVuc2lnbmVkIGxvbmcgRnJhbWVMb2FkZXI6 OmxvYWRSZXNvdXJjZVN5bmNocm9ub3VzbHkoY29uc3QgUmVzb3VyY2VSZXF1ZXN0JiByZXF1CiAK ICAgICBpZiAoUGFnZSogcGFnZSA9IG1fZnJhbWUtPnBhZ2UoKSkKICAgICAgICAgaW5pdGlhbFJl cXVlc3Quc2V0Rmlyc3RQYXJ0eUZvckNvb2tpZXMocGFnZS0+bWFpbkZyYW1lKCktPmxvYWRlcigp LT5kb2N1bWVudExvYWRlcigpLT5yZXF1ZXN0KCkudXJsKCkpOwotICAgIGluaXRpYWxSZXF1ZXN0 LnNldEhUVFBVc2VyQWdlbnQoY2xpZW50KCktPnVzZXJBZ2VudChyZXF1ZXN0LnVybCgpKSk7CiAg ICAgCiAgICAgYWRkRXh0cmFGaWVsZHNUb1N1YnJlc291cmNlUmVxdWVzdChpbml0aWFsUmVxdWVz dCk7CiAK