65472 2011-08-01 08:06:32 -0700 Web Inspector: SourceFrame should store saved scroll positions in View. 2011-08-02 11:33:12 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vsevik vsevik apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 444699 0 vsevik 2011-08-01 08:06:32 -0700 SourceFrame should store saved scroll positions in View. 444786 1 102538 vsevik 2011-08-01 11:44:56 -0700 Created attachment 102538 Patch 445317 2 102538 pfeldman 2011-08-02 09:39:09 -0700 Comment on attachment 102538 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102538&action=review > Source/WebCore/inspector/front-end/ScriptsPanel.js:655 > + newSourceFrame.storeScrollPositionsFromView(oldSourceFrame); inherit* 445376 3 vsevik 2011-08-02 11:33:12 -0700 Committed r92212: <http://trac.webkit.org/changeset/92212> 102538 2011-08-01 11:44:56 -0700 2011-08-02 09:39:09 -0700 Patch bug-65472-20110801224454.patch text/plain 6569 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogOTIxMTkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2YWIwYzAzM2FlMzhiMzAz YjI2ZWQzODY5MDlhNjVmZTEwNmRlZDZmLi5jN2QzMWM4MmUzOWFiMWZhMWEzZDg3YWJlODBmNWU0 ZDQyZWQyMGQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjkgQEAKKzIwMTEtMDgtMDEgIFZzZXZv bG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogU291cmNlRnJhbWUgc2hvdWxkIHN0b3JlIHNhdmVkIHNjcm9sbCBwb3NpdGlvbnMgaW4gVmll dy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1NDcy CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNw ZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlc1BhbmVsLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9y LkZyYW1lUmVzb3VyY2VUcmVlRWxlbWVudC5wcm90b3R5cGUuX3JlY3JlYXRlU291cmNlVmlldyk6 CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzUGFuZWwuanM6CisgICAgICAg IChXZWJJbnNwZWN0b3IuU2NyaXB0c1BhbmVsLnByb3RvdHlwZS5fc291cmNlRmlsZUNoYW5nZWQp OgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvU291cmNlRnJhbWUuanM6CisgICAgICAg IChXZWJJbnNwZWN0b3IuU291cmNlRnJhbWUucHJvdG90eXBlLnNob3cpOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLlNvdXJjZUZyYW1lLnByb3RvdHlwZS5oaWRlKToKKyAgICAgICAgKFdlYkluc3Bl Y3Rvci5Tb3VyY2VGcmFtZS5wcm90b3R5cGUuZ2V0IHNjcm9sbExlZnQpOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLlNvdXJjZUZyYW1lLnByb3RvdHlwZS5zZXQgc2Nyb2xsTGVmdCk6CisgICAgICAg IChXZWJJbnNwZWN0b3IuU291cmNlRnJhbWUucHJvdG90eXBlLmdldCBzY3JvbGxUb3ApOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLlNvdXJjZUZyYW1lLnByb3RvdHlwZS5zZXQgc2Nyb2xsVG9wKToK KyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL1ZpZXcuanM6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuVmlldy5wcm90b3R5cGUuX2lubmVyU2hvdyk6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu Vmlldy5wcm90b3R5cGUuX2lubmVySGlkZSk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVmlldy5w cm90b3R5cGUuZGV0YWNoKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5WaWV3LnByb3RvdHlwZS5z dG9yZVNjcm9sbFBvc2l0aW9ucyk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVmlldy5wcm90b3R5 cGUuc3RvcmVTY3JvbGxQb3NpdGlvbnNGcm9tVmlldyk6CisgICAgICAgIChXZWJJbnNwZWN0b3Iu Vmlldy5wcm90b3R5cGUucmVzdG9yZVNjcm9sbFBvc2l0aW9ucyk6CisKIDIwMTEtMDgtMDEgIE1p aG5lYSBPdmlkZW5pZSAgPG1paG5lYUBhZG9iZS5jb20+CiAKICAgICAgICAgQk9SREVSIGF0dHJp YnV0ZSB3aXRoIHRoZSBvYmplY3QgdGFnLCB1c2luZyBwZXJjZW50YWdlIHZhbHVlcyBub3Qgd29y a2luZy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUmVz b3VyY2VzUGFuZWwuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291 cmNlc1BhbmVsLmpzCmluZGV4IGJkNDY5YzIyMmI2ZjYxYzQ0YzU3NGM5YjQ3OWVjZDIxNzAwMjAy YzcuLjIzMTA5NzU5NjAzYzJlYTZjN2VmNmI4ZGFiODJmZmZmZDE0MTFlMWQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2VzUGFuZWwuanMKKysr IGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZXNQYW5lbC5qcwpA QCAtMTM5OSwxNSArMTM5OSwxMyBAQCBXZWJJbnNwZWN0b3IuRnJhbWVSZXNvdXJjZVRyZWVFbGVt ZW50LnByb3RvdHlwZSA9IHsKICAgICAgICAgdmFyIG5ld1ZpZXcgPSB0aGlzLl9jcmVhdGVTb3Vy Y2VWaWV3KCk7CiAKICAgICAgICAgdmFyIG9sZFZpZXdQYXJlbnROb2RlID0gb2xkVmlldy52aXNp YmxlID8gb2xkVmlldy5lbGVtZW50LnBhcmVudE5vZGUgOiBudWxsOwotICAgICAgICB2YXIgc2Ny b2xsVG9wID0gb2xkVmlldy5zY3JvbGxUb3A7CisgICAgICAgIG5ld1ZpZXcuc3RvcmVTY3JvbGxQ b3NpdGlvbnNGcm9tVmlldyhvbGRWaWV3KTsKIAogICAgICAgICB0aGlzLl9zb3VyY2VWaWV3LmRl dGFjaCgpOwogICAgICAgICB0aGlzLl9zb3VyY2VWaWV3ID0gbmV3VmlldzsKIAogICAgICAgICBp ZiAob2xkVmlld1BhcmVudE5vZGUpCiAgICAgICAgICAgICBuZXdWaWV3LnNob3cob2xkVmlld1Bh cmVudE5vZGUpOwotICAgICAgICBpZiAoc2Nyb2xsVG9wKQotICAgICAgICAgICAgbmV3Vmlldy5z Y3JvbGxUb3AgPSBzY3JvbGxUb3A7CiAKICAgICAgICAgcmV0dXJuIG5ld1ZpZXc7CiAgICAgfSAg ICAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvU2NyaXB0 c1BhbmVsLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzUGFu ZWwuanMKaW5kZXggNjE2ZmRiOGI1NzI2MTA3NDgyZWE1NDE5M2E1ZDI0ZmZjMzM2MTE5ZS4uNjhk ODJiYjUyMGZiMThjMTk1Y2FkNjBjODYyYmVmNTg1ZGNlNTMzMCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzUGFuZWwuanMKKysrIGIvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHRzUGFuZWwuanMKQEAgLTY1Miw3ICs2 NTIsNyBAQCBXZWJJbnNwZWN0b3IuU2NyaXB0c1BhbmVsLnByb3RvdHlwZSA9IHsKICAgICAgICAg ICAgIHJldHVybjsKIAogICAgICAgICB2YXIgbmV3U291cmNlRnJhbWUgPSB0aGlzLl9jcmVhdGVT b3VyY2VGcmFtZShzb3VyY2VGaWxlSWQpCi0gICAgICAgIG5ld1NvdXJjZUZyYW1lLnNjcm9sbFRv cCA9IG9sZFNvdXJjZUZyYW1lLnNjcm9sbFRvcDsKKyAgICAgICAgbmV3U291cmNlRnJhbWUuc3Rv cmVTY3JvbGxQb3NpdGlvbnNGcm9tVmlldyhvbGRTb3VyY2VGcmFtZSk7CiAgICAgICAgIHRoaXMu dmlzaWJsZVZpZXcgPSBuZXdTb3VyY2VGcmFtZTsKICAgICB9LAogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1NvdXJjZUZyYW1lLmpzIGIvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9Tb3VyY2VGcmFtZS5qcwppbmRleCA0NzdjYWRhOWNh MzYyMjE5ZTliMzRiZjgxM2M1NDJmZmFiOGUwMjQ0Li4wMjg1NTYyNmQ1MDY4MTkwZDQ4MmRkMDEy ZWQ2M2Q4MDE3ZWVmZTU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL1NvdXJjZUZyYW1lLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9u dC1lbmQvU291cmNlRnJhbWUuanMKQEAgLTgzLDEzICs4Myw5IEBAIFdlYkluc3BlY3Rvci5Tb3Vy Y2VGcmFtZS5wcm90b3R5cGUgPSB7CiAgICAgICAgIFdlYkluc3BlY3Rvci5WaWV3LnByb3RvdHlw ZS5zaG93LmNhbGwodGhpcywgcGFyZW50RWxlbWVudCk7CiAKICAgICAgICAgdGhpcy5fZW5zdXJl Q29udGVudExvYWRlZCgpOworICAgICAgICAKKyAgICAgICAgdGhpcy5yZXN0b3JlU2Nyb2xsUG9z aXRpb25zKCk7CiAKLSAgICAgICAgaWYgKHRoaXMubG9hZGVkKSB7Ci0gICAgICAgICAgICBpZiAo dGhpcy5fc2Nyb2xsVG9wKQotICAgICAgICAgICAgICAgIHRoaXMuX3RleHRWaWV3ZXIuc2Nyb2xs VG9wID0gdGhpcy5fc2Nyb2xsVG9wOwotICAgICAgICAgICAgaWYgKHRoaXMuX3Njcm9sbExlZnQp Ci0gICAgICAgICAgICAgICAgdGhpcy5fdGV4dFZpZXdlci5zY3JvbGxMZWZ0ID0gdGhpcy5fc2Ny b2xsTGVmdDsKLSAgICAgICAgfQogICAgICAgICAvLyBSZXNpemUgYWZ0ZXIgc2V0dGluZyB0aGUg aW5pdGlhbCBzY3JvbGwgcG9zaXRpb25zIHRvIGF2b2lkIHVubmVjZXNzYXJ5IHJlbmRlcmluZyB3 b3JrLgogICAgICAgICB0aGlzLl90ZXh0Vmlld2VyLnJlc2l6ZSgpOwogICAgIH0sCkBAIC05OCwx MSArOTQsOCBAQCBXZWJJbnNwZWN0b3IuU291cmNlRnJhbWUucHJvdG90eXBlID0gewogICAgIHsK ICAgICAgICAgV2ViSW5zcGVjdG9yLlZpZXcucHJvdG90eXBlLmhpZGUuY2FsbCh0aGlzKTsKIAot ICAgICAgICBpZiAodGhpcy5sb2FkZWQpIHsKLSAgICAgICAgICAgIHRoaXMuX3Njcm9sbFRvcCA9 IHRoaXMuX3RleHRWaWV3ZXIuc2Nyb2xsVG9wOwotICAgICAgICAgICAgdGhpcy5fc2Nyb2xsTGVm dCA9IHRoaXMuX3RleHRWaWV3ZXIuc2Nyb2xsTGVmdDsKKyAgICAgICAgaWYgKHRoaXMubG9hZGVk KQogICAgICAgICAgICAgdGhpcy5fdGV4dFZpZXdlci5mcmVlQ2FjaGVkRWxlbWVudHMoKTsKLSAg ICAgICAgfQogCiAgICAgICAgIHRoaXMuX3RleHRWaWV3ZXIuaGlkZSgpOwogICAgICAgICB0aGlz Ll9oaWRlUG9wdXAoKTsKQEAgLTE2OCwxNCArMTYxLDI0IEBAIFdlYkluc3BlY3Rvci5Tb3VyY2VG cmFtZS5wcm90b3R5cGUgPSB7CiAgICAgICAgIHJldHVybiB0aGlzLl90ZXh0TW9kZWw7CiAgICAg fSwKIAorICAgIGdldCBzY3JvbGxMZWZ0KCkKKyAgICB7CisgICAgICAgIHJldHVybiB0aGlzLmxv YWRlZCA/IHRoaXMuX3RleHRWaWV3ZXIuc2Nyb2xsTGVmdCA6IDA7CisgICAgfSwKKworICAgIHNl dCBzY3JvbGxMZWZ0KHNjcm9sbExlZnQpCisgICAgeworICAgICAgICBpZiAodGhpcy5sb2FkZWQp CisgICAgICAgICAgICB0aGlzLl90ZXh0Vmlld2VyLnNjcm9sbExlZnQgPSBzY3JvbGxMZWZ0Owor ICAgIH0sCisKICAgICBnZXQgc2Nyb2xsVG9wKCkKICAgICB7Ci0gICAgICAgIHJldHVybiB0aGlz LmxvYWRlZCA/IHRoaXMuX3RleHRWaWV3ZXIuc2Nyb2xsVG9wIDogdGhpcy5fc2Nyb2xsVG9wOwor ICAgICAgICByZXR1cm4gdGhpcy5sb2FkZWQgPyB0aGlzLl90ZXh0Vmlld2VyLnNjcm9sbFRvcCA6 IDA7CiAgICAgfSwKIAogICAgIHNldCBzY3JvbGxUb3Aoc2Nyb2xsVG9wKQogICAgIHsKLSAgICAg ICAgdGhpcy5fc2Nyb2xsVG9wID0gc2Nyb2xsVG9wOwogICAgICAgICBpZiAodGhpcy5sb2FkZWQp CiAgICAgICAgICAgICB0aGlzLl90ZXh0Vmlld2VyLnNjcm9sbFRvcCA9IHNjcm9sbFRvcDsKICAg ICB9LApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9WaWV3 LmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9WaWV3LmpzCmluZGV4IGZi ZmE4ZmRjODg2ZTExYmFjODIzNWVkNmEzOTEzMGFkNjUxOWUxMTUuLjI1MTk5MjM3MTg2NjQ2MjBk ZTM1ZDExZDFlZGY5ZTAxZTE3YmIzY2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvVmlldy5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL1ZpZXcuanMKQEAgLTUwLDYgKzUwLDcgQEAgV2ViSW5zcGVjdG9yLlZpZXcucHJvdG90 eXBlID0gewogICAgIF9pbm5lclNob3c6IGZ1bmN0aW9uKCkKICAgICB7CiAgICAgICAgIHRoaXMu ZWxlbWVudC5hZGRTdHlsZUNsYXNzKCJ2aXNpYmxlIik7CisgICAgICAgIHRoaXMucmVzdG9yZVNj cm9sbFBvc2l0aW9ucygpOwogICAgIH0sCiAKICAgICBzaG93OiBmdW5jdGlvbihwYXJlbnRFbGVt ZW50KQpAQCAtNjYsNiArNjcsNyBAQCBXZWJJbnNwZWN0b3IuVmlldy5wcm90b3R5cGUgPSB7CiAK ICAgICBfaW5uZXJIaWRlOiBmdW5jdGlvbigpCiAgICAgeworICAgICAgICB0aGlzLnN0b3JlU2Ny b2xsUG9zaXRpb25zKCk7CiAgICAgICAgIHRoaXMuZWxlbWVudC5yZW1vdmVTdHlsZUNsYXNzKCJ2 aXNpYmxlIik7CiAgICAgfSwKIApAQCAtNzksNiArODEsMjQgQEAgV2ViSW5zcGVjdG9yLlZpZXcu cHJvdG90eXBlID0gewogICAgIHsKICAgICAgICAgaWYgKHRoaXMuZWxlbWVudC5wYXJlbnROb2Rl KQogICAgICAgICAgICAgdGhpcy5lbGVtZW50LnBhcmVudE5vZGUucmVtb3ZlQ2hpbGQodGhpcy5l bGVtZW50KTsKKyAgICB9LAorCisgICAgc3RvcmVTY3JvbGxQb3NpdGlvbnM6IGZ1bmN0aW9uKCkK KyAgICB7CisgICAgICAgIHRoaXMuX3Njcm9sbExlZnQgPSB0aGlzLnNjcm9sbExlZnQ7CisgICAg ICAgIHRoaXMuX3Njcm9sbFRvcCA9IHRoaXMuc2Nyb2xsVG9wOworICAgIH0sCisgICAgCisgICAg c3RvcmVTY3JvbGxQb3NpdGlvbnNGcm9tVmlldzogZnVuY3Rpb24odmlldykKKyAgICB7CisgICAg ICAgIHRoaXMuX3Njcm9sbExlZnQgPSB2aWV3Ll9zY3JvbGxMZWZ0OworICAgICAgICB0aGlzLl9z Y3JvbGxUb3AgPSB2aWV3Ll9zY3JvbGxUb3A7CisgICAgfSwKKworICAgIHJlc3RvcmVTY3JvbGxQ b3NpdGlvbnM6IGZ1bmN0aW9uKCkKKyAgICB7CisgICAgICAgIHRoaXMuc2Nyb2xsTGVmdCA9IHRo aXMuX3Njcm9sbExlZnQ7CisgICAgICAgIHRoaXMuc2Nyb2xsVG9wID0gdGhpcy5fc2Nyb2xsVG9w OwogICAgIH0KIH0KIAo=