65458 2011-08-01 02:49:27 -0700 REGRESSION(r92092): Build fails on 64 bit 2011-08-07 23:17:34 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P1 Blocker --- 65437 65840 1 ossy webkit-unassigned fpizlo ggaren oliver webkit.review.bot zherczeg oldest_to_newest 444614 0 ossy 2011-08-01 02:49:27 -0700 After r92092 the build fails on the 64 bit relase mode on Qt platform: cc1plus: warnings being treated as errors ../../../Source/JavaScriptCore/heap/Heap.h: In function ‘OpaqueJSContext* JSGlobalContextCreateInGroup(const OpaqueJSContextGroup*, OpaqueJSClass*)’: ../../../Source/JavaScriptCore/heap/Heap.h:319: error: array subscript is above array bounds ../../../Source/JavaScriptCore/heap/Heap.h:323: error: array subscript is above array bounds ../../../Source/JavaScriptCore/heap/Heap.h:319: error: array subscript is above array bounds ../../../Source/JavaScriptCore/heap/Heap.h:323: error: array subscript is above array bounds make[1]: *** [obj/release/JSContextRef.o] Error 1 444681 1 102514 zherczeg 2011-08-01 07:12:46 -0700 Created attachment 102514 preliminary patch This patch fixes the compile assert but it cause an infinite loop as it creates a block with cellSize 0. There is some hidden dependency between the blocks and values. Geoff, any idea? 444827 2 fpizlo 2011-08-01 13:24:16 -0700 (In reply to comment #1) > Created an attachment (id=102514) [details] > preliminary patch > > This patch fixes the compile assert but it cause an infinite loop as it creates a block with cellSize 0. There is some hidden dependency between the blocks and values. > > Geoff, any idea? The issue is with the logic in sizeClassFor(). The preciseCutoff is actually the smallest allocation size for imprecise size classes, rather than the upper bound on sizes for precise size classes. So for example in the current scheme, a 120 byte allocation should be allocated as 128 bytes, and so it should go to an imprecise size class. So the number of size classes is not wrong, but the selection algorithm is. I've got a patch for this and am testing it now... 444862 3 102556 fpizlo 2011-08-01 14:16:30 -0700 Created attachment 102556 the patch I believe that this is the more appropriate fix... 444909 4 102556 webkit.review.bot 2011-08-01 15:09:38 -0700 Comment on attachment 102556 the patch Clearing flags on attachment: 102556 Committed r92146: <http://trac.webkit.org/changeset/92146> 444910 5 webkit.review.bot 2011-08-01 15:09:43 -0700 All reviewed patches have been landed. Closing bug. 445161 6 zherczeg 2011-08-02 02:05:23 -0700 Hey Filip! Thank you for fixing this. Could you fix both comments as well: // [ 8, 16... 128 ) // [ 128, 256... 1024 ) (RS=me) 102514 2011-08-01 07:12:46 -0700 2011-08-01 07:12:46 -0700 preliminary patch 0001-heap.patch text/plain 2083 zherczeg RnJvbSBkODY0YmJkNDI1ZDFjZDJjZmRlZWY2Y2NhY2JmMTA5NjFiNTRhMzZhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBab2x0YW4gSGVyY3plZyA8emhlcmN6ZWdAaW5mLnUtc3plZ2Vk Lmh1PgpEYXRlOiBNb24sIDEgQXVnIDIwMTEgMDc6MDk6MTQgLTA3MDAKU3ViamVjdDogW1BBVENI XSBoZWFwCgotLS0KIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgICAgICAgfCAgIDEz ICsrKysrKysrKysrKysKIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL05ld1NwYWNlLmggfCAg ICA0ICsrLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBiYTE1NzNlLi5kOGRkZjdhIDEwMDY0NAot LS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMS0wOC0wMSAgWm9sdGFuIEhl cmN6ZWcgIDx6aGVyY3plZ0BpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgUkVHUkVTU0lPTihy OTIwOTIpOiBCdWlsZCBmYWlscyBvbiA2NCBiaXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTY1NDU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgcHJlY2lzZUNvdW50IGFuZCBpbXByZWNpc2VDb3VudCBzaG91 bGQgbm90IGJlIGRlY3JlYXNlZCBieSBvbmUuCisgICAgICAgIE9uIDY0IGJpdCwgd2hlcmUgcHJl Y2lzZVN0ZXAgaXMgMzIsIGFuZCBhIDEwMyBieXRlIGFyZWEgaXMKKyAgICAgICAgYWxsb2NhdGVk LCB0aGVyZSBpcyBubyBmb3VydGggaXRlbSBvZiB0aGUgYXJyYXkuCisKKyAgICAgICAgKiBoZWFw L05ld1NwYWNlLmg6CisKIDIwMTEtMDctMzEgIEdhdmluIEJhcnJhY2xvdWdoICA8YmFycmFjbG91 Z2hAYXBwbGUuY29tPgogCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD02NDY3OQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvTmV3 U3BhY2UuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9oZWFwL05ld1NwYWNlLmgKaW5kZXggNjJj OGY1Yi4uNDQ0ZTMzYyAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvTmV3 U3BhY2UuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9OZXdTcGFjZS5oCkBAIC04 MSwxMiArODEsMTIgQEAgbmFtZXNwYWNlIEpTQyB7CiAgICAgICAgIC8vIFsgOCwgMTYuLi4gMTI4 ICkKICAgICAgICAgc3RhdGljIGNvbnN0IHNpemVfdCBwcmVjaXNlU3RlcCA9IE1hcmtlZEJsb2Nr OjphdG9tU2l6ZTsKICAgICAgICAgc3RhdGljIGNvbnN0IHNpemVfdCBwcmVjaXNlQ3V0b2ZmID0g MTI4OwotICAgICAgICBzdGF0aWMgY29uc3Qgc2l6ZV90IHByZWNpc2VDb3VudCA9IHByZWNpc2VD dXRvZmYgLyBwcmVjaXNlU3RlcCAtIDE7CisgICAgICAgIHN0YXRpYyBjb25zdCBzaXplX3QgcHJl Y2lzZUNvdW50ID0gcHJlY2lzZUN1dG9mZiAvIHByZWNpc2VTdGVwOwogCiAgICAgICAgIC8vIFsg MTI4LCAyNTYuLi4gMTAyNCApCiAgICAgICAgIHN0YXRpYyBjb25zdCBzaXplX3QgaW1wcmVjaXNl U3RlcCA9IHByZWNpc2VDdXRvZmY7CiAgICAgICAgIHN0YXRpYyBjb25zdCBzaXplX3QgaW1wcmVj aXNlQ3V0b2ZmID0gbWF4Q2VsbFNpemU7Ci0gICAgICAgIHN0YXRpYyBjb25zdCBzaXplX3QgaW1w cmVjaXNlQ291bnQgPSBpbXByZWNpc2VDdXRvZmYgLyBpbXByZWNpc2VTdGVwIC0gMTsKKyAgICAg ICAgc3RhdGljIGNvbnN0IHNpemVfdCBpbXByZWNpc2VDb3VudCA9IGltcHJlY2lzZUN1dG9mZiAv IGltcHJlY2lzZVN0ZXA7CiAKICAgICAgICAgU2l6ZUNsYXNzIG1fcHJlY2lzZVNpemVDbGFzc2Vz W3ByZWNpc2VDb3VudF07CiAgICAgICAgIFNpemVDbGFzcyBtX2ltcHJlY2lzZVNpemVDbGFzc2Vz W2ltcHJlY2lzZUNvdW50XTsKLS0gCjEuNy4yLjMKCg== 102556 2011-08-01 14:16:30 -0700 2011-08-01 15:09:38 -0700 the patch fixsizeclass_patch_1.diff text/plain 2586 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTIxNDApCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjkgQEAK KzIwMTEtMDgtMDEgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBS RUdSRVNTSU9OKHI5MjA5Mik6IEJ1aWxkIGZhaWxzIG9uIDY0IGJpdAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjU0NTgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFRoZSBidWlsZCB3YXMgYnJv a2VuIGJlY2F1c2Ugc29tZSBjb21waWxlcnMgd2VyZSBzbWFydCBlbm91Z2ggdG8gc2VlCisgICAg ICAgIGFuIGFycmF5IGluZGV4IG91dCBvZiBib3VuZHMgZHVlIHRvIHRoZSBkZWNpc2lvbiBmdWN0 aW9uIGZvciB3aGVuIHRvCisgICAgICAgIGdvIGZyb20gcHJlY2lzZSBzaXplIGNsYXNzZXMgdG8g aW1wcmVjaXNlIHNpemUgY2xhc3NlcyBiZWluZyBicm9rZW46CisgICAgICAgIGl0IHdvdWxkIGFz c3VtZSB0aGF0IHNpemVzIGluIHRoZSByYW5nZSA5Ny4uMTI4IGJlbG9uZ2VkIHRvIGEgcHJlY2lz ZQorICAgICAgICBzaXplIGNsYXNzIHdoZW4gaW4gZmFjdCB0aGV5IGJlbG9uZ2VkIHRvIGFuIGlt cHJlY2lzZSBvbmUuCisgICAgICAgIAorICAgICAgICBJbiBmYWN0LCB0aGUgY29kZSB3b3VsZCBo YXZlIHJ1biBjb3JyZWN0bHksIGJ5IHdheSBvZiBhIGZsdWtlLCBiZWNhdXNlCisgICAgICAgIHRo b3VnaCB0aGUgNHRoIHByZWNpc2Ugc2l6ZSBjbGFzcyAoZm9yIDk3Li4xMjgpIGRpZG4ndCBleGlz dCwgdGhlIG5leHQKKyAgICAgICAgYXJyYXkgb3ZlciBmcm9tIG1fcHJlY2lzZVNpemVDbGFzc2Vz IHdhcyBtX2ltcHJlY2lzZVNpemVDbGFzc2VzLCBhbmQKKyAgICAgICAgaXRzIGZpcnN0IGVudHJ5 IHdvdWxkIGhhdmUgYmVlbiBhIHNpemUgY2xhc3MgdGhhdCBpcyBhcHByb3ByaWF0ZSBmb3IKKyAg ICAgICAgYWxsb2NhdGlvbnMgaW4gdGhlIHJhbmdlIDk3Li4xMjguICBIb3dldmVyLCB0aGlzIHJl bGllcyBvbiBzcGVjaWZpYworICAgICAgICBvcmRlcmluZyBvZiBmaWVsZHMgaW4gTmV3U3BhY2Us IHNvIGl0J3Mgc3RpbGwgYSBidWcuCisgICAgICAgIAorICAgICAgICBUaGlzIGZpeGVzIHRoZSBi dWcgYnkgZW5zdXJpbmcgdGhhdCBhbGxvY2F0aW9ucyBsYXJnZXIgdGhhbiA5NiB1c2UKKyAgICAg ICAgdGhlIGltcHJlY2lzZSBzaXplIGNsYXNzZXMuCisKKyAgICAgICAgKiBoZWFwL05ld1NwYWNl Lmg6CisgICAgICAgIChKU0M6Ok5ld1NwYWNlOjpzaXplQ2xhc3NGb3IpOgorCiAyMDExLTA3LTMx ICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdoQGFwcGxlLmNvbT4KIAogICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjQ2NzkKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9oZWFwL05ld1NwYWNlLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0ph dmFTY3JpcHRDb3JlL2hlYXAvTmV3U3BhY2UuaAkocmV2aXNpb24gOTIxMzYpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvaGVhcC9OZXdTcGFjZS5oCSh3b3JraW5nIGNvcHkpCkBAIC04MSw2ICs4 MSw3IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICAvLyBbIDgsIDE2Li4uIDEyOCApCiAgICAg ICAgIHN0YXRpYyBjb25zdCBzaXplX3QgcHJlY2lzZVN0ZXAgPSBNYXJrZWRCbG9jazo6YXRvbVNp emU7CiAgICAgICAgIHN0YXRpYyBjb25zdCBzaXplX3QgcHJlY2lzZUN1dG9mZiA9IDEyODsKKyAg ICAgICAgc3RhdGljIGNvbnN0IHNpemVfdCBtYXhpbXVtUHJlY2lzZUFsbG9jYXRpb25TaXplID0g cHJlY2lzZUN1dG9mZiAtIHByZWNpc2VTdGVwOwogICAgICAgICBzdGF0aWMgY29uc3Qgc2l6ZV90 IHByZWNpc2VDb3VudCA9IHByZWNpc2VDdXRvZmYgLyBwcmVjaXNlU3RlcCAtIDE7CiAKICAgICAg ICAgLy8gWyAxMjgsIDI1Ni4uLiAxMDI0ICkKQEAgLTExMyw3ICsxMTQsNyBAQCBuYW1lc3BhY2Ug SlNDIHsKICAgICBpbmxpbmUgTmV3U3BhY2U6OlNpemVDbGFzcyYgTmV3U3BhY2U6OnNpemVDbGFz c0ZvcihzaXplX3QgYnl0ZXMpCiAgICAgewogICAgICAgICBBU1NFUlQoYnl0ZXMgJiYgYnl0ZXMg PCBtYXhDZWxsU2l6ZSk7Ci0gICAgICAgIGlmIChieXRlcyA8IHByZWNpc2VDdXRvZmYpCisgICAg ICAgIGlmIChieXRlcyA8PSBtYXhpbXVtUHJlY2lzZUFsbG9jYXRpb25TaXplKQogICAgICAgICAg ICAgcmV0dXJuIG1fcHJlY2lzZVNpemVDbGFzc2VzWyhieXRlcyAtIDEpIC8gcHJlY2lzZVN0ZXBd OwogICAgICAgICByZXR1cm4gbV9pbXByZWNpc2VTaXplQ2xhc3Nlc1soYnl0ZXMgLSAxKSAvIGlt cHJlY2lzZVN0ZXBdOwogICAgIH0K