65436 2011-07-31 14:58:28 -0700 Use threadsafeCopy() API when using Database Directory path variable 2019-05-02 16:23:13 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 srikumar.b srikumar.b ap levin nagar28496 srikumar.b webkit.review.bot oldest_to_newest 444459 0 srikumar.b 2011-07-31 14:58:28 -0700 Use threadsafeCopy() while using m_databaseDirectoryPath in DatabaseTracker class 444466 1 102468 srikumar.b 2011-07-31 15:31:05 -0700 Created attachment 102468 patch file Attaching the patch file with the changes to use threadsafeCopy() API 444815 2 srikumar.b 2011-08-01 13:05:54 -0700 tracker database path(m_databaseDirectoryPath) is being used in multiple places. trackerDatabasePath() and deleteOrigin() APIs currently use the DB path without using threadsafeCopy() but these APIs can be called from multiple threads as this tracker DB path is common for all threads which use Database 444966 3 srikumar.b 2011-08-01 16:08:55 -0700 Kindly assign the bug to me if there are any comments in the review 444994 4 102468 levin 2011-08-01 16:54:20 -0700 Comment on attachment 102468 patch file View in context: https://bugs.webkit.org/attachment.cgi?id=102468&action=review > Source/WebCore/ChangeLog:8 > + Use threadsafeCopy() API when using m_databaseDirectoryPath string variable when the databaseGuard lock hasn't been taken > Source/WebCore/storage/DatabaseTracker.cpp:105 > + return SQLiteFileSystem::appendDatabaseFileNameToPath(m_databaseDirectoryPath.threadsafeCopy(), "Databases.db"); This one seems good. > Source/WebCore/storage/DatabaseTracker.cpp:820 > + SQLiteFileSystem::deleteEmptyDatabaseDirectory(m_databaseDirectoryPath.threadsafeCopy()); This seems unnecessary since the lock m_databaseGuard has been taken. 445031 5 102598 srikumar.b 2011-08-01 17:36:35 -0700 Created attachment 102598 revised patch with the comments from David Levin David, Thanks for the comments. I updated the patch with reference to your comments. 445039 6 102598 webkit.review.bot 2011-08-01 17:50:07 -0700 Comment on attachment 102598 revised patch with the comments from David Levin Clearing flags on attachment: 102598 Committed r92157: <http://trac.webkit.org/changeset/92157> 445040 7 webkit.review.bot 2011-08-01 17:50:11 -0700 All reviewed patches have been landed. Closing bug. 102468 2011-07-31 15:31:05 -0700 2011-08-01 16:54:20 -0700 patch file 65436.patch text/plain 2033 srikumar.b SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkyMDkwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTEtMDctMzEgIHNyaWt1bWFy IGJvbmRhICA8c3Jpa3VtYXIuYkBnbWFpbC5jb20+CisKKyAgICAgICAgVXNlIHRocmVhZHNhZmVD b3B5KCkgQVBJIHdoZW4gdXNpbmcgRGF0YWJhc2UgRGlyZWN0b3J5IHBhdGggdmFyaWFibGUgCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTQzNgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSB0aHJlYWRz YWZlQ29weSgpIEFQSSB3aGVuIHVzaW5nIG1fZGF0YWJhc2VEaXJlY3RvcnlQYXRoIHN0cmluZyB2 YXJpYWJsZQorICAgICAgICBpbiBEYXRhYmFzZVRyYWNrZXIgY2xhc3MuIFRoaXMgaXMganVzdCBh IHNhZmV0eSBmaXguCisKKyAgICAgICAgTm8gY2hhbmdlcyB0byBmdW5jdGlvbmFsaXR5IHNvIG5v IG5ldyB0ZXN0cy4KKworICAgICAgICAqIHN0b3JhZ2UvRGF0YWJhc2VUcmFja2VyLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkRhdGFiYXNlVHJhY2tlcjo6dHJhY2tlckRhdGFiYXNlUGF0aCk6Cisg ICAgICAgIChXZWJDb3JlOjpEYXRhYmFzZVRyYWNrZXI6OmRlbGV0ZU9yaWdpbik6CisKIDIwMTEt MDctMzEgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSRUdSRVNTSU9O OiBnZXRCb3VuZGluZ0NsaWVudFJlY3QoKSBtZXRob2Qgb2YgUmFuZ2UgaW5jb3JyZWN0bHkgcmV0 dXJucyBudWxsIGZvciBjb2xsYXBzZWQgUmFuZ2UKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3N0b3Jh Z2UvRGF0YWJhc2VUcmFja2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9zdG9y YWdlL0RhdGFiYXNlVHJhY2tlci5jcHAJKHJldmlzaW9uIDkyMDkwKQorKysgU291cmNlL1dlYkNv cmUvc3RvcmFnZS9EYXRhYmFzZVRyYWNrZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDIsNyAr MTAyLDcgQEAgU3RyaW5nIERhdGFiYXNlVHJhY2tlcjo6ZGF0YWJhc2VEaXJlY3RvcgogCiBTdHJp bmcgRGF0YWJhc2VUcmFja2VyOjp0cmFja2VyRGF0YWJhc2VQYXRoKCkgY29uc3QKIHsKLSAgICBy ZXR1cm4gU1FMaXRlRmlsZVN5c3RlbTo6YXBwZW5kRGF0YWJhc2VGaWxlTmFtZVRvUGF0aChtX2Rh dGFiYXNlRGlyZWN0b3J5UGF0aCwgIkRhdGFiYXNlcy5kYiIpOworICAgIHJldHVybiBTUUxpdGVG aWxlU3lzdGVtOjphcHBlbmREYXRhYmFzZUZpbGVOYW1lVG9QYXRoKG1fZGF0YWJhc2VEaXJlY3Rv cnlQYXRoLnRocmVhZHNhZmVDb3B5KCksICJEYXRhYmFzZXMuZGIiKTsKIH0KIAogdm9pZCBEYXRh YmFzZVRyYWNrZXI6Om9wZW5UcmFja2VyRGF0YWJhc2UoYm9vbCBjcmVhdGVJZkRvZXNOb3RFeGlz dCkKQEAgLTgxNyw3ICs4MTcsNyBAQCBib29sIERhdGFiYXNlVHJhY2tlcjo6ZGVsZXRlT3JpZ2lu KFNlY3VyCiAgICAgICAgICAgICBpZiAobV9kYXRhYmFzZS5pc09wZW4oKSkKICAgICAgICAgICAg ICAgICBtX2RhdGFiYXNlLmNsb3NlKCk7CiAgICAgICAgICAgIFNRTGl0ZUZpbGVTeXN0ZW06OmRl bGV0ZURhdGFiYXNlRmlsZSh0cmFja2VyRGF0YWJhc2VQYXRoKCkpOwotICAgICAgICAgICBTUUxp dGVGaWxlU3lzdGVtOjpkZWxldGVFbXB0eURhdGFiYXNlRGlyZWN0b3J5KG1fZGF0YWJhc2VEaXJl Y3RvcnlQYXRoKTsKKyAgICAgICAgICAgU1FMaXRlRmlsZVN5c3RlbTo6ZGVsZXRlRW1wdHlEYXRh YmFzZURpcmVjdG9yeShtX2RhdGFiYXNlRGlyZWN0b3J5UGF0aC50aHJlYWRzYWZlQ29weSgpKTsK ICAgICAgICAgfQogCiAgICAgICAgIGlmIChtX2NsaWVudCkgewo= 102598 2011-08-01 17:36:35 -0700 2011-08-01 17:50:07 -0700 revised patch with the comments from David Levin 65436.patch text/plain 1656 srikumar.b SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkyMDkwKQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDctMzEgIHNyaWt1bWFy IGJvbmRhICA8c3Jpa3VtYXIuYkBnbWFpbC5jb20+CisKKyAgICAgICAgVXNlIHRocmVhZHNhZmVD b3B5KCkgQVBJIHdoZW4gdXNpbmcgRGF0YWJhc2UgRGlyZWN0b3J5IHBhdGggdmFyaWFibGUgCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTQzNgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSB0aHJlYWRz YWZlQ29weSgpIEFQSSB3aGlsZSB1c2luZyBtX2RhdGFiYXNlRGlyZWN0b3J5UGF0aCBzdHJpbmcg dmFyaWFibGUKKyAgICAgICAgd2hlbiB0aGUgZGF0YWJhc2VHdWFyZCBsb2NrIGhhc24ndCBiZWVu IHRha2VuIGluIERhdGFiYXNlVHJhY2tlciBjbGFzcy4gCisgICAgICAgIFRoaXMgaXMganVzdCBh IHNhZmV0eSBmaXguCisKKyAgICAgICAgTm8gY2hhbmdlcyB0byBmdW5jdGlvbmFsaXR5IHNvIG5v IG5ldyB0ZXN0cy4KKworICAgICAgICAqIHN0b3JhZ2UvRGF0YWJhc2VUcmFja2VyLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkRhdGFiYXNlVHJhY2tlcjo6dHJhY2tlckRhdGFiYXNlUGF0aCk6Cisg ICAgICAgIChXZWJDb3JlOjpEYXRhYmFzZVRyYWNrZXI6OmRlbGV0ZU9yaWdpbik6CisKIDIwMTEt MDctMzEgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSRUdSRVNTSU9O OiBnZXRCb3VuZGluZ0NsaWVudFJlY3QoKSBtZXRob2Qgb2YgUmFuZ2UgaW5jb3JyZWN0bHkgcmV0 dXJucyBudWxsIGZvciBjb2xsYXBzZWQgUmFuZ2UKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3N0b3Jh Z2UvRGF0YWJhc2VUcmFja2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9zdG9y YWdlL0RhdGFiYXNlVHJhY2tlci5jcHAJKHJldmlzaW9uIDkyMDkwKQorKysgU291cmNlL1dlYkNv cmUvc3RvcmFnZS9EYXRhYmFzZVRyYWNrZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDIsNyAr MTAyLDcgQEAgU3RyaW5nIERhdGFiYXNlVHJhY2tlcjo6ZGF0YWJhc2VEaXJlY3RvcgogCiBTdHJp bmcgRGF0YWJhc2VUcmFja2VyOjp0cmFja2VyRGF0YWJhc2VQYXRoKCkgY29uc3QKIHsKLSAgICBy ZXR1cm4gU1FMaXRlRmlsZVN5c3RlbTo6YXBwZW5kRGF0YWJhc2VGaWxlTmFtZVRvUGF0aChtX2Rh dGFiYXNlRGlyZWN0b3J5UGF0aCwgIkRhdGFiYXNlcy5kYiIpOworICAgIHJldHVybiBTUUxpdGVG aWxlU3lzdGVtOjphcHBlbmREYXRhYmFzZUZpbGVOYW1lVG9QYXRoKG1fZGF0YWJhc2VEaXJlY3Rv cnlQYXRoLnRocmVhZHNhZmVDb3B5KCksICJEYXRhYmFzZXMuZGIiKTsKIH0KIAogdm9pZCBEYXRh YmFzZVRyYWNrZXI6Om9wZW5UcmFja2VyRGF0YWJhc2UoYm9vbCBjcmVhdGVJZkRvZXNOb3RFeGlz dCkK