65427 2011-07-31 00:13:43 -0700 [GTK] Remove unused variable coreChild in WebCore::getChildForTable() 2011-07-31 01:49:15 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 dbates dbates mrobinson webkit.review.bot xan.lopez oldest_to_newest 444399 0 dbates 2011-07-31 00:13:43 -0700 I noticed the following compile warning in the output for the GTK Linux 32-bit Release build: ../../Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp: In function ‘WebCore::AccessibilityObject* getChildForTable(WebCore::AccessibilityObject*, gint)’: ../../Source/WebCore/accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:351:26: warning: unused variable ‘coreChild’ [-Wunused-variable] 444400 1 dbates 2011-07-31 00:20:29 -0700 For completeness, this variable was unused at the time it was added in <http://trac.webkit.org/changeset/89660> (https://bugs.webkit.org/show_bug.cgi?id=62718). As of today it is unused. 444401 2 102457 dbates 2011-07-31 00:23:44 -0700 Created attachment 102457 Patch 444402 3 102457 xan.lopez 2011-07-31 00:24:46 -0700 Comment on attachment 102457 Patch r=me 444410 4 102457 webkit.review.bot 2011-07-31 01:49:10 -0700 Comment on attachment 102457 Patch Clearing flags on attachment: 102457 Committed r92082: <http://trac.webkit.org/changeset/92082> 444411 5 webkit.review.bot 2011-07-31 01:49:15 -0700 All reviewed patches have been landed. Closing bug. 102457 2011-07-31 00:23:44 -0700 2011-07-31 01:49:10 -0700 Patch bug-65427-20110731002343.patch text/plain 1589 dbates SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkyMDc2KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDctMzEgIERhbmllbCBC YXRlcyAgPGRiYXRlc0B3ZWJraXQub3JnPgorCisgICAgICAgIFtHVEtdIFJlbW92ZSB1bnVzZWQg dmFyaWFibGUgY29yZUNoaWxkIGluIFdlYkNvcmU6OmdldENoaWxkRm9yVGFibGUoKQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjU0MjcKKworICAgICAg ICBUaGlzIHZhcmlhYmxlIHdhcyB1bnVzZWQgd2hlbiBpdCB3YXMgaW5pdGlhbGx5IGFkZGVkIGlu IDxodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC84OTY2MD4gKGJ1ZyAjNjI3MTgpCisg ICAgICAgIGFuZCBpdCBpcyB1bnVzZWQgdG9kYXkuIFdlIHNob3VsZCByZW1vdmUgaXQuIFRoaXMg d2lsbCBhbHNvIHJlc29sdmUgYSBjb21waWxlciB3YXJuaW5nLgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9ndGsvQWNjZXNz aWJpbGl0eU9iamVjdFdyYXBwZXJBdGsuY3BwOgorICAgICAgICAoZ2V0Q2hpbGRGb3JUYWJsZSk6 CisKIDIwMTEtMDctMzAgIERhbmllbCBCYXRlcyAgPGRiYXRlc0B3ZWJraXQub3JnPgogCiAgICAg ICAgIEZpeCB0aGUgV2luQ2Fpcm8gRGVidWcgYnVpbGQgYWZ0ZXIgPGh0dHA6Ly90cmFjLndlYmtp dC5vcmcvY2hhbmdlc2V0LzkxOTE0PgpJbmRleDogU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9ndGsvQWNjZXNzaWJpbGl0eU9iamVjdFdyYXBwZXJBdGsuY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvZ3RrL0FjY2Vzc2liaWxpdHlPYmplY3RXcmFwcGVy QXRrLmNwcAkocmV2aXNpb24gOTIwNzEpCisrKyBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5 L2d0ay9BY2Nlc3NpYmlsaXR5T2JqZWN0V3JhcHBlckF0ay5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTM0OCw3ICszNDgsNiBAQCBzdGF0aWMgQWNjZXNzaWJpbGl0eU9iamVjdCogZ2V0Q2hpbGRGb3JU CiAgICAgQWNjZXNzaWJpbGl0eU9iamVjdDo6QWNjZXNzaWJpbGl0eUNoaWxkcmVuVmVjdG9yIHRh YmxlQ2hpbGRyZW4gPSBjb3JlT2JqZWN0LT5jaGlsZHJlbigpOwogICAgIHNpemVfdCB0YWJsZUNo aWxkcmVuQ291bnQgPSB0YWJsZUNoaWxkcmVuLnNpemUoKTsKICAgICBzaXplX3QgY2VsbHNDb3Vu dCA9IDA7Ci0gICAgQWNjZXNzaWJpbGl0eU9iamVjdCogY29yZUNoaWxkID0gMDsKIAogICAgIC8v IExvb2sgZm9yIHRoZSBhY3R1YWwgaW5kZXggb2YgdGhlIGNlbGwgaW5zaWRlIHRoZSB0YWJsZS4K ICAgICBzaXplX3QgY3VycmVudCA9IHN0YXRpY19jYXN0PHNpemVfdD4oaW5kZXgpOwo=