65426 2011-07-30 23:13:28 -0700 GTK build bots compile failure - undefined reference (missing symbols) 2011-07-31 02:03:22 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk, MakingBotsRed P2 Normal --- 1 dbates webkit-unassigned mitz mrobinson xan.lopez oldest_to_newest 444387 0 dbates 2011-07-30 23:13:28 -0700 Since <http://trac.webkit.org/changeset/92059> (bug #65419) the GTK build bots have failed to compile with the following error: ../../Source/WebCore/platform/graphics/GlyphBuffer.h:47:19: fatal error: cairo.h: No such file or directory (http://build.webkit.org/builders/GTK%20Linux%2032-bit%20Release/builds/16060/steps/compile-webkit/logs/stdio) GTK 32 Debug: http://build.webkit.org/builders/GTK%20Linux%2032-bit%20Debug/builds/16617/steps/compile-webkit/logs/stdio GTK 64 Debug: http://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug/builds/24716/steps/compile-webkit/logs/stdio Notice the GTK 32 Debug and GTK 64 Debug stdio ouput also lists other errors related to missing definitions for cairo types. 444393 1 mitz 2011-07-30 23:31:02 -0700 This suggests that the build configuration for libWebCoreInternals is incomplete. 444403 2 dbates 2011-07-31 00:29:24 -0700 I committed a build fix in <http://trac.webkit.org/changeset/92076>, which resolves the missing cairo.h file. Now I get the following unresolved symbol errors: [[ /usr/bin/ld: ./.libs/libWebCoreInternals.a(libWebCoreInternals_la-JSInternals.o): in function WebCore::jsInternalsPrototypeFunctionBoundingBox(JSC::ExecState*):DerivedSources/WebCore/JSInternals.cpp:310: error: undefined reference to 'WebCore::toJS(JSC::ExecState*, WebCore::JSDOMGlobalObject*, WebCore::ClientRect*)' /usr/bin/ld: ./.libs/libWebCoreInternals.a(libWebCoreInternals_la-Internals.o): in function WebCore::Internals::boundingBox(WebCore::Element*, int&):../../Source/WebCore/testing/Internals.cpp:159: error: undefined reference to 'WebCore::Document::updateLayoutIgnorePendingStylesheets()' /usr/bin/ld: ./.libs/libWebCoreInternals.a(libWebCoreInternals_la-Internals.o): in function WebCore::Internals::boundingBox(WebCore::Element*, int&):../../Source/WebCore/testing/Internals.cpp:163: error: undefined reference to 'WebCore::RenderObject::absoluteBoundingBoxRect(bool)' /usr/bin/ld: ./.libs/libWebCoreInternals.a(libWebCoreInternals_la-Internals.o): in function WebCore::ClientRect::create():../../Source/WebCore/dom/ClientRect.h:40: error: undefined reference to 'WebCore::ClientRect::ClientRect()' /usr/bin/ld: ./.libs/libWebCoreInternals.a(libWebCoreInternals_la-Internals.o): in function WebCore::ClientRect::create(WebCore::IntRect const&):../../Source/WebCore/dom/ClientRect.h:41: error: undefined reference to 'WebCore::ClientRect::ClientRect(WebCore::IntRect const&)' collect2: ld returned 1 exit status ]] (http://build.webkit.org/builders/GTK%20Linux%2032-bit%20Debug/builds/16626/steps/compile-webkit/logs/stdio) I believe we need to export these symbols in the GTK build. I haven't taken a look where to do this yet. Maybe someone can save me some time with some insight/suggestions? 444404 3 xan.lopez 2011-07-31 00:37:26 -0700 I believe it has to be done in Source/autotools/symbols.filter, but that seems a lot of new stuff, not sure why is it suddenly needed. I have to go now, if you cannot figure it out easily I think you should just rollout. 444405 4 xan.lopez 2011-07-31 00:39:09 -0700 Oh duh, I was checking the wrong commit for the culprits here. You point out the right one in comment #0, makes sense now. 444409 5 dbates 2011-07-31 01:46:04 -0700 (In reply to comment #3) > I believe it has to be done in Source/autotools/symbols.filter, but that seems a lot of new stuff, not sure why is it suddenly needed. I added the missing symbols to symbols.filter in <http://trac.webkit.org/changeset/92080> and <http://trac.webkit.org/changeset/92081> (syntax correction for r92080) but the GTK bots are still failing :( 444412 6 dbates 2011-07-31 02:03:22 -0700 (In reply to comment #5) > (In reply to comment #3) > > I believe it has to be done in Source/autotools/symbols.filter, but that seems a lot of new stuff, not sure why is it suddenly needed. > > I added the missing symbols to symbols.filter in <http://trac.webkit.org/changeset/92080> and <http://trac.webkit.org/changeset/92081> (syntax correction for r92080) but the GTK bots are still failing :( The bots just needed to be poked so as to relink. The poke came in the form of <http://trac.webkit.org/changeset/92082>.