65389 2011-07-29 14:03:54 -0700 DFG JIT verbose mode provides no details about predictions 2011-07-29 19:00:55 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo webkit-unassigned barraclough fpizlo webkit.review.bot oldest_to_newest 444082 0 fpizlo 2011-07-29 14:03:54 -0700 One tool that the DFG JIT provides for debugging the JIT itself is verbose mode, which results in an IR dump of the procedure being compiled. But this IR dump does not print any information about predictions. 444088 1 102394 fpizlo 2011-07-29 14:07:39 -0700 Created attachment 102394 the patch 444090 2 webkit.review.bot 2011-07-29 14:10:37 -0700 Attachment 102394 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/dfg/DFGGraph.cpp:138: Missing space after , [whitespace/comma] [3] Source/JavaScriptCore/dfg/DFGGraph.cpp:139: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 444099 3 102396 fpizlo 2011-07-29 14:18:26 -0700 Created attachment 102396 the patch (fix style, passes tests) 444113 4 102396 barraclough 2011-07-29 14:35:27 -0700 Comment on attachment 102396 the patch (fix style, passes tests) Sorry to be a pain, but (1) this should be ndef NDEBUG only code. If you find this useful to have in a header to be able to use easily when debugging, then I'd wrap in #ifndef NDEBUG, but you could also consider moving to the NDEBUG section of the .cpp & marking as static. Also, code on the same lines as labels doesn't match the coding style, there should really be newlines in here. 444126 5 102401 fpizlo 2011-07-29 15:02:29 -0700 Created attachment 102401 the patch (fix review) 444226 6 102401 webkit.review.bot 2011-07-29 19:00:51 -0700 Comment on attachment 102401 the patch (fix review) Clearing flags on attachment: 102401 Committed r92038: <http://trac.webkit.org/changeset/92038> 444227 7 webkit.review.bot 2011-07-29 19:00:55 -0700 All reviewed patches have been landed. Closing bug. 102394 2011-07-29 14:07:39 -0700 2011-07-29 14:18:26 -0700 the patch betterverbose_patch_1.diff text/plain 2347 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTIwMDUpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAK KzIwMTEtMDctMjkgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBE RkcgSklUIHZlcmJvc2UgbW9kZSBwcm92aWRlcyBubyBkZXRhaWxzIGFib3V0IHByZWRpY3Rpb25z CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTM4OQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAg QWRkZWQgYSBwcmludC1vdXQgb2YgdGhlIHByZWRpY3Rpb25zIHRvIHRoZSBJUiBkdW1wLCB3aXRo IG5hbWVzIGFzIGZvbGxvd3M6CisgICAgICAgICJwLWJvdHRvbSIgPSB0aGUgcGFyc2VyIG1hZGUg bm8gcHJlZGljdGlvbnMKKyAgICAgICAgInAtaW50MzIiID0gdGhlIHBhcnNlciBwcmVkaWN0ZWQg aW50MzIKKyAgICAgICAgLi4uIChzYW1lIGZvciBhcnJheSwgY2VsbCwgZG91YmxlLCBudW1iZXIp CisgICAgICAgICJwLXRvcCIgPSB0aGUgcGFyc2VyIG1hZGUgY29uZmxpY3RpbmcgcHJlZGljdGlv bnMgd2hpY2ggd2lsbCBiZSBpZ25vcmVkLgorCisgICAgICAgICogZGZnL0RGR0dyYXBoLmNwcDoK KyAgICAgICAgKEpTQzo6REZHOjpHcmFwaDo6ZHVtcCk6CisgICAgICAgICogZGZnL0RGR0dyYXBo Lmg6CisgICAgICAgIChKU0M6OkRGRzo6cHJlZGljdGlvblRvU3RyaW5nKToKKwogMjAxMS0wNy0y OCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgICpfbGlzdCBpbnN0 cnVjdGlvbnMgYXJlIG9ubHkgdXNlZCBpbiBvbmUgcGxhY2UsIHdoZXJlIHRoZSBjb2RlIGlzIHdy b25nLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5jcHAJKHJldmlzaW9u IDkyMDAzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTEzMiw3ICsxMzIsMTMgQEAgdm9pZCBHcmFwaDo6ZHVtcChOb2RlSW5kZXgg bm9kZUluZGV4LCBDbwogICAgICAgICBoYXNQcmludGVkID0gdHJ1ZTsKICAgICB9CiAKLSAgICBw cmludGYoIilcbiIpOworICAgIHByaW50ZigiKSIpOworICAgIAorICAgIGlmIChub2RlLmhhc0xv Y2FsKCkpIHsKKyAgICAgICAgcHJpbnRmKCIgIHByZWRpY3RpbmcgJXMiLHByZWRpY3Rpb25Ub1N0 cmluZyhnZXRQcmVkaWN0aW9uKG5vZGUubG9jYWwoKSkpKTsKKyAgICB9CisgICAgCisgICAgcHJp bnRmKCJcbiIpOwogfQogCiB2b2lkIEdyYXBoOjpkdW1wKENvZGVCbG9jayogY29kZUJsb2NrKQpJ bmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5oCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHR3JhcGguaAkocmV2aXNpb24gOTIwMDMpCisr KyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0dyYXBoLmgJKHdvcmtpbmcgY29weSkKQEAg LTc2LDYgKzc2LDE4IEBAIGlubGluZSBib29sIGlzTnVtYmVyUHJlZGljdGlvbihQcmVkaWN0ZWQK ICAgICByZXR1cm4gISEodmFsdWUgJiBQcmVkaWN0TnVtYmVyKSAmJiAhKHZhbHVlICYgflByZWRp Y3ROdW1iZXIpOwogfQogCitpbmxpbmUgY29uc3QgY2hhciogcHJlZGljdGlvblRvU3RyaW5nKFBy ZWRpY3RlZFR5cGUgdmFsdWUpCit7CisgICAgc3dpdGNoICh2YWx1ZSkgeworICAgIGNhc2UgUHJl ZGljdE5vbmU6IHJldHVybiAicC1ib3R0b20iOworICAgIGNhc2UgUHJlZGljdENlbGw6IHJldHVy biAicC1jZWxsIjsKKyAgICBjYXNlIFByZWRpY3RBcnJheTogcmV0dXJuICJwLWFycmF5IjsKKyAg ICBjYXNlIFByZWRpY3RJbnQzMjogcmV0dXJuICJwLWludDMyIjsKKyAgICBjYXNlIFByZWRpY3RO dW1iZXI6IHJldHVybiAicC1udW1iZXIiOworICAgIGRlZmF1bHQ6IHJldHVybiAicC10b3AiOwor ICAgIH0KK30KKwogc3RydWN0IFByZWRpY3Rpb25TbG90IHsKIHB1YmxpYzoKICAgICBQcmVkaWN0 aW9uU2xvdCgpCg== 102396 2011-07-29 14:18:26 -0700 2011-07-29 15:02:29 -0700 the patch (fix style, passes tests) betterverbose_patch_2.diff text/plain 2339 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTIwMDUpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAK KzIwMTEtMDctMjkgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBE RkcgSklUIHZlcmJvc2UgbW9kZSBwcm92aWRlcyBubyBkZXRhaWxzIGFib3V0IHByZWRpY3Rpb25z CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTM4OQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAg QWRkZWQgYSBwcmludC1vdXQgb2YgdGhlIHByZWRpY3Rpb25zIHRvIHRoZSBJUiBkdW1wLCB3aXRo IG5hbWVzIGFzIGZvbGxvd3M6CisgICAgICAgICJwLWJvdHRvbSIgPSB0aGUgcGFyc2VyIG1hZGUg bm8gcHJlZGljdGlvbnMKKyAgICAgICAgInAtaW50MzIiID0gdGhlIHBhcnNlciBwcmVkaWN0ZWQg aW50MzIKKyAgICAgICAgLi4uIChzYW1lIGZvciBhcnJheSwgY2VsbCwgZG91YmxlLCBudW1iZXIp CisgICAgICAgICJwLXRvcCIgPSB0aGUgcGFyc2VyIG1hZGUgY29uZmxpY3RpbmcgcHJlZGljdGlv bnMgd2hpY2ggd2lsbCBiZSBpZ25vcmVkLgorCisgICAgICAgICogZGZnL0RGR0dyYXBoLmNwcDoK KyAgICAgICAgKEpTQzo6REZHOjpHcmFwaDo6ZHVtcCk6CisgICAgICAgICogZGZnL0RGR0dyYXBo Lmg6CisgICAgICAgIChKU0M6OkRGRzo6cHJlZGljdGlvblRvU3RyaW5nKToKKwogMjAxMS0wNy0y OCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgICpfbGlzdCBpbnN0 cnVjdGlvbnMgYXJlIG9ubHkgdXNlZCBpbiBvbmUgcGxhY2UsIHdoZXJlIHRoZSBjb2RlIGlzIHdy b25nLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5jcHAJKHJldmlzaW9u IDkyMDAzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTEzMiw3ICsxMzIsMTIgQEAgdm9pZCBHcmFwaDo6ZHVtcChOb2RlSW5kZXgg bm9kZUluZGV4LCBDbwogICAgICAgICBoYXNQcmludGVkID0gdHJ1ZTsKICAgICB9CiAKLSAgICBw cmludGYoIilcbiIpOworICAgIHByaW50ZigiKSIpOworICAgIAorICAgIGlmIChub2RlLmhhc0xv Y2FsKCkpCisgICAgICAgIHByaW50ZigiICBwcmVkaWN0aW5nICVzIiwgcHJlZGljdGlvblRvU3Ry aW5nKGdldFByZWRpY3Rpb24obm9kZS5sb2NhbCgpKSkpOworICAgIAorICAgIHByaW50ZigiXG4i KTsKIH0KIAogdm9pZCBHcmFwaDo6ZHVtcChDb2RlQmxvY2sqIGNvZGVCbG9jaykKSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHR3JhcGguaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGZnL0RGR0dyYXBoLmgJKHJldmlzaW9uIDkyMDAzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5oCSh3b3JraW5nIGNvcHkpCkBAIC03Niw2ICs3 NiwxOCBAQCBpbmxpbmUgYm9vbCBpc051bWJlclByZWRpY3Rpb24oUHJlZGljdGVkCiAgICAgcmV0 dXJuICEhKHZhbHVlICYgUHJlZGljdE51bWJlcikgJiYgISh2YWx1ZSAmIH5QcmVkaWN0TnVtYmVy KTsKIH0KIAoraW5saW5lIGNvbnN0IGNoYXIqIHByZWRpY3Rpb25Ub1N0cmluZyhQcmVkaWN0ZWRU eXBlIHZhbHVlKQoreworICAgIHN3aXRjaCAodmFsdWUpIHsKKyAgICBjYXNlIFByZWRpY3ROb25l OiByZXR1cm4gInAtYm90dG9tIjsKKyAgICBjYXNlIFByZWRpY3RDZWxsOiByZXR1cm4gInAtY2Vs bCI7CisgICAgY2FzZSBQcmVkaWN0QXJyYXk6IHJldHVybiAicC1hcnJheSI7CisgICAgY2FzZSBQ cmVkaWN0SW50MzI6IHJldHVybiAicC1pbnQzMiI7CisgICAgY2FzZSBQcmVkaWN0TnVtYmVyOiBy ZXR1cm4gInAtbnVtYmVyIjsKKyAgICBkZWZhdWx0OiByZXR1cm4gInAtdG9wIjsKKyAgICB9Cit9 CisKIHN0cnVjdCBQcmVkaWN0aW9uU2xvdCB7CiBwdWJsaWM6CiAgICAgUHJlZGljdGlvblNsb3Qo KQo= 102401 2011-07-29 15:02:29 -0700 2011-07-29 19:00:51 -0700 the patch (fix review) betterverbose_patch_3.diff text/plain 2417 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gOTIwMDUpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjEgQEAK KzIwMTEtMDctMjkgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KKworICAgICAgICBE RkcgSklUIHZlcmJvc2UgbW9kZSBwcm92aWRlcyBubyBkZXRhaWxzIGFib3V0IHByZWRpY3Rpb25z CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTM4OQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAg QWRkZWQgYSBwcmludC1vdXQgb2YgdGhlIHByZWRpY3Rpb25zIHRvIHRoZSBJUiBkdW1wLCB3aXRo IG5hbWVzIGFzIGZvbGxvd3M6CisgICAgICAgICJwLWJvdHRvbSIgPSB0aGUgcGFyc2VyIG1hZGUg bm8gcHJlZGljdGlvbnMKKyAgICAgICAgInAtaW50MzIiID0gdGhlIHBhcnNlciBwcmVkaWN0ZWQg aW50MzIKKyAgICAgICAgLi4uIChzYW1lIGZvciBhcnJheSwgY2VsbCwgZG91YmxlLCBudW1iZXIp CisgICAgICAgICJwLXRvcCIgPSB0aGUgcGFyc2VyIG1hZGUgY29uZmxpY3RpbmcgcHJlZGljdGlv bnMgd2hpY2ggd2lsbCBiZSBpZ25vcmVkLgorCisgICAgICAgICogZGZnL0RGR0dyYXBoLmNwcDoK KyAgICAgICAgKEpTQzo6REZHOjpHcmFwaDo6ZHVtcCk6CisgICAgICAgICogZGZnL0RGR0dyYXBo Lmg6CisgICAgICAgIChKU0M6OkRGRzo6cHJlZGljdGlvblRvU3RyaW5nKToKKwogMjAxMS0wNy0y OCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgICpfbGlzdCBpbnN0 cnVjdGlvbnMgYXJlIG9ubHkgdXNlZCBpbiBvbmUgcGxhY2UsIHdoZXJlIHRoZSBjb2RlIGlzIHdy b25nLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5jcHAJKHJldmlzaW9u IDkyMDAzKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTEzMiw3ICsxMzIsMTIgQEAgdm9pZCBHcmFwaDo6ZHVtcChOb2RlSW5kZXgg bm9kZUluZGV4LCBDbwogICAgICAgICBoYXNQcmludGVkID0gdHJ1ZTsKICAgICB9CiAKLSAgICBw cmludGYoIilcbiIpOworICAgIHByaW50ZigiKSIpOworICAgIAorICAgIGlmIChub2RlLmhhc0xv Y2FsKCkpCisgICAgICAgIHByaW50ZigiICBwcmVkaWN0aW5nICVzIiwgcHJlZGljdGlvblRvU3Ry aW5nKGdldFByZWRpY3Rpb24obm9kZS5sb2NhbCgpKSkpOworICAgIAorICAgIHByaW50ZigiXG4i KTsKIH0KIAogdm9pZCBHcmFwaDo6ZHVtcChDb2RlQmxvY2sqIGNvZGVCbG9jaykKSW5kZXg6IFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHR3JhcGguaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvZGZnL0RGR0dyYXBoLmgJKHJldmlzaW9uIDkyMDAzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL2RmZy9ERkdHcmFwaC5oCSh3b3JraW5nIGNvcHkpCkBAIC03Niw2ICs3 NiwyNiBAQCBpbmxpbmUgYm9vbCBpc051bWJlclByZWRpY3Rpb24oUHJlZGljdGVkCiAgICAgcmV0 dXJuICEhKHZhbHVlICYgUHJlZGljdE51bWJlcikgJiYgISh2YWx1ZSAmIH5QcmVkaWN0TnVtYmVy KTsKIH0KIAorI2lmbmRlZiBOREVCVUcKK2lubGluZSBjb25zdCBjaGFyKiBwcmVkaWN0aW9uVG9T dHJpbmcoUHJlZGljdGVkVHlwZSB2YWx1ZSkKK3sKKyAgICBzd2l0Y2ggKHZhbHVlKSB7CisgICAg Y2FzZSBQcmVkaWN0Tm9uZToKKyAgICAgICAgcmV0dXJuICJwLWJvdHRvbSI7CisgICAgY2FzZSBQ cmVkaWN0Q2VsbDoKKyAgICAgICAgcmV0dXJuICJwLWNlbGwiOworICAgIGNhc2UgUHJlZGljdEFy cmF5OgorICAgICAgICByZXR1cm4gInAtYXJyYXkiOworICAgIGNhc2UgUHJlZGljdEludDMyOgor ICAgICAgICByZXR1cm4gInAtaW50MzIiOworICAgIGNhc2UgUHJlZGljdE51bWJlcjoKKyAgICAg ICAgcmV0dXJuICJwLW51bWJlciI7CisgICAgZGVmYXVsdDoKKyAgICAgICAgcmV0dXJuICJwLXRv cCI7CisgICAgfQorfQorI2VuZGlmCisKIHN0cnVjdCBQcmVkaWN0aW9uU2xvdCB7CiBwdWJsaWM6 CiAgICAgUHJlZGljdGlvblNsb3QoKQo=