<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>65375</bug_id>
          
          <creation_ts>2011-07-29 07:19:10 -0700</creation_ts>
          <short_desc>Style checker should flag usage of &apos;unsigned int&apos;</short_desc>
          <delta_ts>2014-03-21 06:17:32 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>DUPLICATE</resolution>
          <dup_id>96693</dup_id>
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Mihnea Ovidenie">mihnea</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ap</cc>
    
    <cc>jchaffraix</cc>
    
    <cc>levin</cc>
    
    <cc>llango.u-szeged</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>443933</commentid>
    <comment_count>0</comment_count>
    <who name="Mihnea Ovidenie">mihnea</who>
    <bug_when>2011-07-29 07:19:10 -0700</bug_when>
    <thetext>Style checker should report the occurrences of &apos;unsigned int&apos;. Instead of &apos;unsigned int&apos; we should use only &apos;unsigned&apos;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>443987</commentid>
    <comment_count>1</comment_count>
    <who name="Alexey Proskuryakov">ap</who>
    <bug_when>2011-07-29 10:33:52 -0700</bug_when>
    <thetext>A patch in bug 65176 prompted this bug report.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>443993</commentid>
    <comment_count>2</comment_count>
    <who name="David Levin">levin</who>
    <bug_when>2011-07-29 10:40:08 -0700</bug_when>
    <thetext>For anyone interested, I&apos;m happy to coach people on how to add rules to the style checker :).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>444415</commentid>
    <comment_count>3</comment_count>
    <who name="Mihnea Ovidenie">mihnea</who>
    <bug_when>2011-07-31 07:16:16 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; For anyone interested, I&apos;m happy to coach people on how to add rules to the style checker :).

I am interested to learn about style checker and tools, i&apos;ll catch you on #webkit.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>505294</commentid>
    <comment_count>4</comment_count>
    <who name="Julien Chaffraix">jchaffraix</who>
    <bug_when>2011-11-17 15:36:39 -0800</bug_when>
    <thetext>FYI, I did some very simple grepping to see our usage. Here are the results for Source/WebCore/

$ grep -R &quot;unsigned &quot; .|grep -v &quot;unsigned short&quot;|grep -v &quot;unsigned int&quot;|grep -v &quot;unsigned char&quot;|grep -v &quot;unsigned long&quot;|grep -v ChangeLog|wc -l

5085

$ grep -R &quot;unsigned int&quot; .|grep -v ChangeLog|wc -l

877

Those expressions are very rough but it still looks like it is a fairly wide-spread unwritten rule.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>993048</commentid>
    <comment_count>5</comment_count>
    <who name="László Langó">llango.u-szeged</who>
    <bug_when>2014-03-21 06:17:32 -0700</bug_when>
    <thetext>http://trac.webkit.org/changeset/128545

*** This bug has been marked as a duplicate of bug 96693 ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>