65372 2011-07-29 06:18:08 -0700 check-webkit-style complains about missing config.h in files from Tools/ 2012-03-13 13:44:48 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 ademar webkit-unassigned dpranke eric kbalazs oldest_to_newest 443917 0 ademar 2011-07-29 06:18:08 -0700 We usually don't use WebCore's config.h in source files from Tools/ (it's not even in the include path most of the time) but check-webkit-style complains. See for example: https://bugs.webkit.org/show_bug.cgi?id=65328#c11 """ Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/QtTestBrowser/Qt..." exit_code: 1 Tools/QtTestBrowser/cookiejar.cpp:28: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 7 files """ 577746 1 kbalazs 2012-03-13 13:29:02 -0700 I agree, it's quite annoying. 577767 2 levin 2012-03-13 13:44:48 -0700 fwiw, here's the code that implements the checks: http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py#L275 I won't have time to look at this in the foreseeable future. My time on WebKit is *extremely* limited these days.