65368 2011-07-29 04:52:32 -0700 [EFL] Implement declared but missing functions. 2011-10-04 16:54:55 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi darin gyuyoung.kim gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 443889 0 ryuan.choi 2011-07-29 04:52:32 -0700 I found that implementation of Cursor::operator=, localizedString was missing although it was declared. Compiler seems to ignore because WebKit/Efl doesn't use. (but WebKit2 use them.) 443891 1 102347 ryuan.choi 2011-07-29 04:59:12 -0700 Created attachment 102347 Patch 443893 2 rakuco 2011-07-29 05:06:47 -0700 > Source/WebCore/platform/efl/LocalizedStringsEfl.cpp:550 > + return String::fromUTF8(key); Passing strlen(key) as a second parameter to fromUTF8 should make things a bit faster on WTFString's side. 443897 3 102350 ryuan.choi 2011-07-29 05:29:36 -0700 Created attachment 102350 patch2 443898 4 ryuan.choi 2011-07-29 05:30:36 -0700 (In reply to comment #2) > > Source/WebCore/platform/efl/LocalizedStringsEfl.cpp:550 > > + return String::fromUTF8(key); > > Passing strlen(key) as a second parameter to fromUTF8 should make things a bit faster on WTFString's side. Done. 443900 5 rakuco 2011-07-29 05:35:22 -0700 r+ from my side. 445116 6 102350 gyuyoung.kim 2011-08-01 23:07:04 -0700 Comment on attachment 102350 patch2 LGTM 477500 7 109596 ryuan.choi 2011-10-04 02:03:11 -0700 Created attachment 109596 Patch 477514 8 109596 webkit.review.bot 2011-10-04 03:06:46 -0700 Comment on attachment 109596 Patch Clearing flags on attachment: 109596 Committed r96581: <http://trac.webkit.org/changeset/96581> 477515 9 webkit.review.bot 2011-10-04 03:06:50 -0700 All reviewed patches have been landed. Closing bug. 477644 10 darin 2011-10-04 09:31:51 -0700 Thanks for the fixes. I didn’t notice the EFL build breakage. 478059 11 gyuyoung.kim 2011-10-04 16:54:55 -0700 (In reply to comment #10) > Thanks for the fixes. I didn’t notice the EFL build breakage. No problem. please consider EFL build in future. :-) 102347 2011-07-29 04:59:12 -0700 2011-07-29 05:29:30 -0700 Patch bug-65368-20110729205902.patch text/plain 2130 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogOTE5ODQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmMTQ4ZDUzYzZiMjhiMjNi OWM1ZjM4NTAxM2Q3NjdiNGJiNmQ0NzY4Li45ZmMzMmYzNTBhYTc3MzVmZjA5YTcwZGI1NDU2Yzg0 YmQ5N2Y3ODBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDctMjkgIFJ5dWFu IENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdIEltcGxlbWVu dCBkZWNsYXJlZCBidXQgbWlzc2luZyBmdW5jdGlvbnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTM2OAorCisgICAgICAgIEltcGxlbWVudGF0aW9u IHdhcyBtaXNzaW5nIGFsdGhvdWdoIGl0IG1ha2VzIG5vIGVycm9ycyBhbmQgbm8gYnVpbGQgYnJl YWtzCisgICAgICAgIGluIEVmbCBwb3J0IHdpdGhvdXQgd2Via2l0Mi4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIG5ldyBm dW5jdGlvbmFsaXR5LgorCisgICAgICAgICogcGxhdGZvcm0vZWZsL0N1cnNvckVmbC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpDdXJzb3I6Om9wZXJhdG9yPSk6CisgICAgICAgICogcGxhdGZvcm0v ZWZsL0xvY2FsaXplZFN0cmluZ3NFZmwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6bG9jYWxpemVk U3RyaW5nKToKKwogMjAxMS0wNy0yOSAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgTWFrZSB0aGUgRXhjZXB0aW9uQ29kZSBhcmd1bWVudCBvZiBFbGVtZW50Ojpz ZXRTaGFkb3dQc2V1ZG9JZCgpIEFTU0VSVF9OT19FWENFUFRJT04gYnkgZGVmYXVsdApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0N1cnNvckVmbC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9lZmwvQ3Vyc29yRWZsLmNwcAppbmRleCAyNTdkODA4M2U5ZWU5NzI1 YzM3Yzk5NjU2YTFjNDRkNDgxZjc1YWEzLi42NDM0ZTQ1YmIwMzI2MjlmMmM3ODBlZTkwOGI0MjRh NDg4ZWRiZmE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvQ3Vyc29y RWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvQ3Vyc29yRWZsLmNwcApA QCAtNTUsNiArNTUsMTUgQEAgQ3Vyc29yOjp+Q3Vyc29yKCkKIHsKIH0KIAorQ3Vyc29yJiBDdXJz b3I6Om9wZXJhdG9yPShjb25zdCBDdXJzb3ImIG90aGVyKQoreworICAgIG1fdHlwZSA9IG90aGVy Lm1fdHlwZTsKKyAgICBtX2ltYWdlID0gb3RoZXIubV9pbWFnZTsKKyAgICBtX2hvdFNwb3QgPSBv dGhlci5tX2hvdFNwb3Q7CisgICAgbV9wbGF0Zm9ybUN1cnNvciA9IG90aGVyLm1fcGxhdGZvcm1D dXJzb3I7CisgICAgcmV0dXJuICp0aGlzOworfQorCiBzdGF0aWMgY29uc3QgY2hhciogY3Vyc29y U3RyaW5nKEN1cnNvcjo6VHlwZSB0eXBlKQogewogICAgIHN0YXRpYyBjb25zdCBjaGFyKiBjdXJz b3JTdHJpbmdzW10gPSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwv TG9jYWxpemVkU3RyaW5nc0VmbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvTG9j YWxpemVkU3RyaW5nc0VmbC5jcHAKaW5kZXggZDUzNzE1N2FiNmEwMjg3NDExOTczZjRiZWY5YmRm Yzg2NmEzNWQ3NC4uYmRhNTEwYTkzNTk4OTAwMzEyZWM2YTcwYTgzNzI5OTBjNWM1YWIzMiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0xvY2FsaXplZFN0cmluZ3NFZmwu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9Mb2NhbGl6ZWRTdHJpbmdzRWZs LmNwcApAQCAtNTQ1LDQgKzU0NSw5IEBAIFN0cmluZyBjcmFzaGVkUGx1Z2luVGV4dCgpCiAgICAg cmV0dXJuIFN0cmluZzo6ZnJvbVVURjgoInBsdWdpbiBjcmFzaGVkIik7CiB9CiAKK1N0cmluZyBs b2NhbGl6ZWRTdHJpbmcoY29uc3QgY2hhcioga2V5KQoreworICAgIHJldHVybiBTdHJpbmc6OmZy b21VVEY4KGtleSk7Cit9CisKIH0K 102350 2011-07-29 05:29:36 -0700 2011-10-04 02:03:05 -0700 patch2 bug-65368-20110729212926.patch text/plain 2143 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogOTE5ODQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmMTQ4ZDUzYzZiMjhiMjNi OWM1ZjM4NTAxM2Q3NjdiNGJiNmQ0NzY4Li45ZmMzMmYzNTBhYTc3MzVmZjA5YTcwZGI1NDU2Yzg0 YmQ5N2Y3ODBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTEtMDctMjkgIFJ5dWFu IENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdIEltcGxlbWVu dCBkZWNsYXJlZCBidXQgbWlzc2luZyBmdW5jdGlvbnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTM2OAorCisgICAgICAgIEltcGxlbWVudGF0aW9u IHdhcyBtaXNzaW5nIGFsdGhvdWdoIGl0IG1ha2VzIG5vIGVycm9ycyBhbmQgbm8gYnVpbGQgYnJl YWtzCisgICAgICAgIGluIEVmbCBwb3J0IHdpdGhvdXQgd2Via2l0Mi4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMsIG5vIG5ldyBm dW5jdGlvbmFsaXR5LgorCisgICAgICAgICogcGxhdGZvcm0vZWZsL0N1cnNvckVmbC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpDdXJzb3I6Om9wZXJhdG9yPSk6CisgICAgICAgICogcGxhdGZvcm0v ZWZsL0xvY2FsaXplZFN0cmluZ3NFZmwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6bG9jYWxpemVk U3RyaW5nKToKKwogMjAxMS0wNy0yOSAgS2VudCBUYW11cmEgIDx0a2VudEBjaHJvbWl1bS5vcmc+ CiAKICAgICAgICAgTWFrZSB0aGUgRXhjZXB0aW9uQ29kZSBhcmd1bWVudCBvZiBFbGVtZW50Ojpz ZXRTaGFkb3dQc2V1ZG9JZCgpIEFTU0VSVF9OT19FWENFUFRJT04gYnkgZGVmYXVsdApkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0N1cnNvckVmbC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9lZmwvQ3Vyc29yRWZsLmNwcAppbmRleCAyNTdkODA4M2U5ZWU5NzI1 YzM3Yzk5NjU2YTFjNDRkNDgxZjc1YWEzLi42NDM0ZTQ1YmIwMzI2MjlmMmM3ODBlZTkwOGI0MjRh NDg4ZWRiZmE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvQ3Vyc29y RWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvQ3Vyc29yRWZsLmNwcApA QCAtNTUsNiArNTUsMTUgQEAgQ3Vyc29yOjp+Q3Vyc29yKCkKIHsKIH0KIAorQ3Vyc29yJiBDdXJz b3I6Om9wZXJhdG9yPShjb25zdCBDdXJzb3ImIG90aGVyKQoreworICAgIG1fdHlwZSA9IG90aGVy Lm1fdHlwZTsKKyAgICBtX2ltYWdlID0gb3RoZXIubV9pbWFnZTsKKyAgICBtX2hvdFNwb3QgPSBv dGhlci5tX2hvdFNwb3Q7CisgICAgbV9wbGF0Zm9ybUN1cnNvciA9IG90aGVyLm1fcGxhdGZvcm1D dXJzb3I7CisgICAgcmV0dXJuICp0aGlzOworfQorCiBzdGF0aWMgY29uc3QgY2hhciogY3Vyc29y U3RyaW5nKEN1cnNvcjo6VHlwZSB0eXBlKQogewogICAgIHN0YXRpYyBjb25zdCBjaGFyKiBjdXJz b3JTdHJpbmdzW10gPSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwv TG9jYWxpemVkU3RyaW5nc0VmbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvTG9j YWxpemVkU3RyaW5nc0VmbC5jcHAKaW5kZXggZDUzNzE1N2FiNmEwMjg3NDExOTczZjRiZWY5YmRm Yzg2NmEzNWQ3NC4uYjAzMGY4MzVjYjRmYWY4MWUwZGRkZTM4NDg2MWEzNzE2YWE0MzI5MCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0xvY2FsaXplZFN0cmluZ3NFZmwu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9Mb2NhbGl6ZWRTdHJpbmdzRWZs LmNwcApAQCAtNTQ1LDQgKzU0NSw5IEBAIFN0cmluZyBjcmFzaGVkUGx1Z2luVGV4dCgpCiAgICAg cmV0dXJuIFN0cmluZzo6ZnJvbVVURjgoInBsdWdpbiBjcmFzaGVkIik7CiB9CiAKK1N0cmluZyBs b2NhbGl6ZWRTdHJpbmcoY29uc3QgY2hhcioga2V5KQoreworICAgIHJldHVybiBTdHJpbmc6OmZy b21VVEY4KGtleSwgc3RybGVuKGtleSkpOworfQorCiB9Cg== 109596 2011-10-04 02:03:11 -0700 2011-10-04 03:06:46 -0700 Patch bug-65368-20111004180309.patch text/plain 1986 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogOTY1NzUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBlZGE1NjExNjg4MWRlMzg2 NmE0NTA3ODkyYjg3NjJlOTM0M2IxZjJhLi40YjM3Yzg2ODMyNjNhYjg1YWZhNmE0NzZkMGIyMDcx YTZjZjUwZjk2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTEtMTAtMDQgIFJ5dWFu IENob2kgIDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdIEltcGxlbWVu dCBkZWNsYXJlZCBidXQgbWlzc2luZyBmdW5jdGlvbnMuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD02NTM2OAorCisgICAgICAgIFVucmV2aWV3ZWQgYnVp bGQgZml4IGZvciBXZWJLaXQvRWZsIGJ1aWxkcyBhZnRlciByOTY1NjYuCisKKyAgICAgICAgKiBw bGF0Zm9ybS9lZmwvQ3Vyc29yRWZsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkN1cnNvcjo6b3Bl cmF0b3I9KToKKyAgICAgICAgKiBwbGF0Zm9ybS9lZmwvTG9jYWxpemVkU3RyaW5nc0VmbC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpsb2NhbGl6ZWRTdHJpbmcpOgorCiAyMDExLTEwLTAzICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AZ29vZ2xlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9y OiBhZGQgRGVidWdnZXJQcmVzZW50YXRpb25Nb2RlbCBhbmQgQ29uc29sZVZpZXcgdG8gY29tcGls YXRpb24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvQ3Vyc29yRWZs LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9DdXJzb3JFZmwuY3BwCmluZGV4IDI1 N2Q4MDgzZTllZTk3MjVjMzdjOTk2NTZhMWM0NGQ0ODFmNzVhYTMuLjY0MzRlNDViYjAzMjYyOWYy Yzc4MGVlOTA4YjQyNGE0ODhlZGJmYTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2VmbC9DdXJzb3JFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9D dXJzb3JFZmwuY3BwCkBAIC01NSw2ICs1NSwxNSBAQCBDdXJzb3I6On5DdXJzb3IoKQogewogfQog CitDdXJzb3ImIEN1cnNvcjo6b3BlcmF0b3I9KGNvbnN0IEN1cnNvciYgb3RoZXIpCit7CisgICAg bV90eXBlID0gb3RoZXIubV90eXBlOworICAgIG1faW1hZ2UgPSBvdGhlci5tX2ltYWdlOworICAg IG1faG90U3BvdCA9IG90aGVyLm1faG90U3BvdDsKKyAgICBtX3BsYXRmb3JtQ3Vyc29yID0gb3Ro ZXIubV9wbGF0Zm9ybUN1cnNvcjsKKyAgICByZXR1cm4gKnRoaXM7Cit9CisKIHN0YXRpYyBjb25z dCBjaGFyKiBjdXJzb3JTdHJpbmcoQ3Vyc29yOjpUeXBlIHR5cGUpCiB7CiAgICAgc3RhdGljIGNv bnN0IGNoYXIqIGN1cnNvclN0cmluZ3NbXSA9IHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2VmbC9Mb2NhbGl6ZWRTdHJpbmdzRWZsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2VmbC9Mb2NhbGl6ZWRTdHJpbmdzRWZsLmNwcAppbmRleCBlODExNTk4MjFkNjdmMjdi YmViYzgyNzJlYmE2NTZlOTQ4NTY2ZWJlLi4zMDAwZjAyYzA1OWUzYzdhZTMyMjBlZjNkYzU1NTI2 MTc5ZDQ3MzFmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvTG9jYWxp emVkU3RyaW5nc0VmbC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0xvY2Fs aXplZFN0cmluZ3NFZmwuY3BwCkBAIC01NDUsNCArNTQ1LDkgQEAgU3RyaW5nIGNyYXNoZWRQbHVn aW5UZXh0KCkKICAgICByZXR1cm4gU3RyaW5nOjpmcm9tVVRGOCgicGx1Z2luIGNyYXNoZWQiKTsK IH0KIAorU3RyaW5nIGxvY2FsaXplZFN0cmluZyhjb25zdCBjaGFyKiBrZXkpCit7CisgICAgcmV0 dXJuIFN0cmluZzo6ZnJvbVVURjgoa2V5LCBzdHJsZW4oa2V5KSk7Cit9CisKIH0K