65355 2011-07-28 19:36:18 -0700 Remove LegacyDefaultOptionalArguments flag from geolocation IDL files 2011-08-03 16:02:02 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 pilgrim webkit-unassigned abarth webkit.review.bot oldest_to_newest 443776 0 pilgrim 2011-07-28 19:36:18 -0700 As discussed in IRC, we are migrating our IDL files away from the interface-level "LegacyDefaultOptionalArguments" flag and onto argument-level [Optional] or [Optional=CallWithDefaultValue] flags. This patch migrates geolocation-related files. This patch changes behavior -- it makes the geolocation methods match the spec for which arguments are required and which are optional, and (newly) throw TypeError if required arguments are missing. 443778 1 102326 pilgrim 2011-07-28 19:40:24 -0700 Created attachment 102326 Patch 443825 2 102326 abarth 2011-07-28 22:45:02 -0700 Comment on attachment 102326 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102326&action=review > Source/WebCore/page/PositionErrorCallback.idl:-28 > - LegacyDefaultOptionalArguments, We can probably nuke this attribute on all Callback=FunctionOnly interfaces. 445499 3 102326 abarth 2011-08-02 13:48:31 -0700 Comment on attachment 102326 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102326&action=review > Source/WebCore/ChangeLog:8 > + No new tests. (OOPS!) Actually, this line will cause the commit-queue to bounce your patch. 446094 4 102830 pilgrim 2011-08-03 14:43:21 -0700 Created attachment 102830 Patch 446168 5 102830 webkit.review.bot 2011-08-03 16:01:58 -0700 Comment on attachment 102830 Patch Clearing flags on attachment: 102830 Committed r92323: <http://trac.webkit.org/changeset/92323> 446169 6 webkit.review.bot 2011-08-03 16:02:02 -0700 All reviewed patches have been landed. Closing bug. 102326 2011-07-28 19:40:24 -0700 2011-08-03 14:43:15 -0700 Patch bug-65355-20110728224042.patch text/plain 3004 pilgrim SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkxOTY5KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDctMjggIE1hcmsgUGls Z3JpbSAgPHBpbGdyaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSBMZWdhY3lEZWZh dWx0T3B0aW9uYWxBcmd1bWVudHMgZmxhZyBmcm9tIGdlb2xvY2F0aW9uIElETCBmaWxlcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjUzNTUKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMu IChPT1BTISkKKworICAgICAgICAqIHBhZ2UvR2VvbG9jYXRpb24uaWRsOgorICAgICAgICAqIHBh Z2UvUG9zaXRpb25DYWxsYmFjay5pZGw6CisgICAgICAgICogcGFnZS9Qb3NpdGlvbkVycm9yQ2Fs bGJhY2suaWRsOgorCiAyMDExLTA3LTI4ICBMdWtlIE1hY3BoZXJzb24gICA8bWFjcGhlcnNvbkBj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmVtb3ZlIHJlbWFpbmluZyB1c2VzIG9mIENTU1ByaW1p dGl2ZVZhbHVlOjpjb21wdXRlTGVuZ3RoSW50Rm9yTGVuZ3RoKCkKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3BhZ2UvR2VvbG9jYXRpb24uaWRsCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Bh Z2UvR2VvbG9jYXRpb24uaWRsCShyZXZpc2lvbiA5MTk1MCkKKysrIFNvdXJjZS9XZWJDb3JlL3Bh Z2UvR2VvbG9jYXRpb24uaWRsCSh3b3JraW5nIGNvcHkpCkBAIC0yNywxMyArMjcsMTYgQEAgbW9k dWxlIGNvcmUgewogCiAgICAgaW50ZXJmYWNlIFsKICAgICAgICAgQ29uZGl0aW9uYWw9R0VPTE9D QVRJT04sIAotICAgICAgICBMZWdhY3lEZWZhdWx0T3B0aW9uYWxBcmd1bWVudHMsCiAgICAgICAg IEdlbmVyYXRlSXNSZWFjaGFibGU9SW1wbEZyYW1lLAogICAgICAgICBPbWl0Q29uc3RydWN0b3IK ICAgICBdIEdlb2xvY2F0aW9uIHsKLSAgICAgICAgW0N1c3RvbV0gdm9pZCBnZXRDdXJyZW50UG9z aXRpb24oaW4gUG9zaXRpb25DYWxsYmFjayBzdWNjZXNzQ2FsbGJhY2ssIGluIFBvc2l0aW9uRXJy b3JDYWxsYmFjayBlcnJvckNhbGxiYWNrLCBpbiBQb3NpdGlvbk9wdGlvbnMgb3B0aW9ucyk7Cisg ICAgICAgIFtDdXN0b21dIHZvaWQgZ2V0Q3VycmVudFBvc2l0aW9uKGluIFBvc2l0aW9uQ2FsbGJh Y2sgc3VjY2Vzc0NhbGxiYWNrLCAKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgaW4gW09wdGlvbmFsPUNhbGxXaXRoRGVmYXVsdFZhbHVlXSBQb3NpdGlvbkVycm9yQ2Fs bGJhY2sgZXJyb3JDYWxsYmFjaywgCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIGluIFtPcHRpb25hbD1DYWxsV2l0aERlZmF1bHRWYWx1ZV0gUG9zaXRpb25PcHRpb25z IG9wdGlvbnMpOwogCi0gICAgICAgIFtDdXN0b21dIGxvbmcgd2F0Y2hQb3NpdGlvbihpbiBQb3Np dGlvbkNhbGxiYWNrIHN1Y2Nlc3NDYWxsYmFjaywgaW4gUG9zaXRpb25FcnJvckNhbGxiYWNrIGVy cm9yQ2FsbGJhY2ssIGluIFBvc2l0aW9uT3B0aW9ucyBvcHRpb25zKTsKKyAgICAgICAgW0N1c3Rv bV0gbG9uZyB3YXRjaFBvc2l0aW9uKGluIFBvc2l0aW9uQ2FsbGJhY2sgc3VjY2Vzc0NhbGxiYWNr LCAKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGluIFtPcHRpb25hbD1DYWxs V2l0aERlZmF1bHRWYWx1ZV0gUG9zaXRpb25FcnJvckNhbGxiYWNrIGVycm9yQ2FsbGJhY2ssIAor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW4gW09wdGlvbmFsPUNhbGxXaXRo RGVmYXVsdFZhbHVlXSBQb3NpdGlvbk9wdGlvbnMgb3B0aW9ucyk7CiAKICAgICAgICAgdm9pZCBj bGVhcldhdGNoKGluIGxvbmcgd2F0Y2hJZCk7CiAgICAgfTsKSW5kZXg6IFNvdXJjZS9XZWJDb3Jl L3BhZ2UvUG9zaXRpb25DYWxsYmFjay5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUv cGFnZS9Qb3NpdGlvbkNhbGxiYWNrLmlkbAkocmV2aXNpb24gOTE5NTApCisrKyBTb3VyY2UvV2Vi Q29yZS9wYWdlL1Bvc2l0aW9uQ2FsbGJhY2suaWRsCSh3b3JraW5nIGNvcHkpCkBAIC0yNCw3ICsy NCw2IEBACiAKIG1vZHVsZSBjb3JlIHsKICAgICBpbnRlcmZhY2UgWwotICAgICAgICBMZWdhY3lE ZWZhdWx0T3B0aW9uYWxBcmd1bWVudHMsCiAgICAgICAgIENvbmRpdGlvbmFsPUdFT0xPQ0FUSU9O LAogICAgICAgICBDYWxsYmFjaz1GdW5jdGlvbk9ubHkKICAgICBdIFBvc2l0aW9uQ2FsbGJhY2sg ewpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9Qb3NpdGlvbkVycm9yQ2FsbGJhY2suaWRsCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BhZ2UvUG9zaXRpb25FcnJvckNhbGxiYWNrLmlk bAkocmV2aXNpb24gOTE5NTApCisrKyBTb3VyY2UvV2ViQ29yZS9wYWdlL1Bvc2l0aW9uRXJyb3JD YWxsYmFjay5pZGwJKHdvcmtpbmcgY29weSkKQEAgLTI1LDcgKzI1LDYgQEAKIG1vZHVsZSBjb3Jl IHsKICAgICBpbnRlcmZhY2UgWwogICAgICAgICBDb25kaXRpb25hbD1HRU9MT0NBVElPTiwKLSAg ICAgICAgTGVnYWN5RGVmYXVsdE9wdGlvbmFsQXJndW1lbnRzLAogICAgICAgICBDYWxsYmFjaz1G dW5jdGlvbk9ubHkKICAgICBdIFBvc2l0aW9uRXJyb3JDYWxsYmFjayB7CiAgICAgICAgIGJvb2xl YW4gaGFuZGxlRXZlbnQoaW4gUG9zaXRpb25FcnJvciBlcnJvcik7Cg== 102830 2011-08-03 14:43:21 -0700 2011-08-03 16:01:57 -0700 Patch bug-65355-20110803174331.patch text/plain 2997 pilgrim SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDkyMzA4KQorKysgU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDgtMDMgIE1hcmsgUGls Z3JpbSAgPHBpbGdyaW1AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJlbW92ZSBMZWdhY3lEZWZh dWx0T3B0aW9uYWxBcmd1bWVudHMgZmxhZyBmcm9tIGdlb2xvY2F0aW9uIElETCBmaWxlcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjUzNTUKKworICAg ICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYWxs IGV4aXN0aW5nIHRlc3RzIHBhc3MuCisKKyAgICAgICAgKiBwYWdlL0dlb2xvY2F0aW9uLmlkbDoK KyAgICAgICAgKiBwYWdlL1Bvc2l0aW9uQ2FsbGJhY2suaWRsOgorICAgICAgICAqIHBhZ2UvUG9z aXRpb25FcnJvckNhbGxiYWNrLmlkbDoKKwogMjAxMS0wOC0wMyAgSmVmZiBNaWxsZXIgIDxqZWZm bUBhcHBsZS5jb20+CiAKICAgICAgICAgR2VuZXJhdGUgV2ViQ29yZUhlYWRlckRldGVjdGlvbi5o IG9uIFdpbmRvd3MgdG8gZGVmaW5lIEhBVkVfQVZDRgpJbmRleDogU291cmNlL1dlYkNvcmUvcGFn ZS9HZW9sb2NhdGlvbi5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9HZW9s b2NhdGlvbi5pZGwJKHJldmlzaW9uIDkyMjM3KQorKysgU291cmNlL1dlYkNvcmUvcGFnZS9HZW9s b2NhdGlvbi5pZGwJKHdvcmtpbmcgY29weSkKQEAgLTI3LDEzICsyNywxNiBAQCBtb2R1bGUgY29y ZSB7CiAKICAgICBpbnRlcmZhY2UgWwogICAgICAgICBDb25kaXRpb25hbD1HRU9MT0NBVElPTiwg Ci0gICAgICAgIExlZ2FjeURlZmF1bHRPcHRpb25hbEFyZ3VtZW50cywKICAgICAgICAgR2VuZXJh dGVJc1JlYWNoYWJsZT1JbXBsRnJhbWUsCiAgICAgICAgIE9taXRDb25zdHJ1Y3RvcgogICAgIF0g R2VvbG9jYXRpb24gewotICAgICAgICBbQ3VzdG9tXSB2b2lkIGdldEN1cnJlbnRQb3NpdGlvbihp biBQb3NpdGlvbkNhbGxiYWNrIHN1Y2Nlc3NDYWxsYmFjaywgaW4gUG9zaXRpb25FcnJvckNhbGxi YWNrIGVycm9yQ2FsbGJhY2ssIGluIFBvc2l0aW9uT3B0aW9ucyBvcHRpb25zKTsKKyAgICAgICAg W0N1c3RvbV0gdm9pZCBnZXRDdXJyZW50UG9zaXRpb24oaW4gUG9zaXRpb25DYWxsYmFjayBzdWNj ZXNzQ2FsbGJhY2ssIAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBp biBbT3B0aW9uYWw9Q2FsbFdpdGhEZWZhdWx0VmFsdWVdIFBvc2l0aW9uRXJyb3JDYWxsYmFjayBl cnJvckNhbGxiYWNrLCAKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg aW4gW09wdGlvbmFsPUNhbGxXaXRoRGVmYXVsdFZhbHVlXSBQb3NpdGlvbk9wdGlvbnMgb3B0aW9u cyk7CiAKLSAgICAgICAgW0N1c3RvbV0gbG9uZyB3YXRjaFBvc2l0aW9uKGluIFBvc2l0aW9uQ2Fs bGJhY2sgc3VjY2Vzc0NhbGxiYWNrLCBpbiBQb3NpdGlvbkVycm9yQ2FsbGJhY2sgZXJyb3JDYWxs YmFjaywgaW4gUG9zaXRpb25PcHRpb25zIG9wdGlvbnMpOworICAgICAgICBbQ3VzdG9tXSBsb25n IHdhdGNoUG9zaXRpb24oaW4gUG9zaXRpb25DYWxsYmFjayBzdWNjZXNzQ2FsbGJhY2ssIAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaW4gW09wdGlvbmFsPUNhbGxXaXRoRGVm YXVsdFZhbHVlXSBQb3NpdGlvbkVycm9yQ2FsbGJhY2sgZXJyb3JDYWxsYmFjaywgCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBpbiBbT3B0aW9uYWw9Q2FsbFdpdGhEZWZhdWx0 VmFsdWVdIFBvc2l0aW9uT3B0aW9ucyBvcHRpb25zKTsKIAogICAgICAgICB2b2lkIGNsZWFyV2F0 Y2goaW4gbG9uZyB3YXRjaElkKTsKICAgICB9OwpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9Q b3NpdGlvbkNhbGxiYWNrLmlkbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL1Bv c2l0aW9uQ2FsbGJhY2suaWRsCShyZXZpc2lvbiA5MjIzNykKKysrIFNvdXJjZS9XZWJDb3JlL3Bh Z2UvUG9zaXRpb25DYWxsYmFjay5pZGwJKHdvcmtpbmcgY29weSkKQEAgLTI0LDcgKzI0LDYgQEAK IAogbW9kdWxlIGNvcmUgewogICAgIGludGVyZmFjZSBbCi0gICAgICAgIExlZ2FjeURlZmF1bHRP cHRpb25hbEFyZ3VtZW50cywKICAgICAgICAgQ29uZGl0aW9uYWw9R0VPTE9DQVRJT04sCiAgICAg ICAgIENhbGxiYWNrPUZ1bmN0aW9uT25seQogICAgIF0gUG9zaXRpb25DYWxsYmFjayB7CkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9wYWdlL1Bvc2l0aW9uRXJyb3JDYWxsYmFjay5pZGwKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcGFnZS9Qb3NpdGlvbkVycm9yQ2FsbGJhY2suaWRsCShyZXZp c2lvbiA5MjIzNykKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2UvUG9zaXRpb25FcnJvckNhbGxiYWNr LmlkbAkod29ya2luZyBjb3B5KQpAQCAtMjUsNyArMjUsNiBAQAogbW9kdWxlIGNvcmUgewogICAg IGludGVyZmFjZSBbCiAgICAgICAgIENvbmRpdGlvbmFsPUdFT0xPQ0FUSU9OLAotICAgICAgICBM ZWdhY3lEZWZhdWx0T3B0aW9uYWxBcmd1bWVudHMsCiAgICAgICAgIENhbGxiYWNrPUZ1bmN0aW9u T25seQogICAgIF0gUG9zaXRpb25FcnJvckNhbGxiYWNrIHsKICAgICAgICAgYm9vbGVhbiBoYW5k bGVFdmVudChpbiBQb3NpdGlvbkVycm9yIGVycm9yKTsK