65349 2011-07-28 16:29:29 -0700 CJK input broken after clicking on Flash content 2011-08-09 10:38:57 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton andersca ap darin freshworks webkit.review.bot oldest_to_newest 443702 0 thorton 2011-07-28 16:29:29 -0700 Steps to Reproduce: 0. Install Flash. 1. Enable Japanese text entry. Hiragana works. 2. Go to youtube.com. Make sure it's using Flash, not HTML5 Video. 3. Click on a video. 4. Click the play/pause button. 5. Click the back button. 6. Try to type into the search field. Expected Results: Inline text entry. Actual Results: Somewhat-buggy bottom-bar text entry, as in Flash apps. Notes (from ChangeLog): After giving Flash focus on a page and then navigating away from that page using the back button, we were not getting notified to switch back to inline (non-complex) input. Now, notify the page that it can leave complex text mode when the plugin is destroyed. Patch forthcoming. <rdar://problem/9854447> 443704 1 102311 thorton 2011-07-28 16:31:01 -0700 Created attachment 102311 patch 443724 2 102311 webkit.review.bot 2011-07-28 17:07:12 -0700 Comment on attachment 102311 patch Rejecting attachment 102311 from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 1 Last 500 characters of output: eLog M Source/WebKit2/Shared/FontInfo.cpp M Source/WebKit2/WebProcess/WebCoreSupport/mac/WebPopupMenuMac.mm r91961 = c8c9ff84269378e6e74c1a17182ca2426ec5bf38 (refs/remotes/origin/master) First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/9265319 443729 3 102314 thorton 2011-07-28 17:13:41 -0700 Created attachment 102314 patch Bot output is odd, but I somehow deleted the Reviewed by line. 443734 4 102314 webkit.review.bot 2011-07-28 17:26:12 -0700 Comment on attachment 102314 patch Clearing flags on attachment: 102314 Committed r91964: <http://trac.webkit.org/changeset/91964> 443735 5 webkit.review.bot 2011-07-28 17:26:16 -0700 All reviewed patches have been landed. Closing bug. 443809 6 102314 ap 2011-07-28 21:51:04 -0700 Comment on attachment 102314 patch What will fix text input if the plugin view goes into back/forward cache without being deleted? 443813 7 darin 2011-07-28 22:00:01 -0700 Good point. I don’t think the destructor is the right place to put this code. I didn’t actually look at the patch. I just reviewed so the commit-bot would work. Anders was the actual reviewer. 443814 8 thorton 2011-07-28 22:03:24 -0700 Indeed, and I've just Cc'd Anders. I got the impression from him that this was the right place to put it (I went into his office with no idea where to put it), but Alexey's point is definitely valid (and something I hadn't considered). I'll talk to him again tomorrow and see about better options. 443817 9 ap 2011-07-28 22:16:09 -0700 Well, the answer is that pages with plug-ins never go into b/f cache. But we want to fix that, and there is nothing to remind us that this bug needs to be revisited when doing so. 448661 10 ap 2011-08-09 10:38:57 -0700 *** Bug 65892 has been marked as a duplicate of this bug. *** 102311 2011-07-28 16:31:01 -0700 2011-07-28 17:13:41 -0700 patch 9854447.patch text/plain 1440 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3ZGFmNzVmLi4zMDc2MzU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTEtMDctMjggIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgUkVHUkVTU0lPTiAoNS4xKTogQ0pLIGlucHV0IGJyb2tlbiBhZnRlciBjbGlja2lu ZyBvbiBGbGFzaCBjb250ZW50CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS85ODU0NDQ3PgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjUzNDkKKworICAg ICAgICBBZnRlciBnaXZpbmcgRmxhc2ggZm9jdXMgb24gYSBwYWdlIGFuZCB0aGVuIG5hdmlnYXRp bmcgYXdheSBmcm9tIHRoYXQgcGFnZQorICAgICAgICB1c2luZyB0aGUgYmFjayBidXR0b24sIHdl IHdlcmUgbm90IGdldHRpbmcgbm90aWZpZWQgdG8gc3dpdGNoIGJhY2sgdG8KKyAgICAgICAgaW5s aW5lIChub24tY29tcGxleCkgaW5wdXQuIE5vdywgbm90aWZ5IHRoZSBwYWdlIHRoYXQgaXQgY2Fu IGxlYXZlIGNvbXBsZXgKKyAgICAgICAgdGV4dCBtb2RlIHdoZW4gdGhlIHBsdWdpbiBpcyBkZXN0 cm95ZWQuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5jcHA6Cisg ICAgICAgIChXZWJLaXQ6OlBsdWdpblZpZXc6On5QbHVnaW5WaWV3KToKKwogMjAxMS0wNy0yNiAg Q2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJ T04gKFNhZmFyaSA1LjEpOiBKYXZhU2NyaXB0IGRpYWxvZ3Mgbm90IHVzYWJsZSB3aXRoIFZvaWNl T3ZlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdp blZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblZpZXcu Y3BwCmluZGV4IGRiYTQzMjUuLjEwODAzOTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvUGx1Z2lucy9QbHVnaW5WaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQ cm9jZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5jcHAKQEAgLTI4Niw2ICsyODYsOSBAQCBQbHVnaW5W aWV3Ojp+UGx1Z2luVmlldygpCiAgICAgICAgIG1faXNCZWluZ0Rlc3Ryb3llZCA9IHRydWU7CiAg ICAgICAgIG1fcGx1Z2luLT5kZXN0cm95UGx1Z2luKCk7CiAgICAgICAgIG1faXNCZWluZ0Rlc3Ry b3llZCA9IGZhbHNlOworI2lmIFBMQVRGT1JNKE1BQykKKyAgICAgICAgc2V0Q29tcGxleFRleHRJ bnB1dEVuYWJsZWQoZmFsc2UpOworI2VuZGlmCiAgICAgfQogCiAgICAgLy8gSW52YWxpZGF0ZSB0 aGUgb2JqZWN0IG1hcC4K 102314 2011-07-28 17:13:41 -0700 2011-07-28 21:51:04 -0700 patch 9854447.patch text/plain 1479 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA3ZGFmNzVmLi45NTVhODE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTEtMDctMjggIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgUkVHUkVTU0lPTiAoNS4xKTogQ0pLIGlucHV0IGJyb2tlbiBhZnRlciBjbGlja2lu ZyBvbiBGbGFzaCBjb250ZW50CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS85ODU0NDQ3PgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjUzNDkKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZnRlciBnaXZpbmcg Rmxhc2ggZm9jdXMgb24gYSBwYWdlIGFuZCB0aGVuIG5hdmlnYXRpbmcgYXdheSBmcm9tIHRoYXQg cGFnZQorICAgICAgICB1c2luZyB0aGUgYmFjayBidXR0b24sIHdlIHdlcmUgbm90IGdldHRpbmcg bm90aWZpZWQgdG8gc3dpdGNoIGJhY2sgdG8KKyAgICAgICAgaW5saW5lIChub24tY29tcGxleCkg aW5wdXQuIE5vdywgbm90aWZ5IHRoZSBwYWdlIHRoYXQgaXQgY2FuIGxlYXZlIGNvbXBsZXgKKyAg ICAgICAgdGV4dCBtb2RlIHdoZW4gdGhlIHBsdWdpbiBpcyBkZXN0cm95ZWQuCisKKyAgICAgICAg KiBXZWJQcm9jZXNzL1BsdWdpbnMvUGx1Z2luVmlldy5jcHA6CisgICAgICAgIChXZWJLaXQ6OlBs dWdpblZpZXc6On5QbHVnaW5WaWV3KToKKwogMjAxMS0wNy0yNiAgQ2hyaXMgRmxlaXphY2ggIDxj ZmxlaXphY2hAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04gKFNhZmFyaSA1LjEpOiBK YXZhU2NyaXB0IGRpYWxvZ3Mgbm90IHVzYWJsZSB3aXRoIFZvaWNlT3ZlcgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblZpZXcuY3BwIGIvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BsdWdpblZpZXcuY3BwCmluZGV4IGRiYTQzMjUu LjEwODAzOTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1Z2lucy9Q bHVnaW5WaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUGx1 Z2luVmlldy5jcHAKQEAgLTI4Niw2ICsyODYsOSBAQCBQbHVnaW5WaWV3Ojp+UGx1Z2luVmlldygp CiAgICAgICAgIG1faXNCZWluZ0Rlc3Ryb3llZCA9IHRydWU7CiAgICAgICAgIG1fcGx1Z2luLT5k ZXN0cm95UGx1Z2luKCk7CiAgICAgICAgIG1faXNCZWluZ0Rlc3Ryb3llZCA9IGZhbHNlOworI2lm IFBMQVRGT1JNKE1BQykKKyAgICAgICAgc2V0Q29tcGxleFRleHRJbnB1dEVuYWJsZWQoZmFsc2Up OworI2VuZGlmCiAgICAgfQogCiAgICAgLy8gSW52YWxpZGF0ZSB0aGUgb2JqZWN0IG1hcC4K