65333 2011-07-28 11:38:15 -0700 Fix speech input icon rect on RTL directions 2011-07-29 05:49:19 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 39485 1 leandrogracia leandrogracia satish tonyg oldest_to_newest 443581 0 leandrogracia 2011-07-28 11:38:15 -0700 Currently when using speech input the rect containing the whole input element is provided to the client so it can show any popup of their choice when the recognition starts. However this fails in right-to-left text environments because it assumes the icon to be always on the right. This patch fixes this problem by returning the rect of the speech icon itself instead of the whole input element. 443592 1 102279 leandrogracia 2011-07-28 11:51:11 -0700 Created attachment 102279 Patch 443903 2 leandrogracia 2011-07-29 05:49:19 -0700 Committed r91988: <http://trac.webkit.org/changeset/91988> 102279 2011-07-28 11:51:11 -0700 2011-07-29 03:56:22 -0700 Patch bug-65333-20110728195109.patch text/plain 1791 leandrogracia U3VidmVyc2lvbiBSZXZpc2lvbjogOTE5MTIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4YzgyNGZhZGE5NWU0YzNl NDZhY2E0YThkM2FmZjlmNzUxM2ViMTE4Li5kNTViNDdhYmViMWEwYzhjNDdhYTcyODFkMjg4ZDU3 ZWZjNzZmNDBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDctMjggIExlYW5k cm8gR3JhY2lhIEdpbCAgPGxlYW5kcm9ncmFjaWFAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEZp eCBzcGVlY2ggaW5wdXQgaWNvbiByZWN0IG9uIFJUTCBkaXJlY3Rpb25zLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjUzMzMKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIFRoaXMgaXMg dXNlZCBieSBwbGF0Zm9ybXMsIG5vdCBXZWJDb3JlLCBhbmQKKyAgICAgICAgdGhlIGJhc2UgZnVu Y3Rpb25hbGl0eSBpcyBub3QgY2hhbmdlZCBidXQgb25seSB0aGUgZmFpbGluZyBjYXNlcy4KKwor ICAgICAgICAqIGh0bWwvc2hhZG93L1RleHRDb250cm9sSW5uZXJFbGVtZW50cy5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpJbnB1dEZpZWxkU3BlZWNoQnV0dG9uRWxlbWVudDo6ZGVmYXVsdEV2ZW50 SGFuZGxlcik6CisKIDIwMTEtMDctMjcgIEd5dXlvdW5nIEtpbSAgPGd5dXlvdW5nLmtpbUBzYW1z dW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBBZGQgZHVtbXkgTm90aWZpY2F0aW9uUHJlc2VudGVy Q2xpZW50RWZsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9UZXh0Q29u dHJvbElubmVyRWxlbWVudHMuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9zaGFkb3cvVGV4dENv bnRyb2xJbm5lckVsZW1lbnRzLmNwcAppbmRleCAyZjZhYjQzN2FiZTI0ZTZjMGRmMjI4ZGMwOGU1 MTMzNWIyNWE1NjVlLi5kYTkwODRlMzVlZmIxOGY5ZGE0MTAxMGMzZGUyYmMzODZmZmI4OTBkIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL3NoYWRvdy9UZXh0Q29udHJvbElubmVyRWxl bWVudHMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvc2hhZG93L1RleHRDb250cm9sSW5u ZXJFbGVtZW50cy5jcHAKQEAgLTQzNyw3ICs0MzcsNyBAQCB2b2lkIElucHV0RmllbGRTcGVlY2hC dXR0b25FbGVtZW50OjpkZWZhdWx0RXZlbnRIYW5kbGVyKEV2ZW50KiBldmVudCkKICAgICAgICAg Y2FzZSBJZGxlOiB7CiAgICAgICAgICAgICAgIEF0b21pY1N0cmluZyBsYW5ndWFnZSA9IGlucHV0 LT5jb21wdXRlSW5oZXJpdGVkTGFuZ3VhZ2UoKTsKICAgICAgICAgICAgICAgU3RyaW5nIGdyYW1t YXIgPSBpbnB1dC0+Z2V0QXR0cmlidXRlKHdlYmtpdGdyYW1tYXJBdHRyKTsKLSAgICAgICAgICAg ICAgSW50UmVjdCByZWN0ID0gaW5wdXQtPnJlbmRlcmVyKCktPmFic29sdXRlQm91bmRpbmdCb3hS ZWN0KCk7CisgICAgICAgICAgICAgIEludFJlY3QgcmVjdCA9IHJlbmRlcmVyKCktPmFic29sdXRl Qm91bmRpbmdCb3hSZWN0KCk7CiAgICAgICAgICAgICAgIGlmIChzcGVlY2hJbnB1dCgpLT5zdGFy dFJlY29nbml0aW9uKG1fbGlzdGVuZXJJZCwgcmVjdCwgbGFuZ3VhZ2UsIGdyYW1tYXIsIGRvY3Vt ZW50KCktPnNlY3VyaXR5T3JpZ2luKCkpKQogICAgICAgICAgICAgICAgICAgc2V0U3RhdGUoUmVj b3JkaW5nKTsKICAgICAgICAgICAgIH0K