65322 2011-07-28 09:56:19 -0700 Web Inspector: [REGRESSION] Inspected tab crashes if navigated with inspector open and there are watch expressions added. 2011-07-28 16:38:05 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vsevik vsevik apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 443522 0 vsevik 2011-07-28 09:56:19 -0700 Inspected tab crashes if navigated with inspector open and there are watch expressions added. 443526 1 102265 vsevik 2011-07-28 09:59:12 -0700 Created attachment 102265 Patch 443533 2 102265 pfeldman 2011-07-28 10:07:48 -0700 Comment on attachment 102265 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102265&action=review > Source/WebCore/inspector/InspectorRuntimeAgent.cpp:66 > scriptState = getDefaultInspectedState(); Add you should do *errorString = "No frame with id is available."; 443547 3 102268 vsevik 2011-07-28 10:27:35 -0700 Created attachment 102268 Patch (comments addressed) 443707 4 102268 webkit.review.bot 2011-07-28 16:38:00 -0700 Comment on attachment 102268 Patch (comments addressed) Clearing flags on attachment: 102268 Committed r91956: <http://trac.webkit.org/changeset/91956> 443708 5 webkit.review.bot 2011-07-28 16:38:05 -0700 All reviewed patches have been landed. Closing bug. 102265 2011-07-28 09:59:12 -0700 2011-07-28 10:27:28 -0700 Patch bug-65322-20110728205910.patch text/plain 1600 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogOTE5MjgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiYzMzMTU2ODQzZTExNDM0 YTM3NzM4MmM3YzNkNjU4NmY2MzRlZDRjLi40NWI5MDBlOWIxNTJiZDQ0ODBmN2FkNTNmMjU4ZmUw N2UzN2JlMzYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTUgQEAKIDIwMTEtMDctMjggIFZzZXZv bG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogW1JFR1JFU1NJT05dIEluc3BlY3RlZCB0YWIgY3Jhc2hlcyBpZiBuYXZpZ2F0ZWQgd2l0aCBp bnNwZWN0b3Igb3BlbiBhbmQgdGhlcmUgYXJlIHdhdGNoIGV4cHJlc3Npb25zIGFkZGVkLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjUzMjIKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9J bnNwZWN0b3JSdW50aW1lQWdlbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yUnVu dGltZUFnZW50OjpldmFsdWF0ZSk6CisKKzIwMTEtMDctMjggIFZzZXZvbG9kIFZsYXNvdiAgPHZz ZXZpa0BjaHJvbWl1bS5vcmc+CisKICAgICAgICAgV2ViIEluc3BlY3RvcjogQWRkIHJlc291cmNl IGluaXRpYXRvciBjb2x1bW4gdG8gbmV0d29yayBwYW5lbC4KICAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTY1MTA1CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JSdW50aW1lQWdlbnQuY3BwIGIvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL0luc3BlY3RvclJ1bnRpbWVBZ2VudC5jcHAKaW5kZXggNzE0NDU5MzQ1YTdi MWI2Y2NhZTFjNjQ1ZmE5MzA0NTM4YjQ5NGFiMi4uYmNiZjU3N2YxYmU3ZWQ1ZmQ3ODg0NjJhNzJm NjZjYTRkMTRjODNkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3Bl Y3RvclJ1bnRpbWVBZ2VudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3Bl Y3RvclJ1bnRpbWVBZ2VudC5jcHAKQEAgLTYyLDcgKzYyLDcgQEAgdm9pZCBJbnNwZWN0b3JSdW50 aW1lQWdlbnQ6OmV2YWx1YXRlKEVycm9yU3RyaW5nKiBlcnJvclN0cmluZywgY29uc3QgU3RyaW5n JiBleHAKICAgICBTY3JpcHRTdGF0ZSogc2NyaXB0U3RhdGUgPSAwOwogICAgIGlmIChmcmFtZUlk KQogICAgICAgICBzY3JpcHRTdGF0ZSA9IHNjcmlwdFN0YXRlRm9yRnJhbWVJZChlcnJvclN0cmlu ZywgKmZyYW1lSWQpOwotICAgIGVsc2UKKyAgICBpZiAoIXNjcmlwdFN0YXRlKQogICAgICAgICBz Y3JpcHRTdGF0ZSA9IGdldERlZmF1bHRJbnNwZWN0ZWRTdGF0ZSgpOwogICAgIEluamVjdGVkU2Ny aXB0IGluamVjdGVkU2NyaXB0ID0gbV9pbmplY3RlZFNjcmlwdE1hbmFnZXItPmluamVjdGVkU2Ny aXB0Rm9yKHNjcmlwdFN0YXRlKTsKICAgICBpZiAoaW5qZWN0ZWRTY3JpcHQuaGFzTm9WYWx1ZSgp KSB7Cg== 102268 2011-07-28 10:27:35 -0700 2011-07-28 16:38:00 -0700 Patch (comments addressed) bug-65322-20110728212733.patch text/plain 4359 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogOTE5MjgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiYzMzMTU2ODQzZTExNDM0 YTM3NzM4MmM3YzNkNjU4NmY2MzRlZDRjLi4yMzBkNDdiNGZkZjJkN2I4NjI5MWVmOGIwN2Q2MmQ0 NmYzYTZkZTA1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMTEtMDctMjggIFZzZXZv bG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CiAKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogW1JFR1JFU1NJT05dIEluc3BlY3RlZCB0YWIgY3Jhc2hlcyBpZiBuYXZpZ2F0ZWQgd2l0aCBp bnNwZWN0b3Igb3BlbiBhbmQgdGhlcmUgYXJlIHdhdGNoIGV4cHJlc3Npb25zIGFkZGVkLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NjUzMjIKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9J bnNwZWN0b3JDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yUnVu dGltZUFnZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvclJ1bnRpbWVBZ2VudDo6 ZXZhbHVhdGUpOgorICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JSdW50aW1lQWdlbnQuaDoK KyAgICAgICAgKiBpbnNwZWN0b3IvV29ya2VySW5zcGVjdG9yQ29udHJvbGxlci5jcHA6CisKKzIw MTEtMDctMjggIFZzZXZvbG9kIFZsYXNvdiAgPHZzZXZpa0BjaHJvbWl1bS5vcmc+CisKICAgICAg ICAgV2ViIEluc3BlY3RvcjogQWRkIHJlc291cmNlIGluaXRpYXRvciBjb2x1bW4gdG8gbmV0d29y ayBwYW5lbC4KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTY1MTA1CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JD b250cm9sbGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9s bGVyLmNwcAppbmRleCA2ZjAxMDEzYzk0OWViYmM1NWMyMzIyMGU2Mzk5OWNhNjcwNTY3MmRlLi5j YzUxYjA0NzA0NGQxNDBhOTEwMjYzZDY5Mjk1ZGI2NjBkM2JiNDExIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwCkBAIC03OSwxMyArNzks MTEgQEAgcHVibGljOgogICAgIHZpcnR1YWwgflBhZ2VSdW50aW1lQWdlbnQoKSB7IH0KIAogcHJp dmF0ZToKLSAgICB2aXJ0dWFsIFNjcmlwdFN0YXRlKiBzY3JpcHRTdGF0ZUZvckZyYW1lSWQoRXJy b3JTdHJpbmcqIGVycm9yU3RyaW5nLCBjb25zdCBTdHJpbmcmIGZyYW1lSWQpCisgICAgdmlydHVh bCBTY3JpcHRTdGF0ZSogc2NyaXB0U3RhdGVGb3JGcmFtZUlkKGNvbnN0IFN0cmluZyYgZnJhbWVJ ZCkKICAgICB7CiAgICAgICAgIEZyYW1lKiBmcmFtZSA9IG1fcGFnZUFnZW50LT5mcmFtZUZvcklk KGZyYW1lSWQpOwotICAgICAgICBpZiAoIWZyYW1lKSB7Ci0gICAgICAgICAgICAqZXJyb3JTdHJp bmcgPSAiRnJhbWUgbm90IGZvdW5kIjsKKyAgICAgICAgaWYgKCFmcmFtZSkKICAgICAgICAgICAg IHJldHVybiAwOwotICAgICAgICB9CiAgICAgICAgIHJldHVybiBtYWluV29ybGRTY3JpcHRTdGF0 ZShmcmFtZSk7CiAgICAgfQogICAgIHZpcnR1YWwgU2NyaXB0U3RhdGUqIGdldERlZmF1bHRJbnNw ZWN0ZWRTdGF0ZSgpIHsgcmV0dXJuIG1haW5Xb3JsZFNjcmlwdFN0YXRlKG1faW5zcGVjdGVkUGFn ZS0+bWFpbkZyYW1lKCkpOyB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv SW5zcGVjdG9yUnVudGltZUFnZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNw ZWN0b3JSdW50aW1lQWdlbnQuY3BwCmluZGV4IDcxNDQ1OTM0NWE3YjFiNmNjYWUxYzY0NWZhOTMw NDUzOGI0OTRhYjIuLmU0M2FkYTgxMWEzZWE3YTA5MjA0MWIxODEyODA5Mzc5YzM5NmI5ZDQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JSdW50aW1lQWdlbnQu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JSdW50aW1lQWdlbnQu Y3BwCkBAIC02MCw5ICs2MCwxMyBAQCBJbnNwZWN0b3JSdW50aW1lQWdlbnQ6On5JbnNwZWN0b3JS dW50aW1lQWdlbnQoKQogdm9pZCBJbnNwZWN0b3JSdW50aW1lQWdlbnQ6OmV2YWx1YXRlKEVycm9y U3RyaW5nKiBlcnJvclN0cmluZywgY29uc3QgU3RyaW5nJiBleHByZXNzaW9uLCBjb25zdCBTdHJp bmcqIGNvbnN0IG9iamVjdEdyb3VwLCBjb25zdCBib29sKiBjb25zdCBpbmNsdWRlQ29tbWFuZExp bmVBUEksIGNvbnN0IGJvb2wqIGNvbnN0IGRvTm90UGF1c2VPbkV4Y2VwdGlvbnMsIGNvbnN0IFN0 cmluZyogY29uc3QgZnJhbWVJZCwgUmVmUHRyPEluc3BlY3Rvck9iamVjdD4qIHJlc3VsdCwgYm9v bCogd2FzVGhyb3duKQogewogICAgIFNjcmlwdFN0YXRlKiBzY3JpcHRTdGF0ZSA9IDA7Ci0gICAg aWYgKGZyYW1lSWQpCi0gICAgICAgIHNjcmlwdFN0YXRlID0gc2NyaXB0U3RhdGVGb3JGcmFtZUlk KGVycm9yU3RyaW5nLCAqZnJhbWVJZCk7Ci0gICAgZWxzZQorICAgIGlmIChmcmFtZUlkKSB7Cisg ICAgICAgIHNjcmlwdFN0YXRlID0gc2NyaXB0U3RhdGVGb3JGcmFtZUlkKCpmcmFtZUlkKTsKKyAg ICAgICAgaWYgKCFzY3JpcHRTdGF0ZSkgeworICAgICAgICAgICAgKmVycm9yU3RyaW5nID0gIkZy YW1lIHdpdGggZ2l2ZW4gaWQgbm90IGZvdW5kLiI7CisgICAgICAgICAgICByZXR1cm47CisgICAg ICAgIH0KKyAgICB9IGVsc2UKICAgICAgICAgc2NyaXB0U3RhdGUgPSBnZXREZWZhdWx0SW5zcGVj dGVkU3RhdGUoKTsKICAgICBJbmplY3RlZFNjcmlwdCBpbmplY3RlZFNjcmlwdCA9IG1faW5qZWN0 ZWRTY3JpcHRNYW5hZ2VyLT5pbmplY3RlZFNjcmlwdEZvcihzY3JpcHRTdGF0ZSk7CiAgICAgaWYg KGluamVjdGVkU2NyaXB0Lmhhc05vVmFsdWUoKSkgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL0luc3BlY3RvclJ1bnRpbWVBZ2VudC5oIGIvU291cmNlL1dlYkNvcmUvaW5z cGVjdG9yL0luc3BlY3RvclJ1bnRpbWVBZ2VudC5oCmluZGV4IGFkYmVhYmFjMWJhZmNhZGM2ZDc3 MDdjZDc2YjRkZjc2MDAzNjY3N2YuLjNlMWEzYTI2NzlmNWQ5ZWQzMGQyZmI0MzZlMGE1MjkxZDAx MDEzYTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JSdW50 aW1lQWdlbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yUnVudGlt ZUFnZW50LmgKQEAgLTY1LDcgKzY1LDcgQEAgcHVibGljOgogCiBwcm90ZWN0ZWQ6CiAgICAgZXhw bGljaXQgSW5zcGVjdG9yUnVudGltZUFnZW50KEluamVjdGVkU2NyaXB0TWFuYWdlciopOwotICAg IHZpcnR1YWwgU2NyaXB0U3RhdGUqIHNjcmlwdFN0YXRlRm9yRnJhbWVJZChFcnJvclN0cmluZyos IGNvbnN0IFN0cmluZyYgZnJhbWVJZCkgPSAwOworICAgIHZpcnR1YWwgU2NyaXB0U3RhdGUqIHNj cmlwdFN0YXRlRm9yRnJhbWVJZChjb25zdCBTdHJpbmcmIGZyYW1lSWQpID0gMDsKICAgICB2aXJ0 dWFsIFNjcmlwdFN0YXRlKiBnZXREZWZhdWx0SW5zcGVjdGVkU3RhdGUoKSA9IDA7CiAKIHByaXZh dGU6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvV29ya2VySW5zcGVjdG9y Q29udHJvbGxlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvV29ya2VySW5zcGVjdG9y Q29udHJvbGxlci5jcHAKaW5kZXggNTZmNTM5ODk4YWViY2FjNDMzNDc0NzBhNzczOWE2Njc0MDgw NzJjOC4uYzM0OTkyN2EzODNkZjZjZjIyOTEzYjY0YmJkNTQyZjg0NWVlNmFiZCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL1dvcmtlckluc3BlY3RvckNvbnRyb2xsZXIuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9Xb3JrZXJJbnNwZWN0b3JDb250cm9sbGVy LmNwcApAQCAtNjEsNyArNjEsNyBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB+V29ya2VyUnVudGlt ZUFnZW50KCkgeyB9CiAKIHByaXZhdGU6Ci0gICAgdmlydHVhbCBTY3JpcHRTdGF0ZSogc2NyaXB0 U3RhdGVGb3JGcmFtZUlkKEVycm9yU3RyaW5nKiwgY29uc3QgU3RyaW5nJikKKyAgICB2aXJ0dWFs IFNjcmlwdFN0YXRlKiBzY3JpcHRTdGF0ZUZvckZyYW1lSWQoY29uc3QgU3RyaW5nJikKICAgICB7 CiAgICAgICAgIHJldHVybiAwOwogICAgIH0K